129802 2014-03-06 07:46:49 -0800 [GTK] Don't busy loop when the socket is full 2014-03-17 11:21:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scampa.giovanni webkit-unassigned berto cgarcia commit-queue dpino pnormand oldest_to_newest 987696 0 scampa.giovanni 2014-03-06 07:46:49 -0800 [GTK] Don't busy loop when the socket is full 987697 1 225992 scampa.giovanni 2014-03-06 07:47:55 -0800 Created attachment 225992 Patch 990955 2 pnormand 2014-03-16 03:41:39 -0700 Interesting patch! Would you mind providing a ChangeLog? Tools/Scripts/prepare-ChangeLog can generate a template to fill out. 991151 3 225992 cgarcia 2014-03-17 01:40:36 -0700 Comment on attachment 225992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review Thanks for the patch. This patch needs a ChangeLog, see http://www.webkit.org/coding/contributing.html. > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37 > +#include <poll.h> Is this available in all UNIX platforms? > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:535 > + poll(&pollfd, 1, -1); > + } Does this really work? Don't you need to continue the loop when poll returns? 991155 4 scampa.giovanni 2014-03-17 02:23:06 -0700 (In reply to comment #3) > (From update of attachment 225992 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review > > Thanks for the patch. This patch needs a ChangeLog, see http://www.webkit.org/coding/contributing.html. > > > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37 > > +#include <poll.h> > > Is this available in all UNIX platforms? Yes, it is part of the Single Unix Specification, see http://pubs.opengroup.org/onlinepubs/9699919799/toc.htm 991156 5 226897 scampa.giovanni 2014-03-17 02:28:24 -0700 Created attachment 226897 Patch 991300 6 226897 cgarcia 2014-03-17 10:48:19 -0700 Comment on attachment 226897 Patch Ok looks good. Thanks! 991317 7 226897 commit-queue 2014-03-17 11:20:57 -0700 Comment on attachment 226897 Patch Clearing flags on attachment: 226897 Committed r165745: <http://trac.webkit.org/changeset/165745> 991318 8 commit-queue 2014-03-17 11:21:00 -0700 All reviewed patches have been landed. Closing bug. 225992 2014-03-06 07:47:55 -0800 2014-03-17 02:28:14 -0700 Patch bug-129802-20140306164817.patch text/plain 1224 scampa.giovanni U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKaW5kZXggYTU0Y2FmZWQ0ZDNiOWJlODNj MmIxODI4NzdhMTgwZTEzMDkwM2NjMi4uZGQwM2FmYzFjOGUwMzg3Yjk3YTdlNGJmMDA1MjNiZDE2 MDZkNmQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29u bmVjdGlvblVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nv bm5lY3Rpb25Vbml4LmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgPHVuaXN0ZC5oPgog I2luY2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8ZmNudGwuaD4KKyNpbmNsdWRlIDxwb2xsLmg+ CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvRnVuY3Rpb25hbC5o PgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KQEAgLTUyMiw4ICs1MjMsMTYgQEAgYm9v bCBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdl RW5jb2Rlcj4gZW5jb2RlcikKIAogICAgIGludCBieXRlc1NlbnQgPSAwOwogICAgIHdoaWxlICgo Ynl0ZXNTZW50ID0gc2VuZG1zZyhtX3NvY2tldERlc2NyaXB0b3IsICZtZXNzYWdlLCAwKSkgPT0g LTEpIHsKLSAgICAgICAgaWYgKGVycm5vID09IEVJTlRSIHx8IGVycm5vID09IEVBR0FJTiB8fCBl cnJubyA9PSBFV09VTERCTE9DSykKKyAgICAgICAgaWYgKGVycm5vID09IEVJTlRSKQogICAgICAg ICAgICAgY29udGludWU7CisgICAgICAgIGlmIChlcnJubyA9PSBFQUdBSU4gfHwgZXJybm8gPT0g RVdPVUxEQkxPQ0spIHsKKyAgICAgICAgICAgIHN0cnVjdCBwb2xsZmQgcG9sbGZkOworCisgICAg ICAgICAgICBwb2xsZmQuZmQgPSBtX3NvY2tldERlc2NyaXB0b3I7CisgICAgICAgICAgICBwb2xs ZmQuZXZlbnRzID0gUE9MTE9VVDsKKyAgICAgICAgICAgIHBvbGxmZC5yZXZlbnRzID0gMDsKKyAg ICAgICAgICAgIHBvbGwoJnBvbGxmZCwgMSwgLTEpOworICAgICAgICB9CiAKICAgICAgICAgV1RG TG9nQWx3YXlzKCJFcnJvciBzZW5kaW5nIElQQyBtZXNzYWdlOiAlcyIsIHN0cmVycm9yKGVycm5v KSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsK 226897 2014-03-17 02:28:24 -0700 2014-03-17 11:20:56 -0700 Patch bug-129802-20140317102825.patch text/plain 2136 scampa.giovanni U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzc2MmFkYjliNWZhZGVm ZTZlYzlhY2EzMjYyMDQ0ZjQwYzU0ZjIyMy4uOGM5NTBkZTk4OGMzMjc3YTE4NzRhY2Y5Njk3Y2Vj ODRjMjkxMDIyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTA2ICBHaW92 YW5uaSBDYW1wYWduYSAgPGdjYW1wYWduYUBzcmMuZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtd IERvbid0IGJ1c3kgbG9vcCB3aGVuIHRoZSBzb2NrZXQgaXMgZnVsbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5ODAyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgc29ja2V0IGlzIGZ1bGwg YW5kIHdlIHNlZSBFQUdBSU4gb3IgRVdPVUxEQkxPQ0sKKyAgICAgICAgKGJlY2F1c2UgdGhlIHNv Y2tldCBpcyBub24gYmxvY2tpbmcpLCBkb24ndCBidXN5IGxvb3AgYnkKKyAgICAgICAgdHJpbmcg dG8gd3JpdGUgYWdhaW4sIGluc3RlYWQgcG9sbCgpIHVudGlsIHRoZSBzb2NrZXQKKyAgICAgICAg YmVjb21lcyB3cml0YWJsZS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rp b25Vbml4LmNwcDoKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2Fn ZSk6CisKIDIwMTQtMDItMTkgIEdpb3Zhbm5pIENhbXBhZ25hICA8Z2NhbXBhZ25hQHNyYy5nbm9t ZS5vcmc+CiAKICAgICAgICAgW0dUS10gQWRkIEFQSSBmb3IgcmVtZW1iZXJpbmcgdmlzaXRlZCBs aW5rcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVj dGlvblVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlv blVuaXguY3BwCmluZGV4IDA4YTMyOGQ2M2EwY2NlN2Q2ZTViY2MyMmU2NzJmMWQzODU2ZTk5ZjIu Ljk5YWU0OThkZDk4YTc4NTM5OTdmOGNlYzdhNzdkZDBkYTdjNzEyYjYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKQEAgLTM0 LDYgKzM0LDcgQEAKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNpbmNsdWRlIDxlcnJuby5oPgogI2lu Y2x1ZGUgPGZjbnRsLmg+CisjaW5jbHVkZSA8cG9sbC5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRp b25zLmg+CiAjaW5jbHVkZSA8d3RmL0Z1bmN0aW9uYWwuaD4KICNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CkBAIC01MjIsOCArNTIzLDE3IEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dGdv aW5nTWVzc2FnZShzdGQ6OnVuaXF1ZV9wdHI8TWVzc2FnZUVuY29kZXI+IGVuY29kZXIpCiAKICAg ICBpbnQgYnl0ZXNTZW50ID0gMDsKICAgICB3aGlsZSAoKGJ5dGVzU2VudCA9IHNlbmRtc2cobV9z b2NrZXREZXNjcmlwdG9yLCAmbWVzc2FnZSwgMCkpID09IC0xKSB7Ci0gICAgICAgIGlmIChlcnJu byA9PSBFSU5UUiB8fCBlcnJubyA9PSBFQUdBSU4gfHwgZXJybm8gPT0gRVdPVUxEQkxPQ0spCisg ICAgICAgIGlmIChlcnJubyA9PSBFSU5UUikKICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAg ICBpZiAoZXJybm8gPT0gRUFHQUlOIHx8IGVycm5vID09IEVXT1VMREJMT0NLKSB7CisgICAgICAg ICAgICBzdHJ1Y3QgcG9sbGZkIHBvbGxmZDsKKworICAgICAgICAgICAgcG9sbGZkLmZkID0gbV9z b2NrZXREZXNjcmlwdG9yOworICAgICAgICAgICAgcG9sbGZkLmV2ZW50cyA9IFBPTExPVVQ7Cisg ICAgICAgICAgICBwb2xsZmQucmV2ZW50cyA9IDA7CisgICAgICAgICAgICBwb2xsKCZwb2xsZmQs IDEsIC0xKTsKKyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CiAKICAgICAgICAgV1RG TG9nQWx3YXlzKCJFcnJvciBzZW5kaW5nIElQQyBtZXNzYWdlOiAlcyIsIHN0cmVycm9yKGVycm5v KSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsK