129794 2014-03-06 02:35:30 -0800 Remove 'visibilitychange' attribute event listener from document 2014-03-10 19:20:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue esprehn+autocc kangil.han simon.fraser oldest_to_newest 987635 0 jinwoo7.song 2014-03-06 02:35:30 -0800 Remove the unused attribute event listener which is not defined in Page Visibility API spec, too. http://www.w3.org/TR/page-visibility/#sec-document-interface 987636 1 225974 jinwoo7.song 2014-03-06 02:37:18 -0800 Created attachment 225974 Patch 987984 2 simon.fraser 2014-03-06 18:15:24 -0800 What is the web compat risk? 988007 3 jinwoo7.song 2014-03-06 19:58:56 -0800 (In reply to comment #2) > What is the web compat risk? As 'visibilitychange' was not declared in Document.idl, below code did not work. (I also tested in Mac Safari and EFL minibrowser.) <html onvisibilitychange="dostuff"> So there is no compatibility issue by this patch. 989146 4 225974 simon.fraser 2014-03-10 18:10:47 -0700 Comment on attachment 225974 Patch So this breaks 989172 5 225974 commit-queue 2014-03-10 19:20:48 -0700 Comment on attachment 225974 Patch Clearing flags on attachment: 225974 Committed r165423: <http://trac.webkit.org/changeset/165423> 989173 6 commit-queue 2014-03-10 19:20:52 -0700 All reviewed patches have been landed. Closing bug. 225974 2014-03-06 02:37:18 -0800 2014-03-10 19:20:47 -0700 Patch bug-129794-20140306193716.patch text/plain 1388 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2YzNzFjZTJiOTY4ZjY5 OWY1NTUzNzAyNGFjMDBiNzUzOTFkMmE1NC4uYzM5YzE3OTQ1OTA4ZDg5MTRiYmNhNTRkYjE4NTM5 NGM4ZmU3MWFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA2ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgJ3Zp c2liaWxpdHljaGFuZ2UnIGF0dHJpYnV0ZSBldmVudCBsaXN0ZW5lciBmcm9tIGRvY3VtZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3OTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhl IHVudXNlZCBhdHRyaWJ1dGUgZXZlbnQgbGlzdGVuZXIgd2hpY2ggaXMgbm90IGRlZmluZWQgaW4g UGFnZSBWaXNpYmlsaXR5IEFQSSBzcGVjLgorICAgICAgICBodHRwOi8vd3d3LnczLm9yZy9UUi9w YWdlLXZpc2liaWxpdHkvI3NlYy1kb2N1bWVudC1pbnRlcmZhY2UKKworICAgICAgICAqIGRvbS9E b2N1bWVudC5oOgorCiAyMDE0LTAzLTA1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIG1ldGhvZCBmcm9tIFZpYnJhdGlvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuaAppbmRleCBjMTI0NTg2YjMyODEzM2UwZDQ3ZjhhZjljMmRmOWFkYzZiMGU5 YzM1Li4wZWFhN2JmNGEzNGRhMWUwM2RjYzMwYmIzY2Q4NTUzYTE3NzllMWIwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuaApAQCAtMzgzLDkgKzM4Myw2IEBAIHB1YmxpYzoKICAgICBERUZJTkVfQVRUUklC VVRFX0VWRU5UX0xJU1RFTkVSKHdlYmtpdHBvaW50ZXJsb2NrY2hhbmdlKTsKICAgICBERUZJTkVf QVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKHdlYmtpdHBvaW50ZXJsb2NrZXJyb3IpOwogI2VuZGlm Ci0jaWYgRU5BQkxFKFBBR0VfVklTSUJJTElUWV9BUEkpCi0gICAgREVGSU5FX0FUVFJJQlVURV9F VkVOVF9MSVNURU5FUih2aXNpYmlsaXR5Y2hhbmdlKTsKLSNlbmRpZgogI2lmIEVOQUJMRShDU1Bf TkVYVCkKICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKHNlY3VyaXR5cG9saWN5 dmlvbGF0aW9uKTsKICNlbmRpZgo=