129793 2014-03-06 02:13:17 -0800 Fix the !ENABLE(CSS_STICKY_POSITION) build 2014-03-06 14:01:02 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned commit-queue lucas.de.marchi mmaxfield ossy rtakacs simon.fraser thorton oldest_to_newest 987630 0 zsborbely.u-szeged 2014-03-06 02:13:17 -0800 tested on r165180: $ Tools/Scripts/build-webkit --efl --no-css-sticky-position ... /home/bzsolt/webkit/EflWebKit/Source/WebCore/editing/EditingStyle.cpp: In member function 'bool WebCore::EditingStyle::convertPositionStyle()': /home/bzsolt/webkit/EflWebKit/Source/WebCore/editing/EditingStyle.cpp:1207:77: error: 'CSSValueWebkitSticky' was not declared in this scope ... 987631 1 225972 zsborbely.u-szeged 2014-03-06 02:16:22 -0800 Created attachment 225972 Proposed patch 987640 2 ossy 2014-03-06 03:16:56 -0800 It isn't related to EFL, you will get same build failure on all ports if you try to disable CSS Sticky Position. 987677 3 ossy 2014-03-06 06:56:18 -0800 cc-ing Myles and Simon, the author and the reviewer of - https://trac.webkit.org/changeset/163916 - https://trac.webkit.org/changeset/164299 987681 4 225988 zsborbely.u-szeged 2014-03-06 07:07:43 -0800 Created attachment 225988 Proposed patch 987748 5 225988 simon.fraser 2014-03-06 10:28:14 -0800 Comment on attachment 225988 Proposed patch Why does EFL not want sticky enabled? 987750 6 ossy 2014-03-06 10:31:44 -0800 (In reply to comment #5) > (From update of attachment 225988 [details]) > Why does EFL not want sticky enabled? It is enabled by default on EFL, but the guard should work properly. 987760 7 225988 commit-queue 2014-03-06 11:00:42 -0800 Comment on attachment 225988 Proposed patch Clearing flags on attachment: 225988 Committed r165198: <http://trac.webkit.org/changeset/165198> 987761 8 commit-queue 2014-03-06 11:00:46 -0800 All reviewed patches have been landed. Closing bug. 987774 9 thorton 2014-03-06 11:25:45 -0800 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 225988 [details] [details]) > > Why does EFL not want sticky enabled? > > It is enabled by default on EFL, but the guard should work properly. It's a small feature that everyone has enabled (as far as I know); maybe we should get rid of the guard? 987849 10 mmaxfield 2014-03-06 14:01:02 -0800 Thanks for fixing this. It was my fault. 225972 2014-03-06 02:16:22 -0800 2014-03-06 07:07:43 -0800 Proposed patch sticky.patch text/plain 1794 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MjZkMWYxLi5jZGJlMzIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDMtMDYgIFpzb2x0IEJvcmJlbHkgIDxib3JiZXpzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBbRUZMXSBGaXggdGhlICFFTkFCTEUoQ1NTX1NUSUNLWV9QT1NJVElPTikgYnVp bGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTc5 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBt aXNzaW5nIEVOQUJMRShDU1NfU1RJQ0tZX1BPU0lUSU9OKSBndWFyZCB0byBFZGl0aW5nU3R5bGU6 OmNvbnZlcnRQb3NpdGlvblN0eWxlKCkuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRpbmdTdHls ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0aW5nU3R5bGU6OmNvbnZlcnRQb3NpdGlvblN0 eWxlKToKKwogMjAxNC0wMy0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+ CiAKICAgICAgICAgTW92ZSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy8gY29kZSB0byBzdGQ6 OnVuaXF1ZV9wdHIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdGluZ1N0 eWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdGluZ1N0eWxlLmNwcAppbmRleCBi YzVjZDRlLi5mMzc5MmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRp bmdTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nU3R5bGUuY3Bw CkBAIC0xMjA0LDExICsxMjA0LDEzIEBAIGJvb2wgRWRpdGluZ1N0eWxlOjpjb252ZXJ0UG9zaXRp b25TdHlsZSgpCiAgICAgaWYgKCFtX211dGFibGVTdHlsZSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwogCisjaWYgRU5BQkxFKENTU19TVElDS1lfUE9TSVRJT04pCiAgICAgUmVmUHRyPENTU1ByaW1p dGl2ZVZhbHVlPiBzdGlja3kgPSBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUo Q1NTVmFsdWVXZWJraXRTdGlja3kpOwogICAgIGlmIChtX211dGFibGVTdHlsZS0+cHJvcGVydHlN YXRjaGVzKENTU1Byb3BlcnR5UG9zaXRpb24sIHN0aWNreS5nZXQoKSkpIHsKICAgICAgICAgbV9t dXRhYmxlU3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5UG9zaXRpb24sIGNzc1ZhbHVlUG9v bCgpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShDU1NWYWx1ZVN0YXRpYyksIG1fbXV0YWJsZVN0eWxl LT5wcm9wZXJ0eUlzSW1wb3J0YW50KENTU1Byb3BlcnR5UG9zaXRpb24pKTsKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIH0KKyNlbmRpZgogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4g Zml4ZWQgPSBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUoQ1NTVmFsdWVGaXhl ZCk7CiAgICAgaWYgKG1fbXV0YWJsZVN0eWxlLT5wcm9wZXJ0eU1hdGNoZXMoQ1NTUHJvcGVydHlQ b3NpdGlvbiwgZml4ZWQuZ2V0KCkpKSB7CiAgICAgICAgIG1fbXV0YWJsZVN0eWxlLT5zZXRQcm9w ZXJ0eShDU1NQcm9wZXJ0eVBvc2l0aW9uLCBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVy VmFsdWUoQ1NTVmFsdWVBYnNvbHV0ZSksIG1fbXV0YWJsZVN0eWxlLT5wcm9wZXJ0eUlzSW1wb3J0 YW50KENTU1Byb3BlcnR5UG9zaXRpb24pKTsK 225988 2014-03-06 07:07:43 -0800 2014-03-06 11:00:42 -0800 Proposed patch sticky.patch text/plain 1831 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NjE0MWYzLi40ZmVhODMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDMtMDYgIFpzb2x0IEJvcmJlbHkgIDxib3JiZXpzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBGaXggdGhlICFFTkFCTEUoQ1NTX1NUSUNLWV9QT1NJVElPTikgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTc5MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5n IEVOQUJMRShDU1NfU1RJQ0tZX1BPU0lUSU9OKSBndWFyZCB0byBFZGl0aW5nU3R5bGU6OmNvbnZl cnRQb3NpdGlvblN0eWxlKCkuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpFZGl0aW5nU3R5bGU6OmNvbnZlcnRQb3NpdGlvblN0eWxlKToK KwogMjAxNC0wMy0wNiAgR3VycHJlZXQgS2F1ciAgPGsuZ3VycHJlZXRAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjE1ODI1NCk6IFJ1YmJlci1iYW5kaW5nIGF0IEJpbmcgaW1h Z2Ugc2VhcmNoIGNhdXNlcyB0aGUgdG9vbGJhciB0byBtb3ZlIHVwIGFuZCBhd2F5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHAKaW5kZXggYmM1Y2Q0ZS4uZjM3OTJhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nU3R5bGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdGluZ1N0eWxlLmNwcApAQCAtMTIwNCwxMSArMTIwNCwx MyBAQCBib29sIEVkaXRpbmdTdHlsZTo6Y29udmVydFBvc2l0aW9uU3R5bGUoKQogICAgIGlmICgh bV9tdXRhYmxlU3R5bGUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorI2lmIEVOQUJMRShDU1Nf U1RJQ0tZX1BPU0lUSU9OKQogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3RpY2t5ID0g Y3NzVmFsdWVQb29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlV2Via2l0U3RpY2t5 KTsKICAgICBpZiAobV9tdXRhYmxlU3R5bGUtPnByb3BlcnR5TWF0Y2hlcyhDU1NQcm9wZXJ0eVBv c2l0aW9uLCBzdGlja3kuZ2V0KCkpKSB7CiAgICAgICAgIG1fbXV0YWJsZVN0eWxlLT5zZXRQcm9w ZXJ0eShDU1NQcm9wZXJ0eVBvc2l0aW9uLCBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVy VmFsdWUoQ1NTVmFsdWVTdGF0aWMpLCBtX211dGFibGVTdHlsZS0+cHJvcGVydHlJc0ltcG9ydGFu dChDU1NQcm9wZXJ0eVBvc2l0aW9uKSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9Cisj ZW5kaWYKICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGZpeGVkID0gY3NzVmFsdWVQb29s KCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlRml4ZWQpOwogICAgIGlmIChtX211dGFi bGVTdHlsZS0+cHJvcGVydHlNYXRjaGVzKENTU1Byb3BlcnR5UG9zaXRpb24sIGZpeGVkLmdldCgp KSkgewogICAgICAgICBtX211dGFibGVTdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlQb3Np dGlvbiwgY3NzVmFsdWVQb29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlQWJzb2x1 dGUpLCBtX211dGFibGVTdHlsZS0+cHJvcGVydHlJc0ltcG9ydGFudChDU1NQcm9wZXJ0eVBvc2l0 aW9uKSk7Cg==