129790 2014-03-06 01:31:24 -0800 [Mac] Always do a full GC when simulating memory pressure. 2014-04-08 13:27:23 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue ggaren kling oliver oldest_to_newest 987619 0 kling 2014-03-06 01:31:24 -0800 We should call releaseExecutableMemory() when under memory pressure. 987621 1 225967 kling 2014-03-06 01:36:42 -0800 Created attachment 225967 Patch 987728 2 225967 ggaren 2014-03-06 09:41:42 -0800 Comment on attachment 225967 Patch I don't think we can afford to do this :(. The cost of GC under memory pressure is just too high. Can we throw away code without forcing a GC? 998690 3 228864 kling 2014-04-08 12:03:45 -0700 Created attachment 228864 Patch 998708 4 228864 ggaren 2014-04-08 12:29:26 -0700 Comment on attachment 228864 Patch /Volumes/Data/EWS/WebKit/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:76:9: error: use of undeclared identifier 'gcController' gcController().garbageCollectNow(); ^ 998714 5 228871 kling 2014-04-08 12:45:33 -0700 Created attachment 228871 Patch 998716 6 228871 ggaren 2014-04-08 12:46:36 -0700 Comment on attachment 228871 Patch r=me 998749 7 228871 commit-queue 2014-04-08 13:27:20 -0700 Comment on attachment 228871 Patch Clearing flags on attachment: 228871 Committed r166953: <http://trac.webkit.org/changeset/166953> 998750 8 commit-queue 2014-04-08 13:27:23 -0700 All reviewed patches have been landed. Closing bug. 225967 2014-03-06 01:36:42 -0800 2014-04-08 12:03:45 -0700 Patch bug-129790.diff text/plain 2259 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjM3MWNlLi4xYzdkNDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbGVhc2UgbW9yZSBleGVjdXRhYmxlIG1lbW9yeSB3aGVuIHVuZGVyIG1lbW9yeSBwcmVz c3VyZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTc5MD4KKworICAgICAgICBD YWxsIHJlbGVhc2VFeGVjdXRhYmxlTWVtb3J5KCkgZnJvbSB0aGUgbWVtb3J5IHByZXNzdXJlIGhh bmRsZXIgdG8KKyAgICAgICAgZW1wdHkgSlNDJ3MgUmVnRXhwIGNhY2hlIGFuZCBkbyBhIGdhcmJh Z2UgY29sbGVjdGlvbi4gVGhpcyBpcyBsaWtlbHkKKyAgICAgICAgbm90IHRoZSBpZGVhbCBlbmQg c3RhdGUsIHNpbmNlIHdlIGRvbid0IHdhbnQgdG8gc3RhcnQgZG9pbmcgc3VwZXIKKyAgICAgICAg ZXhwZW5zaXZlIEdDIHdvcmsgdW5kZXIgcHJlc3N1cmUsIGJ1dCBpdCB3aWxsIGhlbHAgdXMgZ2V0 IGEgYmV0dGVyCisgICAgICAgIHBpY3R1cmUgZnJvbSBtZW1vcnkgYm90cy4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9NZW1v cnlQcmVzc3VyZUhhbmRsZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpNZW1vcnlQcmVzc3Vy ZUhhbmRsZXI6OnJlbGVhc2VNZW1vcnkpOgorCiAyMDE0LTAzLTA1ICBSeXVhbiBDaG9pICA8cnl1 YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIG1ldGhvZCBmcm9t IFZpYnJhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9y eVByZXNzdXJlSGFuZGxlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1v cnlQcmVzc3VyZUhhbmRsZXJNYWMubW0KaW5kZXggMTE1NjU4ZC4uM2EyMWRmZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVy TWFjLm1tCkBAIC04MCwxMSArODAsOCBAQCB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6aW5z dGFsbCgpCiAgICAgfSk7CiAKICAgICAvLyBBbGxvdyBzaW11bGF0aW9uIG9mIG1lbW9yeSBwcmVz c3VyZSB3aXRoICJub3RpZnl1dGlsIC1wIG9yZy5XZWJLaXQubG93TWVtb3J5IgotICAgIC8vIE5v dGUgdGhhdCB3ZSBhbHNvIGFzayBKU0MgdG8gZ2FyYmFnZSBjb2xsZWN0IHNvbWUgdGltZSBzb29u LCB1bmxpa2UgdGhlIHJlYWwgbWVtb3J5IHByZXNzdXJlIHBhdGguCi0gICAgLy8gVGhpcyBpcyB0 byBnZXQgbW9yZSBzdGFibGUgbnVtYmVycyBpbiBtZW1vcnkgYmVuY2htYXJrcyB1c2luZyB0aGlz IG1lY2hhbmlzbS4KICAgICBub3RpZnlfcmVnaXN0ZXJfZGlzcGF0Y2goIm9yZy5XZWJLaXQubG93 TWVtb3J5IiwgJl9ub3RpZnlUb2tlbiwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXihpbnQp IHsKICAgICAgICAgbWVtb3J5UHJlc3N1cmVIYW5kbGVyKCkucmVzcG9uZFRvTWVtb3J5UHJlc3N1 cmUoKTsKLSAgICAgICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3RTb29uKCk7CiAgICAg fSk7CiAKICAgICBtX2luc3RhbGxlZCA9IHRydWU7CkBAIC0xNzUsNiArMTcyLDkgQEAgdm9pZCBN ZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VNZW1vcnkoYm9vbCkKIAogICAgIGdjQ29udHJv bGxlcigpLmRpc2NhcmRBbGxDb21waWxlZENvZGUoKTsKIAorICAgIC8vIEZJWE1FOiBBdm9pZCB0 aHJhc2h5IEdDIHdvcmsgd2hpbGUgdW5kZXIgcmVhbCBwcmVzc3VyZS4KKyAgICBnY0NvbnRyb2xs ZXIoKS5yZWxlYXNlRXhlY3V0YWJsZU1lbW9yeSgpOworCiAgICAgLy8gRmFzdE1hbGxvYyBoYXMg bG9jay1mcmVlIHRocmVhZCBzcGVjaWZpYyBjYWNoZXMgdGhhdCBjYW4gb25seSBiZSBjbGVhcmVk IGZyb20gdGhlIHRocmVhZCBpdHNlbGYuCiAgICAgU3RvcmFnZVRocmVhZDo6cmVsZWFzZUZhc3RN YWxsb2NGcmVlTWVtb3J5SW5BbGxUaHJlYWRzKCk7CiAgICAgV29ya2VyVGhyZWFkOjpyZWxlYXNl RmFzdE1hbGxvY0ZyZWVNZW1vcnlJbkFsbFRocmVhZHMoKTsK 228864 2014-04-08 12:03:45 -0700 2014-04-08 12:29:26 -0700 Patch bug-129790.diff text/plain 1617 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZjk2M2QxLi42NzU0YTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDQtMDggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtNYWNdIEFsd2F5cyBkbyBhIGZ1bGwgR0Mgd2hlbiBzaW11bGF0aW5nIG1lbW9yeSBwcmVz c3VyZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTc5MD4KKworICAgICAgICBU byBnZXQgbW9yZSBjb25zaXN0ZW50IGFjY291bnRpbmcgb24gYXV0b21hdGVkIG1lbW9yeSB0ZXN0 ZXJzLAorICAgICAgICBhZGQgYSBzeW5jaHJvbm91cyBHQyBhcyBwYXJ0IG9mIHRoZSBzaW11bGF0 ZWQgbWVtb3J5IHByZXNzdXJlIGV2ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1h Yy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeVByZXNzdXJlSGFuZGxlcjo6aW5zdGFsbCk6 CisKIDIwMTQtMDQtMDcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAg ICAgW1dLMl1baU9TXSBDb25zZWN1dGl2ZSB2aWRlb3MgaW4gZnVsbCBzY3JlZW4gZGlzcGxheSBv bmx5IGJsYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5 UHJlc3N1cmVIYW5kbGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9y eVByZXNzdXJlSGFuZGxlck1hYy5tbQppbmRleCA4MzU0ZDA3Li5jZjM0ZjIxNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVy TWFjLm1tCkBAIC03MCw2ICs3MCwxMSBAQCB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6aW5z dGFsbCgpCiAKICAgICAvLyBBbGxvdyBzaW11bGF0aW9uIG9mIG1lbW9yeSBwcmVzc3VyZSB3aXRo ICJub3RpZnl1dGlsIC1wIG9yZy5XZWJLaXQubG93TWVtb3J5IgogICAgIG5vdGlmeV9yZWdpc3Rl cl9kaXNwYXRjaCgib3JnLldlYktpdC5sb3dNZW1vcnkiLCAmX25vdGlmeVRva2VuLCBkaXNwYXRj aF9nZXRfbWFpbl9xdWV1ZSgpLCBeKGludCkgeworCisgICAgICAgIC8vIFdlIG9ubHkgZG8gYSBz eW5jaHJvbm91cyBHQyB3aGVuICpzaW11bGF0aW5nKiBtZW1vcnkgcHJlc3N1cmUuCisgICAgICAg IC8vIFRoaXMgZ2l2ZXMgdXMgYSBtb3JlIGNvbnNpc3RlbnQgcGljdHVyZSBvZiBsaXZlIG9iamVj dHMgYXQgdGhlIGVuZCBvZiB0ZXN0aW5nLgorICAgICAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdl Q29sbGVjdE5vdygpOworCiAgICAgICAgIG1lbW9yeVByZXNzdXJlSGFuZGxlcigpLnJlc3BvbmRU b01lbW9yeVByZXNzdXJlKCk7CiAgICAgICAgIG1hbGxvY196b25lX3ByZXNzdXJlX3JlbGllZihu dWxscHRyLCAwKTsKICAgICB9KTsK 228871 2014-04-08 12:45:33 -0700 2014-04-08 13:27:20 -0700 Patch bug-129790-2.diff text/plain 1795 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZjk2M2QxLi42NzU0YTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDQtMDggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtNYWNdIEFsd2F5cyBkbyBhIGZ1bGwgR0Mgd2hlbiBzaW11bGF0aW5nIG1lbW9yeSBwcmVz c3VyZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTc5MD4KKworICAgICAgICBU byBnZXQgbW9yZSBjb25zaXN0ZW50IGFjY291bnRpbmcgb24gYXV0b21hdGVkIG1lbW9yeSB0ZXN0 ZXJzLAorICAgICAgICBhZGQgYSBzeW5jaHJvbm91cyBHQyBhcyBwYXJ0IG9mIHRoZSBzaW11bGF0 ZWQgbWVtb3J5IHByZXNzdXJlIGV2ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1h Yy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeVByZXNzdXJlSGFuZGxlcjo6aW5zdGFsbCk6 CisKIDIwMTQtMDQtMDcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAg ICAgW1dLMl1baU9TXSBDb25zZWN1dGl2ZSB2aWRlb3MgaW4gZnVsbCBzY3JlZW4gZGlzcGxheSBv bmx5IGJsYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5 UHJlc3N1cmVIYW5kbGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9y eVByZXNzdXJlSGFuZGxlck1hYy5tbQppbmRleCA4MzU0ZDA3Li5iMjhjMzU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJN YWMubW0KQEAgLTI5LDYgKzI5LDcgQEAKICNpZiAhUExBVEZPUk0oSU9TKQogCiAjaW1wb3J0ICJJ T1N1cmZhY2VQb29sLmgiCisjaW1wb3J0ICJHQ0NvbnRyb2xsZXIuaCIKICNpbXBvcnQgIkxheWVy UG9vbC5oIgogI2ltcG9ydCAiV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oIgogI2ltcG9ydCA8bWFs bG9jL21hbGxvYy5oPgpAQCAtNzAsNiArNzEsMTEgQEAgdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRs ZXI6Omluc3RhbGwoKQogCiAgICAgLy8gQWxsb3cgc2ltdWxhdGlvbiBvZiBtZW1vcnkgcHJlc3N1 cmUgd2l0aCAibm90aWZ5dXRpbCAtcCBvcmcuV2ViS2l0Lmxvd01lbW9yeSIKICAgICBub3RpZnlf cmVnaXN0ZXJfZGlzcGF0Y2goIm9yZy5XZWJLaXQubG93TWVtb3J5IiwgJl9ub3RpZnlUb2tlbiwg ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXihpbnQpIHsKKworICAgICAgICAvLyBXZSBvbmx5 IGRvIGEgc3luY2hyb25vdXMgR0Mgd2hlbiAqc2ltdWxhdGluZyogbWVtb3J5IHByZXNzdXJlLgor ICAgICAgICAvLyBUaGlzIGdpdmVzIHVzIGEgbW9yZSBjb25zaXN0ZW50IHBpY3R1cmUgb2YgbGl2 ZSBvYmplY3RzIGF0IHRoZSBlbmQgb2YgdGVzdGluZy4KKyAgICAgICAgZ2NDb250cm9sbGVyKCku Z2FyYmFnZUNvbGxlY3ROb3coKTsKKwogICAgICAgICBtZW1vcnlQcmVzc3VyZUhhbmRsZXIoKS5y ZXNwb25kVG9NZW1vcnlQcmVzc3VyZSgpOwogICAgICAgICBtYWxsb2Nfem9uZV9wcmVzc3VyZV9y ZWxpZWYobnVsbHB0ciwgMCk7CiAgICAgfSk7Cg==