129786 2014-03-06 00:05:14 -0800 [GTK] Only build the Udis86 disassembler with the CMake build and when explicitly enabled 2016-01-05 07:02:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 zan zan benjamin berto bunhere cmarcelo commit-queue dbates gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 987588 0 zan 2014-03-06 00:05:14 -0800 [GTK] Only build the Udis86 disassembler with the CMake build and when explicitly enabled 987592 1 225961 zan 2014-03-06 00:16:24 -0800 Created attachment 225961 Patch 987672 2 225961 mrobinson 2014-03-06 06:42:48 -0800 Comment on attachment 225961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225961&action=review So looking at this it seems like it isn't even a configurable feature for the Mac port. Instead it appears that Platform.h just enables it unconditionally if the platform is one that supports the diassembler. From what you've said about the disassembler, that might be enough for us. > Source/WTF/wtf/Platform.h:671 > +#if !defined(WTF_USE_UDIS86) && ENABLE(JIT) && ((OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK)) || (PLATFORM(EFL) && OS(LINUX))) \ It looks like this > Source/cmake/OptionsGTK.cmake:255 > +if (WTF_USE_UDIS86) > + add_definitions(-DWTF_USE_UDIS86) > +endif () > + It's probably better to use the cmakeconfig.h instead of adding a new command-line argument to the linker. > Tools/Scripts/webkitdirs.pm:1999 > + push @args, $ENV{"WebKitCMakeArguments"} if $ENV{"WebKitCMakeArguments"}; Additionally arguments can be passed to build-webkit directly, I believe. Failing that the right thing to do is to add an advanced CMake configuration variable, I believe. 987758 3 225961 zan 2014-03-06 10:59:05 -0800 Comment on attachment 225961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225961&action=review >> Source/cmake/OptionsGTK.cmake:255 >> + > > It's probably better to use the cmakeconfig.h instead of adding a new command-line argument to the linker. Agreed. >> Tools/Scripts/webkitdirs.pm:1999 >> + push @args, $ENV{"WebKitCMakeArguments"} if $ENV{"WebKitCMakeArguments"}; > > Additionally arguments can be passed to build-webkit directly, I believe. Failing that the right thing to do is to add an advanced CMake configuration variable, I believe. There's indeed a --cmakeargs flag available in build-webkit. There isn't one in build-jsc, but I'll add that in another patch and remove this. 987769 4 zan 2014-03-06 11:09:24 -0800 (In reply to comment #2) > (From update of attachment 225961 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225961&action=review > > So looking at this it seems like it isn't even a configurable feature for the Mac port. Instead it appears that Platform.h just enables it unconditionally if the platform is one that supports the diassembler. From what you've said about the disassembler, that might be enough for us. > Thinking about it, the Udis86 disassembler only supports x86 and x86-64 architectures, and it is a very specific debugging tool that isn't really useful to a great majority of people using any build, release or development. Because of that I'd recommend keeping it disabled by default, but make it easy to enable by passing -DWTF_USE_UDIS86 to cmake (through --cmakeargs or directly). 1152198 5 225961 mcatanzaro 2016-01-03 17:23:32 -0800 Comment on attachment 225961 Patch Removing from request queue; this patch is not actionable in its current form.... 1152696 6 zan 2016-01-05 04:34:53 -0800 The Udis86 disassembler is now enabled by default in Platform.h, so the USE_UDIS86 guards in CMakeFiles should be removed. 1152699 7 zan 2016-01-05 04:47:59 -0800 (In reply to comment #6) > The Udis86 disassembler is now enabled by default in Platform.h, so the > USE_UDIS86 guards in CMakeFiles should be removed. https://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h#L735 1152706 8 zan 2016-01-05 07:02:56 -0800 Continued in bug #152731. 225961 2014-03-06 00:16:24 -0800 2016-01-03 17:23:32 -0800 Patch bug-129786-20140306001622.patch text/plain 10203 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 OTUwMjE5NTMzNjVkNWExZmJkYTViZTUxMzRjMzRlNjEwMTkwYzBkLi45MDZmMTlhNzA3MGM5OTk4 NWE2NjBiN2Y4MzZkNzY2NzZlNTRjMzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gT25seSBidWlsZCB0aGUgVWRpczg2IGRpc2Fzc2VtYmxlciB3 aXRoIHRoZSBDTWFrZSBidWlsZCBhbmQgd2hlbiBleHBsaWNpdGx5IGVuYWJsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTc4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCByMTY1MDY3LiBU aGUgVWRpczg2IGRpc2Fzc2VtYmxlciBpcyBub3cgb25seSBidWlsZGFibGUgdGhyb3VnaCBDTWFr ZS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorICAgICAgICAqIEdOVW1ha2VmaWxlLmxp c3QuYW06CisKIDIwMTQtMDMtMDUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgUldJIG1lc3NhZ2UgZnJlcXVlbmN5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9n CmluZGV4IDc4ZjExMDkyMWNmMzdmZGE5YzViMWU5ODk4NjgzNjVjNzVmMDdhODIuLjViZGRjODUx ZDk2MTA2MDA5MGRhMjkyZGQ2MmRlM2U5M2ZiZWYwMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTQtMDMtMDYgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIE9ubHkgYnVpbGQgdGhlIFVkaXM4NiBkaXNhc3NlbWJsZXIgd2l0aCB0aGUgQ01ha2Ug YnVpbGQgYW5kIHdoZW4gZXhwbGljaXRseSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3ODYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgcjE2NTA2Ny4gVGhlIFVkaXM4NiBkaXNh c3NlbWJsZXIgaXMgbm93IG9ubHkgYnVpbGRhYmxlIHRocm91Z2ggdGhlIENNYWtlIGJ1aWxkCisg ICAgICAgIHdoaWNoIGRpcmVjdGx5IGRlZmluZXMgdGhlIFdURl9VU0VfVURJUzg2IG1hY3JvLgor CisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTQtMDMtMDUgIHBlYXZvQG91dGxvb2su Y29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbjMyXVtMTElOVF0gQ3Jhc2gg d2hlbiBydW5uaW5nIEpTQyBzdHJlc3MgdGVzdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZp bGUuYW0KaW5kZXggNmI1OWQyODg1NzlhODJjMGExNjAwNGViYmI5ZDFmZTdhYjQzNGZmMi4uOWMz OTk2OGQ3OTkyY2I5OTIzMzE3YTNlYTU0NGJlNjc4MjkyZGJiMyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9HTlVtYWtlZmlsZS5hbQpAQCAtNTcsNyArNTcsNiBAQCBqYXZhc2NyaXB0Y29yZV9jcHBmbGFn cyArPSBcCiAJLUkkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyIFwKIAkt SSQoc3JjZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnIFwKIAktSSQoc3JjZGlyKS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyIFwKLQktSSQoc3JjZGlyKS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4NiBcCiAJLUkkKHNyY2RpcikvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bCBcCiAJLUkkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAgXAogCS1JJChzcmNkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IgXApAQCAt MTI4LDEwICsxMjcsNiBAQCBEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9KU0NCdWlsdGlu cy5oOiBEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9KU0NCdQogRGVyaXZlZFNvdXJjZXMv SmF2YVNjcmlwdENvcmUvSlNDQnVpbHRpbnMuY3BwOiAkKHNyY2RpcikvU291cmNlL0phdmFTY3Jp cHRDb3JlL2dlbmVyYXRlLWpzLWJ1aWx0aW5zICQoamF2YXNjcmlwdGNvcmVfYnVpbHRpbnNfanNf bm9zb3VyY2VzKQogCSQoQU1fVl9HRU4pJChQWVRIT04pICReICRACiAKLURlcml2ZWRTb3VyY2Vz L0phdmFTY3JpcHRDb3JlL3VkaXM4Nl9pdGFiLmg6IERlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRD b3JlL3VkaXM4Nl9pdGFiLmMKLURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL3VkaXM4Nl9p dGFiLmM6ICQodWRpczg2X25vc291cmNlcykKLQkkKEFNX1ZfR0VOKSQoUFlUSE9OKSAkKHNyY2Rp cikvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvaXRhYi5weSAtLW91 dHB1dERpciBEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZSAkKHNyY2RpcikvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvb3B0YWJsZS54bWwKLQogJChsaWJqYXZh c2NyaXB0Y29yZWd0a19AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQF9AV0VCS0lUR1RLX0FQ SV9NSU5PUl9WRVJTSU9OQF9sYV9PQkpFQ1RTKTogRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENv cmUvTExJbnRBc3NlbWJseS5oCiAKIGpzYzogJChqYXZhc2NyaXB0Y29yZV9idWlsdF9ub3NvdXJj ZXMpIFByb2dyYW1zL2pzYyQoRVhFRVhUKQpAQCAtMjM1LDggKzIzMCw3IEBAIEVYVFJBX0RJU1Qg Kz0gXAogCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9USEFOS1MgXAogCSQoamF2YXNjcmlwdGNvcmVf YnVpbHRpbnNfanNfbm9zb3VyY2VzKSBcCiAJJChsbGludF9ub3NvdXJjZXMpIFwKLQkkKG9mZmxp bmVhc21fbm9zb3VyY2VzKSBcCi0JJCh1ZGlzODZfbm9zb3VyY2VzKQorCSQob2ZmbGluZWFzbV9u b3NvdXJjZXMpCiAKIENMRUFORklMRVMgKz0gXAogCSQoamF2YXNjcmlwdGNvcmVfYnVpbHRfbm9z b3VyY2VzKSBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUu bGlzdC5hbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCmluZGV4 IDViODNhNGYxMzdlZDI4Y2ZlOTE4NmY5MTQ4YmZmMjRkMjRkYmU5Y2MuLjdmMjk5MmIyN2EzY2Uy NTIxMGVjNmYxOWRkM2ZkOWM5M2NlMzFlMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVt YWtlZmlsZS5saXN0LmFtCkBAIC0zNyw5ICszNyw3IEBAIGphdmFzY3JpcHRjb3JlX2J1aWx0X25v c291cmNlcyArPSBcCiAJRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvQnl0ZWNvZGVzLmgg XAogCURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL0luaXRCeXRlY29kZXMuYXNtIFwKIAlE ZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9MTEludERlc2lyZWRPZmZzZXRzLmggXAotCURl cml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL0xMSW50QXNzZW1ibHkuaCBcCi0JRGVyaXZlZFNv dXJjZXMvSmF2YVNjcmlwdENvcmUvdWRpczg2X2l0YWIuYyBcCi0JRGVyaXZlZFNvdXJjZXMvSmF2 YVNjcmlwdENvcmUvdWRpczg2X2l0YWIuaAorCURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3Jl L0xMSW50QXNzZW1ibHkuaAogCiBqYXZhc2NyaXB0Y29yZV9idWlsdGluc19qc19ub3NvdXJjZXMg Kz0gXAogCSQod2lsZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlu cy8qLmpzKQpAQCAtNDY0LDIyICs0NjIsNyBAQCBqYXZhc2NyaXB0Y29yZV9zb3VyY2VzICs9IFwK IAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0Rpc2Fzc2VtYmxlci5oIFwKIAlT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0xMVk1EaXNhc3NlbWJsZXIuY3BwIFwK IAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0xMVk1EaXNhc3NlbWJsZXIuaCBc Ci0JU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9VRGlzODZEaXNhc3NlbWJsZXIu Y3BwIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL1VEaXM4NkRpc2Fzc2Vt Ymxlci5oIFwKIAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL1g4NkRpc2Fzc2Vt Ymxlci5jcHAgXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3Vk aXM4Ni5jIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlz ODYuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2 X2RlY29kZS5jIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91 ZGlzODZfZGVjb2RlLmggXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRp czg2L3VkaXM4Nl9leHRlcm4uaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxl ci91ZGlzODYvdWRpczg2X2lucHV0LmMgXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3Nl bWJsZXIvdWRpczg2L3VkaXM4Nl9pbnB1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz YXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfaXRhYl9ob2xkZXIuYyBcCi0JU291cmNlL0phdmFTY3Jp cHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X3N5bi5jIFwKLQlTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLmggXAotCVNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9zeW4tYXR0LmMgXAotCVNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9zeW4taW50ZWwuYyBc Ci0JU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X3R5cGVz LmggXAogCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJicmV2aWF0ZWRUeXBlcy5oIFwK IAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFiYnJldmlhdGlvbnMuaCBcCiAJU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXAuY3BwIFwKQEAgLTEzNDEsMTIgKzEz MjQsNiBAQCBvZmZsaW5lYXNtX25vc291cmNlcyArPSBcCiAJU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vdHJhbnNmb3JtLnJiIFwKIAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS94ODYucmIKIAotdWRpczg2X25vc291cmNlcyArPSBcCi0JU291cmNlL0phdmFTY3JpcHRD b3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvaXRhYi5weSBcCi0JU291cmNlL0phdmFTY3JpcHRDb3Jl L2Rpc2Fzc2VtYmxlci91ZGlzODYvb3B0YWJsZS54bWwgXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkX29wY29kZS5weSBcCi0JU291cmNlL0phdmFTY3JpcHRD b3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRfb3B0YWJsZS5weQotCiAjIG1pbmlkb20KIFByb2dy YW1zX21pbmlkb21fU09VUkNFUyA9IFwKIAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L0pTTm9kZS5jIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDQzYjk2MjIzNTMxMzAwMjk2NGE0YzQ1OThiMjA2 MjY1MjBkMzBiNjkuLmRjMWU4OTE1MWY3NjVlNmFhYmY5N2MwMGFiMWE4NmYxYjdhZTM2NmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYv UGxhdGZvcm0uaApAQCAtNjY4LDcgKzY2OCw3IEBACiAvKiBJZiBwb3NzaWJsZSwgdHJ5IHRvIGVu YWJsZSBhIGRpc2Fzc2VtYmxlci4gVGhpcyBpcyBvcHRpb25hbC4gV2UgcHJvY2VlZCBpbiB0d28K ICAgIHN0ZXBzOiBmaXJzdCB3ZSB0cnkgdG8gZmluZCBzb21lIGRpc2Fzc2VtYmxlciB0aGF0IHdl IGNhbiB1c2UsIGFuZCB0aGVuIHdlCiAgICBkZWNpZGUgaWYgdGhlIGhpZ2gtbGV2ZWwgZGlzYXNz ZW1ibGVyIEFQSSBjYW4gYmUgZW5hYmxlZC4gKi8KLSNpZiAhZGVmaW5lZChXVEZfVVNFX1VESVM4 NikgJiYgRU5BQkxFKEpJVCkgJiYgKChPUyhEQVJXSU4pICYmICFQTEFURk9STShFRkwpICYmICFQ TEFURk9STShHVEspKSB8fCAoT1MoTElOVVgpICYmIChQTEFURk9STShFRkwpIHx8IFBMQVRGT1JN KEdUSykpKSkgXAorI2lmICFkZWZpbmVkKFdURl9VU0VfVURJUzg2KSAmJiBFTkFCTEUoSklUKSAm JiAoKE9TKERBUldJTikgJiYgIVBMQVRGT1JNKEVGTCkgJiYgIVBMQVRGT1JNKEdUSykpIHx8IChQ TEFURk9STShFRkwpICYmIE9TKExJTlVYKSkpIFwKICAgICAmJiAoQ1BVKFg4NikgfHwgQ1BVKFg4 Nl82NCkpCiAjZGVmaW5lIFdURl9VU0VfVURJUzg2IDEKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZQppbmRleCBjN2FhMTUzYzE2Njk1NzQ4OWQzMTQ3YzcxMzZiZTU5ZTFjZjE3ZDkzLi42NGI0YWM4 MDU4YzNlZDdkZTQyNzc2NGI0ZTJkZjRlM2U0MTY2ZGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpA QCAtMTIzLDcgKzEyMyw2IEBAIHNldChpbmNsdWRlZGlyICIke3ByZWZpeH0vaW5jbHVkZSIpCiBz ZXQoVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTn0pCiAKIHNldChXVEZfVVNFX1NPVVAgMSkKLXNl dChXVEZfVVNFX1VESVM4NiAxKQogCiBzZXQoV1RGX09VVFBVVF9OQU1FIFdURkdUSykKIHNldChK YXZhU2NyaXB0Q29yZV9PVVRQVVRfTkFNRSBqYXZhc2NyaXB0Y29yZWd0ay0ke1dFQktJVEdUS19B UElfVkVSU0lPTn0pCkBAIC0yNTAsNiArMjQ5LDEwIEBAIGlmIChFTkFCTEVfR0FNRVBBRCkKICAg ICBmaW5kX3BhY2thZ2UoR1VkZXYpCiBlbmRpZiAoKQogCitpZiAoV1RGX1VTRV9VRElTODYpCisg ICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9VRElTODYpCitlbmRpZiAoKQorCiBzZXQoQ1BB Q0tfU09VUkNFX0dFTkVSQVRPUiBUQloyKQogCiBzZXQoREVSSVZFRF9TT1VSQ0VTX0dPQkpFQ1Rf RE9NX0JJTkRJTkdTX0RJUiAke0RFUklWRURfU09VUkNFU19ESVJ9L3dlYmtpdGRvbSkKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNmQ4ZTMwNTBi MDYwZDQwNWI2ZGQ3NmQ2YzhmNGY5N2U2ODdmMTBiLi5lOWYyZWMxOGZjOGY0ZjlkM2I1NmMzMGJh M2IwNTUxMGNiZDgyOGZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDMtMDYgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE9ubHkgYnVpbGQgdGhlIFVkaXM4 NiBkaXNhc3NlbWJsZXIgd2l0aCB0aGUgQ01ha2UgYnVpbGQgYW5kIHdoZW4gZXhwbGljaXRseSBl bmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjk3ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9t Q01ha2VQcm9qZWN0KTogQWxzbyB0YWtlIGluIENNYWtlIGFyZ3VtZW50cyBsaXN0ZWQgaW4gdGhl IFdlYktpdENNYWtlQXJndW1lbnRzCisgICAgICAgIGVudmlyb25tZW50IHZhcmlhYmxlLiBUaGlz IG1ha2VzIGl0IGVhc3kgdG8gZW5hYmxlIGZlYXR1cmVzIHRoYXQgYXJlbid0IG5lY2Vzc2FyeSBp biBwcm9kdWN0aW9uIG9yIGV2ZW4KKyAgICAgICAgZGFpbHkgZGV2ZWxvcGVyIGJ1aWxkcywgbGlr ZSB0aGUgVWRpczg2IGRpc2Fzc2VtYmxlci4KKwogMjAxNC0wMy0wNSAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bQ01ha2VdIFRhcmJhbGwg aXMgY3JlYXRlZCB3aXRoIHdyb25nIHRhcmJhbGwgcGF0aHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBi ZGE4MjRjZWYyNWM2ODhmNzRjYjMxNmUzMDg2YzFkZTc5ZGJkZmMxLi5lYzVjNGFkNzE4MDRkMWQ1 Y2IzMDdkNWFjNWRjMjBmYWVhNGYzZTZjIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xOTk2LDYgKzE5 OTYsNyBAQCBzdWIgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICBwdXNo IEBhcmdzLCAiLS1uby13YXJuLXVudXNlZC1jbGkiOwogICAgIHB1c2ggQGFyZ3MsIEBjbWFrZUFy Z3MgaWYgQGNtYWtlQXJnczsKICAgICBwdXNoIEBhcmdzLCAkYWRkaXRpb25hbENNYWtlQXJncyBp ZiAkYWRkaXRpb25hbENNYWtlQXJnczsKKyAgICBwdXNoIEBhcmdzLCAkRU5WeyJXZWJLaXRDTWFr ZUFyZ3VtZW50cyJ9IGlmICRFTlZ7IldlYktpdENNYWtlQXJndW1lbnRzIn07CiAKICAgICBwdXNo IEBhcmdzLCAnIicgLiBzb3VyY2VEaXIoKSAuICciJzsKIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IGU5M2NiODg4NTI3ODY3NTFmZDE3ZDEzMWRjMTdkNDJjODk2ZTQ2 MjMuLmIxMTYwNWM5ZGM1OTdhMzlhODhiZmFkOTM4OTBhNWE0YmU0MTI1ZDggMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0wMy0wNiAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gT25s eSBidWlsZCB0aGUgVWRpczg2IGRpc2Fzc2VtYmxlciB3aXRoIHRoZSBDTWFrZSBidWlsZCBhbmQg d2hlbiBleHBsaWNpdGx5IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyOTc4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJldmVydCByMTY1MDY3IGJ1dCBrZWVwIHRoZSBVZGlzODYgZGlzYXNz ZW1ibGVyIGJ1aWxkYWJsZSBmb3IgdGhlIEdUSyBwb3J0IHRocm91Z2ggdGhlIENNYWtlIGJ1aWxk CisgICAgICAgIHdoZW4gLURXVEZfVVNFX1VESVM4NiB3YXMgcGFzc2VkIHRvIHRoZSBDTWFrZSBn ZW5lcmF0aW9uLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTQtMDMtMDUgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gTmluamEgZ2VuZXJhdG9y IGJ1aWxkcyBmYWlsIHdpdGggIkFyZ3VtZW50IGxpc3QgdG9vIGxvbmciCmRpZmYgLS1naXQgYS9H TlVtYWtlZmlsZS5hbSBiL0dOVW1ha2VmaWxlLmFtCmluZGV4IGQxNDJiNjhjYjRjZDRhMmVkZTNk ODk3MzVmZDY2NzBjZTdhMmNjMTMuLmFhZjI3OTc2YWRkNGNlNDdlNmEwN2VhNWMxZGE0OWZhYzZl OWExZTkgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBA IC03Niw3ICs3Niw2IEBAIGphdmFzY3JpcHRjb3JlX2J1aWx0X3NvdXJjZXMgOj0KIGphdmFzY3Jp cHRjb3JlX2J1aWx0X25vc291cmNlcyA6PQogbGxpbnRfbm9zb3VyY2VzIDo9CiBvZmZsaW5lYXNt X25vc291cmNlcyA6PQotdWRpczg2X25vc291cmNlcyA6PQogcGxhdGZvcm1fd2ViY29yZV9jcHBm bGFncyA6PQogcGxhdGZvcm1fY3BwZmxhZ3MgOj0KIHBsYXRmb3JtX2J1aWx0X3NvdXJjZXMgOj0K