129785 2014-03-05 23:50:16 -0800 Use the LLVM disassembler on ARM64 if we are enabling the FTL 2014-03-06 07:49:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough benjamin cmarcelo commit-queue ggaren joepeck mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 987583 0 fpizlo 2014-03-05 23:50:16 -0800 Patch forthcoming. 987584 1 225959 fpizlo 2014-03-05 23:52:14 -0800 Created attachment 225959 the patch 987597 2 225959 ggaren 2014-03-06 00:40:16 -0800 Comment on attachment 225959 the patch r=me 987614 3 225959 commit-queue 2014-03-06 01:11:35 -0800 Comment on attachment 225959 the patch Clearing flags on attachment: 225959 Committed r165180: <http://trac.webkit.org/changeset/165180> 987615 4 commit-queue 2014-03-06 01:11:38 -0800 All reviewed patches have been landed. Closing bug. 987628 5 joepeck 2014-03-06 02:08:43 -0800 Building on my Mac I'm seeing a duplicate symbol Ld error: duplicate symbol __ZN3JSC16tryToDisassembleERKNS_21MacroAssemblerCodePtrEmPKcRN3WTF11PrintStreamENS_21InstructionSubsetHintE in: /Volumes/Data/Build/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/ARM64Disassembler.o /Volumes/Data/Build/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/X86Disassembler.o I'll try a clean build. 987634 6 225959 joepeck 2014-03-06 02:34:32 -0800 Comment on attachment 225959 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=225959&action=review > Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp:58 > #endif // USE(ARM64_DISASSEMBLER) > > +#if USE(LLVM_DISASSEMBLER) I'm guessing this new code should probably have gone inside of the ARM64_DISASSEMBLER #ifdef. Moving it inside gets me past my duplicate symbol issue. A clean build did not help. 987692 7 fpizlo 2014-03-06 07:40:37 -0800 Land patch, pass out! I'm fixing it. 987698 8 fpizlo 2014-03-06 07:49:40 -0800 Fixed in r165191 225959 2014-03-05 23:52:14 -0800 2014-03-06 02:34:32 -0800 the patch blah.patch text/plain 2908 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MTc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAzLTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg VXNlIHRoZSBMTFZNIGRpc2Fzc2VtYmxlciBvbiBBUk02NCBpZiB3ZSBhcmUgZW5hYmxpbmcgdGhl IEZUTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5 Nzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBPdXIgZGlzYXNzZW1ibGVyIGNhbid0IGhhbmRsZSBzb21lIG9mIHRoZSBjb2RlIHNlcXVl bmNlcyB0aGF0IExMVk0gZW1pdHMuIExMVk0ncyBkaXNhc3NlbWJsZXIKKyAgICAgICAgaXMgc3Ry aWN0bHkgbW9yZSBjYXBhYmxlIGF0IHRoaXMgcG9pbnQuIFVzZSBpdCBpZiBpdCdzIGF2YWlsYWJs ZS4KKworICAgICAgICAqIGRpc2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHA6CisgICAg ICAgIChKU0M6OnRyeVRvRGlzYXNzZW1ibGUpOgorCiAyMDE0LTAzLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IFJXSSBtZXNzYWdlIGZyZXF1ZW5jeQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fz c2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHAJKHJldmlzaW9uIDE2 NTEyOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjREaXNhc3Nl bWJsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdo dCAoQykgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQg KEMpIDIwMTIsIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC01NSwzICs1NSwxNyBAQCBib29sIHRyeVRvRGlzYXNz ZW1ibGUoY29uc3QgTWFjcm9Bc3NlbWJsCiAKICNlbmRpZiAvLyBVU0UoQVJNNjRfRElTQVNTRU1C TEVSKQogCisjaWYgVVNFKExMVk1fRElTQVNTRU1CTEVSKQorCisjaW5jbHVkZSAiTExWTURpc2Fz c2VtYmxlci5oIgorCituYW1lc3BhY2UgSlNDIHsKKworYm9vbCB0cnlUb0Rpc2Fzc2VtYmxlKGNv bnN0IE1hY3JvQXNzZW1ibGVyQ29kZVB0ciYgY29kZVB0ciwgc2l6ZV90IHNpemUsIGNvbnN0IGNo YXIqIHByZWZpeCwgUHJpbnRTdHJlYW0mIG91dCwgSW5zdHJ1Y3Rpb25TdWJzZXRIaW50IGhpbnQp Cit7CisgICAgcmV0dXJuIHRyeVRvRGlzYXNzZW1ibGVXaXRoTExWTShjb2RlUHRyLCBzaXplLCBw cmVmaXgsIG91dCwgaGludCk7Cit9CisKK30gLy8gbmFtZXNwYWNlIEpTQworCisjZW5kaWYgLy8g VVNFKExMVk1fRElTQVNTRU1CTEVSKQpJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTE3NCkKKysrIFNvdXJj ZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDMt MDUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgdGhlIExM Vk0gZGlzYXNzZW1ibGVyIG9uIEFSTTY0IGlmIHdlIGFyZSBlbmFibGluZyB0aGUgRlRMCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3ODUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9y bS5oOgorCiAyMDE0LTAzLTA1ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29t PgogCiAgICAgICAgIFtXaW4zMl1bTExJTlRdIENyYXNoIHdoZW4gcnVubmluZyBKU0Mgc3RyZXNz IHRlc3RzLgpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxNjUxMjgpCisrKyBTb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NzcsNyArNjc3LDcgQEAKICNkZWZp bmUgRU5BQkxFX0RJU0FTU0VNQkxFUiAxCiAjZW5kaWYKIAotI2lmICFkZWZpbmVkKFdURl9VU0Vf QVJNNjRfRElTQVNTRU1CTEVSKSAmJiBFTkFCTEUoSklUKSAmJiBQTEFURk9STShJT1MpICYmIENQ VShBUk02NCkKKyNpZiAhZGVmaW5lZChXVEZfVVNFX0FSTTY0X0RJU0FTU0VNQkxFUikgJiYgRU5B QkxFKEpJVCkgJiYgUExBVEZPUk0oSU9TKSAmJiBDUFUoQVJNNjQpICYmICFVU0UoTExWTV9ESVNB U1NFTUJMRVIpCiAjZGVmaW5lIFdURl9VU0VfQVJNNjRfRElTQVNTRU1CTEVSIDEKICNlbmRpZgog Cg==