129776 2014-03-05 21:27:37 -0800 Subpixel rendering: Setting content to opaque on m_graphicsLayer depends on subpixel accumulation. 2014-03-06 07:37:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 987551 0 zalan 2014-03-05 21:27:37 -0800 diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp index 2528ffa..68c9465 100644 --- a/Source/WebCore/rendering/RenderLayerBacking.cpp +++ b/Source/WebCore/rendering/RenderLayerBacking.cpp @@ -819,7 +819,7 @@ void RenderLayerBacking::updateGraphicsLayerGeometry() if (!m_isMainFrameRenderViewLayer) { // For non-root layers, background is always painted by the primary graphics layer. ASSERT(!m_backgroundLayer); - bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isEmpty(); + bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isZero(); m_graphicsLayer->setContentsOpaque(!hadSubpixelRounding && m_owningLayer.backgroundIsKnownToBeOpaqueInRect(localCompositingBounds)); } 987555 1 225951 zalan 2014-03-05 21:36:09 -0800 Created attachment 225951 Patch 987556 2 zalan 2014-03-05 21:37:42 -0800 Should find a way to test it :( 987678 3 225986 zalan 2014-03-06 06:57:11 -0800 Created attachment 225986 Patch 987689 4 225986 commit-queue 2014-03-06 07:37:11 -0800 Comment on attachment 225986 Patch Clearing flags on attachment: 225986 Committed r165190: <http://trac.webkit.org/changeset/165190> 987690 5 commit-queue 2014-03-06 07:37:14 -0800 All reviewed patches have been landed. Closing bug. 225951 2014-03-05 21:36:09 -0800 2014-03-06 06:57:09 -0800 Patch bug-129776-20140305213609.patch text/plain 1765 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQzMjQ0NDcyODU4ODcz NDgwZjFjZjEwNjZlOTliZDlhZjJjOWE0OS4uNDVhNTdlYmMxYmQzYmE1NjI5MmJjNWYyZWFmYTg2 ZTg3YTBjNTFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBTZXR0aW5nIGNvbnRlbnQgdG8gb3BhcXVlIG9uIG1fZ3JhcGhpY3NMYXllciBkZXBlbmRzIG9u IHN1YnBpeGVsIGFjY3VtdWxhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyOTc3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGlzRW1wdHkoKSByZXR1cm5zIHRydWUgd2hlbiBhbnkgb2YgdGhlIGRp bWVuc2lvbnMgaXMgPD0gMC4gU3VicGl4ZWwgYWNjdW11bGF0aW9uIGNvdWxkIGhhcHBlbgorICAg ICAgICBpbiBvbmUgYW5kL29yIHRvIG5lZ2F0aXZlIGRpcmVjdGlvbi4gVXNlIGlzWmVybygpIGlu c3RlYWQoKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVy R2VvbWV0cnkpOgorCiAyMDE0LTAzLTA1ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5j b20+CiAKICAgICAgICAgQnVpbGQgZml4LCB0YWtlIDIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDI1MjhmZmFlMDg2MjI3NzM5Nzg5 YzhiYTAwNWVlOWEwNzdiNzJjMTIuLjY4Yzk0NjUxNzExZmE2ZjRlYzMyMTJmYTFhMGI2YWUwZmQw NTkzM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuY3BwCkBAIC04MTksNyArODE5LDcgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0 ZUdyYXBoaWNzTGF5ZXJHZW9tZXRyeSgpCiAgICAgaWYgKCFtX2lzTWFpbkZyYW1lUmVuZGVyVmll d0xheWVyKSB7CiAgICAgICAgIC8vIEZvciBub24tcm9vdCBsYXllcnMsIGJhY2tncm91bmQgaXMg YWx3YXlzIHBhaW50ZWQgYnkgdGhlIHByaW1hcnkgZ3JhcGhpY3MgbGF5ZXIuCiAgICAgICAgIEFT U0VSVCghbV9iYWNrZ3JvdW5kTGF5ZXIpOwotICAgICAgICBib29sIGhhZFN1YnBpeGVsUm91bmRp bmcgPSAhbV9kZXZpY2VQaXhlbEZyYWN0aW9uRnJvbVJlbmRlcmVyLmlzRW1wdHkoKTsKKyAgICAg ICAgYm9vbCBoYWRTdWJwaXhlbFJvdW5kaW5nID0gIW1fZGV2aWNlUGl4ZWxGcmFjdGlvbkZyb21S ZW5kZXJlci5pc1plcm8oKTsKICAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09w YXF1ZSghaGFkU3VicGl4ZWxSb3VuZGluZyAmJiBtX293bmluZ0xheWVyLmJhY2tncm91bmRJc0tu b3duVG9CZU9wYXF1ZUluUmVjdChsb2NhbENvbXBvc2l0aW5nQm91bmRzKSk7CiAgICAgfQogCg== 225986 2014-03-06 06:57:11 -0800 2014-03-06 07:37:11 -0800 Patch bug-129776-20140306065714.patch text/plain 1832 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDYxNDFmM2Q2MjU2MmNm NzE2YWQxMGFkODMyNTQ1M2YxNDU3OGM0OC4uZGQwODM3NDdmMmYyNWNmZmIwYWRkYzlmNTMyZmU3 YjRjNTFhNWQyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBTZXR0aW5nIGNvbnRlbnQgdG8gb3BhcXVlIG9uIG1fZ3JhcGhpY3NMYXllciBkZXBlbmRzIG9u IHN1YnBpeGVsIGFjY3VtdWxhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyOTc3NgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KKworICAgICAgICBpc0VtcHR5KCkgcmV0dXJucyB0cnVlIHdoZW4gYW55IG9mIHRoZSBkaW1l bnNpb25zIGlzIDw9IDAuIFN1YnBpeGVsIGFjY3VtdWxhdGlvbiBjb3VsZCBoYXBwZW4KKyAgICAg ICAgaW4gb25lIGRpcmVjdGlvbiBvbmx5LiBVc2UgaXNaZXJvKCkgaW5zdGVhZCgpLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUdyYXBoaWNzTGF5ZXJHZW9tZXRyeSk6CisKIDIw MTQtMDMtMDYgIEd1cnByZWV0IEthdXIgIDxrLmd1cnByZWV0QHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIxNTgyNTQpOiBSdWJiZXItYmFuZGluZyBhdCBCaW5nIGltYWdlIHNl YXJjaCBjYXVzZXMgdGhlIHRvb2xiYXIgdG8gbW92ZSB1cCBhbmQgYXdheQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCAyNTI4ZmZhZTA4 NjIyNzczOTc4OWM4YmEwMDVlZTlhMDc3YjcyYzEyLi42OGM5NDY1MTcxMWZhNmY0ZWMzMjEyZmEx YTBiNmFlMGZkMDU5MzNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcApAQCAtODE5LDcgKzgxOSw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNr aW5nOjp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKQogICAgIGlmICghbV9pc01haW5GcmFt ZVJlbmRlclZpZXdMYXllcikgewogICAgICAgICAvLyBGb3Igbm9uLXJvb3QgbGF5ZXJzLCBiYWNr Z3JvdW5kIGlzIGFsd2F5cyBwYWludGVkIGJ5IHRoZSBwcmltYXJ5IGdyYXBoaWNzIGxheWVyLgog ICAgICAgICBBU1NFUlQoIW1fYmFja2dyb3VuZExheWVyKTsKLSAgICAgICAgYm9vbCBoYWRTdWJw aXhlbFJvdW5kaW5nID0gIW1fZGV2aWNlUGl4ZWxGcmFjdGlvbkZyb21SZW5kZXJlci5pc0VtcHR5 KCk7CisgICAgICAgIGJvb2wgaGFkU3VicGl4ZWxSb3VuZGluZyA9ICFtX2RldmljZVBpeGVsRnJh Y3Rpb25Gcm9tUmVuZGVyZXIuaXNaZXJvKCk7CiAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+c2V0 Q29udGVudHNPcGFxdWUoIWhhZFN1YnBpeGVsUm91bmRpbmcgJiYgbV9vd25pbmdMYXllci5iYWNr Z3JvdW5kSXNLbm93blRvQmVPcGFxdWVJblJlY3QobG9jYWxDb21wb3NpdGluZ0JvdW5kcykpOwog ICAgIH0KIAo=