129766 2014-03-05 17:59:14 -0800 Web Inspector: Prevent possible deadlock in view indication 2014-03-05 19:23:23 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 987464 0 joepeck 2014-03-05 17:59:14 -0800 We need the lock to get the Debuggable, but if we have the debuggable, we can use it outside of the lock. 987465 1 225932 joepeck 2014-03-05 18:00:59 -0800 Created attachment 225932 [PATCH] Proposed Fix 987481 2 225932 ggaren 2014-03-05 18:52:48 -0800 Comment on attachment 225932 [PATCH] Proposed Fix r=me 987503 3 225932 commit-queue 2014-03-05 19:23:21 -0800 Comment on attachment 225932 [PATCH] Proposed Fix Clearing flags on attachment: 225932 Committed r165165: <http://trac.webkit.org/changeset/165165> 987504 4 commit-queue 2014-03-05 19:23:23 -0800 All reviewed patches have been landed. Closing bug. 225932 2014-03-05 18:00:59 -0800 2014-03-05 19:23:21 -0800 [PATCH] Proposed Fix deadlock.patch text/plain 1851 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5MzIyZTkuLjBkZDQwNjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0LTAzLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJldmVu dCBwb3NzaWJsZSBkZWFkbG9jayBpbiB2aWV3IGluZGljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTc2NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJ bnNwZWN0b3IubW06CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6cmVjZWl2 ZWRJbmRpY2F0ZU1lc3NhZ2UpOgorCisyMDE0LTAzLTA1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQVNTRVJUSU9OIEZBSUxF RDogbV9qYXZhU2NyaXB0QnJlYWtwb2ludHMuaXNFbXB0eSgpCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3NjMKIApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCmlu ZGV4IGYxNjAwNjQuLmRkMTBiODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KQEAgLTQ3OSwxMyArNDc5 LDE2IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZlZEluZGljYXRlTWVzc2FnZShOU0Rp Y3Rpb25hcnkgKnVzZXJJbmZvKQogICAgIEJPT0wgaW5kaWNhdGVFbmFibGVkID0gW1t1c2VySW5m byBvYmplY3RGb3JLZXk6V0lSSW5kaWNhdGVFbmFibGVkS2V5XSBib29sVmFsdWVdOwogCiAgICAg ZGlzcGF0Y2hBc3luY09uUXVldWVTYWZlRm9yQW55RGVidWdnYWJsZSheewotICAgICAgICBzdGQ6 OmxvY2tfZ3VhcmQ8c3RkOjptdXRleD4gbG9jayhtX211dGV4KTsKKyAgICAgICAgUmVtb3RlSW5z cGVjdG9yRGVidWdnYWJsZSogZGVidWdnYWJsZSA9IG51bGxwdHI7CisgICAgICAgIHsKKyAgICAg ICAgICAgIHN0ZDo6bG9ja19ndWFyZDxzdGQ6Om11dGV4PiBsb2NrKG1fbXV0ZXgpOwogCi0gICAg ICAgIGF1dG8gaXQgPSBtX2RlYnVnZ2FibGVNYXAuZmluZChpZGVudGlmaWVyKTsKLSAgICAgICAg aWYgKGl0ID09IG1fZGVidWdnYWJsZU1hcC5lbmQoKSkKLSAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgICAgIGF1dG8gaXQgPSBtX2RlYnVnZ2FibGVNYXAuZmluZChpZGVudGlmaWVyKTsKKyAg ICAgICAgICAgIGlmIChpdCA9PSBtX2RlYnVnZ2FibGVNYXAuZW5kKCkpCisgICAgICAgICAgICAg ICAgcmV0dXJuOwogCi0gICAgICAgIFJlbW90ZUluc3BlY3RvckRlYnVnZ2FibGUqIGRlYnVnZ2Fi bGUgPSBpdC0+dmFsdWUuZmlyc3Q7CisgICAgICAgICAgICBkZWJ1Z2dhYmxlID0gaXQtPnZhbHVl LmZpcnN0OworICAgICAgICB9CiAgICAgICAgIGRlYnVnZ2FibGUtPnNldEluZGljYXRpbmcoaW5k aWNhdGVFbmFibGVkKTsKICAgICB9KTsKIH0K