129763 2014-03-05 15:54:15 -0800 Web Inspector: ASSERTION FAILED: m_javaScriptBreakpoints.isEmpty() 2014-03-05 19:14:09 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff joepeck bburg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 987425 0 msaboff 2014-03-05 15:54:15 -0800 I built ToT WebKit (r165132) debug. Open www.apple.com (page really doesn't seem to matter) in Safari. Open and navigate around the inspector. Close the inspector window and: ASSERTION FAILED: m_javaScriptBreakpoints.isEmpty() /Volumes/Data/src/webkit/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp(114) : virtual void Inspector::InspectorDebuggerAgent::disable(bool) 1 0x113c486e0 WTFCrash 2 0x1138a3581 Inspector::InspectorDebuggerAgent::disable(bool) 3 0x116bbd9af WebCore::WebDebuggerAgent::disable(bool) 4 0x116336adf WebCore::PageDebuggerAgent::disable(bool) 5 0x1138a3451 Inspector::InspectorDebuggerAgent::willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) 6 0x11389049e Inspector::InspectorAgentRegistry::willDestroyFrontendAndBackend(Inspector::InspectorDisconnectReason) 7 0x11591c73f WebCore::InspectorController::disconnectFrontend(Inspector::InspectorDisconnectReason) 8 0x11591ce15 WebCore::InspectorController::close() 9 0x111b381b9 WebKit::WebInspector::close() 10 0x111b41553 void IPC::callMemberFunctionImpl<WebKit::WebInspector, void (WebKit::WebInspector::*)(), std::__1::tuple<> >(WebKit::WebInspector*, void (WebKit::WebInspector::*)(), std::__1::tuple<>&&, std::index_sequence<>) 11 0x111b414c8 void IPC::callMemberFunction<WebKit::WebInspector, void (WebKit::WebInspector::*)(), std::__1::tuple<>, std::make_index_sequence<0ul> >(std::__1::tuple<>&&, WebKit::WebInspector*, void (WebKit::WebInspector::*)()) 12 0x111b4091c void IPC::handleMessage<Messages::WebInspector::Close, WebKit::WebInspector, void (WebKit::WebInspector::*)()>(IPC::MessageDecoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)()) 13 0x111b3fe67 WebKit::WebInspector::didReceiveWebInspectorMessage(IPC::Connection*, IPC::MessageDecoder&) 14 0x111b9a446 WebKit::WebPage::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) 15 0x111b9a537 non-virtual thunk to WebKit::WebPage::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) 16 0x111814baa IPC::MessageReceiverMap::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) 17 0x111cec47a WebKit::WebProcess::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) 18 0x11165a563 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) 19 0x1116526a0 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) 20 0x11165a2f1 IPC::Connection::dispatchOneMessage() 21 0x1116684f2 WTF::FunctionWrapper<void (IPC::Connection::*)()>::operator()(IPC::Connection*) 22 0x111668475 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (IPC::Connection::*)()>, void (IPC::Connection*)>::operator()() 23 0x111670202 WTF::Function<void ()>::operator()() const 24 0x11167017c std::__1::__function::__func<WTF::Function<void ()>, std::__1::allocator<WTF::Function<void ()> >, void ()>::operator()() 25 0x113c6e9ea std::__1::function<void ()>::operator()() const 26 0x113c7dfb4 WTF::RunLoop::performWork() 27 0x113c7f454 WTF::RunLoop::performWork(void*) 28 0x7fff94b949a1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 29 0x7fff94b86112 __CFRunLoopDoSources0 30 0x7fff94b8589f __CFRunLoopRun 31 0x7fff94b85325 CFRunLoopRunSpecific 987430 1 joepeck 2014-03-05 16:12:17 -0800 I'll investigate a fix. 987432 2 225924 joepeck 2014-03-05 16:23:31 -0800 Created attachment 225924 [PATCH] Proposed Fix 987482 3 225924 ggaren 2014-03-05 18:53:03 -0800 Comment on attachment 225924 [PATCH] Proposed Fix r=me 987494 4 225924 commit-queue 2014-03-05 19:14:07 -0800 Comment on attachment 225924 [PATCH] Proposed Fix Clearing flags on attachment: 225924 Committed r165163: <http://trac.webkit.org/changeset/165163> 987495 5 commit-queue 2014-03-05 19:14:09 -0800 All reviewed patches have been landed. Closing bug. 225924 2014-03-05 16:23:31 -0800 2014-03-05 19:14:07 -0800 [PATCH] Proposed Fix breakpoints.patch text/plain 1345 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRmMmY3M2YuLmY5MzIyZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQVNTRVJU SU9OIEZBSUxFRDogbV9qYXZhU2NyaXB0QnJlYWtwb2ludHMuaXNFbXB0eSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3NjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciB0aGUgbGlzdCBvZiBh bGwgYnJlYWtwb2ludHMsIGluY2x1ZGluZyB1bnJlc29sdmVkIGJyZWFrcG9pbnRzLgorCisgICAg ICAgICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcDoKKyAgICAg ICAgKEluc3BlY3Rvcjo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6Y2xlYXJJbnNwZWN0b3JCcmVh a3BvaW50U3RhdGUpOgorCiAyMDE0LTAzLTA1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgYWZ0ZXIgcjE2NTEwOSB0byBhdm9pZCBleHRyYSBj b3BpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRz L0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggZGE1NDA4NS4uYTMx NGUxNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMv SW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKQEAgLTY5NCw2ICs2OTQs OCBAQCB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmNsZWFySW5zcGVjdG9yQnJlYWtwb2lu dFN0YXRlKCkKICAgICBmb3IgKGNvbnN0IFN0cmluZyYgaWRlbnRpZmllciA6IGJyZWFrcG9pbnRJ ZGVudGlmaWVycykKICAgICAgICAgcmVtb3ZlQnJlYWtwb2ludCgmZHVtbXlFcnJvciwgaWRlbnRp Zmllcik7CiAKKyAgICBtX2phdmFTY3JpcHRCcmVha3BvaW50cy5jbGVhcigpOworCiAgICAgY2xl YXJEZWJ1Z2dlckJyZWFrcG9pbnRTdGF0ZSgpOwogfQogCg==