129754 2014-03-05 13:19:56 -0800 JSObject::fastGetOwnPropertySlot does a slow check for OverridesGetOwnPropertySlot 2014-03-05 19:15:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 987367 0 mhahnenberg 2014-03-05 13:19:56 -0800 It should just use the InlineTypeFlags in JSCell. 987368 1 225907 mhahnenberg 2014-03-05 13:21:05 -0800 Created attachment 225907 Patch 987371 2 225907 ggaren 2014-03-05 13:26:31 -0800 Comment on attachment 225907 Patch r=me Is speedup? 987483 3 mhahnenberg 2014-03-05 18:54:11 -0800 (In reply to comment #2) > (From update of attachment 225907 [details]) > r=me > > Is speedup? Doesn't affect any of the usual benchmarks, although that's not surprising since we didn't see a regression from it after 32-bit structures. 987496 4 225907 commit-queue 2014-03-05 19:14:56 -0800 Comment on attachment 225907 Patch Clearing flags on attachment: 225907 Committed r165164: <http://trac.webkit.org/changeset/165164> 987497 5 commit-queue 2014-03-05 19:15:03 -0800 All reviewed patches have been landed. Closing bug. 225907 2014-03-05 13:21:05 -0800 2014-03-05 19:14:55 -0800 Patch bug-129754-20140305131716.patch text/plain 4153 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAzLTA1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSlNPYmplY3Q6OmZhc3RHZXRPd25Qcm9wZXJ0eVNsb3QgZG9lcyBhIHNsb3cgY2hl Y2sgZm9yIE92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lVHlwZUZsYWdzIGFyZSBzdG9yZWQgaW4g SlNDZWxsLCBzbyB3ZSBjYW4ganVzdCBsb2FkIHRob3NlIGluc3RlYWQgb2YgZ29pbmcgdGhyb3Vn aCB0aGUgVHlwZUluZm8uCisKKyAgICAgICAgKiBydW50aW1lL0pTQ2VsbC5oOgorICAgICAgICAo SlNDOjpKU0NlbGw6OmlubGluZVR5cGVGbGFncyk6CisgICAgICAgICogcnVudGltZS9KU09iamVj dC5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6ZmFzdEdldE93blByb3BlcnR5U2xvdCk6Cisg ICAgICAgICogcnVudGltZS9KU1R5cGVJbmZvLmg6CisgICAgICAgIChKU0M6OlR5cGVJbmZvOjpU eXBlSW5mbyk6CisgICAgICAgIChKU0M6OlR5cGVJbmZvOjpvdmVycmlkZXNHZXRPd25Qcm9wZXJ0 eVNsb3QpOgorCiAyMDE0LTAzLTA1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgogCiAgICAgICAgIEpTRGF0YVZpZXdQcm90b3R5cGU6OmdldERhdGEoKSBhbmQgc2V0RGF0YSgp IGNyYXNoIG9uIHBsYXRmb3JtcyB0aGF0IGRvbid0IGFsbG93IHVuYWxpZ25lZCBhY2Nlc3NlcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgJKHJldmlzaW9uIDE2NTEy MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMDEsNiArMTAxLDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0U3RydWN0dXJlKFZN JiwgU3RydWN0dXJlKik7CiAgICAgdm9pZCBjbGVhclN0cnVjdHVyZSgpIHsgbV9zdHJ1Y3R1cmVJ RCA9IDA7IH0KIAorICAgIFR5cGVJbmZvOjpJbmxpbmVUeXBlRmxhZ3MgaW5saW5lVHlwZUZsYWdz KCkgY29uc3QgeyByZXR1cm4gbV9mbGFnczsgfQorCiAgICAgY29uc3QgY2hhciogY2xhc3NOYW1l KCk7CiAKICAgICAvLyBFeHRyYWN0aW5nIHRoZSB2YWx1ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkocmV2aXNpb24gMTY1MTIwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtMTIzMyw3 ICsxMjMzLDcgQEAgQUxXQVlTX0lOTElORSBib29sIEpTT2JqZWN0OjpnZXRPd25Qcm9wZQogCiBB TFdBWVNfSU5MSU5FIGJvb2wgSlNPYmplY3Q6OmZhc3RHZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0 YXRlKiBleGVjLCBWTSYgdm0sIFN0cnVjdHVyZSYgc3RydWN0dXJlLCBQcm9wZXJ0eU5hbWUgcHJv cGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpCiB7Ci0gICAgaWYgKCFzdHJ1Y3R1cmUudHlw ZUluZm8oKS5vdmVycmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3QoKSkKKyAgICBpZiAoIVR5cGVJbmZv OjpvdmVycmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3QoaW5saW5lVHlwZUZsYWdzKCkpKQogICAgICAg ICByZXR1cm4gYXNPYmplY3QodGhpcyktPmlubGluZUdldE93blByb3BlcnR5U2xvdChleGVjLCB2 bSwgc3RydWN0dXJlLCBwcm9wZXJ0eU5hbWUsIHNsb3QpOwogICAgIHJldHVybiBzdHJ1Y3R1cmUu Y2xhc3NJbmZvKCktPm1ldGhvZFRhYmxlLmdldE93blByb3BlcnR5U2xvdCh0aGlzLCBleGVjLCBw cm9wZXJ0eU5hbWUsIHNsb3QpOwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNUeXBlSW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTVHlwZUluZm8uaAkocmV2aXNpb24gMTY1MTIwKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNUeXBlSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2Nyw3IEBA IG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgLCBtX2ZsYWdzKGlubGluZVR5cGVGbGFncykK ICAgICAgICAgICAgICwgbV9mbGFnczIob3V0T2ZMaW5lVHlwZUZsYWdzKQogICAgICAgICB7Ci0g ICAgICAgICAgICBBU1NFUlQobV90eXBlID49IENvbXBvdW5kVHlwZSB8fCAhKG1fZmxhZ3MgJiBP dmVycmlkZXNWaXNpdENoaWxkcmVuKSk7CisgICAgICAgICAgICBBU1NFUlQobV90eXBlID49IENv bXBvdW5kVHlwZSB8fCAhKGlzU2V0T25GbGFnczEoT3ZlcnJpZGVzVmlzaXRDaGlsZHJlbikpKTsK ICAgICAgICAgICAgIC8vIE5vIG9iamVjdCB0aGF0IGRvZXNuJ3QgSW1wbGVtZW50c0hhc0luc3Rh bmNlIHNob3VsZCBvdmVycmlkZSBpdCEKICAgICAgICAgICAgIEFTU0VSVCgobV9mbGFncyAmIChJ bXBsZW1lbnRzSGFzSW5zdGFuY2UgfCBPdmVycmlkZXNIYXNJbnN0YW5jZSkpICE9IE92ZXJyaWRl c0hhc0luc3RhbmNlKTsKICAgICAgICAgICAgIC8vIEltcGxlbWVudHNEZWZhdWx0SGFzSW5zdGFu Y2UgbWVhbnMgKEltcGxlbWVudHNIYXNJbnN0YW5jZSAmICFPdmVycmlkZXNIYXNJbnN0YW5jZSkK QEAgLTg4LDcgKzg4LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGJvb2wgaXNFbnZpcm9u bWVudFJlY29yZCgpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFnczEoSXNFbnZpcm9ubWVudFJl Y29yZCk7IH0KICAgICAgICAgYm9vbCBvdmVycmlkZXNIYXNJbnN0YW5jZSgpIGNvbnN0IHsgcmV0 dXJuIGlzU2V0T25GbGFnczEoT3ZlcnJpZGVzSGFzSW5zdGFuY2UpOyB9CiAgICAgICAgIGJvb2wg aW1wbGVtZW50c0RlZmF1bHRIYXNJbnN0YW5jZSgpIGNvbnN0IHsgcmV0dXJuIGlzU2V0T25GbGFn czEoSW1wbGVtZW50c0RlZmF1bHRIYXNJbnN0YW5jZSk7IH0KLSAgICAgICAgYm9vbCBvdmVycmlk ZXNHZXRPd25Qcm9wZXJ0eVNsb3QoKSBjb25zdCB7IHJldHVybiBpc1NldE9uRmxhZ3MxKE92ZXJy aWRlc0dldE93blByb3BlcnR5U2xvdCk7IH0KKyAgICAgICAgYm9vbCBvdmVycmlkZXNHZXRPd25Q cm9wZXJ0eVNsb3QoKSBjb25zdCB7IHJldHVybiBvdmVycmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3Qo aW5saW5lVHlwZUZsYWdzKCkpOyB9CisgICAgICAgIHN0YXRpYyBib29sIG92ZXJyaWRlc0dldE93 blByb3BlcnR5U2xvdChJbmxpbmVUeXBlRmxhZ3MgZmxhZ3MpIHsgcmV0dXJuIGZsYWdzICYgT3Zl cnJpZGVzR2V0T3duUHJvcGVydHlTbG90OyB9CiAgICAgICAgIGJvb2wgaW50ZXJjZXB0c0dldE93 blByb3BlcnR5U2xvdEJ5SW5kZXhFdmVuV2hlbkxlbmd0aElzTm90WmVybygpIGNvbnN0IHsgcmV0 dXJuIGlzU2V0T25GbGFnczEoSW50ZXJjZXB0c0dldE93blByb3BlcnR5U2xvdEJ5SW5kZXhFdmVu V2hlbkxlbmd0aElzTm90WmVybyk7IH0KICAgICAgICAgYm9vbCBvdmVycmlkZXNWaXNpdENoaWxk cmVuKCkgY29uc3QgeyByZXR1cm4gaXNTZXRPbkZsYWdzMShPdmVycmlkZXNWaXNpdENoaWxkcmVu KTsgfQogICAgICAgICBib29sIG92ZXJyaWRlc0dldFByb3BlcnR5TmFtZXMoKSBjb25zdCB7IHJl dHVybiBpc1NldE9uRmxhZ3MyKE92ZXJyaWRlc0dldFByb3BlcnR5TmFtZXMpOyB9Cg==