129745 2014-03-05 10:33:58 -0800 Tweak after r165109 to avoid extra copies 2014-03-08 15:13:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 987300 0 andersca 2014-03-05 10:33:58 -0800 Tweak after r165109 to avoid extra copies 987302 1 225891 andersca 2014-03-05 10:36:04 -0800 Created attachment 225891 Patch 987306 2 225891 ggaren 2014-03-05 10:48:58 -0800 Comment on attachment 225891 Patch r=me 987309 3 andersca 2014-03-05 10:54:36 -0800 Committed r165115: <http://trac.webkit.org/changeset/165115> 988646 4 darin 2014-03-08 15:13:36 -0800 This was very important. The copies were not just performance problems. They were correctness problems! 225891 2014-03-05 10:36:04 -0800 2014-03-05 10:48:57 -0800 Patch bug-129745-20140305103603.patch text/plain 3565 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NzI1NWM2MTJhMTIzM2RiNjM2MjUxOGM1NTI2YWZlZWRkZTc2OGQxLi5kNmJkMzkxODI3OWEzZGQ0 ZmJjMzc5OGE5OGZhNzhjMDA4ZDkxZGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wMy0wNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFR3ZWFrIGFmdGVyIHIxNjUxMDkgdG8gYXZvaWQgZXh0cmEgY29waWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk3NDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAv SGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6OnZpc2l0UHJvdGVjdGVkT2JqZWN0cyk6Cisg ICAgICAgIChKU0M6OkhlYXA6OnZpc2l0VGVtcFNvcnRWZWN0b3JzKToKKyAgICAgICAgKEpTQzo6 SGVhcDo6Y2xlYXJSZW1lbWJlcmVkU2V0KToKKyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAg ICAgKEpTQzo6SGVhcDo6Zm9yRWFjaFByb3RlY3RlZENlbGwpOgorCiAyMDE0LTAzLTA1ICBNYXJr IEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHU3RvcmVC YXJyaWVyRWxpc2lvblBoYXNlIHNob3VsZCBzaG91bGQgR0NTdGF0ZSBkaXJlY3RseSBpbnN0ZWFk IG9mIG1fZ2NDbG9iYmVyU2V0IHdoZW4gY2FsbGluZyB3cml0ZXNPdmVybGFwKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5jcHAKaW5kZXggMjJlN2EzMjViZTI1ZjBmMjllNzk1OTk4YzVhNDgx N2ZiMzM0ZDgwNi4uMjVhNzRiMTE2NGQzYjZhNzFmNzI0NDk1ZDkzMTlkMGM4YWI2NTA0NiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKQEAgLTU2OSw3ICs1NjksNyBAQCB2b2lkIEhl YXA6OnZpc2l0UHJvdGVjdGVkT2JqZWN0cyhIZWFwUm9vdFZpc2l0b3ImIGhlYXBSb290VmlzaXRv cikKICAgICBHQ1BIQVNFKFZpc2l0UHJvdGVjdGVkT2JqZWN0cyk7CiAgICAgTUFSS19MT0dfUk9P VChtX3Nsb3RWaXNpdG9yLCAiUHJvdGVjdGVkIE9iamVjdHMiKTsKIAotICAgIGZvciAoYXV0byBw YWlyIDogbV9wcm90ZWN0ZWRWYWx1ZXMpCisgICAgZm9yIChhdXRvJiBwYWlyIDogbV9wcm90ZWN0 ZWRWYWx1ZXMpCiAgICAgICAgIGhlYXBSb290VmlzaXRvci52aXNpdCgmcGFpci5rZXkpOwogICAg IG1fc2xvdFZpc2l0b3IuZG9uYXRlQW5kRHJhaW4oKTsKIH0KQEAgLTU3OSwxMCArNTc5LDEwIEBA IHZvaWQgSGVhcDo6dmlzaXRUZW1wU29ydFZlY3RvcnMoSGVhcFJvb3RWaXNpdG9yJiBoZWFwUm9v dFZpc2l0b3IpCiAgICAgR0NQSEFTRShWaXNpdFRlbXBTb3J0VmVjdG9ycyk7CiAgICAgTUFSS19M T0dfUk9PVChtX3Nsb3RWaXNpdG9yLCAiVGVtcCBTb3J0IFZlY3RvcnMiKTsKIAotICAgIHR5cGVk ZWYgVmVjdG9yPFZlY3RvcjxWYWx1ZVN0cmluZ1BhaXIsIDAsIFVuc2FmZVZlY3Rvck92ZXJmbG93 PiogPiBWZWN0b3JPZlZhbHVlU3RyaW5nVmVjdG9yczsKKyAgICB0eXBlZGVmIFZlY3RvcjxWZWN0 b3I8VmFsdWVTdHJpbmdQYWlyLCAwLCBVbnNhZmVWZWN0b3JPdmVyZmxvdz4qPiBWZWN0b3JPZlZh bHVlU3RyaW5nVmVjdG9yczsKIAotICAgIGZvciAoYXV0byB2ZWN0b3IgOiBtX3RlbXBTb3J0aW5n VmVjdG9ycykgewotICAgICAgICBmb3IgKGF1dG8gdmFsdWVTdHJpbmdQYWlyIDogKnZlY3Rvcikg eworICAgIGZvciAoYXV0byogdmVjdG9yIDogbV90ZW1wU29ydGluZ1ZlY3RvcnMpIHsKKyAgICAg ICAgZm9yIChhdXRvJiB2YWx1ZVN0cmluZ1BhaXIgOiAqdmVjdG9yKSB7CiAgICAgICAgICAgICBp ZiAodmFsdWVTdHJpbmdQYWlyLmZpcnN0KQogICAgICAgICAgICAgICAgIGhlYXBSb290VmlzaXRv ci52aXNpdCgmdmFsdWVTdHJpbmdQYWlyLmZpcnN0KTsKICAgICAgICAgfQpAQCAtNjY4LDcgKzY2 OCw3IEBAIHZvaWQgSGVhcDo6Y2xlYXJSZW1lbWJlcmVkU2V0KFZlY3Rvcjxjb25zdCBKU0NlbGwq PiYgcmVtZW1iZXJlZFNldCkKIHsKICNpZiBFTkFCTEUoR0dDKQogICAgIEdDUEhBU0UoQ2xlYXJS ZW1lbWJlcmVkU2V0KTsKLSAgICBmb3IgKGF1dG8gY2VsbCA6IHJlbWVtYmVyZWRTZXQpCisgICAg Zm9yIChhdXRvKiBjZWxsIDogcmVtZW1iZXJlZFNldCkKICAgICAgICAgTWFya2VkQmxvY2s6OmJs b2NrRm9yKGNlbGwpLT5jbGVhclJlbWVtYmVyZWQoY2VsbCk7CiAjZWxzZQogICAgIFVOVVNFRF9Q QVJBTShyZW1lbWJlcmVkU2V0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAppbmRleCBiMTA4 MmM0NGZhOTNlNDYyZTAwZTIxMGE2YTM4ZWEwZDYxOWYxZGY0Li4wYmNlMmE1ZmZhZTM2ZTIyNGU1 YWJjNGExMzhmMDNhNzc0YjRlYmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCkBAIC0z MjgsNyArMzI4LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIEhhc2hTZXQ8Y29uc3QgSlND ZWxsKj4gbV9jb3B5aW5nUmVtZW1iZXJlZFNldDsKIAogICAgICAgICBQcm90ZWN0Q291bnRTZXQg bV9wcm90ZWN0ZWRWYWx1ZXM7Ci0gICAgICAgIFZlY3RvcjxWZWN0b3I8VmFsdWVTdHJpbmdQYWly LCAwLCBVbnNhZmVWZWN0b3JPdmVyZmxvdz4qID4gbV90ZW1wU29ydGluZ1ZlY3RvcnM7CisgICAg ICAgIFZlY3RvcjxWZWN0b3I8VmFsdWVTdHJpbmdQYWlyLCAwLCBVbnNhZmVWZWN0b3JPdmVyZmxv dz4qPiBtX3RlbXBTb3J0aW5nVmVjdG9yczsKICAgICAgICAgT3duUHRyPEhhc2hTZXQ8TWFya2Vk QXJndW1lbnRCdWZmZXIqPj4gbV9tYXJrTGlzdFNldDsKIAogICAgICAgICBNYWNoaW5lVGhyZWFk cyBtX21hY2hpbmVUaHJlYWRzOwpAQCAtNDUxLDcgKzQ1MSw3IEBAIG5hbWVzcGFjZSBKU0Mgewog CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rvcj4gaW5saW5lIHR5cGVuYW1lIEZ1bmN0b3I6 OlJldHVyblR5cGUgSGVhcDo6Zm9yRWFjaFByb3RlY3RlZENlbGwoRnVuY3RvciYgZnVuY3RvcikK ICAgICB7Ci0gICAgICAgIGZvciAoYXV0byBwYWlyIDogbV9wcm90ZWN0ZWRWYWx1ZXMpCisgICAg ICAgIGZvciAoYXV0byYgcGFpciA6IG1fcHJvdGVjdGVkVmFsdWVzKQogICAgICAgICAgICAgZnVu Y3RvcihwYWlyLmtleSk7CiAgICAgICAgIG1faGFuZGxlU2V0LmZvckVhY2hTdHJvbmdIYW5kbGUo ZnVuY3RvciwgbV9wcm90ZWN0ZWRWYWx1ZXMpOwogCg==