129720 2014-03-04 17:54:44 -0800 Streamline JSValue::get(). 2014-03-04 18:29:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling mhahnenberg oldest_to_newest 987054 0 kling 2014-03-04 17:54:44 -0800 Streamline JSValue::get() to avoid fetching Structure and VM repeatedly. 987055 1 225834 kling 2014-03-04 17:56:08 -0800 Created attachment 225834 Patch 987062 2 225834 ggaren 2014-03-04 18:09:23 -0800 Comment on attachment 225834 Patch Can you make vm and structure arguments 2 and 3, instead of the last two arguments? The last argument is the output, and I'd like to distinguish the input values from the output value. 987065 3 kling 2014-03-04 18:29:35 -0800 Committed r165090: <http://trac.webkit.org/changeset/165090> 225834 2014-03-04 17:56:08 -0800 2014-03-04 18:09:22 -0800 Patch bug-129720.diff text/plain 5236 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg0NWVjNGUuLmZjNzIyZjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTAzLTA0ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBTdHJlYW1saW5lIEpTVmFsdWU6OmdldCgp LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5NzIwPgorCisgICAgICAgIEZldGNo IGVhY2ggU3RydWN0dXJlIGFuZCBWTSBvbmx5IG9uY2Ugd2hlbiB3YWxraW5nIHRoZSBwcm90b3R5 cGUgY2hhaW4KKyAgICAgICAgaW4gSlNPYmplY3Q6OmdldFByb3BlcnR5U2xvdCgpLCB0aGVuIHBh c3MgaXQgYWxvbmcgdG8gdGhlIGZ1bmN0aW9ucworICAgICAgICB3ZSBjYWxsIGZyb20gdGhlcmUs IHNvIHRoZXkgZG9uJ3QgaGF2ZSB0byByZS1mZXRjaCBpdC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAg ICAgKEpTQzo6SlNPYmplY3Q6OmlubGluZUdldE93blByb3BlcnR5U2xvdCk6CisgICAgICAgIChK U0M6OkpTT2JqZWN0OjpmYXN0R2V0T3duUHJvcGVydHlTbG90KToKKyAgICAgICAgKEpTQzo6SlNP YmplY3Q6OmdldFByb3BlcnR5U2xvdCk6CisKKzIwMTQtMDMtMDQgIEFuZHJlYXMgS2xpbmcgIDxh a2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFNwYW0gc3RhdGljIGJyYW5jaCBwcmVkaWN0aW9u IGhpbnRzIG9uIEpTIGJpbmRpbmdzLgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5 NzAzPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVj dC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAppbmRleCA3MTZk NGRhLi4yOTg3YzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgK QEAgLTEyMCw3ICsxMjAsNyBAQCBwdWJsaWM6CiAgICAgSlNWYWx1ZSBnZXQoRXhlY1N0YXRlKiwg UHJvcGVydHlOYW1lKSBjb25zdDsKICAgICBKU1ZhbHVlIGdldChFeGVjU3RhdGUqLCB1bnNpZ25l ZCBwcm9wZXJ0eU5hbWUpIGNvbnN0OwogCi0gICAgYm9vbCBmYXN0R2V0T3duUHJvcGVydHlTbG90 KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90Jik7CisgICAgYm9vbCBmYXN0 R2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90 JiwgVk0mLCBTdHJ1Y3R1cmUmKTsKICAgICBib29sIGdldFByb3BlcnR5U2xvdChFeGVjU3RhdGUq LCBQcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwogICAgIGJvb2wgZ2V0UHJvcGVydHlTbG90 KEV4ZWNTdGF0ZSosIHVuc2lnbmVkIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90Jik7CiAKQEAg LTk0OSw3ICs5NDksNyBAQCBwcml2YXRlOgogICAgIHRlbXBsYXRlPFB1dE1vZGU+CiAgICAgYm9v bCBwdXREaXJlY3RJbnRlcm5hbChWTSYsIFByb3BlcnR5TmFtZSwgSlNWYWx1ZSwgdW5zaWduZWQg YXR0ciwgUHV0UHJvcGVydHlTbG90JiwgSlNDZWxsKik7CiAKLSAgICBib29sIGlubGluZUdldE93 blByb3BlcnR5U2xvdChFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwor ICAgIGJvb2wgaW5saW5lR2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFt ZSwgUHJvcGVydHlTbG90JiwgVk0mLCBTdHJ1Y3R1cmUmKTsKICAgICBKU19FWFBPUlRfUFJJVkFU RSB2b2lkIGZpbGxHZXR0ZXJQcm9wZXJ0eVNsb3QoUHJvcGVydHlTbG90JiwgSlNWYWx1ZSwgdW5z aWduZWQsIFByb3BlcnR5T2Zmc2V0KTsKIAogICAgIGNvbnN0IEhhc2hFbnRyeSogZmluZFByb3Bl cnR5SGFzaEVudHJ5KFZNJiwgUHJvcGVydHlOYW1lKSBjb25zdDsKQEAgLTEyMDQsMTYgKzEyMDQs MTQgQEAgaW5saW5lIEpTVmFsdWUgSlNPYmplY3Q6OnByb3RvdHlwZSgpIGNvbnN0CiAgICAgcmV0 dXJuIHN0cnVjdHVyZSgpLT5zdG9yZWRQcm90b3R5cGUoKTsKIH0KIAotQUxXQVlTX0lOTElORSBi b29sIEpTT2JqZWN0OjppbmxpbmVHZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0YXRlKiBleGVjLCBQ cm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpCitBTFdBWVNfSU5M SU5FIGJvb2wgSlNPYmplY3Q6OmlubGluZUdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4 ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYgc2xvdCwgVk0mIHZt LCBTdHJ1Y3R1cmUmIHN0cnVjdHVyZSkKIHsKICAgICB1bnNpZ25lZCBhdHRyaWJ1dGVzOwogICAg IEpTQ2VsbCogc3BlY2lmaWM7Ci0gICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKLSAgICBTdHJ1Y3R1 cmUqIHN0cnVjdHVyZSA9IHRoaXMtPnN0cnVjdHVyZSh2bSk7Ci0gICAgUHJvcGVydHlPZmZzZXQg b2Zmc2V0ID0gc3RydWN0dXJlLT5nZXQodm0sIHByb3BlcnR5TmFtZSwgYXR0cmlidXRlcywgc3Bl Y2lmaWMpOworICAgIFByb3BlcnR5T2Zmc2V0IG9mZnNldCA9IHN0cnVjdHVyZS5nZXQodm0sIHBy b3BlcnR5TmFtZSwgYXR0cmlidXRlcywgc3BlY2lmaWMpOwogICAgIGlmIChMSUtFTFkoaXNWYWxp ZE9mZnNldChvZmZzZXQpKSkgewogICAgICAgICBKU1ZhbHVlIHZhbHVlID0gZ2V0RGlyZWN0KG9m ZnNldCk7Ci0gICAgICAgIGlmIChzdHJ1Y3R1cmUtPmhhc0dldHRlclNldHRlclByb3BlcnRpZXMo KSAmJiB2YWx1ZS5pc0dldHRlclNldHRlcigpKQorICAgICAgICBpZiAoc3RydWN0dXJlLmhhc0dl dHRlclNldHRlclByb3BlcnRpZXMoKSAmJiB2YWx1ZS5pc0dldHRlclNldHRlcigpKQogICAgICAg ICAgICAgZmlsbEdldHRlclByb3BlcnR5U2xvdChzbG90LCB2YWx1ZSwgYXR0cmlidXRlcywgb2Zm c2V0KTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgc2xvdC5zZXRWYWx1ZSh0aGlzLCBhdHRy aWJ1dGVzLCB2YWx1ZSwgb2Zmc2V0KTsKQEAgLTEyMjgsMjYgKzEyMjYsMjkgQEAgQUxXQVlTX0lO TElORSBib29sIEpTT2JqZWN0OjppbmxpbmVHZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0YXRlKiBl eGVjLCBQcm9wZXJ0eU4KIC8vIGJhc2UgY2xhc3MgY2FsbCB0byB0aGlzLgogQUxXQVlTX0lOTElO RSBib29sIEpTT2JqZWN0OjpnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmplY3QqIG9iamVjdCwgRXhl Y1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNs b3QpCiB7Ci0gICAgcmV0dXJuIG9iamVjdC0+aW5saW5lR2V0T3duUHJvcGVydHlTbG90KGV4ZWMs IHByb3BlcnR5TmFtZSwgc2xvdCk7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBTdHJ1 Y3R1cmUmIHN0cnVjdHVyZSA9ICpvYmplY3QtPnN0cnVjdHVyZSh2bSk7CisgICAgcmV0dXJuIG9i amVjdC0+aW5saW5lR2V0T3duUHJvcGVydHlTbG90KGV4ZWMsIHByb3BlcnR5TmFtZSwgc2xvdCwg dm0sIHN0cnVjdHVyZSk7CiB9CiAKLUFMV0FZU19JTkxJTkUgYm9vbCBKU09iamVjdDo6ZmFzdEdl dE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5h bWUsIFByb3BlcnR5U2xvdCYgc2xvdCkKK0FMV0FZU19JTkxJTkUgYm9vbCBKU09iamVjdDo6ZmFz dEdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0 eU5hbWUsIFByb3BlcnR5U2xvdCYgc2xvdCwgVk0mIHZtLCBTdHJ1Y3R1cmUmIHN0cnVjdHVyZSkK IHsKLSAgICBWTSYgdm0gPSBleGVjLT52bSgpOwotICAgIGlmICghc3RydWN0dXJlKHZtKS0+dHlw ZUluZm8oKS5vdmVycmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3QoKSkKLSAgICAgICAgcmV0dXJuIGFz T2JqZWN0KHRoaXMpLT5pbmxpbmVHZXRPd25Qcm9wZXJ0eVNsb3QoZXhlYywgcHJvcGVydHlOYW1l LCBzbG90KTsKLSAgICByZXR1cm4gbWV0aG9kVGFibGUodm0pLT5nZXRPd25Qcm9wZXJ0eVNsb3Qo dGhpcywgZXhlYywgcHJvcGVydHlOYW1lLCBzbG90KTsKKyAgICBpZiAoIXN0cnVjdHVyZS50eXBl SW5mbygpLm92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdCgpKQorICAgICAgICByZXR1cm4gYXNP YmplY3QodGhpcyktPmlubGluZUdldE93blByb3BlcnR5U2xvdChleGVjLCBwcm9wZXJ0eU5hbWUs IHNsb3QsIHZtLCBzdHJ1Y3R1cmUpOworICAgIHJldHVybiBzdHJ1Y3R1cmUuY2xhc3NJbmZvKCkt Pm1ldGhvZFRhYmxlLmdldE93blByb3BlcnR5U2xvdCh0aGlzLCBleGVjLCBwcm9wZXJ0eU5hbWUs IHNsb3QpOwogfQogCiAvLyBJdCBtYXkgc2VlbSBjcmF6eSB0byBpbmxpbmUgYSBmdW5jdGlvbiB0 aGlzIGxhcmdlIGJ1dCBpdCBtYWtlcyBhIGJpZyBkaWZmZXJlbmNlCiAvLyBzaW5jZSB0aGlzIGlz IGZ1bmN0aW9uIHZlcnkgaG90IGluIHZhcmlhYmxlIGxvb2t1cAogQUxXQVlTX0lOTElORSBib29s IEpTT2JqZWN0OjpnZXRQcm9wZXJ0eVNsb3QoRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUg cHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpCiB7CisgICAgVk0mIHZtID0gZXhlYy0+ dm0oKTsKICAgICBKU09iamVjdCogb2JqZWN0ID0gdGhpczsKICAgICB3aGlsZSAodHJ1ZSkgewot ICAgICAgICBpZiAob2JqZWN0LT5mYXN0R2V0T3duUHJvcGVydHlTbG90KGV4ZWMsIHByb3BlcnR5 TmFtZSwgc2xvdCkpCisgICAgICAgIFN0cnVjdHVyZSYgc3RydWN0dXJlID0gKm9iamVjdC0+c3Ry dWN0dXJlKHZtKTsKKyAgICAgICAgaWYgKG9iamVjdC0+ZmFzdEdldE93blByb3BlcnR5U2xvdChl eGVjLCBwcm9wZXJ0eU5hbWUsIHNsb3QsIHZtLCBzdHJ1Y3R1cmUpKQogICAgICAgICAgICAgcmV0 dXJuIHRydWU7Ci0gICAgICAgIEpTVmFsdWUgcHJvdG90eXBlID0gb2JqZWN0LT5wcm90b3R5cGUo KTsKKyAgICAgICAgSlNWYWx1ZSBwcm90b3R5cGUgPSBzdHJ1Y3R1cmUuc3RvcmVkUHJvdG90eXBl KCk7CiAgICAgICAgIGlmICghcHJvdG90eXBlLmlzT2JqZWN0KCkpCiAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgICAgIG9iamVjdCA9IGFzT2JqZWN0KHByb3RvdHlwZSk7Cg==