129707 2014-03-04 14:31:59 -0800 [iOS][MediaControls] Reverse-pinching using the built-in controls should enter full screen 2014-03-19 14:39:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble calvaris commit-queue eric.carlson glenn philipj sergio oldest_to_newest 986983 0 jer.noble 2014-03-04 14:31:59 -0800 [iOS][MediaControls] Reverse-pinching using the built-in controls should enter full screen 986985 1 225817 jer.noble 2014-03-04 14:35:08 -0800 Created attachment 225817 Patch 986991 2 225817 eric.carlson 2014-03-04 14:42:01 -0800 Comment on attachment 225817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225817&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:265 > + handlePlayButtonTouchEnd: function(event) {  Garbage character? 988935 3 226316 jer.noble 2014-03-10 10:20:52 -0700 Created attachment 226316 Patch for landing 990549 4 226316 commit-queue 2014-03-14 10:26:41 -0700 Comment on attachment 226316 Patch for landing Rejecting attachment 226316 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226316, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6579497612607488 992269 5 jer.noble 2014-03-19 14:39:25 -0700 Committed r165919: <http://trac.webkit.org/changeset/165919> 225817 2014-03-04 14:35:08 -0800 2014-03-04 14:42:00 -0800 Patch bug-129707-20140304143508.patch text/plain 3603 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y0ODkxYzdmNTY0YzQ3 YTdhOGM5NWZjMTAyYmFiNTQxMzNiNmM2Ny4uN2VjOGRkNzY4MWZmMjlkODI4OGUxZDVmZjk4YzYx ODhlYTkwNGY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTA0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW01lZGlhQ29udHJv bHNdIFJldmVyc2UtcGluY2hpbmcgdXNpbmcgdGhlIGJ1aWx0LWluIGNvbnRyb2xzIHNob3VsZCBl bnRlciBmdWxsIHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI5NzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIGRlZmF1bHQgY29udHJvbHMgb24gaU9TIHNob3VsZCByZXNwb25kIHRvIGEg cGluY2ggZ2VzdHVyZSBieSBlbnRlcmluZyBmdWxsc2NyZWVuLiBBZGQgYSBnZXN0dXJlCisgICAg ICAgIGV2ZW50IGxpc3RlbmVyLCBhbmQgZW50ZXIgZnVsbCBzY3JlZW4gaWYgdGhlIHVzZXIgZG9l cyBhIHF1aWNrICg+MiB2ZWxvY2l0eSkgcmV2ZXJzZSAoPjEuMjUgc2NhbGUpIHBpbmNoLgorCisg ICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanM6CisgICAg ICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5jcmVhdGVCYXNlKToKKyAgICAgICAgKENvbnRy b2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZVBsYXlCdXR0b25Ub3VjaEVuZCk6CisgICAgICAgIChD b250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVCYXNlR2VzdHVyZVN0YXJ0KToKKyAgICAgICAg KENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZUJhc2VHZXN0dXJlQ2hhbmdlKToKKyAgICAg ICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZUJhc2VHZXN0dXJlRW5kKToKKwogMjAx NC0wMy0wMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBTdGFydCBwbGF5YmFjayBidXR0b24gbWlzcGxhY2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCmluZGV4IDBm Y2VjYjRlYTJhYWI0YmMxNmJlMTUyMDdkN2FjZWI2OGQ0MTRmYWQuLmYxOGM3ODljYjRmYWViODcw YTMyNDllMmM0Njg5NzUxYzNmN2NhY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCkBAIC01MSw2ICs1MSw5 IEBAIENvbnRyb2xsZXJJT1MucHJvdG90eXBlID0gewogICAgICAgICBzdGFydFBsYXliYWNrQnV0 dG9uLnNldEF0dHJpYnV0ZSgncHNldWRvJywgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtc3RhcnQt cGxheWJhY2stYnV0dG9uJyk7CiAgICAgICAgIHN0YXJ0UGxheWJhY2tCdXR0b24uc2V0QXR0cmli dXRlKCdhcmlhLWxhYmVsJywgdGhpcy5VSVN0cmluZygnU3RhcnQgUGxheWJhY2snKSk7CiAKKyAg ICAgICAgdGhpcy5saXN0ZW5Gb3IodGhpcy5iYXNlLCAnZ2VzdHVyZXN0YXJ0JywgdGhpcy5oYW5k bGVCYXNlR2VzdHVyZVN0YXJ0KTsKKyAgICAgICAgdGhpcy5saXN0ZW5Gb3IodGhpcy5iYXNlLCAn Z2VzdHVyZWNoYW5nZScsIHRoaXMuaGFuZGxlQmFzZUdlc3R1cmVDaGFuZ2UpOworICAgICAgICB0 aGlzLmxpc3RlbkZvcih0aGlzLmJhc2UsICdnZXN0dXJlZW5kJywgdGhpcy5oYW5kbGVCYXNlR2Vz dHVyZUVuZCk7CiAgICAgICAgIHRoaXMubGlzdGVuRm9yKHRoaXMuYmFzZSwgJ3RvdWNoc3RhcnQn LCB0aGlzLmhhbmRsZVdyYXBwZXJUb3VjaFN0YXJ0KTsKICAgICAgICAgdGhpcy5zdG9wTGlzdGVu aW5nRm9yKHRoaXMuYmFzZSwgJ21vdXNlbW92ZScsIHRoaXMuaGFuZGxlV3JhcHBlck1vdXNlTW92 ZSk7CiAgICAgICAgIHRoaXMuc3RvcExpc3RlbmluZ0Zvcih0aGlzLmJhc2UsICdtb3VzZW91dCcs IHRoaXMuaGFuZGxlV3JhcHBlck1vdXNlT3V0KTsKQEAgLTI1OSw3ICsyNjIsNyBAQCBDb250cm9s bGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5jb250cm9scy5wbGF5QnV0dG9uLmNs YXNzTGlzdC5hZGQoJ2FjdGl2ZScpOwogICAgIH0sCiAKLSAgICBoYW5kbGVQbGF5QnV0dG9uVG91 Y2hFbmQ6IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgaGFuZGxlUGxheUJ1dHRvblRvdWNoRW5kOiBm dW5jdGlvbihldmVudCkge8KgCiAgICAgICAgIHRoaXMuY29udHJvbHMucGxheUJ1dHRvbi5jbGFz c0xpc3QucmVtb3ZlKCdhY3RpdmUnKTsKIAogICAgICAgICBpZiAodGhpcy5jYW5QbGF5KCkpCkBA IC0yNzUsNiArMjc4LDMyIEBAIENvbnRyb2xsZXJJT1MucHJvdG90eXBlID0gewogICAgICAgICBl dmVudC5zdG9wUHJvcGFnYXRpb24oKTsKICAgICB9LAogCisgICAgaGFuZGxlQmFzZUdlc3R1cmVT dGFydDogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgdGhpcy5nZXN0dXJlU3RhcnRUaW1lID0g bmV3IERhdGUoKTsKKyAgICB9LAorCisgICAgaGFuZGxlQmFzZUdlc3R1cmVDaGFuZ2U6IGZ1bmN0 aW9uKGV2ZW50KSB7CisgICAgICAgIGlmICghdGhpcy52aWRlby5jb250cm9scyB8fCB0aGlzLmlz QXVkaW8oKSB8fCB0aGlzLmlzRnVsbFNjcmVlbigpIHx8IHRoaXMuZ2VzdHVyZVN0YXJ0VGltZSA9 PT0gdW5kZWZpbmVkKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBjdXJyZW50 R2VzdHVyZVRpbWUgPSBuZXcgRGF0ZSgpOworICAgICAgICB2YXIgZHVyYXRpb24gPSAoY3VycmVu dEdlc3R1cmVUaW1lIC0gdGhpcy5nZXN0dXJlU3RhcnRUaW1lKSAvIDEwMDA7CisgICAgICAgIGlm ICghZHVyYXRpb24pCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFyIHZlbG9jaXR5 ID0gTWF0aC5hYnMoZXZlbnQuc2NhbGUgLSAxKSAvIGR1cmF0aW9uOworCisgICAgICAgIGlmIChl dmVudC5zY2FsZSA8IDEuMjUgfHwgdmVsb2NpdHkgPCAyKQorICAgICAgICAgICAgcmV0dXJuOwor CisgICAgICAgIGRlbGV0ZSB0aGlzLmdlc3R1cmVTdGFydFRpbWU7CisgICAgICAgIHRoaXMudmlk ZW8ud2Via2l0RW50ZXJGdWxsc2NyZWVuKCk7CisgICAgfSwKKworICAgIGhhbmRsZUJhc2VHZXN0 dXJlRW5kOiBmdW5jdGlvbihldmVudCkgeworICAgICAgICBkZWxldGUgdGhpcy5nZXN0dXJlU3Rh cnRUaW1lOworICAgIH0sCisKICAgICBoYW5kbGVXcmFwcGVyVG91Y2hTdGFydDogZnVuY3Rpb24o ZXZlbnQpIHsKICAgICAgICAgaWYgKGV2ZW50LnRhcmdldCAhPSB0aGlzLmJhc2UgJiYgZXZlbnQu dGFyZ2V0ICE9IHRoaXMuY29udHJvbHMud2lyZWxlc3NQbGF5YmFja1N0YXR1cykKICAgICAgICAg ICAgIHJldHVybjsK 226316 2014-03-10 10:20:52 -0700 2014-03-14 10:33:45 -0700 Patch for landing bug-129707-20140310102119.patch text/plain 3293 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFjOGVjNzg1N2E0YTQ2 ZjUzYTE4YmZmNjQ5ODZjZDExMWZjNDUwMC4uYzZjNjZhYmM1ZTM1NDNiOWRiMTY3YjFkZjBkZDAy N2U1YmI2MjUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTA0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW01lZGlhQ29udHJv bHNdIFJldmVyc2UtcGluY2hpbmcgdXNpbmcgdGhlIGJ1aWx0LWluIGNvbnRyb2xzIHNob3VsZCBl bnRlciBmdWxsIHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI5NzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIGRlZmF1bHQgY29udHJvbHMgb24gaU9TIHNob3VsZCByZXNwb25kIHRvIGEg cGluY2ggZ2VzdHVyZSBieSBlbnRlcmluZyBmdWxsc2NyZWVuLiBBZGQgYSBnZXN0dXJlCisgICAg ICAgIGV2ZW50IGxpc3RlbmVyLCBhbmQgZW50ZXIgZnVsbCBzY3JlZW4gaWYgdGhlIHVzZXIgZG9l cyBhIHF1aWNrICg+MiB2ZWxvY2l0eSkgcmV2ZXJzZSAoPjEuMjUgc2NhbGUpIHBpbmNoLgorCisg ICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanM6CisgICAg ICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5jcmVhdGVCYXNlKToKKyAgICAgICAgKENvbnRy b2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZVBsYXlCdXR0b25Ub3VjaEVuZCk6CisgICAgICAgIChD b250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVCYXNlR2VzdHVyZVN0YXJ0KToKKyAgICAgICAg KENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZUJhc2VHZXN0dXJlQ2hhbmdlKToKKyAgICAg ICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZUJhc2VHZXN0dXJlRW5kKToKKwogMjAx NC0wMy0wMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBTdGFydCBwbGF5YmFjayBidXR0b24gbWlzcGxhY2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCmluZGV4IDBm Y2VjYjRlYTJhYWI0YmMxNmJlMTUyMDdkN2FjZWI2OGQ0MTRmYWQuLjhjM2JkZTA5NzM3NDZiNzA5 MjdhOTE5NjA1MDhiNDRlOTI3MjUxM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCkBAIC01MSw2ICs1MSw5 IEBAIENvbnRyb2xsZXJJT1MucHJvdG90eXBlID0gewogICAgICAgICBzdGFydFBsYXliYWNrQnV0 dG9uLnNldEF0dHJpYnV0ZSgncHNldWRvJywgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtc3RhcnQt cGxheWJhY2stYnV0dG9uJyk7CiAgICAgICAgIHN0YXJ0UGxheWJhY2tCdXR0b24uc2V0QXR0cmli dXRlKCdhcmlhLWxhYmVsJywgdGhpcy5VSVN0cmluZygnU3RhcnQgUGxheWJhY2snKSk7CiAKKyAg ICAgICAgdGhpcy5saXN0ZW5Gb3IodGhpcy5iYXNlLCAnZ2VzdHVyZXN0YXJ0JywgdGhpcy5oYW5k bGVCYXNlR2VzdHVyZVN0YXJ0KTsKKyAgICAgICAgdGhpcy5saXN0ZW5Gb3IodGhpcy5iYXNlLCAn Z2VzdHVyZWNoYW5nZScsIHRoaXMuaGFuZGxlQmFzZUdlc3R1cmVDaGFuZ2UpOworICAgICAgICB0 aGlzLmxpc3RlbkZvcih0aGlzLmJhc2UsICdnZXN0dXJlZW5kJywgdGhpcy5oYW5kbGVCYXNlR2Vz dHVyZUVuZCk7CiAgICAgICAgIHRoaXMubGlzdGVuRm9yKHRoaXMuYmFzZSwgJ3RvdWNoc3RhcnQn LCB0aGlzLmhhbmRsZVdyYXBwZXJUb3VjaFN0YXJ0KTsKICAgICAgICAgdGhpcy5zdG9wTGlzdGVu aW5nRm9yKHRoaXMuYmFzZSwgJ21vdXNlbW92ZScsIHRoaXMuaGFuZGxlV3JhcHBlck1vdXNlTW92 ZSk7CiAgICAgICAgIHRoaXMuc3RvcExpc3RlbmluZ0Zvcih0aGlzLmJhc2UsICdtb3VzZW91dCcs IHRoaXMuaGFuZGxlV3JhcHBlck1vdXNlT3V0KTsKQEAgLTI3NSw2ICsyNzgsMzIgQEAgQ29udHJv bGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOwog ICAgIH0sCiAKKyAgICBoYW5kbGVCYXNlR2VzdHVyZVN0YXJ0OiBmdW5jdGlvbihldmVudCkgewor ICAgICAgICB0aGlzLmdlc3R1cmVTdGFydFRpbWUgPSBuZXcgRGF0ZSgpOworICAgIH0sCisKKyAg ICBoYW5kbGVCYXNlR2VzdHVyZUNoYW5nZTogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgaWYg KCF0aGlzLnZpZGVvLmNvbnRyb2xzIHx8IHRoaXMuaXNBdWRpbygpIHx8IHRoaXMuaXNGdWxsU2Ny ZWVuKCkgfHwgdGhpcy5nZXN0dXJlU3RhcnRUaW1lID09PSB1bmRlZmluZWQpCisgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgdmFyIGN1cnJlbnRHZXN0dXJlVGltZSA9IG5ldyBEYXRlKCk7 CisgICAgICAgIHZhciBkdXJhdGlvbiA9IChjdXJyZW50R2VzdHVyZVRpbWUgLSB0aGlzLmdlc3R1 cmVTdGFydFRpbWUpIC8gMTAwMDsKKyAgICAgICAgaWYgKCFkdXJhdGlvbikKKyAgICAgICAgICAg IHJldHVybjsKKworICAgICAgICB2YXIgdmVsb2NpdHkgPSBNYXRoLmFicyhldmVudC5zY2FsZSAt IDEpIC8gZHVyYXRpb247CisKKyAgICAgICAgaWYgKGV2ZW50LnNjYWxlIDwgMS4yNSB8fCB2ZWxv Y2l0eSA8IDIpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgZGVsZXRlIHRoaXMuZ2Vz dHVyZVN0YXJ0VGltZTsKKyAgICAgICAgdGhpcy52aWRlby53ZWJraXRFbnRlckZ1bGxzY3JlZW4o KTsKKyAgICB9LAorCisgICAgaGFuZGxlQmFzZUdlc3R1cmVFbmQ6IGZ1bmN0aW9uKGV2ZW50KSB7 CisgICAgICAgIGRlbGV0ZSB0aGlzLmdlc3R1cmVTdGFydFRpbWU7CisgICAgfSwKKwogICAgIGhh bmRsZVdyYXBwZXJUb3VjaFN0YXJ0OiBmdW5jdGlvbihldmVudCkgewogICAgICAgICBpZiAoZXZl bnQudGFyZ2V0ICE9IHRoaXMuYmFzZSAmJiBldmVudC50YXJnZXQgIT0gdGhpcy5jb250cm9scy53 aXJlbGVzc1BsYXliYWNrU3RhdHVzKQogICAgICAgICAgICAgcmV0dXJuOwo=