129699 2014-03-04 13:22:37 -0800 REGRESSION(r164812): it made things run slower (Requested by pizlo on #webkit). 2014-03-04 13:25:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129435 1 commit-queue commit-queue fpizlo oliver rniwa oldest_to_newest 986942 0 commit-queue 2014-03-04 13:22:37 -0800 http://trac.webkit.org/changeset/164812 broke the build: it made things run slower (Requested by pizlo on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 986944 1 225808 commit-queue 2014-03-04 13:22:59 -0800 Created attachment 225808 ROLLOUT of r164812 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 986946 2 fpizlo 2014-03-04 13:23:06 -0800 *** Bug 129636 has been marked as a duplicate of this bug. *** 986947 3 225808 commit-queue 2014-03-04 13:25:17 -0800 Comment on attachment 225808 ROLLOUT of r164812 Clearing flags on attachment: 225808 Committed r165073: <http://trac.webkit.org/changeset/165073> 986948 4 commit-queue 2014-03-04 13:25:20 -0800 All reviewed patches have been landed. Closing bug. 225808 2014-03-04 13:22:59 -0800 2014-03-04 13:25:17 -0800 ROLLOUT of r164812 bug-129699-20140304132259.patch text/plain 6262 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OGJlNjEyNjQ5YjA0ZmYyNmM1NmU3ZmRkNWY2ZGEzMDViNGJiZGQ5Li4yNzE0OTU2ZmI0ZDU1OGI0 NGU3OWFkYTIwYTNmMjViM2Y4ZThiYTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0wMy0wNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE2NDgxMi4KKyAgICAg ICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTY0ODEyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk2OTkKKworICAgICAgICBpdCBt YWRlIHRoaW5ncyBydW4gc2xvd2VyIChSZXF1ZXN0ZWQgYnkgcGl6bG8gb24gI3dlYmtpdCkuCisK KyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6Oklu dGVycHJldGVyOjpleGVjdXRlKToKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAoR2xvYmFs T2JqZWN0OjpmaW5pc2hDcmVhdGlvbik6CisgICAgICAgICogcnVudGltZS9CYXRjaGVkVHJhbnNp dGlvbk9wdGltaXplci5oOgorICAgICAgICAoSlNDOjpCYXRjaGVkVHJhbnNpdGlvbk9wdGltaXpl cjo6QmF0Y2hlZFRyYW5zaXRpb25PcHRpbWl6ZXIpOgorICAgICAgICAoSlNDOjpCYXRjaGVkVHJh bnNpdGlvbk9wdGltaXplcjo6fkJhdGNoZWRUcmFuc2l0aW9uT3B0aW1pemVyKToKKwogMjAxNC0w My0wMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEdldE15QXJn dW1lbnRCeVZhbCBpbiBGVEwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvSW50ZXJwcmV0ZXIuY3BwCmluZGV4IGZjN2E5OTYwZGU1ZWM4MWNjMmU3NGZkODE0NGEwOTg2 ZDQ1MGE3YzQuLmMyMTliY2JiZGFhMDA5NDk1NmM1ODc3YTUzNGYyYTBjMzVjNGRiNmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcApA QCAtMTE3OSwyNiArMTE3OSwxOCBAQCBKU1ZhbHVlIEludGVycHJldGVyOjpleGVjdXRlKEV2YWxF eGVjdXRhYmxlKiBldmFsLCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwgSlNWYWx1ZQogICAgICAgICBp ZiAodmFyaWFibGVPYmplY3QtPm5leHQoKSkKICAgICAgICAgICAgIHZhcmlhYmxlT2JqZWN0LT5n bG9iYWxPYmplY3QoKS0+dmFySW5qZWN0aW9uV2F0Y2hwb2ludCgpLT5maXJlQWxsKCk7CiAKLSAg ICAgICAgewotICAgICAgICAgICAgU2FtcGxpbmdSZWdpb24gc2FtcGxpbmdSZWdpb24oInZhcmlh YmxlIHB1dHMiKTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IG51bVZhcmlhYmxlczsgKytpKSB7Ci0gICAgICAgICAgICAgICAgY29uc3QgSWRlbnRp ZmllciYgaWRlbnQgPSBjb2RlQmxvY2stPnZhcmlhYmxlKGkpOwotICAgICAgICAgICAgICAgIGlm ICghdmFyaWFibGVPYmplY3QtPmhhc1Byb3BlcnR5KGNhbGxGcmFtZSwgaWRlbnQpKSB7Ci0gICAg ICAgICAgICAgICAgICAgIFB1dFByb3BlcnR5U2xvdCBzbG90KHZhcmlhYmxlT2JqZWN0KTsKLSAg ICAgICAgICAgICAgICAgICAgdmFyaWFibGVPYmplY3QtPm1ldGhvZFRhYmxlKCktPnB1dCh2YXJp YWJsZU9iamVjdCwgY2FsbEZyYW1lLCBpZGVudCwganNVbmRlZmluZWQoKSwgc2xvdCk7Ci0gICAg ICAgICAgICAgICAgfQorICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtVmFyaWFi bGVzOyArK2kpIHsKKyAgICAgICAgICAgIGNvbnN0IElkZW50aWZpZXImIGlkZW50ID0gY29kZUJs b2NrLT52YXJpYWJsZShpKTsKKyAgICAgICAgICAgIGlmICghdmFyaWFibGVPYmplY3QtPmhhc1By b3BlcnR5KGNhbGxGcmFtZSwgaWRlbnQpKSB7CisgICAgICAgICAgICAgICAgUHV0UHJvcGVydHlT bG90IHNsb3QodmFyaWFibGVPYmplY3QpOworICAgICAgICAgICAgICAgIHZhcmlhYmxlT2JqZWN0 LT5tZXRob2RUYWJsZSgpLT5wdXQodmFyaWFibGVPYmplY3QsIGNhbGxGcmFtZSwgaWRlbnQsIGpz VW5kZWZpbmVkKCksIHNsb3QpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAg ewotICAgICAgICAgICAgU2FtcGxpbmdSZWdpb24gc2FtcGxpbmdSZWdpb24oImZ1bmN0aW9uIHB1 dHMiKTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1G dW5jdGlvbnM7ICsraSkgewotICAgICAgICAgICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSogZnVu Y3Rpb24gPSBjb2RlQmxvY2stPmZ1bmN0aW9uRGVjbChpKTsKLSAgICAgICAgICAgICAgICBQdXRQ cm9wZXJ0eVNsb3Qgc2xvdCh2YXJpYWJsZU9iamVjdCk7Ci0gICAgICAgICAgICAgICAgdmFyaWFi bGVPYmplY3QtPm1ldGhvZFRhYmxlKCktPnB1dCh2YXJpYWJsZU9iamVjdCwgY2FsbEZyYW1lLCBm dW5jdGlvbi0+bmFtZSgpLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGZ1bmN0aW9uLCBzY29wZSks IHNsb3QpOwotICAgICAgICAgICAgfQorICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bUZ1 bmN0aW9uczsgKytpKSB7CisgICAgICAgICAgICBGdW5jdGlvbkV4ZWN1dGFibGUqIGZ1bmN0aW9u ID0gY29kZUJsb2NrLT5mdW5jdGlvbkRlY2woaSk7CisgICAgICAgICAgICBQdXRQcm9wZXJ0eVNs b3Qgc2xvdCh2YXJpYWJsZU9iamVjdCk7CisgICAgICAgICAgICB2YXJpYWJsZU9iamVjdC0+bWV0 aG9kVGFibGUoKS0+cHV0KHZhcmlhYmxlT2JqZWN0LCBjYWxsRnJhbWUsIGZ1bmN0aW9uLT5uYW1l KCksIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgZnVuY3Rpb24sIHNjb3BlKSwgc2xvdCk7CiAgICAg ICAgIH0KICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggMzUwODFmZTRhNWZjM2MzMmRi YTBlMTcxN2VhNTA4NGQzZTE3NjdhOC4uNjhmZWI2OGM3NmIxN2NiZThjMzYwZjRjZGU3M2QyNGU3 M2M0MTI1YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKQEAgLTI1LDcgKzI1LDYgQEAKICNpbmNsdWRl ICJBUElTaGltcy5oIgogI2luY2x1ZGUgIkJ1dHRlcmZseUlubGluZXMuaCIKICNpbmNsdWRlICJC eXRlY29kZUdlbmVyYXRvci5oIgotI2luY2x1ZGUgIkNvZGVDYWNoZS5oIgogI2luY2x1ZGUgIkNv bXBsZXRpb24uaCIKICNpbmNsdWRlICJDb3BpZWRTcGFjZUlubGluZXMuaCIKICNpbmNsdWRlICJF eGNlcHRpb25IZWxwZXJzLmgiCkBAIC0yNDEsNyArMjQwLDYgQEAgc3RhdGljIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25UcmFuc2ZlckFycmF5QnVmZmVyKEV4ZWNTdGF0ZSop Owogc3RhdGljIE5PX1JFVFVSTl9XSVRIX1ZBTFVFIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NB TEwgZnVuY3Rpb25RdWl0KEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgZnVuY3Rpb25GYWxzZShFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1 ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRWZmZWN0ZnVsNDIoRXhlY1N0YXRlKik7Ci1zdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNsZWFyQ29kZUNhY2hlKEV4ZWNT dGF0ZSopOwogCiAjaWYgRU5BQkxFKFNBTVBMSU5HX0ZMQUdTKQogc3RhdGljIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25TZXRTYW1wbGluZ0ZsYWdzKEV4ZWNTdGF0ZSopOwpA QCAtMzc5LDcgKzM3Nyw2IEBAIHByb3RlY3RlZDoKICAgICAgICAgcHV0RGlyZWN0TmF0aXZlRnVu Y3Rpb24odm0sIHRoaXMsIElkZW50aWZpZXIoJnZtLCAiREZHVHJ1ZSIpLCAwLCBmdW5jdGlvbkZh bHNlLCBERkdUcnVlLCBEb250RW51bSB8IEpTQzo6RnVuY3Rpb24pOwogICAgICAgICAKICAgICAg ICAgYWRkRnVuY3Rpb24odm0sICJlZmZlY3RmdWw0MiIsIGZ1bmN0aW9uRWZmZWN0ZnVsNDIsIDAp OwotICAgICAgICBhZGRGdW5jdGlvbih2bSwgImNsZWFyQ29kZUNhY2hlIiwgZnVuY3Rpb25DbGVh ckNvZGVDYWNoZSwgMCk7CiAgICAgICAgIAogICAgICAgICBKU0FycmF5KiBhcnJheSA9IGNvbnN0 cnVjdEVtcHR5QXJyYXkoZ2xvYmFsRXhlYygpLCAwKTsKICAgICAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBhcmd1bWVudHMuc2l6ZSgpOyArK2kpCkBAIC03NTEsMTMgKzc0OCw2IEBAIEVuY29k ZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25FZmZlY3RmdWw0MihFeGVjU3RhdGUqKQog ICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoNDIpKTsKIH0KIAotRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNsZWFyQ29kZUNhY2hlKEV4ZWNTdGF0ZSogZXhl YykKLXsKLSAgICBpZiAoQ29kZUNhY2hlKiBjYWNoZSA9IGV4ZWMtPnZtKCkuY29kZUNhY2hlKCkp Ci0gICAgICAgIGNhY2hlLT5jbGVhcigpOwotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNV bmRlZmluZWQoKSk7Ci19Ci0KIC8vIFVzZSBTRUggZm9yIFJlbGVhc2UgYnVpbGRzIG9ubHkgdG8g Z2V0IHJpZCBvZiB0aGUgY3Jhc2ggcmVwb3J0IGRpYWxvZwogLy8gKGx1Y2tpbHkgdGhlIHNhbWUg dGVzdHMgZmFpbCBpbiBSZWxlYXNlIGFuZCBEZWJ1ZyBidWlsZHMgc28gZmFyKS4gTmVlZCB0bwog Ly8gYmUgaW4gYSBzZXBhcmF0ZSBtYWluIGZ1bmN0aW9uIGJlY2F1c2UgdGhlIGpzY21haW4gZnVu Y3Rpb24gcmVxdWlyZXMgb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9CYXRjaGVkVHJhbnNpdGlvbk9wdGltaXplci5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQmF0Y2hlZFRyYW5zaXRpb25PcHRpbWl6ZXIuaAppbmRleCA0YjUyMWI4YjVh YTM1MzBkYmMzNTJlZmUxZGY1MjNhNjQ3ZTU0ZDMzLi43NmRlZjcxMzg0N2RkZTc1ODQ4MzljNDI3 OGNkOWI2MjIwZjU3M2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9CYXRjaGVkVHJhbnNpdGlvbk9wdGltaXplci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0JhdGNoZWRUcmFuc2l0aW9uT3B0aW1pemVyLmgKQEAgLTEsNSArMSw2IEBACisv LyAtKi0gbW9kZTogYysrOyBjLWJhc2ljLW9mZnNldDogNCAtKi0KIC8qCi0gKiBDb3B5cmlnaHQg KEMpIDIwMDgsIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMzUsMTMgKzM2LDEzIEBAIGNsYXNzIEJhdGNoZWRUcmFu c2l0aW9uT3B0aW1pemVyIHsKIHB1YmxpYzoKICAgICBCYXRjaGVkVHJhbnNpdGlvbk9wdGltaXpl cihWTSYgdm0sIEpTT2JqZWN0KiBvYmplY3QpCiAgICAgICAgIDogbV92bSgmdm0pCi0gICAgICAg ICwgbV9vYmplY3Qob2JqZWN0LT5zdHJ1Y3R1cmUoKS0+aXNEaWN0aW9uYXJ5KCkgPyBudWxscHRy IDogb2JqZWN0KQorICAgICAgICAsIG1fb2JqZWN0KG9iamVjdCkKICAgICB7CiAgICAgfQogCiAg ICAgfkJhdGNoZWRUcmFuc2l0aW9uT3B0aW1pemVyKCkKICAgICB7Ci0gICAgICAgIGlmIChtX29i amVjdCAmJiBtX29iamVjdC0+c3RydWN0dXJlKCktPmlzRGljdGlvbmFyeSgpKQorICAgICAgICBp ZiAobV9vYmplY3QtPnN0cnVjdHVyZSgpLT5pc0RpY3Rpb25hcnkoKSkKICAgICAgICAgICAgIG1f b2JqZWN0LT5mbGF0dGVuRGljdGlvbmFyeU9iamVjdCgqbV92bSk7CiAgICAgfQogCg==