129698 2014-03-04 13:22:16 -0800 ASSERT Failure: stringImpl.length() > 1 in JSString.h 2014-03-05 11:41:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED WORKSFORME P2 Normal --- 1 msaboff msaboff commit-queue oldest_to_newest 986941 0 msaboff 2014-03-04 13:22:16 -0800 This ASSERT (and preceding comment) // Should have picked a VM-global empty or single-character string already. ASSERT(stringImpl.length() > 1); isn't accurate. The ASSERT should be updated to handle the case where we have a single character string with the characters value greater than JSC::maxSingleCharacterString (currently 255). 986949 1 225809 msaboff 2014-03-04 13:25:55 -0800 Created attachment 225809 Patch 986958 2 225809 ggaren 2014-03-04 13:50:04 -0800 Comment on attachment 225809 Patch r=me 986959 3 225809 commit-queue 2014-03-04 13:51:10 -0800 Comment on attachment 225809 Patch Rejecting attachment 225809 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 225809, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/runtime/JSString.h Hunk #1 FAILED at 416. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/JSString.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4558849583349760 986993 4 msaboff 2014-03-04 14:45:31 -0800 akling fixed this by removing the ASSERT in r165066. 225809 2014-03-04 13:25:55 -0800 2014-03-04 13:51:10 -0800 Patch 129698.patch text/plain 1657 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MDcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAzLTA0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFTU0VSVCBGYWlsdXJlOiBzdHJpbmdJbXBsLmxlbmd0aCgpID4gMSBpbiBKU1N0cmluZy5o CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk2OTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVk IHRoZSBBU1NFUlQgdG8gYWxzbyBjaGVjayBmb3Igc2luZ2xlIGNoYXJhY3RlciBzdHJpbmdzIHRo YXQgY29udGFpbiBhCisgICAgICAgIGNoYXJhY3RlciB3aXRoIHRoZSB2YWx1ZSBncmVhdGVyIHRo YW4gSlNDOjptYXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcuCisKKyAgICAgICAgKiBydW50aW1lL0pT U3RyaW5nLmg6CisgICAgICAgIChKU0M6OmpzU3RyaW5nV2l0aFdlYWtPd25lcik6CisKIDIwMTQt MDMtMDIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBHZXRNeUFy Z3VtZW50QnlWYWwgaW4gRlRMCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U1N0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT U3RyaW5nLmgJKHJldmlzaW9uIDE2NTA1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTU3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTQxNiw4ICs0MTYsMTAgQEAgbmFtZXNw YWNlIEpTQyB7CiAgICAgewogICAgICAgICBXZWFrSGFuZGxlT3duZXIqIGpzU3RyaW5nV2Vha093 bmVyID0gdm0uanNTdHJpbmdXZWFrT3duZXIuZ2V0KCk7CiAKLSAgICAgICAgLy8gU2hvdWxkIGhh dmUgcGlja2VkIGEgVk0tZ2xvYmFsIGVtcHR5IG9yIHNpbmdsZS1jaGFyYWN0ZXIgc3RyaW5nIGFs cmVhZHkuCi0gICAgICAgIEFTU0VSVChzdHJpbmdJbXBsLmxlbmd0aCgpID4gMSk7CisgICAgICAg IC8vIFNob3VsZCBoYXZlIHBpY2tlZCBhIFZNLWdsb2JhbCBlbXB0eSBvciBzaW5nbGUtY2hhcmFj dGVyIHN0cmluZyBhbHJlYWR5IGlmCisgICAgICAgIC8vIGl0IGlzIHBvc3NpYmxlIHRvIG1ha2Ug YSBzaW5nbGUgY2hhcmFjdGVyIHN0cmluZy4KKyAgICAgICAgQVNTRVJUKChzdHJpbmdJbXBsLmxl bmd0aCgpID4gMSkKKyAgICAgICAgICAgIHx8ICgoc3RyaW5nSW1wbC5sZW5ndGgoKSA9PSAxKSAm JiAoc3RyaW5nSW1wbFswdV0gPiBKU0M6Om1heFNpbmdsZUNoYXJhY3RlclN0cmluZykpKTsKIAog ICAgICAgICAvLyBJZiB0aGlzIFZNIGlzIG5vdCBhbGxvd2VkIHRvIHdlYWtseSBvd24gc3RyaW5n cyBqdXN0IG1ha2UgYSBuZXcgSlNTdHJpbmcuCiAgICAgICAgIGlmICghanNTdHJpbmdXZWFrT3du ZXIpCg==