129697 2014-03-04 13:04:59 -0800 Web Inspector: Listen for the XPC_ERROR_CONNECTION_INVALID event to deref 2014-03-04 14:09:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue simon.fraser timothy oldest_to_newest 986934 0 joepeck 2014-03-04 13:04:59 -0800 We could have deref'd on XPC_ERROR_CONNECTION_INTERRUPTED instead of XPC_ERROR_CONNECTION_INVALID. Explicitly deref only on XPC_ERROR_CONNECTION_INVALID. 986936 1 225805 joepeck 2014-03-04 13:07:04 -0800 Created attachment 225805 [PATCH] Proposed Fix 986966 2 225805 commit-queue 2014-03-04 14:09:36 -0800 Comment on attachment 225805 [PATCH] Proposed Fix Clearing flags on attachment: 225805 Committed r165075: <http://trac.webkit.org/changeset/165075> 986967 3 commit-queue 2014-03-04 14:09:38 -0800 All reviewed patches have been landed. Closing bug. 225805 2014-03-04 13:07:04 -0800 2014-03-04 14:09:35 -0800 [PATCH] Proposed Fix proposed-guard-malloc-fix.patch text/plain 2524 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQxMzAxNGEuLmMxYTQ2YjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTGlzdGVu IGZvciB0aGUgWFBDX0VSUk9SX0NPTk5FQ1RJT05fSU5WQUxJRCBldmVudCB0byBkZXJlZgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5Njk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv cmVtb3RlL1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24ubW06CisgICAgICAgIChJbnNwZWN0 b3I6OlJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb246OlJlbW90ZUluc3BlY3RvclhQQ0Nvbm5l Y3Rpb24pOgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9u OjpoYW5kbGVFdmVudCk6CisKIDIwMTQtMDMtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIE1pY3JvLW9wdGltaXplIFN0cmluZ3MgaW4gSlMgYmluZGluZ3Mu CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0b3JYUENDb25uZWN0aW9uLm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbi5tbQppbmRleCAyODk3OTVl Li4zZDI5ZjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Jl bW90ZS9SZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uLm1tCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24ubW0K QEAgLTYwLDcgKzYwLDcgQEAgUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbjo6UmVtb3RlSW5z cGVjdG9yWFBDQ29ubmVjdGlvbih4cGNfY29ubmVjdGlvbl90IGNvbm4KICAgICAgICAgaGFuZGxl RXZlbnQob2JqZWN0KTsKICAgICB9KTsKIAotICAgIC8vIEJhbGFuY2VkIGJ5IGRlcmVmIHdoZW4g dGhlIHhwY19jb25uZWN0aW9uIHJlY2VpdmVzIFhQQ19FUlJPUi4KKyAgICAvLyBCYWxhbmNlZCBi eSBkZXJlZiB3aGVuIHRoZSB4cGNfY29ubmVjdGlvbiByZWNlaXZlcyBYUENfRVJST1JfQ09OTkVD VElPTl9JTlZBTElELgogICAgIHJlZigpOwogCiAgICAgeHBjX2Nvbm5lY3Rpb25fcmVzdW1lKG1f Y29ubmVjdGlvbik7CkBAIC0xMjIsMTcgKzEyMiwyMSBAQCBOU0RpY3Rpb25hcnkgKlJlbW90ZUlu c3BlY3RvclhQQ0Nvbm5lY3Rpb246OmRlc2VyaWFsaXplTWVzc2FnZSh4cGNfb2JqZWN0X3Qgb2Jq ZQogdm9pZCBSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uOjpoYW5kbGVFdmVudCh4cGNfb2Jq ZWN0X3Qgb2JqZWN0KQogewogICAgIGlmICh4cGNfZ2V0X3R5cGUob2JqZWN0KSA9PSBYUENfVFlQ RV9FUlJPUikgewotICAgICAgICBzdGQ6OmxvY2tfZ3VhcmQ8c3RkOjptdXRleD4gbG9jayhtX211 dGV4KTsKLSAgICAgICAgaWYgKG1fY2xpZW50KQotICAgICAgICAgICAgbV9jbGllbnQtPnhwY0Nv bm5lY3Rpb25GYWlsZWQodGhpcyk7CisgICAgICAgIHsKKyAgICAgICAgICAgIHN0ZDo6bG9ja19n dWFyZDxzdGQ6Om11dGV4PiBsb2NrKG1fbXV0ZXgpOworICAgICAgICAgICAgaWYgKG1fY2xpZW50 KQorICAgICAgICAgICAgICAgIG1fY2xpZW50LT54cGNDb25uZWN0aW9uRmFpbGVkKHRoaXMpOwog Ci0gICAgICAgIG1fY2xvc2VkID0gdHJ1ZTsKLSAgICAgICAgbV9jbGllbnQgPSBudWxscHRyOwot ICAgICAgICBjbG9zZU9uUXVldWUoKTsKKyAgICAgICAgICAgIG1fY2xvc2VkID0gdHJ1ZTsKKyAg ICAgICAgICAgIG1fY2xpZW50ID0gbnVsbHB0cjsKKyAgICAgICAgICAgIGNsb3NlT25RdWV1ZSgp OworICAgICAgICB9CiAKLSAgICAgICAgLy8gVGhpcyBpcyB0aGUgbGFzdCBldmVudCB3ZSB3aWxs IGV2ZXIgcmVjZWl2ZSBmcm9tIHRoZSBjb25uZWN0aW9uLgotICAgICAgICAvLyBCYWxhbmNlIHRo ZSByZWYoKSBpbiB0aGUgY29uc3RydWN0b3IuCi0gICAgICAgIGRlcmVmKCk7CisgICAgICAgIGlm IChvYmplY3QgPT0gWFBDX0VSUk9SX0NPTk5FQ1RJT05fSU5WQUxJRCkgeworICAgICAgICAgICAg Ly8gVGhpcyBpcyB0aGUgbGFzdCBldmVudCB3ZSB3aWxsIGV2ZXIgcmVjZWl2ZSBmcm9tIHRoZSBj b25uZWN0aW9uLgorICAgICAgICAgICAgLy8gVGhpcyBiYWxhbmNlcyB0aGUgcmVmKCkgaW4gdGhl IGNvbnN0cnVjdG9yLgorICAgICAgICAgICAgZGVyZWYoKTsKKyAgICAgICAgfQogICAgICAgICBy ZXR1cm47CiAgICAgfQogCg==