129696 2014-03-04 12:28:19 -0800 REGRESSION: Web Inspector: Exception showing the DOM tree for a node with too many children 2014-07-11 15:58:33 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 timothy webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 986930 0 timothy 2014-03-04 12:28:19 -0800 DOMTreeElement.js:430:67: JS ERROR: TypeError: null is not an object (evaluating 'item.listItemElement.firstChild') 986931 1 webkit-bug-importer 2014-03-04 12:28:30 -0800 <rdar://problem/16225976> 1012541 2 232274 jonowells 2014-05-29 17:43:43 -0700 Created attachment 232274 [PATCH] Addition of _childrenListNode check. Fixes a regression from 3117564d. See 'git show 3117564d'. 1014288 3 232274 joepeck 2014-06-09 17:16:57 -0700 Comment on attachment 232274 [PATCH] Addition of _childrenListNode check. r=me 1014296 4 232274 commit-queue 2014-06-09 17:46:57 -0700 Comment on attachment 232274 [PATCH] Addition of _childrenListNode check. Clearing flags on attachment: 232274 Committed r169735: <http://trac.webkit.org/changeset/169735> 1014297 5 commit-queue 2014-06-09 17:46:59 -0700 All reviewed patches have been landed. Closing bug. 1021925 6 timothy 2014-07-11 15:58:33 -0700 This caused bug 134845. We might need to revert this fix and find a more targeted fix for this issue. 232274 2014-05-29 17:43:43 -0700 2014-06-09 17:46:57 -0700 [PATCH] Addition of _childrenListNode check. nodes.diff text/plain 2838 jonowells ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZiOTc2MGQuLmY1YjFmMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTI5ICBKb25vIFdlbGxzICA8 am9ub3dlbGxzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBXZWIgSW5zcGVjdG9y OiBFeGNlcHRpb24gc2hvd2luZyB0aGUgRE9NIHRyZWUgZm9yIGEgbm9kZSB3aXRoIHRvbyBtYW55 IGNoaWxkcmVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjk2OTYKKworICAgICAgICBGaXggaXNzdWUgd2hlcmUgc29tZXRpbWVzIGluc3BlY3Rpbmcg YW4gZWxlbWVudCB3aWxsIHRyeSB0byBhdHRhY2ggdGhlICJzaG93IGFsbCBub2RlcyIgYnV0dG9u CisgICAgICAgIGJlZm9yZSB0aGUgZXhwYW5kIGZ1bmN0aW9uIGlzIGNhbGxlZCBpbiBUcmVlRWxl bWVudCBiZWZvcmUgX2NoaWxkcmVuTGlzdE5vZGUgaGFzIGJlZW4gc2V0LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFRyZWVPdXRsaW5lLnByb3RvdHlwZS5hcHBlbmRD aGlsZCk6CisgICAgICAgIChUcmVlT3V0bGluZS5wcm90b3R5cGUuaW5zZXJ0Q2hpbGQpOgorICAg ICAgICBBZGRlZCBjaGVjayBmb3IgZXhpc3RhbmNlIG9mIHRoaXMuX2NoaWxkcmVuTGlzdE5vZGUu CisKIDIwMTQtMDUtMjkgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeCBhbiBleGNlcHRpb24gaW4gSW5zcGVjdG9yQmFja2VuZC5Db21tYW5kLnByb3Rv dHlwZS5zdXBwb3J0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggZmZmMWRiNy4uZTcxYTYzMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91 dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VHJlZU91dGxpbmUuanMKQEAgLTg1LDggKzg1LDE1IEBAIFRyZWVPdXRsaW5lLnByb3RvdHlwZS5h cHBlbmRDaGlsZCA9IGZ1bmN0aW9uKGNoaWxkKQogICAgIGlmIChjaGlsZC5oYXNDaGlsZHJlbiAm JiBjaGlsZC50cmVlT3V0bGluZS5fdHJlZUVsZW1lbnRzRXhwYW5kZWRTdGF0ZVtjaGlsZC5pZGVu dGlmaWVyXSAhPT0gdW5kZWZpbmVkKQogICAgICAgICBjaGlsZC5leHBhbmRlZCA9IGNoaWxkLnRy ZWVPdXRsaW5lLl90cmVlRWxlbWVudHNFeHBhbmRlZFN0YXRlW2NoaWxkLmlkZW50aWZpZXJdOwog Ci0gICAgaWYgKHRoaXMuX2NoaWxkcmVuTGlzdE5vZGUpCi0gICAgICAgIGNoaWxkLl9hdHRhY2go KTsKKyAgICBpZiAoIXRoaXMuX2NoaWxkcmVuTGlzdE5vZGUpIHsKKyAgICAgICAgdGhpcy5fY2hp bGRyZW5MaXN0Tm9kZSA9IHRoaXMudHJlZU91dGxpbmUuX2NoaWxkcmVuTGlzdE5vZGUub3duZXJE b2N1bWVudC5jcmVhdGVFbGVtZW50KCJvbCIpOworICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3RO b2RlLnBhcmVudFRyZWVFbGVtZW50ID0gdGhpczsKKyAgICAgICAgdGhpcy5fY2hpbGRyZW5MaXN0 Tm9kZS5jbGFzc0xpc3QuYWRkKCJjaGlsZHJlbiIpOworICAgICAgICBpZiAodGhpcy5oaWRkZW4p CisgICAgICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLmNsYXNzTGlzdC5hZGQoImhpZGRl biIpOworICAgIH0KKworICAgIGNoaWxkLl9hdHRhY2goKTsKIAogICAgIGlmICh0aGlzLnRyZWVP dXRsaW5lLm9uYWRkKQogICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLm9uYWRkKGNoaWxkKTsKQEAg LTEzNCw4ICsxNDEsMTUgQEAgVHJlZU91dGxpbmUucHJvdG90eXBlLmluc2VydENoaWxkID0gZnVu Y3Rpb24oY2hpbGQsIGluZGV4KQogICAgIGlmIChjaGlsZC5oYXNDaGlsZHJlbiAmJiBjaGlsZC50 cmVlT3V0bGluZS5fdHJlZUVsZW1lbnRzRXhwYW5kZWRTdGF0ZVtjaGlsZC5pZGVudGlmaWVyXSAh PT0gdW5kZWZpbmVkKQogICAgICAgICBjaGlsZC5leHBhbmRlZCA9IGNoaWxkLnRyZWVPdXRsaW5l Ll90cmVlRWxlbWVudHNFeHBhbmRlZFN0YXRlW2NoaWxkLmlkZW50aWZpZXJdOwogCi0gICAgaWYg KHRoaXMuX2NoaWxkcmVuTGlzdE5vZGUpCi0gICAgICAgIGNoaWxkLl9hdHRhY2goKTsKKyAgICBp ZiAoIXRoaXMuX2NoaWxkcmVuTGlzdE5vZGUpIHsKKyAgICAgICAgdGhpcy5fY2hpbGRyZW5MaXN0 Tm9kZSA9IHRoaXMudHJlZU91dGxpbmUuX2NoaWxkcmVuTGlzdE5vZGUub3duZXJEb2N1bWVudC5j cmVhdGVFbGVtZW50KCJvbCIpOworICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLnBhcmVu dFRyZWVFbGVtZW50ID0gdGhpczsKKyAgICAgICAgdGhpcy5fY2hpbGRyZW5MaXN0Tm9kZS5jbGFz c0xpc3QuYWRkKCJjaGlsZHJlbiIpOworICAgICAgICBpZiAodGhpcy5oaWRkZW4pCisgICAgICAg ICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLmNsYXNzTGlzdC5hZGQoImhpZGRlbiIpOworICAg IH0KKworICAgIGNoaWxkLl9hdHRhY2goKTsKIAogICAgIGlmICh0aGlzLnRyZWVPdXRsaW5lLm9u YWRkKQogICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLm9uYWRkKGNoaWxkKTsK