129690 2014-03-04 11:30:10 -0800 [iOS WebKit2]: Next/Prev button in the accessory bar do not work 2014-03-04 14:47:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 986895 0 enrica 2014-03-04 11:30:10 -0800 This bug track the work required to implement this functionality on iOS. <rdar://problem/16073569> 986896 1 225796 enrica 2014-03-04 11:34:08 -0800 Created attachment 225796 Patch 986904 2 225796 simon.fraser 2014-03-04 11:42:50 -0800 Comment on attachment 225796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225796&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:483 > + void nextAssistedNode(bool isForward); It's not clear if this is a getter or a command. I think it should be focusNextAssistedNode, or moveToNextAssistedNode. It would also be nice if the param were an enum. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1594 > +static inline bool hasFocusableNode(Node* startNode, Page* page, bool isForward) > +{ > + return nextFocusableNode(startNode, page, isForward) != nil; > +} > + > +void WebPage::nextAssistedNode(bool isForward) > +{ > + Node* nextNode = nextFocusableNode(m_assistedNode.get(), m_page.get(), isForward); > + if (nextNode) > + toElement(nextNode)->focus(); > +} I think all these Node* should really be Element* (but should be fixed in a subsequent patch) 986997 3 enrica 2014-03-04 14:47:24 -0800 Committed revision 165081. 225796 2014-03-04 11:34:08 -0800 2014-03-04 11:42:50 -0800 Patch prevnext.txt text/plain 7015 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTA2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE0LTAzLTA0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXZWJLaXQyXTogTmV4 dC9QcmV2IGJ1dHRvbiBpbiB0aGUgYWNjZXNzb3J5IGJhciBkbyBub3Qgd29yay4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTY5MAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTYwNzM1Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkaW5nIHN1cHBvcnQgZm9yIE5leHQgYW5kIFByZXZpb3VzIGJ1 dHRvbnMgaW4gdGhlIGFjY2Vzc29yeSBiYXIuCisgICAgICAgIFdoZW4gdGhlIHJlcXVlc3QgaXMg cHJvY2Vzc2VkIGJ5IHRoZSBXZWJQcm9jZXNzLCB3ZSBpZGVudGlmeSB0aGUgbmV4dAorICAgICAg ICBmb2N1c2FibGUgbm9kZSB0aGF0IG5lZWRzIHRvIGJlIGFzc2lzdGVkIGFuZCB3ZSBjYWxsIGZv Y3VzKCkgb24gdGhlIGVsZW1lbnQKKyAgICAgICAgbGV0dGluZyB0aGUgZm9jdXMgY2hhbmdpbmcg bWFjaGluZXJ5IHRha2UgY2FyZSBvZiB1cGRhdGluZyB0aGUgYXNzaXN0ZWQgbm9kZS4KKyAgICAg ICAgVGhpcyBjaGFuZ2UgYWxzbyBhZGQgc3VwcG9ydCBmb3IgdGhlIENsZWFyIGJ1dHRvbiwgd2hl biBhcHByb3ByaWF0ZSBhbmQgaG9va3MgdXAKKyAgICAgICAgdGhlIGNhbGwgdG8gdGhlIFdlYlBy b2Nlc3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgYWNjZXNzb3J5VGFiOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGFj Y2Vzc29yeUNsZWFyXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3VwZGF0ZUFjY2Vzc29y eV0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6Om5leHRBc3Npc3RlZE5vZGUpOgorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UubWVzc2FnZXMuaW46CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpuZXh0Rm9jdXNhYmxlTm9kZSk6CisgICAg ICAgIChXZWJLaXQ6Omhhc0ZvY3VzYWJsZU5vZGUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl OjpuZXh0QXNzaXN0ZWROb2RlKToKKwogMjAxNC0wMy0wMyAgRW5yaWNhIENhc3VjY2kgIDxlbnJp Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIFNlbGVjdGlvbiByZW1haW5zIGFmdGVyIHJl bG9hZC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHJldmlz aW9uIDE2NTAyOSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAko d29ya2luZyBjb3B5KQpAQCAtNDgwLDYgKzQ4MCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHBlcmZv cm1BY3Rpb25PbkVsZW1lbnQodWludDMyX3QgYWN0aW9uKTsKICAgICB2b2lkIHNhdmVJbWFnZVRv TGlicmFyeShjb25zdCBTaGFyZWRNZW1vcnk6OkhhbmRsZSYgaW1hZ2VIYW5kbGUsIHVpbnQ2NF90 IGltYWdlU2l6ZSk7CiAgICAgdm9pZCBkaWRVcGRhdGVCbG9ja1NlbGVjdGlvbldpdGhUb3VjaCh1 aW50MzJfdCB0b3VjaCwgdWludDMyX3QgZmxhZ3MsIGZsb2F0IGdyb3dUaHJlc2hvbGQsIGZsb2F0 IHNocmlua1RocmVzaG9sZCk7CisgICAgdm9pZCBuZXh0QXNzaXN0ZWROb2RlKGJvb2wgaXNGb3J3 YXJkKTsKICAgICB2b2lkIHNldEFzc2lzdGVkTm9kZVZhbHVlKGNvbnN0IFN0cmluZyYpOwogICAg IHZvaWQgc2V0QXNzaXN0ZWROb2RlVmFsdWVBc051bWJlcihkb3VibGUpOwogICAgIHZvaWQgc2V0 QXNzaXN0ZWROb2RlU2VsZWN0ZWRJbmRleCh1aW50MzJfdCBpbmRleCwgYm9vbCBhbGxvd011bHRp cGxlU2VsZWN0aW9uID0gZmFsc2UpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE2 NTA1MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMjg3LDYgKzEyODcsNyBAQCAtICh2b2lkKWFj Y2Vzc29yeURvbmUKIAogLSAodm9pZClhY2Nlc3NvcnlUYWI6KEJPT0wpaXNOZXh0CiB7CisgICAg X3BhZ2UtPm5leHRBc3Npc3RlZE5vZGUoaXNOZXh0KTsKIH0KIAogLSAodm9pZClhY2Nlc3NvcnlB dXRvRmlsbApAQCAtMTI5NSwxNCArMTI5NiwyOSBAQCAtICh2b2lkKWFjY2Vzc29yeUF1dG9GaWxs CiAKIC0gKHZvaWQpYWNjZXNzb3J5Q2xlYXIKIHsKKyAgICBfcGFnZS0+c2V0QXNzaXN0ZWROb2Rl VmFsdWUoU3RyaW5nKCkpOwogfQogCiAtICh2b2lkKV91cGRhdGVBY2Nlc3NvcnkKIHsKICAgICBb X2Zvcm1BY2Nlc3NvcnlWaWV3IHNldE5leHRFbmFibGVkOl9hc3Npc3RlZE5vZGVJbmZvcm1hdGlv bi5oYXNOZXh0Tm9kZV07CiAgICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXRQcmV2aW91c0VuYWJs ZWQ6X2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmhhc1ByZXZpb3VzTm9kZV07Ci0gICAgCi0gICAg W19mb3JtQWNjZXNzb3J5VmlldyBzZXRDbGVhclZpc2libGU6Tk9dOworCisgICAgaWYgKFVJQ3Vy cmVudFVzZXJJbnRlcmZhY2VJZGlvbUlzUGFkKCkpCisgICAgICAgIFtfZm9ybUFjY2Vzc29yeVZp ZXcgc2V0Q2xlYXJWaXNpYmxlOk5PXTsKKyAgICBlbHNlIHsKKyAgICAgICAgc3dpdGNoIChfYXNz aXN0ZWROb2RlSW5mb3JtYXRpb24uZWxlbWVudFR5cGUpIHsKKyAgICAgICAgY2FzZSBXZWJLaXQ6 OldLVHlwZURhdGU6CisgICAgICAgIGNhc2UgV2ViS2l0OjpXS1R5cGVNb250aDoKKyAgICAgICAg Y2FzZSBXZWJLaXQ6OldLVHlwZURhdGVUaW1lTG9jYWw6CisgICAgICAgIGNhc2UgV2ViS2l0OjpX S1R5cGVUaW1lOgorICAgICAgICAgICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXRDbGVhclZpc2li bGU6WUVTXTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAg ICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXRDbGVhclZpc2libGU6Tk9dOworICAgICAgICAgICAg YnJlYWs7CisgICAgICAgIH0KKyAgICB9CiAKICAgICAvLyBGSVhNRTogaGlkZSBvciBzaG93IHRo ZSBBdXRvRmlsbCBidXR0b24gYXMgbmVlZGVkLgogfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0JKHJldmlzaW9uIDE2NTAyOSkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCSh3b3JraW5n IGNvcHkpCkBAIC01MTAsNiArNTEwLDExIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzdG9wQXNzaXN0 aW5nTm9kZSgpCiAgICAgbV9wYWdlQ2xpZW50LnN0b3BBc3Npc3RpbmdOb2RlKCk7CiB9CiAKK3Zv aWQgV2ViUGFnZVByb3h5OjpuZXh0QXNzaXN0ZWROb2RlKGJvb2wgaXNGb3J3YXJkKQoreworICAg IHByb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpOZXh0QXNzaXN0ZWROb2RlKGlzRm9y d2FyZCksIG1fcGFnZUlEKTsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnNldEFzc2lzdGVkTm9k ZVZhbHVlKGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgcHJvY2VzcygpLnNlbmQoTWVzc2Fn ZXM6OldlYlBhZ2U6OlNldEFzc2lzdGVkTm9kZVZhbHVlKHZhbHVlKSwgbV9wYWdlSUQpOwpJbmRl eDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lv biAxNjUwMjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5o CSh3b3JraW5nIGNvcHkpCkBAIC00NjYsNiArNDY2LDcgQEAgcHVibGljOgogICAgIHZvaWQgc3Rh cnRJbnRlcmFjdGlvbldpdGhFbGVtZW50QXRQb3NpdGlvbihjb25zdCBXZWJDb3JlOjpJbnRQb2lu dCYpOwogICAgIHZvaWQgc3RvcEludGVyYWN0aW9uKCk7CiAgICAgdm9pZCBwZXJmb3JtQWN0aW9u T25FbGVtZW50KHVpbnQzMl90IGFjdGlvbik7CisgICAgdm9pZCBuZXh0QXNzaXN0ZWROb2RlKGJv b2wgaXNGb3J3YXJkKTsKICAgICB2b2lkIHNldEFzc2lzdGVkTm9kZVZhbHVlKGNvbnN0IFN0cmlu ZyYpOwogICAgIHZvaWQgc2V0QXNzaXN0ZWROb2RlVmFsdWVBc051bWJlcihkb3VibGUpOwogICAg IHZvaWQgc2V0QXNzaXN0ZWROb2RlU2VsZWN0ZWRJbmRleCh1aW50MzJfdCBpbmRleCwgYm9vbCBh bGxvd011bHRpcGxlU2VsZWN0aW9uKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCShyZXZpc2lvbiAxNjUwMjkp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5p bgkod29ya2luZyBjb3B5KQpAQCAtNjQsNiArNjQsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIExl Z2FjeVJlY2VpdmVyIHsKICAgICBTdGFydEludGVyYWN0aW9uV2l0aEVsZW1lbnRBdFBvc2l0aW9u KFdlYkNvcmU6OkludFBvaW50IHBvaW50KQogICAgIFN0b3BJbnRlcmFjdGlvbigpCiAgICAgUGVy Zm9ybUFjdGlvbk9uRWxlbWVudCh1aW50MzJfdCBhY3Rpb24pCisgICAgTmV4dEFzc2lzdGVkTm9k ZShib29sIGlzRm9yd2FyZCkKICAgICBTZXRBc3Npc3RlZE5vZGVWYWx1ZShTdHJpbmcgdmFsdWUp CiAgICAgU2V0QXNzaXN0ZWROb2RlVmFsdWVBc051bWJlcihkb3VibGUgdmFsdWUpCiAgICAgU2V0 QXNzaXN0ZWROb2RlU2VsZWN0ZWRJbmRleCh1aW50MzJfdCBpbmRleCwgYm9vbCBhbGxvd011bHRp cGxlU2VsZWN0aW9uKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTY1MDI5KQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xNTY4LDcgKzE1NjgsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNBc3Npc3RhYmxlTm9k ZShOb2RlCiAgICAgcmV0dXJuIG5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCk7CiB9CiAKLXN0YXRp YyBpbmxpbmUgYm9vbCBoYXNGb2N1c2FibGVOb2RlKE5vZGUqIHN0YXJ0Tm9kZSwgUGFnZSogcGFn ZSwgYm9vbCBpc0ZvcndhcmQpCitzdGF0aWMgaW5saW5lIE5vZGUqIG5leHRGb2N1c2FibGVOb2Rl KE5vZGUqIHN0YXJ0Tm9kZSwgUGFnZSogcGFnZSwgYm9vbCBpc0ZvcndhcmQpCiB7CiAgICAgUmVm UHRyPEtleWJvYXJkRXZlbnQ+IGtleSA9IEtleWJvYXJkRXZlbnQ6OmNyZWF0ZSgpOwogCkBAIC0x NTgxLDYgKzE1ODEsMTggQEAgc3RhdGljIGlubGluZSBib29sIGhhc0ZvY3VzYWJsZU5vZGUoTm9k ZQogICAgIHJldHVybiBuZXh0Tm9kZTsKIH0KIAorc3RhdGljIGlubGluZSBib29sIGhhc0ZvY3Vz YWJsZU5vZGUoTm9kZSogc3RhcnROb2RlLCBQYWdlKiBwYWdlLCBib29sIGlzRm9yd2FyZCkKK3sK KyAgICByZXR1cm4gbmV4dEZvY3VzYWJsZU5vZGUoc3RhcnROb2RlLCBwYWdlLCBpc0ZvcndhcmQp ICE9IG5pbDsKK30KKwordm9pZCBXZWJQYWdlOjpuZXh0QXNzaXN0ZWROb2RlKGJvb2wgaXNGb3J3 YXJkKQoreworICAgIE5vZGUqIG5leHROb2RlID0gbmV4dEZvY3VzYWJsZU5vZGUobV9hc3Npc3Rl ZE5vZGUuZ2V0KCksIG1fcGFnZS5nZXQoKSwgaXNGb3J3YXJkKTsKKyAgICBpZiAobmV4dE5vZGUp CisgICAgICAgIHRvRWxlbWVudChuZXh0Tm9kZSktPmZvY3VzKCk7Cit9CisKIHZvaWQgV2ViUGFn ZTo6Z2V0QXNzaXN0ZWROb2RlSW5mb3JtYXRpb24oQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24mIGlu Zm9ybWF0aW9uKQogewogICAgIGluZm9ybWF0aW9uLmVsZW1lbnRSZWN0ID0gbV9wYWdlLT5mb2N1 c0NvbnRyb2xsZXIoKS5mb2N1c2VkT3JNYWluRnJhbWUoKS52aWV3KCktPmNvbnRlbnRzVG9Sb290 VmlldyhtX2Fzc2lzdGVkTm9kZS0+cmVuZGVyZXIoKS0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3Qo KSk7Cg==