129685 2014-03-04 08:53:13 -0800 [GStreamer] WebSource doesn't need the "iradio-mode" property 2014-03-05 06:43:26 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 agomez webkit-unassigned andersca calvaris cgarcia commit-queue gustavo menard mrobinson pnormand vjaquez oldest_to_newest 986830 0 agomez 2014-03-04 08:53:13 -0800 As we have been discussing at https://bugzilla.gnome.org/show_bug.cgi?id=725383 , the "iradio-mode" property was intended to be automatically set by "uridecodebin". For quite some time, this was not happening and now we are removing this automatic mechanism since it doesn't bring any advantage. The "iradio-mode" property is a private property that was not even exposed so it could only be set by the playbin through the uridecodebin. Let's sent always the "icy-metadata" header and remove the code from this property. 987225 1 225876 agomez 2014-03-05 05:43:58 -0800 Created attachment 225876 Patch 987234 2 225876 commit-queue 2014-03-05 06:43:22 -0800 Comment on attachment 225876 Patch Clearing flags on attachment: 225876 Committed r165106: <http://trac.webkit.org/changeset/165106> 987235 3 commit-queue 2014-03-05 06:43:26 -0800 All reviewed patches have been landed. Closing bug. 225876 2014-03-05 05:43:58 -0800 2014-03-05 06:43:22 -0800 Patch bug-129685-20140305154356.patch text/plain 4394 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI0MzBkZWNjODE3NTc0 Yjg1ZDg2OTAwYTBmMzljYzM5M2M0YWQ4OS4uM2IwNjZkYzVkMDUwYzJmMjE0Nzk3NmFhNjNlZThk ZjJkZDc2ZGU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAzLTA1ICBBbmRy ZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBXZWJT b3VyY2UgZG9lc24ndCBuZWVkIHRoZSAiaXJhZGlvLW1vZGUiIHByb3BlcnR5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk2ODUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHRoZSAiaXJhZGlv LW1vZGUiIHByb3BlcnR5IGZyb20gdGhlIFdLIHNvdXJjZSBlbGVtZW50CisgICAgICAgIHNpbmNl IHRoaXMgd2FzIG9ubHkgYXZhaWxhYmxlIGZvciBpdHMgbW9kaWZpY2F0aW9uIGZyb20KKyAgICAg ICAgcGxheWJpbi91cmlkZWNvZGViaW4gYW5kLCBhcyBkaXNjdXNzZWQgaW4gR1N0cmVhbWVyIGJ1 ZyAjNzI1MzgzLAorICAgICAgICBpdCB3YXMgbm90IGJlaW5nIHNldCBhbmQgbm93IGlzIGdvaW5n IHRvIGJlIHJlbW92ZWQuCisKKyAgICAgICAgSXQgaXMgc2FmZSBqdXN0IHRvIHNlbmQgYWx3YXlz IHRoZSAiaWN5LW1ldGFkYXRhIiBoZWFkZXIgc2V0IGFuZAorICAgICAgICBkZWFsIHdpdGggcmV0 dXJuaW5nICJpY3kiIGhlYWRlcnMgYXMgd2Ugd2VyZSBhbHJlYWR5IGRvaW5nLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHA6CisgICAgICAgICh3ZWJLaXRXZWJTcmNTZXRQcm9wZXJ0eSk6CisgICAgICAgICh3ZWJLaXRX ZWJTcmNHZXRQcm9wZXJ0eSk6CisgICAgICAgICh3ZWJLaXRXZWJTcmNTdGFydCk6CisKIDIwMTQt MDMtMDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWJwaXhl bCByZW5kZXJpbmc6IEluY29ycmVjdCByZXBhaW50IHJlY3QgY3V0cyBvZmYgY29udGVudCdzIHJp Z2h0IGVkZ2UgYWZ0ZXIgbW92ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJl YW1lci5jcHAKaW5kZXggYmRkZmJlMzY2ZmRjYTU0ZWFmYTk3YmZkNDlhODUyNzU0ZjI2YjMxZS4u MzAxN2YxZDQ0MmQ2MTVkYjFiMmJkYTU3ODI0ODA0ODVhYzNiODdlYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdT dHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTEzNSw3ICsxMzUsNiBAQCBzdHJ1 Y3QgX1dlYktpdFdlYlNyY1ByaXZhdGUgewogICAgIEdSZWZQdHI8R3N0QnVmZmVyPiBidWZmZXI7 CiAKICAgICAvLyBpY2VjYXN0IHN0dWZmCi0gICAgZ2Jvb2xlYW4gaXJhZGlvTW9kZTsKICAgICBn Y2hhciogaXJhZGlvTmFtZTsKICAgICBnY2hhciogaXJhZGlvR2VucmU7CiAgICAgZ2NoYXIqIGly YWRpb1VybDsKQEAgLTE0Myw4ICsxNDIsNyBAQCBzdHJ1Y3QgX1dlYktpdFdlYlNyY1ByaXZhdGUg ewogfTsKIAogZW51bSB7Ci0gICAgUFJPUF9JUkFESU9fTU9ERSA9IDEsCi0gICAgUFJPUF9JUkFE SU9fTkFNRSwKKyAgICBQUk9QX0lSQURJT19OQU1FID0gMSwKICAgICBQUk9QX0lSQURJT19HRU5S RSwKICAgICBQUk9QX0lSQURJT19VUkwsCiAgICAgUFJPUF9JUkFESU9fVElUTEUsCkBAIC0yMDQs MTQgKzIwMiw2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc3JjX2NsYXNzX2luaXQoV2ViS2l0 V2ViU3JjQ2xhc3MqIGtsYXNzKQogCiAgICAgLy8gaWNlY2FzdCBzdHVmZgogICAgIGdfb2JqZWN0 X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2tsYXNzLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgUFJPUF9JUkFESU9fTU9ERSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGdfcGFyYW1fc3BlY19ib29sZWFuKCJpcmFkaW8tbW9kZSIsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaXJhZGlvLW1v ZGUiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIkVuYWJsZSBpbnRlcm5ldCByYWRpbyBtb2RlIChleHRyYWN0aW9uIG9mIHNob3V0Y2Fz dC9pY2VjYXN0IG1ldGFkYXRhKSIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBGQUxTRSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHUGFyYW1GbGFncykgKEdfUEFSQU1fUkVB RFdSSVRFIHwgR19QQVJBTV9TVEFUSUNfU1RSSU5HUykpKTsKLQotICAgIGdfb2JqZWN0X2NsYXNz X2luc3RhbGxfcHJvcGVydHkob2tsYXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgUFJPUF9JUkFESU9fTkFNRSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoImlyYWRpby1uYW1lIiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImlyYWRpby1uYW1lIiwKQEAg LTMzMSwxNCArMzIxLDggQEAgc3RhdGljIHZvaWQgd2ViS2l0V2ViU3JjRmluYWxpemUoR09iamVj dCogb2JqZWN0KQogc3RhdGljIHZvaWQgd2ViS2l0V2ViU3JjU2V0UHJvcGVydHkoR09iamVjdCog b2JqZWN0LCBndWludCBwcm9wSUQsIGNvbnN0IEdWYWx1ZSogdmFsdWUsIEdQYXJhbVNwZWMqIHBz cGVjKQogewogICAgIFdlYktpdFdlYlNyYyogc3JjID0gV0VCS0lUX1dFQl9TUkMob2JqZWN0KTsK LSAgICBXZWJLaXRXZWJTcmNQcml2YXRlKiBwcml2ID0gc3JjLT5wcml2OwogCiAgICAgc3dpdGNo IChwcm9wSUQpIHsKLSAgICBjYXNlIFBST1BfSVJBRElPX01PREU6IHsKLSAgICAgICAgR011dGV4 TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9MT0NLKHNyYykpOwotICAgICAgICBwcml2LT5p cmFkaW9Nb2RlID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7Ci0gICAgICAgIGJyZWFrOwot ICAgIH0KICAgICBjYXNlIFBST1BfTE9DQVRJT046CiAgICAgICAgIGdzdF91cmlfaGFuZGxlcl9z ZXRfdXJpKHJlaW50ZXJwcmV0X2Nhc3Q8R3N0VVJJSGFuZGxlcio+KHNyYyksIGdfdmFsdWVfZ2V0 X3N0cmluZyh2YWx1ZSksIDApOwogICAgICAgICBicmVhazsKQEAgLTM1NSw5ICszMzksNiBAQCBz dGF0aWMgdm9pZCB3ZWJLaXRXZWJTcmNHZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50 IHByb3BJRCwgR1ZhbHVlKiB2YWx1ZQogCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JK RUNUX0dFVF9MT0NLKHNyYykpOwogICAgIHN3aXRjaCAocHJvcElEKSB7Ci0gICAgY2FzZSBQUk9Q X0lSQURJT19NT0RFOgotICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5p cmFkaW9Nb2RlKTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX0lSQURJT19OQU1FOgog ICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFsdWUsIHByaXYtPmlyYWRpb05hbWUpOwogICAg ICAgICBicmVhazsKQEAgLTUwNyw4ICs0ODgsOCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViS2l0V2Vi U3JjU3RhcnQoV2ViS2l0V2ViU3JjKiBzcmMpCiAgICAgfQogICAgIHByaXYtPm9mZnNldCA9IHBy aXYtPnJlcXVlc3RlZE9mZnNldDsKIAotICAgIGlmIChwcml2LT5pcmFkaW9Nb2RlKQotICAgICAg ICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZCgiaWN5LW1ldGFkYXRhIiwgIjEiKTsKKyAgICAv LyBXZSBhbHdheXMgcmVxdWVzdCBJY2VjYXN0L1Nob3V0Y2FzdCBtZXRhZGF0YSwganVzdCBpbiBj YXNlIC4uLgorICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJpY3ktbWV0YWRhdGEiLCAi MSIpOwogCiAgICAgLy8gTmVlZGVkIHRvIHVzZSBETE5BIHN0cmVhbWluZyBzZXJ2ZXJzCiAgICAg cmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoInRyYW5zZmVyTW9kZS5kbG5hIiwgIlN0cmVhbWlu ZyIpOwo=