129673 2014-03-04 01:46:07 -0800 Micro-optimize Strings in JS bindings. 2014-03-04 08:59:45 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling barraclough kling rniwa oldest_to_newest 986741 0 kling 2014-03-04 01:46:07 -0800 Micro-optimize Strings in JS bindings. 986746 1 225762 kling 2014-03-04 01:49:40 -0800 Created attachment 225762 Patch 986748 2 225762 kling 2014-03-04 01:57:43 -0800 Comment on attachment 225762 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/JavaScriptCore/runtime/JSString.h:419 > + // Should have picked a global empty or single-character string already. s/global/VM-global/ 986749 3 225762 rniwa 2014-03-04 02:05:08 -0800 Comment on attachment 225762 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225762&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:597 > + return JSC::jsStringWithWeakOwner(vm, *s.impl()); Why don't we use *stringImpl instead? 986835 4 kling 2014-03-04 08:59:45 -0800 Committed r165054: <http://trac.webkit.org/changeset/165054> 225762 2014-03-04 01:49:40 -0800 2014-03-04 02:05:07 -0800 Patch bug-129673.diff text/plain 4789 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ5M2ZjZmEuLjU5ZDc2YzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTA0ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBNaWNyby1vcHRpbWl6ZSBTdHJpbmdzIGlu IEpTIGJpbmRpbmdzLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5NjczPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UganNTdHJp bmdXaXRoV2Vha093bmVyKCkgdGFrZSBhIFN0cmluZ0ltcGwmIGluc3RlYWQgb2YgYSBTdHJpbmcu CisgICAgICAgIFRoaXMgYXZvaWRzIGJyYW5jaGVzIGluIGxlbmd0aCgpIGFuZCBvcGVyYXRvcltd LgorCisgICAgICAgIEFsc28gY2FsbCBKU1N0cmluZzo6Y3JlYXRlKCkgZGlyZWN0bHkgaW5zdGVh ZCBvZiBqc1N0cmluZygpIGFuZCBqdXN0CisgICAgICAgIGFzc2VydCB0aGF0IHRoZSBzdHJpbmcg bGVuZ3RoIGlzID4xLiBUaGlzIHdheSB3ZSBkb24ndCBkdXBsaWNhdGUgdGhlCisgICAgICAgIG9w dGltaXphdGlvbnMgZm9yIGVtcHR5IGFuZCBzaW5nbGUtY2hhcmFjdGVyIHN0cmluZ3MuCisKKyAg ICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmg6CisgICAgICAgIChKU0M6OmpzU3RyaW5nV2l0aFdl YWtPd25lcik6CisKIDIwMTQtMDMtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29t PgogCiAgICAgICAgIFN0cnVjdHVyZU9yT2Zmc2V0IHNob3VsZCBiZSBmYXN0bWFsbG9jZWQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAppbmRleCBiN2NmZGViLi4zNGNl NzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKQEAgLTQxMiwy NSArNDEyLDI3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gSlNTdHJpbmc6OmNy ZWF0ZSgqdm0sIHMuaW1wbCgpKTsKICAgICB9CiAKLSAgICBpbmxpbmUgSlNTdHJpbmcqIGpzU3Ry aW5nV2l0aFdlYWtPd25lcihWTSogdm0sIGNvbnN0IFN0cmluZyYgcykKKyAgICBpbmxpbmUgSlNT dHJpbmcqIGpzU3RyaW5nV2l0aFdlYWtPd25lcihWTSYgdm0sIFN0cmluZ0ltcGwmIHN0cmluZ0lt cGwpCiAgICAgewotICAgICAgICBXZWFrSGFuZGxlT3duZXIqIGpzU3RyaW5nV2Vha093bmVyID0g dm0tPmpzU3RyaW5nV2Vha093bmVyLmdldCgpOwotICAgICAgICBTdHJpbmdJbXBsKiBpbXBsID0g cy5pbXBsKCk7CisgICAgICAgIFdlYWtIYW5kbGVPd25lcioganNTdHJpbmdXZWFrT3duZXIgPSB2 bS5qc1N0cmluZ1dlYWtPd25lci5nZXQoKTsKIAotICAgICAgICAvLyBJZiB0aGlzIHZtIGlzIG5v dCBhbGxvd2VkIHRvIHdlYWtseSBvd24gc3RyaW5ncyBqdXN0IGNhbGwganNTdHJpbmcuCi0gICAg ICAgIGlmICghanNTdHJpbmdXZWFrT3duZXIgfHwgIWltcGwpCi0gICAgICAgICAgICByZXR1cm4g anNTdHJpbmcodm0sIHMpOworICAgICAgICAvLyBTaG91bGQgaGF2ZSBwaWNrZWQgYSBnbG9iYWwg ZW1wdHkgb3Igc2luZ2xlLWNoYXJhY3RlciBzdHJpbmcgYWxyZWFkeS4KKyAgICAgICAgQVNTRVJU KHN0cmluZ0ltcGwubGVuZ3RoKCkgPiAxKTsKKworICAgICAgICAvLyBJZiB0aGlzIFZNIGlzIG5v dCBhbGxvd2VkIHRvIHdlYWtseSBvd24gc3RyaW5ncyBqdXN0IG1ha2UgYSBuZXcgSlNTdHJpbmcu CisgICAgICAgIGlmICghanNTdHJpbmdXZWFrT3duZXIpCisgICAgICAgICAgICByZXR1cm4gSlNT dHJpbmc6OmNyZWF0ZSh2bSwgJnN0cmluZ0ltcGwpOwogCiAgICAgICAgIC8vIENoZWNrIGZvciBh biBleGlzdGluZyB3ZWFrbHkgb3duZWQgSlNTdHJpbmcuCi0gICAgICAgIGlmIChXZWFrSW1wbCog d2Vha0ltcGwgPSBpbXBsLT53ZWFrSlNTdHJpbmcoKSkgeworICAgICAgICBpZiAoV2Vha0ltcGwq IHdlYWtJbXBsID0gc3RyaW5nSW1wbC53ZWFrSlNTdHJpbmcoKSkgewogICAgICAgICAgICAgaWYg KHdlYWtJbXBsLT5zdGF0ZSgpID09IFdlYWtJbXBsOjpMaXZlKQogICAgICAgICAgICAgICAgIHJl dHVybiBhc1N0cmluZyh3ZWFrSW1wbC0+anNWYWx1ZSgpKTsKICAgICAgICAgICAgIFdlYWtTZXQ6 OmRlYWxsb2NhdGUod2Vha0ltcGwpOwotICAgICAgICAgICAgaW1wbC0+c2V0V2Vha0pTU3RyaW5n KG51bGxwdHIpOworICAgICAgICAgICAgc3RyaW5nSW1wbC5zZXRXZWFrSlNTdHJpbmcobnVsbHB0 cik7CiAgICAgICAgIH0KIAotICAgICAgICBKU1N0cmluZyogc3RyaW5nID0ganNTdHJpbmcodm0s IHMpOwotICAgICAgICBpbXBsLT5zZXRXZWFrSlNTdHJpbmcoV2Vha1NldDo6YWxsb2NhdGUoc3Ry aW5nLCBqc1N0cmluZ1dlYWtPd25lciwgaW1wbCkpOworICAgICAgICBKU1N0cmluZyogc3RyaW5n ID0gSlNTdHJpbmc6OmNyZWF0ZSh2bSwgJnN0cmluZ0ltcGwpOworICAgICAgICBzdHJpbmdJbXBs LnNldFdlYWtKU1N0cmluZyhXZWFrU2V0OjphbGxvY2F0ZShzdHJpbmcsIGpzU3RyaW5nV2Vha093 bmVyLCAmc3RyaW5nSW1wbCkpOwogICAgICAgICByZXR1cm4gc3RyaW5nOwogICAgIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDlkNDljNTUuLjc4OGUwOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAog MjAxNC0wMy0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKKyAgICAgICAg TWljcm8tb3B0aW1pemUgU3RyaW5ncyBpbiBKUyBiaW5kaW5ncy4KKyAgICAgICAgPGh0dHBzOi8v d2Via2l0Lm9yZy9iLzEyOTY3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUd2Vha2VkIGZvciBuZXcganNTdHJpbmdXaXRoV2Vha093bmVyIHNpZ25h dHVyZS4gVGhpcyBwYXRjaCByZW1vdmVzCisgICAgICAgIDM2IGJ5dGVzIG9mIGNvZGUgZnJvbSBl dmVyeSB3cmFwcGVyIGdldHRlciB0aGF0IHJldHVybnMgYSBET01TdHJpbmcuCisKKyAgICAgICAg KiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OmpzU3RyaW5n V2l0aENhY2hlKToKKworMjAxNC0wMy0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CisKICAgICAgICAgUmVtb3ZlIERvY3VtZW50OjppZEF0dHJpYnV0ZU5hbWUoKS4KICAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTY2Mz4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTUJpbmRpbmcuaAppbmRleCA1OGViOWExLi4yYWM0OTY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaApAQCAtNTgyLDE5ICs1ODIsMTkgQEAgSlND OjpFbmNvZGVkSlNWYWx1ZSBvYmplY3RUb1N0cmluZ0Z1bmN0aW9uR2V0dGVyKEpTQzo6RXhlY1N0 YXRlKiwgSlNDOjpKU09iamVjdCoKIAogaW5saW5lIEpTQzo6SlNWYWx1ZSBqc1N0cmluZ1dpdGhD YWNoZShKU0M6OkV4ZWNTdGF0ZSogZXhlYywgY29uc3QgU3RyaW5nJiBzKQogeworICAgIEpTQzo6 Vk0mIHZtID0gZXhlYy0+dm0oKTsKKwogICAgIFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwgPSBzLmlt cGwoKTsKICAgICBpZiAoIXN0cmluZ0ltcGwgfHwgIXN0cmluZ0ltcGwtPmxlbmd0aCgpKQotICAg ICAgICByZXR1cm4ganNFbXB0eVN0cmluZyhleGVjKTsKKyAgICAgICAgcmV0dXJuIGpzRW1wdHlT dHJpbmcoJnZtKTsKIAogICAgIGlmIChzdHJpbmdJbXBsLT5sZW5ndGgoKSA9PSAxKSB7CiAgICAg ICAgIFVDaGFyIHNpbmdsZUNoYXJhY3RlciA9ICgqc3RyaW5nSW1wbClbMHVdOwotICAgICAgICBp ZiAoc2luZ2xlQ2hhcmFjdGVyIDw9IEpTQzo6bWF4U2luZ2xlQ2hhcmFjdGVyU3RyaW5nKSB7Ci0g ICAgICAgICAgICBKU0M6OlZNKiB2bSA9ICZleGVjLT52bSgpOwotICAgICAgICAgICAgcmV0dXJu IHZtLT5zbWFsbFN0cmluZ3Muc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKHN0YXRpY19jYXN0PHVuc2ln bmVkIGNoYXI+KHNpbmdsZUNoYXJhY3RlcikpOwotICAgICAgICB9CisgICAgICAgIGlmIChzaW5n bGVDaGFyYWN0ZXIgPD0gSlNDOjptYXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcpCisgICAgICAgICAg ICByZXR1cm4gdm0uc21hbGxTdHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0cmluZyhzdGF0aWNfY2Fz dDx1bnNpZ25lZCBjaGFyPihzaW5nbGVDaGFyYWN0ZXIpKTsKICAgICB9CiAKLSAgICByZXR1cm4g SlNDOjpqc1N0cmluZ1dpdGhXZWFrT3duZXIoJmV4ZWMtPnZtKCksIHMpOworICAgIHJldHVybiBK U0M6OmpzU3RyaW5nV2l0aFdlYWtPd25lcih2bSwgKnMuaW1wbCgpKTsKIH0KIAogaW5saW5lIFN0 cmluZyBwcm9wZXJ0eU5hbWVUb1N0cmluZyhKU0M6OlByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUp Cg==