129671 2014-03-04 01:37:23 -0800 inSynchronizationOfLazyAttribute is making setAttributeInternal incomprehensible 2016-04-29 20:25:11 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 129550 1 rniwa rniwa benjamin cmarcelo commit-queue esprehn+autocc kangil.han kling koivisto oldest_to_newest 986733 0 rniwa 2014-03-04 01:37:23 -0800 inSynchronizationOfLazyAttribute is evaluated 4 times in various conditions even though all can just call ensureUniqueElementData().attributeAt(index).setValue(newValue) and exit early when it's true. Just do that so that the rest of code is more readable. 986751 1 225764 rniwa 2014-03-04 02:15:19 -0800 Created attachment 225764 Cleanup 986753 2 225764 kling 2014-03-04 02:21:08 -0800 Comment on attachment 225764 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=225764&action=review > Source/WebCore/dom/Element.cpp:1032 > + if (UNLIKELY(inSynchronizationOfLazyAttribute)) { > + ensureUniqueElementData().attributeAt(index).setValue(newValue); > + return; > + } I think you have a bug here. If there is an Attr node, you will no longer reset its text children. 986756 3 225764 rniwa 2014-03-04 02:32:07 -0800 Comment on attachment 225764 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=225764&action=review >> Source/WebCore/dom/Element.cpp:1032 >> + } > > I think you have a bug here. If there is an Attr node, you will no longer reset its text children. It comes from http://trac.webkit.org/changeset/139100. I can add a comment if you'd like. 1188975 4 225764 rniwa 2016-04-29 20:25:00 -0700 Comment on attachment 225764 Cleanup Too old. 225764 2014-03-04 02:15:19 -0800 2016-04-29 20:25:00 -0700 Cleanup bug-129671-20140304021644.patch text/plain 2556 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTA0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGluU3luY2hyb25pemF0aW9uT2ZM YXp5QXR0cmlidXRlIGlzIG1ha2luZyBzZXRBdHRyaWJ1dGVJbnRlcm5hbCBpbmNvbXByZWhlbnNp YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk2 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCBhbiBlYXJseSBleGl0IGZvciB3aGVuIGluU3luY2hyb25pemF0aW9uT2ZMYXp5QXR0cmlidXRl IGlzIHRydWUuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpFbGVtZW50OjpzZXRBdHRyaWJ1dGVJbnRlcm5hbCk6CisKIDIwMTQtMDMtMDQgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTY0ODU2KTog VXNlIGFmdGVyIGZyZWUgaW4gV2ViQ29yZTo6UXVhbGlmaWVkTmFtZTo6b3BlcmF0b3I9PSAvIFdl YkNvcmU6OlN0eWxlZEVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAJKHJldmlzaW9uIDE2NTA0NCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAyNiwyNiArMTAyNiwyOSBAQCBpbmxpbmUgdm9pZCBF bGVtZW50OjpzZXRBdHRyaWJ1dGVJbnRlcm5hCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAg ICBpZiAoVU5MSUtFTFkoaW5TeW5jaHJvbml6YXRpb25PZkxhenlBdHRyaWJ1dGUpKSB7CisgICAg ICAgIGVuc3VyZVVuaXF1ZUVsZW1lbnREYXRhKCkuYXR0cmlidXRlQXQoaW5kZXgpLnNldFZhbHVl KG5ld1ZhbHVlKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGNvbnN0IEF0dHJpYnV0 ZSYgYXR0cmlidXRlID0gYXR0cmlidXRlQXQoaW5kZXgpOwogICAgIEF0b21pY1N0cmluZyBvbGRW YWx1ZSA9IGF0dHJpYnV0ZS52YWx1ZSgpOwogICAgIGJvb2wgdmFsdWVDaGFuZ2VkID0gbmV3VmFs dWUgIT0gb2xkVmFsdWU7Ci0gICAgUXVhbGlmaWVkTmFtZSBhdHRyaWJ1dGVOYW1lID0gKCFpblN5 bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSB8fCB2YWx1ZUNoYW5nZWQpID8gYXR0cmlidXRl Lm5hbWUoKSA6IG5hbWU7CisgICAgUXVhbGlmaWVkTmFtZSBhdHRyaWJ1dGVOYW1lID0gdmFsdWVD aGFuZ2VkID8gYXR0cmlidXRlLm5hbWUoKSA6IG5hbWU7CiAKLSAgICBpZiAoIWluU3luY2hyb25p emF0aW9uT2ZMYXp5QXR0cmlidXRlKQotICAgICAgICB3aWxsTW9kaWZ5QXR0cmlidXRlKGF0dHJp YnV0ZU5hbWUsIG9sZFZhbHVlLCBuZXdWYWx1ZSk7CisgICAgd2lsbE1vZGlmeUF0dHJpYnV0ZShh dHRyaWJ1dGVOYW1lLCBvbGRWYWx1ZSwgbmV3VmFsdWUpOwogCiAgICAgaWYgKHZhbHVlQ2hhbmdl ZCkgewogICAgICAgICAvLyBJZiB0aGVyZSBpcyBhbiBBdHRyIG5vZGUgaG9va2VkIHRvIHRoaXMg YXR0cmlidXRlLCB0aGUgQXR0cjo6c2V0VmFsdWUoKSBjYWxsIGJlbG93CiAgICAgICAgIC8vIHdp bGwgd3JpdGUgaW50byB0aGUgRWxlbWVudERhdGEuCiAgICAgICAgIC8vIEZJWE1FOiBSZWZhY3Rv ciB0aGlzIHNvIGl0IG1ha2VzIHNvbWUgc2Vuc2UuCi0gICAgICAgIGlmIChSZWZQdHI8QXR0cj4g YXR0ck5vZGUgPSBpblN5bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSA/IDAgOiBhdHRySWZF eGlzdHMoYXR0cmlidXRlTmFtZSkpCisgICAgICAgIGlmIChSZWZQdHI8QXR0cj4gYXR0ck5vZGUg PSBhdHRySWZFeGlzdHMoYXR0cmlidXRlTmFtZSkpCiAgICAgICAgICAgICBhdHRyTm9kZS0+c2V0 VmFsdWUobmV3VmFsdWUpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBlbnN1cmVVbmlxdWVF bGVtZW50RGF0YSgpLmF0dHJpYnV0ZUF0KGluZGV4KS5zZXRWYWx1ZShuZXdWYWx1ZSk7CiAgICAg fQogCi0gICAgaWYgKCFpblN5bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSkKLSAgICAgICAg ZGlkTW9kaWZ5QXR0cmlidXRlKGF0dHJpYnV0ZU5hbWUsIG9sZFZhbHVlLCBuZXdWYWx1ZSk7Cisg ICAgZGlkTW9kaWZ5QXR0cmlidXRlKGF0dHJpYnV0ZU5hbWUsIG9sZFZhbHVlLCBuZXdWYWx1ZSk7 CiB9CiAKIHN0YXRpYyBpbmxpbmUgQXRvbWljU3RyaW5nIG1ha2VJZEZvclN0eWxlUmVzb2x1dGlv bihjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlLCBib29sIGluUXVpcmtzTW9kZSkK