129662 2014-03-04 00:52:32 -0800 Don't synchronize attributes in reflect setters when we don't need to 2014-03-04 11:07:22 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa barraclough benjamin cdumez cgarcia cmarcelo commit-queue esprehn+autocc ggaren kangil.han kling koivisto oliver ossy webkit-bug-importer oldest_to_newest 986708 0 rniwa 2014-03-04 00:52:32 -0800 We're currently calling setAttribute on every setters generated by "Reflect" keyword in IDL. 986709 1 webkit-bug-importer 2014-03-04 00:53:05 -0800 <rdar://problem/16220728> 986718 2 225748 rniwa 2014-03-04 01:07:04 -0800 Created attachment 225748 Fixes the bug 986757 3 225748 rniwa 2014-03-04 02:43:04 -0800 Comment on attachment 225748 Fixes the bug Clearing flags on attachment: 225748 Committed r165046: <http://trac.webkit.org/changeset/165046> 986758 4 rniwa 2014-03-04 02:43:08 -0800 All reviewed patches have been landed. Closing bug. 986804 5 ossy 2014-03-04 07:36:49 -0800 (In reply to comment #3) > (From update of attachment 225748 [details]) > Clearing flags on attachment: 225748 > > Committed r165046: <http://trac.webkit.org/changeset/165046> It broke the bindings tests. Could you fix them? 986880 6 koivisto 2014-03-04 11:07:22 -0800 Updated bindings test results in https://trac.webkit.org/r165062 225748 2014-03-04 01:07:04 -0800 2014-03-04 02:43:03 -0800 Fixes the bug bug-129662-20140304010829.patch text/plain 4008 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTA0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTA0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERvbid0IHN5bmNocm9uaXplIGF0 dHJpYnV0ZXMgaW4gcmVmbGVjdCBzZXR0ZXJzIHdoZW4gd2UgZG9uJ3QgbmVlZCB0bworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NjYyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZhc3QgbWFqb3Jp dHkgb2YgYXR0cmlidXRlcyBkb24ndCBuZWVkIHN5bmNocm9uaXphdGlvbi4gQXZvaWQgY2FsbGlu ZyBzeW5jaHJvbml6ZUF0dHJpYnV0ZSBpbiBzZXR0ZXJzCisgICAgICAgIGZvciB0aG9zZSBjb250 ZW50IGF0dHJpYnV0ZXMgZ2VuZXJhdGVkIGJ5ICJSZWZsZWN0IiBrZXl3b3JkIGluIElETC4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKFNl dHRlckV4cHJlc3Npb24pOgorICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkVsZW1lbnQ6OnNldEF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24pOiBBZGRl ZC4KKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorCiAyMDE0LTAzLTA0ICBIeW93b24gS2ltICA8 aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBNb3ZlIEV2YXNHTENvbnRleHQgYW5k IEV2YXNHTFN1cmZhY2UgZmlsZXMgaW50byB0aGUgZWZsIGNvbW1vbiBkaXJlY3RvcnkuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBt CShyZXZpc2lvbiAxNjUwNDMpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3IucG0JKHdvcmtpbmcgY29weSkKQEAgLTU5MywxNSArNTkzLDE5IEBAIHN1YiBT ZXR0ZXJFeHByZXNzaW9uCiAgICAgICAgIHJldHVybiAoInNldCIgLiAkZ2VuZXJhdG9yLT5XS191 Y2ZpcnN0KCRnZW5lcmF0b3ItPkF0dHJpYnV0ZU5hbWVGb3JHZXR0ZXJBbmRTZXR0ZXIoJGF0dHJp YnV0ZSkpKTsKICAgICB9CiAKKyAgICBteSAkYXR0cmlidXRlVHlwZSA9ICRhdHRyaWJ1dGUtPnNp Z25hdHVyZS0+dHlwZTsKKwogICAgIG15ICRmdW5jdGlvbk5hbWU7Ci0gICAgaWYgKCRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+dHlwZSBlcSAiYm9vbGVhbiIpIHsKKyAgICBpZiAoJGF0dHJpYnV0ZVR5 cGUgZXEgImJvb2xlYW4iKSB7CiAgICAgICAgICRmdW5jdGlvbk5hbWUgPSAic2V0Qm9vbGVhbkF0 dHJpYnV0ZSI7Ci0gICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJs b25nIikgeworICAgIH0gZWxzaWYgKCRhdHRyaWJ1dGVUeXBlIGVxICJsb25nIikgewogICAgICAg ICAkZnVuY3Rpb25OYW1lID0gInNldEludGVncmFsQXR0cmlidXRlIjsKLSAgICB9IGVsc2lmICgk YXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGUgZXEgInVuc2lnbmVkIGxvbmciKSB7CisgICAgfSBl bHNpZiAoJGF0dHJpYnV0ZVR5cGUgZXEgInVuc2lnbmVkIGxvbmciKSB7CiAgICAgICAgICRmdW5j dGlvbk5hbWUgPSAic2V0VW5zaWduZWRJbnRlZ3JhbEF0dHJpYnV0ZSI7Ci0gICAgfSBlbHNlIHsK KyAgICB9IGVsc2lmICgkZ2VuZXJhdG9yLT5Jc1NWR0FuaW1hdGVkVHlwZSgkYXR0cmlidXRlVHlw ZSkpIHsKICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICJzZXRBdHRyaWJ1dGUiOworICAgIH0gZWxz ZSB7CisgICAgICAgICRmdW5jdGlvbk5hbWUgPSAic2V0QXR0cmlidXRlV2l0aG91dFN5bmNocm9u aXphdGlvbiI7CiAgICAgfQogCiAgICAgcmV0dXJuICgkZnVuY3Rpb25OYW1lLCAkY29udGVudEF0 dHJpYnV0ZU5hbWUpOwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMTY1MDQz KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MDA3LDYgKzEwMDcsMTIgQEAgdm9pZCBFbGVtZW50OjpzZXRBdHRyaWJ1dGUoY29uc3QgUXVhbGlm aQogICAgIHNldEF0dHJpYnV0ZUludGVybmFsKGluZGV4LCBuYW1lLCB2YWx1ZSwgTm90SW5TeW5j aHJvbml6YXRpb25PZkxhenlBdHRyaWJ1dGUpOwogfQogCit2b2lkIEVsZW1lbnQ6OnNldEF0dHJp YnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29u c3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICB1bnNpZ25lZCBpbmRleCA9IGVsZW1lbnRE YXRhKCkgPyBlbGVtZW50RGF0YSgpLT5maW5kQXR0cmlidXRlSW5kZXhCeU5hbWUobmFtZSkgOiBF bGVtZW50RGF0YTo6YXR0cmlidXRlTm90Rm91bmQ7CisgICAgc2V0QXR0cmlidXRlSW50ZXJuYWwo aW5kZXgsIG5hbWUsIHZhbHVlLCBOb3RJblN5bmNocm9uaXphdGlvbk9mTGF6eUF0dHJpYnV0ZSk7 Cit9CisKIHZvaWQgRWxlbWVudDo6c2V0U3luY2hyb25pemVkTGF6eUF0dHJpYnV0ZShjb25zdCBR dWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQogewogICAgIHVu c2lnbmVkIGluZGV4ID0gZWxlbWVudERhdGEoKSA/IGVsZW1lbnREYXRhKCktPmZpbmRBdHRyaWJ1 dGVJbmRleEJ5TmFtZShuYW1lKSA6IEVsZW1lbnREYXRhOjphdHRyaWJ1dGVOb3RGb3VuZDsKQEAg LTIwNTQsNyArMjA2MCw3IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgRWxlbWVudDo6cHNldWRvKCkg Y28KIAogdm9pZCBFbGVtZW50OjpzZXRQc2V1ZG8oY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkK IHsKLSAgICBzZXRBdHRyaWJ1dGUocHNldWRvQXR0ciwgdmFsdWUpOworICAgIHNldEF0dHJpYnV0 ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24ocHNldWRvQXR0ciwgdmFsdWUpOwogfQogCiBMYXlvdXRT aXplIEVsZW1lbnQ6Om1pbmltdW1TaXplRm9yUmVzaXppbmcoKSBjb25zdApJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5oCShyZXZpc2lvbiAxNjUwNDMpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsNiArMTQ0LDcgQEAgcHVibGljOgogICAgIGJvb2wg aGFzQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmKSBjb25zdDsKICAgICBjb25zdCBBdG9t aWNTdHJpbmcmIGdldEF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJikgY29uc3Q7CiAgICAg dm9pZCBzZXRBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGNvbnN0IEF0b21pY1N0cmlu ZyYgdmFsdWUpOworICAgIHZvaWQgc2V0QXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihj b25zdCBRdWFsaWZpZWROYW1lJiwgY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSk7CiAgICAgdm9p ZCBzZXRTeW5jaHJvbml6ZWRMYXp5QXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmLCBjb25z dCBBdG9taWNTdHJpbmcmIHZhbHVlKTsKICAgICBib29sIHJlbW92ZUF0dHJpYnV0ZShjb25zdCBR dWFsaWZpZWROYW1lJik7CiAK