<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129642</bug_id>
          
          <creation_ts>2014-03-03 16:59:34 -0800</creation_ts>
          <short_desc>StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)</short_desc>
          <delta_ts>2014-09-26 13:19:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, MakingBotsRed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>129217</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>andersca</cc>
    
    <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>burg</cc>
    
    <cc>graouts</cc>
    
    <cc>joepeck</cc>
    
    <cc>sam</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>986591</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-03-03 16:59:34 -0800</bug_when>
    <thetext>inspector/test-harness-trivially-works.html frequently asserts:

http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r165013%20(3509)/inspector/test-harness-trivially-works-crash-log.txt

Thread 25 Crashed:: WebCore: LocalStorage
0   com.apple.JavaScriptCore      	0x0000000101d74b2a WTFCrash + 42 (Assertions.cpp:333)
1   com.apple.WebCore             	0x00000001050e4db2 WebCore::StorageTracker::deleteOrigin(WebCore::SecurityOrigin*) + 130 (StorageTracker.cpp:455)
2   com.apple.WebCore             	0x00000001050e402d WebCore::StorageTracker::deleteOriginWithIdentifier(WTF::String const&amp;) + 61 (StorageTracker.cpp:449)
3   com.apple.WebCore             	0x00000001050cd815 WebCore::StorageAreaSync::deleteEmptyDatabase() + 421 (StorageAreaSync.cpp:517)
4   com.apple.WebCore             	0x00000001050cfac2 WTF::FunctionWrapper&lt;void (WebCore::StorageAreaSync::*)()&gt;::operator()(WebCore::StorageAreaSync*) + 114 (Functional.h:218)
5   com.apple.WebCore             	0x00000001050cfa45 WTF::BoundFunctionImpl&lt;WTF::FunctionWrapper&lt;void (WebCore::StorageAreaSync::*)()&gt;, void (WebCore::StorageAreaSync*)&gt;::operator()() + 53 (Functional.h:496)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986593</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-03-03 17:00:49 -0800</bug_when>
    <thetext>&lt;rdar://problem/16217802&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986850</commentid>
    <comment_count>2</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2014-03-04 09:51:11 -0800</bug_when>
    <thetext>StorageTracker.cpp:455: ASSERT(isMainThread());

This is an indication of a treading issue or the assertion is bad. It does not seem Inspector specific, this test does nothing more than test the Inspector test harness. The Inspector is closing when this happens.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986858</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-03-04 10:09:06 -0800</bug_when>
    <thetext>What should we do in the meanwhile? Would skipping this particular test be sufficient? Or does an assertion  in &quot;trivially works&quot; test mean that all Inspector tests are affected?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986861</commentid>
    <comment_count>4</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2014-03-04 10:15:00 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; What should we do in the meanwhile? Would skipping this particular test be sufficient? Or does an assertion  in &quot;trivially works&quot; test mean that all Inspector tests are affected?

It would affect tests in LayoutTests/inspector/ but not LayoutTests/inspector-protocol. The latter uses a dummy page and doesn&apos;t actually open up an inspector instance through WK/WK2.

I was working to move tests in LayoutTests/inspector-protocol/ to LayoutTests/inspector, so enabling those tests after moving them to the different test harness is blocked by this flakiness.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986863</commentid>
    <comment_count>5</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2014-03-04 10:16:25 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; What should we do in the meanwhile? Would skipping this particular test be sufficient? Or does an assertion  in &quot;trivially works&quot; test mean that all Inspector tests are affected?

So, it could be skipped for now to make bots green, but it should be addressed ASAP to unblock writing replay tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986878</commentid>
    <comment_count>6</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2014-03-04 10:57:40 -0800</bug_when>
    <thetext>Marked skipped in &lt;https://trac.webkit.org/changeset/165061&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986885</commentid>
    <comment_count>7</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-03-04 11:18:53 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; StorageTracker.cpp:455: ASSERT(isMainThread());

Aren&apos;t we on the main thread?!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986886</commentid>
    <comment_count>8</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-03-04 11:20:09 -0800</bug_when>
    <thetext>Oh, I see: Crashed Thread:  25  WebCore: LocalStorage</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988912</commentid>
    <comment_count>9</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-03-10 09:50:56 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt;this test does nothing more than test the Inspector test harness. 

What is &quot;the inspector test harness&quot;?  DRT?  WebKitTestRunner?  Or some other executable?

I ask, because a WebKit app that enables LocalStorage is also required to explicitly shut down local storage before it exits.  DRT and WKTR do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>988914</commentid>
    <comment_count>10</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-03-10 09:51:35 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #2)
&gt; &gt;this test does nothing more than test the Inspector test harness. 
&gt; 
&gt; What is &quot;the inspector test harness&quot;?  DRT?  WebKitTestRunner?  Or some other executable?
&gt; 
&gt; I ask, because a WebKit app that enables LocalStorage is also required to explicitly shut down local storage before it exits.  DRT and WKTR do this.

I guess I misunderstood the significance of &quot;Inspector test harness&quot; as this just appears to be DRT crashing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>989759</commentid>
    <comment_count>11</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2014-03-12 11:38:31 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #9)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt;this test does nothing more than test the Inspector test harness. 
&gt; &gt; 
&gt; &gt; What is &quot;the inspector test harness&quot;?  DRT?  WebKitTestRunner?  Or some other executable?
&gt; &gt; 
&gt; &gt; I ask, because a WebKit app that enables LocalStorage is also required to explicitly shut down local storage before it exits.  DRT and WKTR do this.
&gt; 
&gt; I guess I misunderstood the significance of &quot;Inspector test harness&quot; as this just appears to be DRT crashing.

Yes, &quot;Inspector test harness&quot; just runs inside DRT and WKTR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>995641</commentid>
    <comment_count>12</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-03-29 23:05:35 -0700</bug_when>
    <thetext>Saw this on inspector/dom/content-flow-content-removal.html today. Did we get more tests that use the harness?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>996008</commentid>
    <comment_count>13</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-03-31 14:25:34 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; Saw this on inspector/dom/content-flow-content-removal.html today. Did we get more tests that use the harness?

Everything in the inspector/ directory was ported at the same time to the new test &quot;harness&quot;. I think any test that uses a real inspector instance–everything under inspector/–could hit this assertion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037325</commentid>
    <comment_count>14</comment_count>
      <attachid>238679</attachid>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-09-25 15:43:33 -0700</bug_when>
    <thetext>Created attachment 238679
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037326</commentid>
    <comment_count>15</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-09-25 15:50:50 -0700</bug_when>
    <thetext>We really need an easy way to take sudden termination assertions while all these main thread operations are still outstanding.

This introduces a new one, but there&apos;s so many already that it&apos;s okay for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037332</commentid>
    <comment_count>16</comment_count>
      <attachid>238679</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-09-25 16:24:23 -0700</bug_when>
    <thetext>Comment on attachment 238679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238679&amp;action=review

&gt; Source/WebCore/storage/StorageAreaSync.cpp:526
&gt; +            String databaseIdentifierCopy = m_databaseIdentifier.isolatedCopy();
&gt; +            callOnMainThread([databaseIdentifierCopy] {

This is not thread safe. A new copy of the string is made for the capture, and databaseIdentifierCopy races with it for derefing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037381</commentid>
    <comment_count>17</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-09-25 19:20:10 -0700</bug_when>
    <thetext>Committed r173991: &lt;http://trac.webkit.org/changeset/173991&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037428</commentid>
    <comment_count>18</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-09-26 00:02:31 -0700</bug_when>
    <thetext>In the landed patch, what guarantees that &quot;this&quot; object is still alive when code executes on the main thread? I&apos;m concerned that this might have introduced a potential use-after-free security bug.

If you just needed to pass a string, you could make an isolated StringImpl*, and manually delete it when done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037504</commentid>
    <comment_count>19</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-09-26 10:19:03 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; (From update of attachment 238679 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=238679&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/storage/StorageAreaSync.cpp:526
&gt; &gt; +            String databaseIdentifierCopy = m_databaseIdentifier.isolatedCopy();
&gt; &gt; +            callOnMainThread([databaseIdentifierCopy] {
&gt; 
&gt; This is not thread safe. A new copy of the string is made for the capture, and databaseIdentifierCopy races with it for derefing.

I might be dense, but.. if the local is instead a String&amp;&amp; databaseIdentifierCopy, then this should cause capture to transfer the StringImpl ref from databesIdentifierCopy to the captured version, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037513</commentid>
    <comment_count>20</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-09-26 10:45:16 -0700</bug_when>
    <thetext>&gt; if the local is instead a String&amp;&amp; databaseIdentifierCopy

I don&apos;t think that would compile.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037520</commentid>
    <comment_count>21</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-09-26 11:01:14 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; &gt; if the local is instead a String&amp;&amp; databaseIdentifierCopy
&gt; 
&gt; I don&apos;t think that would compile.

C++11 doesn&apos;t support capture-by-move in lambdas. C++14 does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037521</commentid>
    <comment_count>22</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-09-26 11:29:26 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; Committed r173991: &lt;http://trac.webkit.org/changeset/173991&gt;

I might have r+&apos;ed, but based on Alexey&apos;s feedback afterwards I don&apos;t think this patch should have been landed as-is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037522</commentid>
    <comment_count>23</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-09-26 11:45:59 -0700</bug_when>
    <thetext>It&apos;s not evident from the bug, but Brian did account for my feedback when landing. That was still not quite correct, so he followed up with a better fix in &lt;http://trac.webkit.org/changeset/174014&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037532</commentid>
    <comment_count>24</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-09-26 13:03:49 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; It&apos;s not evident from the bug, but Brian did account for my feedback when landing. That was still not quite correct, so he followed up with a better fix in &lt;http://trac.webkit.org/changeset/174014&gt;.

Ack, my apologies - Saw the continued chatter without actually looking at the landed patch :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037538</commentid>
    <comment_count>25</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-09-26 13:19:54 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; (In reply to comment #23)
&gt; &gt; It&apos;s not evident from the bug, but Brian did account for my feedback when landing. That was still not quite correct, so he followed up with a better fix in &lt;http://trac.webkit.org/changeset/174014&gt;.
&gt; 
&gt; Ack, my apologies - Saw the continued chatter without actually looking at the landed patch :)

I assumed that commit-queue would add a link to the fixup commit here, but I must have used dcommit or something. Sorry for the confusion!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>238679</attachid>
            <date>2014-09-25 15:43:33 -0700</date>
            <delta_ts>2014-09-25 16:24:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-129642-20140925154323.patch</filename>
            <type>text/plain</type>
            <size>5244</size>
            <attacher name="Brian Burg">burg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTczOTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzI2NzE0MmY0MDNjM2M1
MzFhYTdlMDg1OTM0N2RiNmU5MDliNWZmYi4uODI0ZDVhNDU4ZWE4MmEyZDQwYzNiYzkyODc1MDkx
NDkwNDUwZTY0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA5LTI1ICBCcmlh
biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBTdG9yYWdlVHJh
Y2tlcjo6ZGVsZXRlT3JpZ2luIGJlaW5nIGNhbGxlZCBvZmYgdGhlIG1haW4gdGhyZWFkIChBU1NF
UlRzIGluIGluc3BlY3Rvci90ZXN0LWhhcm5lc3MtdHJpdmlhbGx5LXdvcmtzLmh0bWwgdGVzdCkK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTY0Mgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGVh
cmluZyBkb3duIHRoZSBpbnNwZWN0b3IgZnJvbnRlbmQncyBwYWdlLCB3ZSB0cmlnZ2VyIGEgdGhy
ZWFkaW5nIHZpb2xhdGlvbgorICAgICAgICBpbiBTdG9yYWdlQXJlYVN5bmMncyBmaW5hbCBzeW5j
IGNvZGUgdW5kZXJuZWF0aCBTdG9yYWdlQXJlYVN5bmM6OmRlbGV0ZUVtcHR5RGF0YWJhc2UoKS4K
KworICAgICAgICBObyBuZXcgdGVzdHMuIFJlZ3Jlc3Npb24gaXMgY292ZXJlZCBieSBpbnNwZWN0
b3IvdGVzdC1oYXJuZXNzLXRyaXZpYWxseS13b3Jrcy5odG1sLgorCisgICAgICAgICogc3RvcmFn
ZS9TdG9yYWdlQXJlYVN5bmMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZUFyZWFTeW5j
OjpkZWxldGVFbXB0eURhdGFiYXNlKTogYWRkIGEgbWlzc2luZyBjYWxsT25NYWluVGhyZWFkKCkg
d2hlbgorICAgICAgICBjYWxsaW5nIFN0b3JhZ2VUcmFja2VyOjpkZWxldGVPcmlnaW5XaXRoSWRl
bnRpZmllcigpLgorCiAyMDE0LTA5LTI1ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNv
bT4KIAogICAgICAgICBSYWNlIGluIHJlZiBwb2ludGVyIGZvciBXZWJWaWRlb0Z1bGxzY3JlZW5J
bnRlcmZhY2VBVktpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFn
ZUFyZWFTeW5jLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFTeW5jLmNw
cAppbmRleCBhOGEwMjc3YjRkMDUxOWZhZWEzNGVlNDQ0OTM1NWQ5YmMyOGE2OGU1Li5jMGY3ZjJm
ODdmNDYwMDcwMThhMTc1YmVmNzcxYmMzZTJiYjVhMjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9zdG9yYWdlL1N0b3JhZ2VBcmVhU3luYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3Rv
cmFnZS9TdG9yYWdlQXJlYVN5bmMuY3BwCkBAIC01MjEsOSArNTIxLDEyIEBAIHZvaWQgU3RvcmFn
ZUFyZWFTeW5jOjpkZWxldGVFbXB0eURhdGFiYXNlKCkKICAgICBpZiAoIWNvdW50KSB7CiAgICAg
ICAgIHF1ZXJ5LmZpbmFsaXplKCk7CiAgICAgICAgIG1fZGF0YWJhc2UuY2xvc2UoKTsKLSAgICAg
ICAgaWYgKFN0b3JhZ2VUcmFja2VyOjp0cmFja2VyKCkuaXNBY3RpdmUoKSkKLSAgICAgICAgICAg
IFN0b3JhZ2VUcmFja2VyOjp0cmFja2VyKCkuZGVsZXRlT3JpZ2luV2l0aElkZW50aWZpZXIobV9k
YXRhYmFzZUlkZW50aWZpZXIpOwotICAgICAgICBlbHNlIHsKKyAgICAgICAgaWYgKFN0b3JhZ2VU
cmFja2VyOjp0cmFja2VyKCkuaXNBY3RpdmUoKSkgeworICAgICAgICAgICAgU3RyaW5nIGRhdGFi
YXNlSWRlbnRpZmllckNvcHkgPSBtX2RhdGFiYXNlSWRlbnRpZmllci5pc29sYXRlZENvcHkoKTsK
KyAgICAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW2RhdGFiYXNlSWRlbnRpZmllckNvcHldIHsK
KyAgICAgICAgICAgICAgICBTdG9yYWdlVHJhY2tlcjo6dHJhY2tlcigpLmRlbGV0ZU9yaWdpbldp
dGhJZGVudGlmaWVyKGRhdGFiYXNlSWRlbnRpZmllckNvcHkpOworICAgICAgICAgICAgfSk7Cisg
ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBTdHJpbmcgZGF0YWJhc2VGaWxlbmFtZSA9IG1f
c3luY01hbmFnZXItPmZ1bGxEYXRhYmFzZUZpbGVuYW1lKG1fZGF0YWJhc2VJZGVudGlmaWVyKTsK
ICAgICAgICAgICAgIGlmICghU1FMaXRlRmlsZVN5c3RlbTo6ZGVsZXRlRGF0YWJhc2VGaWxlKGRh
dGFiYXNlRmlsZW5hbWUpKQogICAgICAgICAgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGRl
bGV0ZSBkYXRhYmFzZSBmaWxlICVzXG4iLCBkYXRhYmFzZUZpbGVuYW1lLnV0ZjgoKS5kYXRhKCkp
OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCmluZGV4IGYzYTgzZDY1MWY0ZGUyYjNjYWFkNDhhZmJlMWQwNGVlOTU1OTI2NjAuLmMyNjU5
ZWI2NGFmNTZmMDhmY2YwM2NkYTRmMDJmMWQ2ZjY0NTY3ZWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA
QAorMjAxNC0wOS0yNSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CisK
KyAgICAgICAgU3RvcmFnZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbiBiZWluZyBjYWxsZWQgb2ZmIHRo
ZSBtYWluIHRocmVhZCAoQVNTRVJUcyBpbiBpbnNwZWN0b3IvdGVzdC1oYXJuZXNzLXRyaXZpYWxs
eS13b3Jrcy5odG1sIHRlc3QpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xMjk2NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBSZW1vdmUgdGhlIGJsYW5rZXQgU2tpcCBmb3IgYWxsIHRlc3RzIGluIGluc3Bl
Y3Rvci8uCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBjbGVhbiB1cCBleHBlY3RhdGlv
bnMgZm9yIGluc3BlY3Rvci8gYW5kIGFkZCBuZXcgdHJhY2tpbmcgYnVncy4KKwogMjAxNC0wOS0y
NSAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBB
U1NFUlRJT04gRkFJTEVEOiBjb2x1bW5Db3VudCBpbiBXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNl
R3JpZFRlbXBsYXRlQXJlYXNSb3cKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3Rh
dGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGQ1OTY2NDAzNDkzZThj
YTQ4NWZmZWU3OGEwMDRjMGY4NzRiMDUzNjYuLmMzYWFkNWM4MDQ4NmM2OTI1NzhlYmZlYjA2ZDc3
OTkwNDY5Mzc4YWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysr
IGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTAsOCArOTAsNiBAQCB3ZWJraXQu
b3JnL2IvMTI5NjM5IGluc3BlY3Rvci1wcm90b2NvbC9kb20vZG9tLXNlYXJjaC1jcmFzaC5odG1s
IFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTI5MzI3IGluc3BlY3Rvci1wcm90b2NvbC9pbmRleGVk
ZGIvYmFzaWNzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEyNzQxNCBpbnNw
ZWN0b3ItcHJvdG9jb2wvcGFnZS9kZW55LVgtRnJhbWVPcHRpb24uaHRtbCBbIFBhc3MgRmFpbHVy
ZSBdCiAKLXdlYmtpdC5vcmcvYi8xMjk2NDIgaW5zcGVjdG9yIFsgU2tpcCBdCi0KICMgVGhlc2Ug
dGVzdHMgY2F1c2UgYXNzZXJ0aW9uIGZhaWx1cmVzIGluIHN1YnNlcXVlbnQgdGVzdHMKIHdlYmtp
dC5vcmcvYi8xMzE5MTkgaW5zcGVjdG9yL2RvbSBbIFNraXAgXQogCkBAIC05OSwxNiArOTcsMTcg
QEAgd2Via2l0Lm9yZy9iLzEzMTkxOSBpbnNwZWN0b3IvZG9tIFsgU2tpcCBdCiAjIHdlYmtpdC5v
cmcvYi8xMjk4MTcgaW5zcGVjdG9yL2RvbS9jb250ZW50LWZsb3ctbGlzdC5odG1sIFsgUGFzcyBG
YWlsdXJlIF0KICMgd2Via2l0Lm9yZy9iLzEyOTgxNyBpbnNwZWN0b3IvZG9tL2NvbnRlbnQtZmxv
dy1jb250ZW50LXJlbW92YWwuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLSMgQ29sbGVjdGluZyBy
ZWdpb24ncyBjaGlsZHJlbiBpbiBhIG5hbWVkIGZsb3cgbm90IHN1cHBvcnRlZCB5ZXQKLXdlYmtp
dC5vcmcvYi83NDE0NCBmYXN0L3JlZ2lvbnMvZmxvdy1ib2R5LWluLWh0bWwuaHRtbCBbIFNraXAg
XQotd2Via2l0Lm9yZy9iLzc0MTQ0IGZhc3QvcmVnaW9ucy91bml2ZXJzYWwtc2VsZWN0b3ItY2hp
bGRyZW4tdG8tdGhlLXNhbWUtcmVnaW9uLmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi83NDE0
NCBmYXN0L3JlZ2lvbnMvcmVnaW9uLWNvbnRlbnQtZmxvd24taW50by1yZWdpb24uaHRtbCBbIFNr
aXAgXQorIyBUaGVzZSB0ZXN0cyBzdGlsbCBteXN0ZXJpb3VzbHkgZmxha2UgYW5kL29yIHRpbWUg
b3V0Lgord2Via2l0Lm9yZy9iLzEzNzEzMSBpbnNwZWN0b3IvZGVidWdnZXIgWyBTa2lwIF0KK3dl
YmtpdC5vcmcvYi8xMzcxMzAgaW5zcGVjdG9yL3JlcGxheSBbIFNraXAgXQogCiAjIERvZXNuJ3Qg
d29yayB5ZXQsIHJlbGllcyBvbiBuZXR3b3JrIHJlcGxheSBmdW5jdGlvbmFsaXR5ICh3ZWJraXQu
b3JnL2IvMTMwNzI4LCB3ZWJraXQub3JnL2IvMTI5MzkxKQogd2Via2l0Lm9yZy9iLzEzMTMxOCBo
dHRwL3Rlc3RzL2luc3BlY3Rvci9yZXBsYXkvZG9jdW1lbnQtbGFzdC1tb2RpZmllZC1mYWxsYmFj
ay12YWx1ZS5odG1sIFsgU2tpcCBdCiAKLSMgQXNzZXJ0cyBpbiBkZWJ1ZyBidWlsZHMuCi1bIERl
YnVnIF0gaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVwbGF5L2RvY3VtZW50LWxhc3QtbW9kaWZpZWQt
ZmFsbGJhY2stdmFsdWUuaHRtbCBbIFNraXAgXQorIyBDb2xsZWN0aW5nIHJlZ2lvbidzIGNoaWxk
cmVuIGluIGEgbmFtZWQgZmxvdyBub3Qgc3VwcG9ydGVkIHlldAord2Via2l0Lm9yZy9iLzc0MTQ0
IGZhc3QvcmVnaW9ucy9mbG93LWJvZHktaW4taHRtbC5odG1sIFsgU2tpcCBdCit3ZWJraXQub3Jn
L2IvNzQxNDQgZmFzdC9yZWdpb25zL3VuaXZlcnNhbC1zZWxlY3Rvci1jaGlsZHJlbi10by10aGUt
c2FtZS1yZWdpb24uaHRtbCBbIFNraXAgXQord2Via2l0Lm9yZy9iLzc0MTQ0IGZhc3QvcmVnaW9u
cy9yZWdpb24tY29udGVudC1mbG93bi1pbnRvLXJlZ2lvbi5odG1sIFsgU2tpcCBdCiAKICMgRXhw
YW5kbyBwcm9wZXJ0aWVzIG9uIGF0dHJpYnV0ZSBub2RlcyBkaXNhcHBlYXIKIHdlYmtpdC5vcmcv
Yi84ODA0NSBmYXN0L2RvbS9nYy1hdHRyaWJ1dGUtbm9kZS5odG1sIFsgRmFpbHVyZSBQYXNzIF0K
</data>
<flag name="review"
          id="263431"
          type_id="1"
          status="+"
          setter="beidson"
    />
          </attachment>
      

    </bug>

</bugzilla>