<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129637</bug_id>
          
          <creation_ts>2014-03-03 16:37:18 -0800</creation_ts>
          <short_desc>[GTK] Give the WebKit GObject DOM bindings API break detection it&apos;s own buildbot bubble</short_desc>
          <delta_ts>2014-03-06 06:03:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>129571</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>986567</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-03 16:37:18 -0800</bug_when>
    <thetext>Carlos requested this in 129571.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986603</commentid>
    <comment_count>1</comment_count>
      <attachid>225719</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-03 17:11:42 -0800</bug_when>
    <thetext>Created attachment 225719
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986849</commentid>
    <comment_count>2</comment_count>
      <attachid>225719</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-04 09:50:00 -0800</bug_when>
    <thetext>Comment on attachment 225719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225719&amp;action=review

Thanks!

&gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:663
&gt; +    def evaluateCommand(self, cmd):
&gt; +        if self.missingAPI:
&gt; +            return FAILURE
&gt; +        return SUCCESS

I think we can return WARNINGS in case of compatible api changes, so that I won&apos;t miss them :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986854</commentid>
    <comment_count>3</comment_count>
      <attachid>225786</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-04 10:01:58 -0800</bug_when>
    <thetext>Created attachment 225786
Return a warning when there is new API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986900</commentid>
    <comment_count>4</comment_count>
      <attachid>225798</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-04 11:36:47 -0800</bug_when>
    <thetext>Created attachment 225798
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986901</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-03-04 11:37:59 -0800</bug_when>
    <thetext>Attachment 225798 did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:384:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:387:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable &apos;SUCCESS&apos;  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:389:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable &apos;WARNINGS&apos;  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:391:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable &apos;FAILURE&apos;  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:394:  [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable &apos;RunGtkWebKitGObjectDOMBindingsAPIBreakTests&apos;  [pylint/E0602] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986907</commentid>
    <comment_count>6</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-04 11:50:23 -0800</bug_when>
    <thetext>(In reply to comment #5)

&gt; 
&gt; If any of these errors are false positives, please file a bug against check-webkit-style.

The style errors all look like false positives. The tests run fine for me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987153</commentid>
    <comment_count>7</comment_count>
      <attachid>225798</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-04 23:41:05 -0800</bug_when>
    <thetext>Comment on attachment 225798
Patch

I guess it&apos;s the same patch, simply adding unit tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987250</commentid>
    <comment_count>8</comment_count>
      <attachid>225798</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-05 07:42:45 -0800</bug_when>
    <thetext>Comment on attachment 225798
Patch

Clearing flags on attachment: 225798

Committed r165108: &lt;http://trac.webkit.org/changeset/165108&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987251</commentid>
    <comment_count>9</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-05 07:42:47 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987595</commentid>
    <comment_count>10</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-06 00:21:17 -0800</bug_when>
    <thetext>Was there anything wrong with this patch? I don&apos;t see the new step in the bots, should we reopen this? or am I missing something?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>987666</commentid>
    <comment_count>11</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-06 06:03:42 -0800</bug_when>
    <thetext>I was hoping that the bots would detect the change to master.cfg and reload, but I guess they did not. Today I&apos;ll try to figure out what we need to do to have the bubble show up.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>225719</attachid>
            <date>2014-03-03 17:11:42 -0800</date>
            <delta_ts>2014-03-04 10:01:50 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-129637-20140303171142.patch</filename>
            <type>text/plain</type>
            <size>2979</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWMxZjZkNGRiNmQ4YzVhZjc4MmNhMmFhZjcyMTcyOWU5
ZGQ2NTZjZS4uOWY1NDk2ZjQ0ZTIwY2U3NzIwNjJiODM1MTFhM2NiZTFkNTUzNTJiYiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5
IEBACiAyMDE0LTAzLTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K
IAorICAgICAgICBbR1RLXSBHaXZlIHRoZSBXZWJLaXQgR09iamVjdCBET00gYmluZGluZ3MgQVBJ
IGJyZWFrIGRldGVjdGlvbiBpdCdzIG93biBidWlsZGJvdCBidWJibGUKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYzNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1bkd0a1dlYktpdEdP
YmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVzdHMpOiBBZGRlZCB0aGlzIHRlc3QgcnVubmVyLgor
ICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cy5jb21t
YW5kQ29tcGxldGUpOiBSdW4gdGhlIGJyZWFrYWdlIHRlc3QgY29tbWFuZCBhbmQgc2NhbiB0aGUg
b3V0cHV0LgorICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtU
ZXN0cy5ldmFsdWF0ZUNvbW1hbmQpOiBSZXR1cm4gZmFpbHVyZSBpZiB0aGVyZSBpcyBtaXNzaW5n
IEFQSSAoYW4gQVBJIGJyZWFrKS4KKyAgICAgICAgTmV3IEFQSSB0eXBpY2FsbHkganVzdCByZXF1
aXJlcyBhIHJlYmFzZWxpbmUgYW5kIGlzbid0IG5lY2Vzc2FyaWx5IGEgZmFpdWxyZS4KKyAgICAg
ICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKTogQWRkIHRoZSB0ZXN0IGZvciBHVEsrLgorCisyMDE0
LTAzLTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAg
ICBbR1RLXVtDTWFrZV0gR2VuZXJhdGUgZG9jdW1lbnRhdGlvbiBmb3IgdGhlIERPTSBiaW5kaW5n
cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjEx
CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct
Y29uZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu
b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDk5NTVhNDYwOGVlZjljOWRiOWIzZjFlMmY0Njg3
YTEwOGQ3ZDI0NmMuLjRlZGI0OWQxZDY4NjYzOWE5MzhjMmI4ZjZkYmFhZGU0M2E4ZjFjODYgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln
L21hc3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y
Zy1jb25maWcvbWFzdGVyLmNmZwpAQCAtNjM1LDYgKzYzNSwzMyBAQCBjbGFzcyBSdW5HdGtBUElU
ZXN0cyhzaGVsbC5UZXN0KToKIAogICAgICAgICByZXR1cm4gW3NlbGYubmFtZV0KIAorY2xhc3Mg
UnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cyhzaGVsbC5UZXN0KToK
KyAgICBuYW1lID0gIldlYktpdCBHT2JqZWN0IERPTSBiaW5kaW5ncyBBUEkgYnJlYWsgdGVzdHMi
CisgICAgZGVzY3JpcHRpb24gPSBbIldlYktpdCBHT2JqZWN0IERPTSBiaW5kaW5ncyBBUEkgYnJl
YWsgdGVzdHMgcnVubmluZyJdCisgICAgZGVzY3JpcHRpb25Eb25lID0gWyJXZWJLaXQgR09iamVj
dCBET00gYmluZGluZ3MgQVBJIGJyZWFrIHRlc3RzIl0KKyAgICBjb21tYW5kID0gWyIuL1Rvb2xz
L2d0ay9jaGVjay1mb3Itd2Via2l0ZG9tLWFwaS1icmVha3MiXQorCisgICAgZGVmIGNvbW1hbmRD
b21wbGV0ZShzZWxmLCBjbWQpOgorICAgICAgICBzaGVsbC5UZXN0LmNvbW1hbmRDb21wbGV0ZShz
ZWxmLCBjbWQpCisKKyAgICAgICAgbG9nVGV4dCA9IGNtZC5sb2dzWydzdGRpbyddLmdldFRleHQo
KQorCisgICAgICAgIHNlbGYubWlzc2luZ0FQSSA9IGJvb2wocmUuZmluZGFsbCgiTWlzc2luZyBB
UEkiLCBsb2dUZXh0KSkKKyAgICAgICAgc2VsZi5uZXdBUEkgPSBib29sKHJlLmZpbmRhbGwoIk5l
dyBBUEkiLCBsb2dUZXh0KSkKKworICAgICAgICBsaW5lID0gIiIKKyAgICAgICAgaWYgc2VsZi5u
ZXdBUEk6CisgICAgICAgICAgICBsaW5lICs9ICJGb3VuZCBuZXcgQVBJLiIKKyAgICAgICAgaWYg
c2VsZi5taXNzaW5nQVBJOgorICAgICAgICAgICAgbGluZSArPSAiRm91bmQgbWlzc2luZyBBUEku
IgorICAgICAgICBpZiBsaW5lOgorICAgICAgICAgICAgc2VsZi5zdGF0dXNMaW5lID0gWyBsaW5l
IF0KKworICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAgICAgICAgaWYgc2Vs
Zi5taXNzaW5nQVBJOgorICAgICAgICAgICAgcmV0dXJuIEZBSUxVUkUKKyAgICAgICAgcmV0dXJu
IFNVQ0NFU1MKKwogY2xhc3MgUnVuV2ViS2l0TGVha1Rlc3RzKFJ1bldlYktpdFRlc3RzKToKICAg
ICB3YXJuT25XYXJuaW5ncyA9IFRydWUKICAgICBkZWYgc3RhcnQoc2VsZik6CkBAIC03OTcsNiAr
ODI0LDcgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICAgICBzZWxmLmFk
ZFN0ZXAoUnVuRWZsQVBJVGVzdHMpCiAgICAgICAgIGlmIHBsYXRmb3JtID09ICJndGsiOgogICAg
ICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkd0a0FQSVRlc3RzKCkpCisgICAgICAgICAgICBzZWxm
LmFkZFN0ZXAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cygpKQog
CiBjbGFzcyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgIENvbXBpbGVDbGFzcyA9
IENvbXBpbGVXZWJLaXQK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>225786</attachid>
            <date>2014-03-04 10:01:58 -0800</date>
            <delta_ts>2014-03-04 11:36:45 -0800</delta_ts>
            <desc>Return a warning when there is new API</desc>
            <filename>bug-129637-20140304100153.patch</filename>
            <type>text/plain</type>
            <size>3033</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWMxZjZkNGRiNmQ4YzVhZjc4MmNhMmFhZjcyMTcyOWU5
ZGQ2NTZjZS4uOWY1NDk2ZjQ0ZTIwY2U3NzIwNjJiODM1MTFhM2NiZTFkNTUzNTJiYiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5
IEBACiAyMDE0LTAzLTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K
IAorICAgICAgICBbR1RLXSBHaXZlIHRoZSBXZWJLaXQgR09iamVjdCBET00gYmluZGluZ3MgQVBJ
IGJyZWFrIGRldGVjdGlvbiBpdCdzIG93biBidWlsZGJvdCBidWJibGUKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYzNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1bkd0a1dlYktpdEdP
YmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVzdHMpOiBBZGRlZCB0aGlzIHRlc3QgcnVubmVyLgor
ICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cy5jb21t
YW5kQ29tcGxldGUpOiBSdW4gdGhlIGJyZWFrYWdlIHRlc3QgY29tbWFuZCBhbmQgc2NhbiB0aGUg
b3V0cHV0LgorICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtU
ZXN0cy5ldmFsdWF0ZUNvbW1hbmQpOiBSZXR1cm4gZmFpbHVyZSBpZiB0aGVyZSBpcyBtaXNzaW5n
IEFQSSAoYW4gQVBJIGJyZWFrKS4KKyAgICAgICAgTmV3IEFQSSB0eXBpY2FsbHkganVzdCByZXF1
aXJlcyBhIHJlYmFzZWxpbmUgYW5kIGlzbid0IG5lY2Vzc2FyaWx5IGEgZmFpdWxyZS4KKyAgICAg
ICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKTogQWRkIHRoZSB0ZXN0IGZvciBHVEsrLgorCisyMDE0
LTAzLTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAg
ICBbR1RLXVtDTWFrZV0gR2VuZXJhdGUgZG9jdW1lbnRhdGlvbiBmb3IgdGhlIERPTSBiaW5kaW5n
cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjEx
CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct
Y29uZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu
b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDk5NTVhNDYwOGVlZjljOWRiOWIzZjFlMmY0Njg3
YTEwOGQ3ZDI0NmMuLjMzMDU5ZWRmNDBmYTI5YmMxZTJlNjNkNDMyMThiOTE1ZGJmMjMwYjkgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln
L21hc3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y
Zy1jb25maWcvbWFzdGVyLmNmZwpAQCAtNjM1LDYgKzYzNSwzNSBAQCBjbGFzcyBSdW5HdGtBUElU
ZXN0cyhzaGVsbC5UZXN0KToKIAogICAgICAgICByZXR1cm4gW3NlbGYubmFtZV0KIAorY2xhc3Mg
UnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cyhzaGVsbC5UZXN0KToK
KyAgICBuYW1lID0gIldlYktpdCBHT2JqZWN0IERPTSBiaW5kaW5ncyBBUEkgYnJlYWsgdGVzdHMi
CisgICAgZGVzY3JpcHRpb24gPSBbIldlYktpdCBHT2JqZWN0IERPTSBiaW5kaW5ncyBBUEkgYnJl
YWsgdGVzdHMgcnVubmluZyJdCisgICAgZGVzY3JpcHRpb25Eb25lID0gWyJXZWJLaXQgR09iamVj
dCBET00gYmluZGluZ3MgQVBJIGJyZWFrIHRlc3RzIl0KKyAgICBjb21tYW5kID0gWyIuL1Rvb2xz
L2d0ay9jaGVjay1mb3Itd2Via2l0ZG9tLWFwaS1icmVha3MiXQorCisgICAgZGVmIGNvbW1hbmRD
b21wbGV0ZShzZWxmLCBjbWQpOgorICAgICAgICBzaGVsbC5UZXN0LmNvbW1hbmRDb21wbGV0ZShz
ZWxmLCBjbWQpCisKKyAgICAgICAgbG9nVGV4dCA9IGNtZC5sb2dzWydzdGRpbyddLmdldFRleHQo
KQorCisgICAgICAgIHNlbGYubWlzc2luZ0FQSSA9IGJvb2wocmUuZmluZGFsbCgiTWlzc2luZyBB
UEkiLCBsb2dUZXh0KSkKKyAgICAgICAgc2VsZi5uZXdBUEkgPSBib29sKHJlLmZpbmRhbGwoIk5l
dyBBUEkiLCBsb2dUZXh0KSkKKworICAgICAgICBsaW5lID0gIiIKKyAgICAgICAgaWYgc2VsZi5u
ZXdBUEk6CisgICAgICAgICAgICBsaW5lICs9ICJGb3VuZCBuZXcgQVBJLiIKKyAgICAgICAgaWYg
c2VsZi5taXNzaW5nQVBJOgorICAgICAgICAgICAgbGluZSArPSAiRm91bmQgbWlzc2luZyBBUEku
IgorICAgICAgICBpZiBsaW5lOgorICAgICAgICAgICAgc2VsZi5zdGF0dXNMaW5lID0gWyBsaW5l
IF0KKworICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAgICAgICAgaWYgc2Vs
Zi5taXNzaW5nQVBJOgorICAgICAgICAgICAgcmV0dXJuIEZBSUxVUkUKKyAgICAgICAgaWYgc2Vs
Zi5uZXdBUEk6CisgICAgICAgICAgICByZXR1cm4gV0FSTklOR1MKKyAgICAgICAgcmV0dXJuIFNV
Q0NFU1MKKwogY2xhc3MgUnVuV2ViS2l0TGVha1Rlc3RzKFJ1bldlYktpdFRlc3RzKToKICAgICB3
YXJuT25XYXJuaW5ncyA9IFRydWUKICAgICBkZWYgc3RhcnQoc2VsZik6CkBAIC03OTcsNiArODI2
LDcgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICAgICBzZWxmLmFkZFN0
ZXAoUnVuRWZsQVBJVGVzdHMpCiAgICAgICAgIGlmIHBsYXRmb3JtID09ICJndGsiOgogICAgICAg
ICAgICAgc2VsZi5hZGRTdGVwKFJ1bkd0a0FQSVRlc3RzKCkpCisgICAgICAgICAgICBzZWxmLmFk
ZFN0ZXAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cygpKQogCiBj
bGFzcyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgIENvbXBpbGVDbGFzcyA9IENv
bXBpbGVXZWJLaXQK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>225798</attachid>
            <date>2014-03-04 11:36:47 -0800</date>
            <delta_ts>2014-03-05 07:42:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-129637-20140304113647.patch</filename>
            <type>text/plain</type>
            <size>6334</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWMxZjZkNGRiNmQ4YzVhZjc4MmNhMmFhZjcyMTcyOWU5
ZGQ2NTZjZS4uMjZmODc1ZGJkNjJmYzIzNDk3ODBkOWI4NTU1Y2NjMGNlZDJlZTg5ZCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw
IEBACiAyMDE0LTAzLTAzICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K
IAorICAgICAgICBbR1RLXSBHaXZlIHRoZSBXZWJLaXQgR09iamVjdCBET00gYmluZGluZ3MgQVBJ
IGJyZWFrIGRldGVjdGlvbiBpdCdzIG93biBidWlsZGJvdCBidWJibGUKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYzNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1bkd0a1dlYktpdEdP
YmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVzdHMpOiBBZGRlZCB0aGlzIHRlc3QgcnVubmVyLgor
ICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtUZXN0cy5jb21t
YW5kQ29tcGxldGUpOiBSdW4gdGhlIGJyZWFrYWdlIHRlc3QgY29tbWFuZCBhbmQgc2NhbiB0aGUg
b3V0cHV0LgorICAgICAgICAoUnVuR3RrV2ViS2l0R09iamVjdERPTUJpbmRpbmdzQVBJQnJlYWtU
ZXN0cy5ldmFsdWF0ZUNvbW1hbmQpOiBSZXR1cm4gZmFpbHVyZSBpZiB0aGVyZSBpcyBtaXNzaW5n
IEFQSSAoYW4gQVBJIGJyZWFrKS4KKyAgICAgICAgTmV3IEFQSSB0eXBpY2FsbHkganVzdCByZXF1
aXJlcyBhIHJlYmFzZWxpbmUgYW5kIGlzbid0IG5lY2Vzc2FyaWx5IGEgZmFpdWxyZS4KKyAgICAg
ICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKTogQWRkIHRoZSB0ZXN0IGZvciBHVEsrLgorICAgICAg
ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191
bml0dGVzdC5weTogQWRkIGEgdW5pdCB0ZXN0IGZvciB0aGUgbmV3IGJ1YmJsZS4KKworMjAxNC0w
My0wMyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAgICAg
W0dUS11bQ01ha2VdIEdlbmVyYXRlIGRvY3VtZW50YXRpb24gZm9yIHRoZSBET00gYmluZGluZ3MK
ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjIxMQog
CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv
bmZpZy9tYXN0ZXIuY2ZnIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y
Zy1jb25maWcvbWFzdGVyLmNmZwppbmRleCA5OTU1YTQ2MDhlZWY5YzlkYjliM2YxZTJmNDY4N2Ex
MDhkN2QyNDZjLi4zMzA1OWVkZjQwZmEyOWJjMWUyZTYzZDQzMjE4YjkxNWRiZjIzMGI5IDEwMDY0
NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9t
YXN0ZXIuY2ZnCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct
Y29uZmlnL21hc3Rlci5jZmcKQEAgLTYzNSw2ICs2MzUsMzUgQEAgY2xhc3MgUnVuR3RrQVBJVGVz
dHMoc2hlbGwuVGVzdCk6CiAKICAgICAgICAgcmV0dXJuIFtzZWxmLm5hbWVdCiAKK2NsYXNzIFJ1
bkd0a1dlYktpdEdPYmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVzdHMoc2hlbGwuVGVzdCk6Cisg
ICAgbmFtZSA9ICJXZWJLaXQgR09iamVjdCBET00gYmluZGluZ3MgQVBJIGJyZWFrIHRlc3RzIgor
ICAgIGRlc2NyaXB0aW9uID0gWyJXZWJLaXQgR09iamVjdCBET00gYmluZGluZ3MgQVBJIGJyZWFr
IHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsiV2ViS2l0IEdPYmplY3Qg
RE9NIGJpbmRpbmdzIEFQSSBicmVhayB0ZXN0cyJdCisgICAgY29tbWFuZCA9IFsiLi9Ub29scy9n
dGsvY2hlY2stZm9yLXdlYmtpdGRvbS1hcGktYnJlYWtzIl0KKworICAgIGRlZiBjb21tYW5kQ29t
cGxldGUoc2VsZiwgY21kKToKKyAgICAgICAgc2hlbGwuVGVzdC5jb21tYW5kQ29tcGxldGUoc2Vs
ZiwgY21kKQorCisgICAgICAgIGxvZ1RleHQgPSBjbWQubG9nc1snc3RkaW8nXS5nZXRUZXh0KCkK
KworICAgICAgICBzZWxmLm1pc3NpbmdBUEkgPSBib29sKHJlLmZpbmRhbGwoIk1pc3NpbmcgQVBJ
IiwgbG9nVGV4dCkpCisgICAgICAgIHNlbGYubmV3QVBJID0gYm9vbChyZS5maW5kYWxsKCJOZXcg
QVBJIiwgbG9nVGV4dCkpCisKKyAgICAgICAgbGluZSA9ICIiCisgICAgICAgIGlmIHNlbGYubmV3
QVBJOgorICAgICAgICAgICAgbGluZSArPSAiRm91bmQgbmV3IEFQSS4iCisgICAgICAgIGlmIHNl
bGYubWlzc2luZ0FQSToKKyAgICAgICAgICAgIGxpbmUgKz0gIkZvdW5kIG1pc3NpbmcgQVBJLiIK
KyAgICAgICAgaWYgbGluZToKKyAgICAgICAgICAgIHNlbGYuc3RhdHVzTGluZSA9IFsgbGluZSBd
CisKKyAgICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6CisgICAgICAgIGlmIHNlbGYu
bWlzc2luZ0FQSToKKyAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCisgICAgICAgIGlmIHNlbGYu
bmV3QVBJOgorICAgICAgICAgICAgcmV0dXJuIFdBUk5JTkdTCisgICAgICAgIHJldHVybiBTVUND
RVNTCisKIGNsYXNzIFJ1bldlYktpdExlYWtUZXN0cyhSdW5XZWJLaXRUZXN0cyk6CiAgICAgd2Fy
bk9uV2FybmluZ3MgPSBUcnVlCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgpAQCAtNzk3LDYgKzgyNiw3
IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVw
KFJ1bkVmbEFQSVRlc3RzKQogICAgICAgICBpZiBwbGF0Zm9ybSA9PSAiZ3RrIjoKICAgICAgICAg
ICAgIHNlbGYuYWRkU3RlcChSdW5HdGtBUElUZXN0cygpKQorICAgICAgICAgICAgc2VsZi5hZGRT
dGVwKFJ1bkd0a1dlYktpdEdPYmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVzdHMoKSkKIAogY2xh
c3MgQnVpbGRBbmRUZXN0RmFjdG9yeShGYWN0b3J5KToKICAgICBDb21waWxlQ2xhc3MgPSBDb21w
aWxlV2ViS2l0CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr
aXQub3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkgYi9Ub29scy9CdWlsZFNsYXZlU3Vw
cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkKaW5kZXgg
ZjQ0MjYzZDNkNDg5ZWQxOGJjMDgxN2RkYTI0MWI5ZGU4M2MwMWVkNi4uNTFiMWU4MmZkZDMwZWJk
NDcyNTgxMzExY2VjNDc2ZDVhNzNhOWZkYiAxMDA3NTUKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1
cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CisrKyBi
L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNm
Z191bml0dGVzdC5weQpAQCAtMzgxLDYgKzM4MSw1MSBAQCBjbGFzcyBCdWlsZFN0ZXBzQ29uc3Ry
dWN0b3JUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICAgICBzZWxmLmZhaWwo
IkVycm9yIGR1cmluZyBpbnN0YW50aWF0aW9uICVzIGJ1aWxkc3RlcCBmb3IgJXMgYnVpbGRlcjog
JXNcbiIgJSAoYnVpbGRTdGVwTmFtZSwgYnVpbGRlck5hbWUsIGUpKQogICAgICAgICByZXR1cm4g
ZG9UZXN0CiAKK2NsYXNzIFJ1bkd0a1dlYktpdEdPYmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVz
dHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgYXNzZXJ0UmVzdWx0cyhzZWxmLCBl
eHBlY3RlZF9taXNzaW5nLCBleHBlY3RlZF9uZXcsIHN0ZGlvKToKKyAgICAgICAgZXhwZWN0ZWRf
dGV4dCA9ICIiCisgICAgICAgIGV4cGVjdGVkX3Jlc3VsdHMgPSBTVUNDRVNTCisgICAgICAgIGlm
IGV4cGVjdGVkX25ldzoKKyAgICAgICAgICAgIGV4cGVjdGVkX3Jlc3VsdHMgPSBXQVJOSU5HUwor
ICAgICAgICBpZiBleHBlY3RlZF9taXNzaW5nOgorICAgICAgICAgICAgZXhwZWN0ZWRfcmVzdWx0
cyA9IEZBSUxVUkUKKworICAgICAgICBjbWQgPSBTdHViUmVtb3RlQ29tbWFuZCgwLCBzdGRpbykK
KyAgICAgICAgc3RlcCA9IFJ1bkd0a1dlYktpdEdPYmplY3RET01CaW5kaW5nc0FQSUJyZWFrVGVz
dHMoKQorICAgICAgICBzdGVwLmNvbW1hbmRDb21wbGV0ZShjbWQpCisKKyAgICAgICAgYWN0dWFs
X3Jlc3VsdHMgPSBzdGVwLmV2YWx1YXRlQ29tbWFuZChjbWQpCisgICAgICAgIHNlbGYuYXNzZXJ0
RXF1YWwoZXhwZWN0ZWRfcmVzdWx0cywgYWN0dWFsX3Jlc3VsdHMpCisgICAgICAgIHNlbGYuYXNz
ZXJ0RXF1YWwoZXhwZWN0ZWRfbWlzc2luZywgc3RlcC5taXNzaW5nQVBJKQorICAgICAgICBzZWxm
LmFzc2VydEVxdWFsKGV4cGVjdGVkX25ldywgc3RlcC5uZXdBUEkpCisKKyAgICBkZWYgdGVzdF9t
aXNzaW5nX2FuZF9uZXdfYXBpKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoZXhw
ZWN0ZWRfbWlzc2luZz1UcnVlLCBleHBlY3RlZF9uZXc9VHJ1ZSwgc3RkaW89IiIiTWlzc2luZyBB
UEkgKEFQSSBicmVhayEpIGRldGVjdGVkIGluIEdPYmplY3QgRE9NIGJpbmRpbmdzCisgICAgZ2Jv
b2xlYW4gd2Via2l0X2RvbV9odG1sX2lucHV0X2VsZW1lbnRfZ2V0X3dlYmtpdGRpcmVjdG9yeShX
ZWJLaXRET01IVE1MSW5wdXRFbGVtZW50KikKKyAgICBnY2hhciogd2Via2l0X2RvbV90ZXh0X3Ry
YWNrX2N1ZV9nZXRfdGV4dChXZWJLaXRET01UZXh0VHJhY2tDdWUqKQorCitOZXcgQVBJIGRldGVj
dGVkIGluIEdPYmplY3QgRE9NIGJpbmRpbmdzCisgICAgdm9pZCB3ZWJraXRfZG9tX2h0bWxfaW5w
dXRfZWxlbWVudF9zZXRfY2FwdHVyZShXZWJLaXRET01IVE1MSW5wdXRFbGVtZW50KiwgZ2Jvb2xl
YW4pCisgICAgZ2Jvb2xlYW4gd2Via2l0X2RvbV9odG1sX2lucHV0X2VsZW1lbnRfZ2V0X2NhcHR1
cmUoV2ViS2l0RE9NSFRNTElucHV0RWxlbWVudCopCisgICAgdm9pZCB3ZWJraXRfZG9tX3RleHRf
dHJhY2tfYWRkX2N1ZShXZWJLaXRET01UZXh0VHJhY2sqLCBXZWJLaXRET01UZXh0VHJhY2tDdWUq
LCBHRXJyb3IqKikKKyAgICBnY2hhciogd2Via2l0X2RvbV9kb2N1bWVudF9nZXRfb3JpZ2luKFdl
YktpdERPTURvY3VtZW50KikiIiIpCisKKyAgICBkZWYgdGVzdF9taXNzaW5nX2FwaShzZWxmKToK
KyAgICAgICAgc2VsZi5hc3NlcnRSZXN1bHRzKGV4cGVjdGVkX21pc3Npbmc9VHJ1ZSwgZXhwZWN0
ZWRfbmV3PUZhbHNlLCBzdGRpbz0iIiJNaXNzaW5nIEFQSSAoQVBJIGJyZWFrISkgZGV0ZWN0ZWQg
aW4gR09iamVjdCBET00gYmluZGluZ3MKKyAgICBnYm9vbGVhbiB3ZWJraXRfZG9tX2h0bWxfaW5w
dXRfZWxlbWVudF9nZXRfd2Via2l0ZGlyZWN0b3J5KFdlYktpdERPTUhUTUxJbnB1dEVsZW1lbnQq
KQorICAgIGdjaGFyKiB3ZWJraXRfZG9tX3RleHRfdHJhY2tfY3VlX2dldF90ZXh0KFdlYktpdERP
TVRleHRUcmFja0N1ZSopIiIiKQorCisgICAgZGVmIHRlc3RfbmV3X2FwaShzZWxmKToKKyAgICAg
ICAgc2VsZi5hc3NlcnRSZXN1bHRzKGV4cGVjdGVkX21pc3Npbmc9RmFsc2UsIGV4cGVjdGVkX25l
dz1UcnVlLCBzdGRpbz0iIiJOZXcgQVBJIGRldGVjdGVkIGluIEdPYmplY3QgRE9NIGJpbmRpbmdz
CisgICAgdm9pZCB3ZWJraXRfZG9tX2h0bWxfaW5wdXRfZWxlbWVudF9zZXRfY2FwdHVyZShXZWJL
aXRET01IVE1MSW5wdXRFbGVtZW50KiwgZ2Jvb2xlYW4pCisgICAgZ2Jvb2xlYW4gd2Via2l0X2Rv
bV9odG1sX2lucHV0X2VsZW1lbnRfZ2V0X2NhcHR1cmUoV2ViS2l0RE9NSFRNTElucHV0RWxlbWVu
dCopCisgICAgdm9pZCB3ZWJraXRfZG9tX3RleHRfdHJhY2tfYWRkX2N1ZShXZWJLaXRET01UZXh0
VHJhY2sqLCBXZWJLaXRET01UZXh0VHJhY2tDdWUqLCBHRXJyb3IqKikKKyAgICBnY2hhciogd2Vi
a2l0X2RvbV9kb2N1bWVudF9nZXRfb3JpZ2luKFdlYktpdERPTURvY3VtZW50KikiIiIpCisKKyAg
ICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoZXhw
ZWN0ZWRfbWlzc2luZz1GYWxzZSwgZXhwZWN0ZWRfbmV3PUZhbHNlLCBzdGRpbz0iIikKKworCiAj
IEZJWE1FOiBXZSBzaG91bGQgcnVuIHRoaXMgZmlsZSBhcyBwYXJ0IG9mIHRlc3Qtd2Via2l0cHku
CiAjIFVuZm9ydHVuYXRlbHkgdGVzdC13ZWJraXRweSBjdXJyZW50bHkgcmVxdWlyZXMgdGhhdCB1
bml0dGVzdHMKICMgYmUgbG9jYXRlZCBpbiBhIGRpcmVjdG9yeSB3aXRoIGEgdmFsaWQgbW9kdWxl
IG5hbWUuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>