129623 2014-03-03 14:50:15 -0800 Web Inspector: Gradient.js:120:22: JS ERROR: TypeError: undefined is not an object (evaluating 'stop.offset') 2014-04-24 01:44:13 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 986499 0 timothy 2014-03-03 14:50:15 -0800 Seeing Gradient.js:120:22: JS ERROR: TypeError: undefined is not an object (evaluating 'stop.offset') while poking around some internal scripts. 986501 1 webkit-bug-importer 2014-03-03 14:50:53 -0800 <rdar://problem/16215772> 986505 2 timothy 2014-03-03 15:00:25 -0800 The content seems to be: var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);"; And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]]. 986507 3 webkit-bug-importer 2014-03-03 15:01:43 -0800 <rdar://problem/16215950> 986514 4 timothy 2014-03-03 15:06:18 -0800 Found in modernizr-2.0.6.min.js 986516 5 225694 timothy 2014-03-03 15:12:44 -0800 Created attachment 225694 Patch 986521 6 joepeck 2014-03-03 15:20:30 -0800 (In reply to comment #2) > The content seems to be: > > var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);"; > > And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]]. This strikes me as a little weird. The input was "left top", "right bottom". Are we sure we are doing the right thing for these kinds of inputs? 986522 7 225694 joepeck 2014-03-03 15:20:45 -0800 Comment on attachment 225694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225694&action=review > Source/WebInspectorUI/UserInterface/Models/Gradient.js:192 > + // We don't support any of the legacy linerar gradient formats. linerar 986525 8 225698 timothy 2014-03-03 15:24:17 -0800 Created attachment 225698 Patch 986529 9 timothy 2014-03-03 15:26:17 -0800 (In reply to comment #6) > (In reply to comment #2) > > The content seems to be: > > > > var a = "background-image:", b = "gradient(linear,left top,right bottom,from(#9f9),to(white));", c = "linear-gradient(left top,#9f9, white);"; > > > > And the components passed to stopsWithComponents are [["left","top"],["#9f9"],["white"]]. > > This strikes me as a little weird. The input was "left top", "right bottom". Are we sure we are doing the right thing for these kinds of inputs? Yeah, the "left" and "top" get sorted and recombined for a switch that looks for "left top". That allows ["top", "left"] to work without the need for case "top left" and all the other permutations. 986546 10 225698 commit-queue 2014-03-03 16:02:58 -0800 Comment on attachment 225698 Patch Clearing flags on attachment: 225698 Committed r165017: <http://trac.webkit.org/changeset/165017> 986547 11 commit-queue 2014-03-03 16:03:01 -0800 All reviewed patches have been landed. Closing bug. 986703 12 graouts 2014-03-04 00:23:39 -0800 Thanks for cleaning up after me Tim! 1003585 13 graouts 2014-04-24 01:44:13 -0700 This fix caused https://bugs.webkit.org/show_bug.cgi?id=132083. 225694 2014-03-03 15:12:44 -0800 2014-03-03 15:24:13 -0800 Patch bug-129623-20140303151244.patch text/plain 2141 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm Y2Y2ZDg1OWQ5OTEwMjIwNDhmMmFjMzRkZmJmOGE4NGFmNzVjYzk4Li43YWY1NjJkMTAxMDkxMjRl ZmY3ZTExNGJmYzg1NjNiZTcwMjczM2U3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNC0wMy0wMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgRG9uJ3QgdHJ5IHRvIHBhcnNlIGxlZ2FjeSBDU1MgZ3JhZGllbnRzIC0t IHdlIGRvbid0IHN1cHBvcnQgdGhlbS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9HcmFkaWVudC5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5HcmFkaWVudC5zdG9wc1dpdGhDb21wb25lbnRzKTogRml4IGEg cG9zc2libGUgZXhjZXB0aW9uIG9uIG1hbGZvcm1lZCBzdG9wcy4KKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5MaW5lYXJHcmFkaWVudC5saW5lYXJHcmFkaWVudFdpdGhDb21wb25lbnRzKTogUmV0dXJu IGVhcmx5IGZvciBsZWdhY3kgZ3JhZGllbnRzLgorCisyMDE0LTAzLTAzICBUaW1vdGh5IEhhdGNo ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgYW4gaW5ub2N1b3VzIGVy cm9yIG1lc3NhZ2UgYW5kIHN1cHBvcnQgZGVmYXVsdCB2aWV3cyBmb3IgUmVzb3VyY2UgYW5kIERl YnVnZ2VyIHNpZGViYXJzLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjk2MjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9HcmFkaWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9HcmFkaWVudC5qcwppbmRleCAxMTZkNjYzNjk4OWRiMTZkNjExYTdl MzZlNGIyMDYxOTI4OTNlMjk5Li40Mjc5YWYzZDIwMzllYzc0NTQyMDQ0NWEwZDg5MzU5ODBjN2E3 NmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvR3JhZGllbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0dyYWRpZW50LmpzCkBAIC0xMTcsNiArMTE3LDEyIEBAIFdlYkluc3BlY3Rvci5HcmFk aWVudCA9IHsKIAogICAgICAgICBmb3IgKHZhciBpID0gMCwgY291bnQgPSBzdG9wcy5sZW5ndGg7 IGkgPCBjb3VudDsgKytpKSB7CiAgICAgICAgICAgICB2YXIgc3RvcCA9IHN0b3BzW2ldOworCisg ICAgICAgICAgICAvLyBJZiBvbmUgb2YgdGhlIHN0b3BzIGZhaWxlZCB0byBwYXJzZSwgdGhlbiB0 aGlzIGlzIG5vdCBhIHZhbGlkCisgICAgICAgICAgICAvLyBzZXQgb2YgY29tcG9uZW50cyBmb3Ig YSBncmFkaWVudC4gU28gdGhlIHdob2xlIHRoaW5nIGlzIGludmFsaWQuCisgICAgICAgICAgICBp ZiAoIXN0b3ApCisgICAgICAgICAgICAgICAgcmV0dXJuIG51bGw7CisKICAgICAgICAgICAgIGlm ICghc3RvcC5vZmZzZXQpCiAgICAgICAgICAgICAgICAgc3RvcC5vZmZzZXQgPSBpIC8gKGNvdW50 IC0gMSk7CiAgICAgICAgIH0KQEAgLTE4Miw2ICsxODgsOSBAQCBXZWJJbnNwZWN0b3IuTGluZWFy R3JhZGllbnQubGluZWFyR3JhZGllbnRXaXRoQ29tcG9uZW50cyA9IGZ1bmN0aW9uKGNvbXBvbmVu dHMpCiAgICAgICAgICAgICByZXR1cm4gbnVsbDsKICAgICAgICAgfQogICAgICAgICBjb21wb25l bnRzLnNoaWZ0KCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gV2UgZG9uJ3Qgc3VwcG9ydCBh bnkgb2YgdGhlIGxlZ2FjeSBsaW5lcmFyIGdyYWRpZW50IGZvcm1hdHMuCisgICAgICAgIHJldHVy biBudWxsOwogICAgIH0KIAogICAgIHZhciBzdG9wcyA9IFdlYkluc3BlY3Rvci5HcmFkaWVudC5z dG9wc1dpdGhDb21wb25lbnRzKGNvbXBvbmVudHMpOwo= 225698 2014-03-03 15:24:17 -0800 2014-03-03 16:02:58 -0800 Patch bug-129623-20140303152416.patch text/plain 2141 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm Y2Y2ZDg1OWQ5OTEwMjIwNDhmMmFjMzRkZmJmOGE4NGFmNzVjYzk4Li45NzUwNzdhMGRlZmRmMzU5 MzU5OTNjYjM3MDYyY2UwZDJhOTc2MDFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNC0wMy0wMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgRG9uJ3QgdHJ5IHRvIHBhcnNlIGxlZ2FjeSBDU1MgZ3JhZGllbnRzIC0t IHdlIGRvbid0IHN1cHBvcnQgdGhlbS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBl Y29yYXJvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvR3JhZGllbnQuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuR3JhZGllbnQuc3RvcHNXaXRoQ29tcG9uZW50cyk6IEZpeCBh IHBvc3NpYmxlIGV4Y2VwdGlvbiBvbiBtYWxmb3JtZWQgc3RvcHMuCisgICAgICAgIChXZWJJbnNw ZWN0b3IuTGluZWFyR3JhZGllbnQubGluZWFyR3JhZGllbnRXaXRoQ29tcG9uZW50cyk6IFJldHVy biBlYXJseSBmb3IgbGVnYWN5IGdyYWRpZW50cy4KKworMjAxNC0wMy0wMyAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3ZlIGFuIGlubm9jdW91cyBl cnJvciBtZXNzYWdlIGFuZCBzdXBwb3J0IGRlZmF1bHQgdmlld3MgZm9yIFJlc291cmNlIGFuZCBE ZWJ1Z2dlciBzaWRlYmFycy4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI5NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvR3JhZGllbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvR3JhZGllbnQuanMKaW5kZXggMTE2ZDY2MzY5ODlkYjE2ZDYxMWE3 ZTM2ZTRiMjA2MTkyODkzZTI5OS4uYmVhYWNiYmE0NThkOGUyYjkxNjgwYWFjYTAzOTYwNDVjYmE2 MWVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL0dyYWRpZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9HcmFkaWVudC5qcwpAQCAtMTE3LDYgKzExNywxMiBAQCBXZWJJbnNwZWN0b3IuR3Jh ZGllbnQgPSB7CiAKICAgICAgICAgZm9yICh2YXIgaSA9IDAsIGNvdW50ID0gc3RvcHMubGVuZ3Ro OyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICAgICAgdmFyIHN0b3AgPSBzdG9wc1tpXTsKKwor ICAgICAgICAgICAgLy8gSWYgb25lIG9mIHRoZSBzdG9wcyBmYWlsZWQgdG8gcGFyc2UsIHRoZW4g dGhpcyBpcyBub3QgYSB2YWxpZAorICAgICAgICAgICAgLy8gc2V0IG9mIGNvbXBvbmVudHMgZm9y IGEgZ3JhZGllbnQuIFNvIHRoZSB3aG9sZSB0aGluZyBpcyBpbnZhbGlkLgorICAgICAgICAgICAg aWYgKCFzdG9wKQorICAgICAgICAgICAgICAgIHJldHVybiBudWxsOworCiAgICAgICAgICAgICBp ZiAoIXN0b3Aub2Zmc2V0KQogICAgICAgICAgICAgICAgIHN0b3Aub2Zmc2V0ID0gaSAvIChjb3Vu dCAtIDEpOwogICAgICAgICB9CkBAIC0xODIsNiArMTg4LDkgQEAgV2ViSW5zcGVjdG9yLkxpbmVh ckdyYWRpZW50LmxpbmVhckdyYWRpZW50V2l0aENvbXBvbmVudHMgPSBmdW5jdGlvbihjb21wb25l bnRzKQogICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgICAgIH0KICAgICAgICAgY29tcG9u ZW50cy5zaGlmdCgpOworICAgIH0gZWxzZSB7CisgICAgICAgIC8vIFdlIGRvbid0IHN1cHBvcnQg YW55IG9mIHRoZSBsZWdhY3kgbGluZWFyIGdyYWRpZW50IGZvcm1hdHMuCisgICAgICAgIHJldHVy biBudWxsOwogICAgIH0KIAogICAgIHZhciBzdG9wcyA9IFdlYkluc3BlY3Rvci5HcmFkaWVudC5z dG9wc1dpdGhDb21wb25lbnRzKGNvbXBvbmVudHMpOwo=