12962 2007-03-04 00:46:28 -0800 4XPath tests crash on lang() function 2007-03-05 11:26:56 -0800 1 1 1 Unclassified WebKit XML 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 12953 1 ap ap oldest_to_newest 20498 0 ap 2007-03-04 00:46:28 -0800 4XPath test suite causes a crash with lang(). 20499 1 13469 ap 2007-03-04 01:23:17 -0800 Created attachment 13469 proposed fix 20505 2 13469 zimmermann 2007-03-04 03:43:20 -0800 Comment on attachment 13469 proposed fix Patch looks good. r=me, if no other test breaks. (yay my first review :-)) 20549 3 ap 2007-03-04 21:47:31 -0800 Committed revision 19957. 13469 2007-03-04 01:23:17 -0800 2007-03-04 03:43:20 -0800 proposed fix 12962r1_patch.txt text/plain 2889 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTk1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDctMDMtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYyCisgICAgICAgIDRY UGF0aCB0ZXN0cyBjcmFzaCBvbiBsYW5nKCkgZnVuY3Rpb24KKworICAgICAgICBDb3ZlcmVkIGJ5 IDRYUGF0aCB0ZXN0cywgdG8gYmUgbGFuZGVkIGxhdGVyLgorCisgICAgICAgICogcGxhdGZvcm0v U3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdJbXBsOjpyZXZlcnNlRmlu ZCk6IERvIG5vdCBjcmFzaCB3aXRoIGVtcHR5IHN0cmluZ3MuCisgICAgICAgICogeG1sL1hQYXRo RnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhQYXRoOjpGdW5MYW5nOjpkb0V2YWx1 YXRlKTogRG8gbm90IGNyYXNoIHdoZW4gYW4gZWxlbWVudCBoYXMgbm8KKyAgICAgICAgYXR0cmli dXRlcy4gVXNlIGEgcHJvcGVyIG5hbWVzcGFjZSBmb3IgeG1sOmxhbmcgKG5vdCBzdXJlIHdoZXJl ICJ4bXMiIGNhbWUgZnJvbSkuCisgICAgICAgIFJld3JvdGUgdGhlIGFsZ29yaXRobSBmb3Igc3Vm Zml4IHJlbW92aW5nIHRvIG1hdGNoIHRoZSBzcGVjLgorCiAyMDA3LTAzLTAyICBLZXZpbiBNY0N1 bGxvdWdoICA8a21jY3VsbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdl b2ZmLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9TdHJpbmdJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL1N0cmluZ0ltcGwuY3BwCShyZXZpc2lvbiAxOTk1MikKKysrIFdl YkNvcmUvcGxhdGZvcm0vU3RyaW5nSW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3Nyw3ICs3 NzcsNyBAQCBpbnQgU3RyaW5nSW1wbDo6ZmluZChjb25zdCBTdHJpbmdJbXBsKiBzCiAKIGludCBT dHJpbmdJbXBsOjpyZXZlcnNlRmluZChjb25zdCBVQ2hhciBjLCBpbnQgaW5kZXgpIGNvbnN0CiB7 Ci0gICAgaWYgKGluZGV4ID49IChpbnQpbV9sZW5ndGgpCisgICAgaWYgKGluZGV4ID49IChpbnQp bV9sZW5ndGggfHwgbV9sZW5ndGggPT0gMCkKICAgICAgICAgcmV0dXJuIC0xOwogCiAgICAgaWYg KGluZGV4IDwgMCkKSW5kZXg6IFdlYkNvcmUveG1sL1hQYXRoRnVuY3Rpb25zLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3htbC9YUGF0aEZ1bmN0aW9ucy5jcHAJKHJldmlzaW9uIDE5OTUyKQor KysgV2ViQ29yZS94bWwvWFBhdGhGdW5jdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2 ICszMiw3IEBACiAKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIk5hbWVkQXR0ck1h cC5oIgorI2luY2x1ZGUgIlhNTE5hbWVzLmgiCiAjaW5jbHVkZSAiWFBhdGhWYWx1ZS5oIgogI2lu Y2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAKQEAgLTU5NiwxMCArNTk3LDEwIEBAIFZhbHVlIEZ1 bkxhbmc6OmRvRXZhbHVhdGUoKSBjb25zdAogCiAgICAgUmVmUHRyPE5vZGU+IGxhbmdOb2RlID0g MDsKICAgICBOb2RlKiBub2RlID0gZXZhbHVhdGlvbkNvbnRleHQoKS5ub2RlLmdldCgpOwotICAg IFN0cmluZyB4bXNuc1VSSSA9IG5vZGUtPmxvb2t1cE5hbWVzcGFjZVVSSSgieG1zIik7CiAgICAg d2hpbGUgKG5vZGUpIHsKICAgICAgICAgTmFtZWRBdHRyTWFwKiBhdHRycyA9IG5vZGUtPmF0dHJp YnV0ZXMoKTsKLSAgICAgICAgbGFuZ05vZGUgPSBhdHRycy0+Z2V0TmFtZWRJdGVtTlMoeG1zbnNV UkksICJsYW5nIik7CisgICAgICAgIGlmIChhdHRycykKKyAgICAgICAgICAgIGxhbmdOb2RlID0g YXR0cnMtPmdldE5hbWVkSXRlbU5TKFhNTE5hbWVzOjp4bWxOYW1lc3BhY2VVUkksICJsYW5nIik7 CiAgICAgICAgIGlmIChsYW5nTm9kZSkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBub2Rl ID0gbm9kZS0+cGFyZW50Tm9kZSgpOwpAQCAtNjA5LDEzICs2MTAsMTggQEAgVmFsdWUgRnVuTGFu Zzo6ZG9FdmFsdWF0ZSgpIGNvbnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIFN0cmlu ZyBsYW5nTm9kZVZhbHVlID0gbGFuZ05vZGUtPm5vZGVWYWx1ZSgpOworICAgIHdoaWxlICh0cnVl KSB7CisgICAgICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShsYW5nTm9kZVZhbHVlLCBsYW5nKSkK KyAgICAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgLy8gZXh0cmFjdCAnZW4nIG91dCBvZiAn ZW4tdXMnCi0gICAgaW50IGluZGV4ID0gbGFuZ05vZGVWYWx1ZS5maW5kKCctJyk7Ci0gICAgaWYg KGluZGV4ICE9IC0xKQorICAgICAgICAvLyBSZW1vdmUgc3VmZml4ZXMgb25lIGJ5IG9uZS4KKyAg ICAgICAgaW50IGluZGV4ID0gbGFuZ05vZGVWYWx1ZS5yZXZlcnNlRmluZCgnLScpOworICAgICAg ICBpZiAoaW5kZXggPT0gLTEpCisgICAgICAgICAgICBicmVhazsKICAgICAgICAgbGFuZ05vZGVW YWx1ZSA9IGxhbmdOb2RlVmFsdWUubGVmdChpbmRleCk7CisgICAgfQogCi0gICAgcmV0dXJuIGVx dWFsSWdub3JpbmdDYXNlKGxhbmdOb2RlVmFsdWUsIGxhbmcpOworICAgIHJldHVybiBmYWxzZTsK IH0KIAogYm9vbCBGdW5MYW5nOjppc0NvbnN0YW50KCkgY29uc3QK