129617 2014-03-03 12:13:59 -0800 Web Inspector: TypeError: null is not an object (evaluating 'document.body.classList') 2014-03-03 13:46:55 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 986440 0 joepeck 2014-03-03 12:13:59 -0800 Inspecting the inspector I see: [Error] TypeError: null is not an object (evaluating 'document.body.classList') _windowFocused (Main.js, line 783) (anonymous function) ([native code], line 0) Weird. 986442 1 webkit-bug-importer 2014-03-03 12:14:45 -0800 <rdar://problem/16213488> 986449 2 timothy 2014-03-03 12:40:36 -0800 Well we do add the _windowFocused listener before the DOMContentLoaded event. So if it fires early it will cause this. I guess we should delay adding the listener until DOMContentLoaded. 986453 3 225683 timothy 2014-03-03 12:45:39 -0800 Created attachment 225683 Patch 986481 4 225683 commit-queue 2014-03-03 13:46:53 -0800 Comment on attachment 225683 Patch Clearing flags on attachment: 225683 Committed r165007: <http://trac.webkit.org/changeset/165007> 986482 5 commit-queue 2014-03-03 13:46:55 -0800 All reviewed patches have been landed. Closing bug. 225683 2014-03-03 12:45:39 -0800 2014-03-03 13:46:53 -0800 Patch bug-129617-20140303124539.patch text/plain 3650 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh ZjJmZmUxZWI2OGQ1MWVkZDJhMjVkODY0OGI0ZTU2OTcxNmQzNWIwLi5hMjZkYmQzMWEyNTEwMDg5 ZTk2MDIxYTc4N2VhZjE2OTcyNGM5NzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0wMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgRml4IGFuIGV4Y2VwdGlvbiBjYXVzZWQgYnkgdHJ5aW5nIHRvIGFjY2Vz cyB0aGUgRE9NIGJlZm9yZSBpdCBpcyBsb2FkZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKTogTW92ZSBnbG9iYWwgZXZlbnQgbGlzdGVuZXJz IGZyb20gaGVyZS4uLgorICAgICAgICAoV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQpOiAuLi4g dG8gaGVyZS4KKwogMjAxNC0wMy0wMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKICAgICAgICAgTWFrZSBTdGFydCBUaW1lbGluZSBSZWNvcmRpbmcgaW4gdGhlIERldmVs b3AgbWVudSBzaG93IHRoZSBUaW1lbGluZSB2aWV3IGFnYWluLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDhlMmY0NzQ3ZjJiNDg1 OWE5MWU3MzdhYWZkMWQzYWJkZTQ1MWI3ZjYuLmMyNzA1NWQyYzg4NmJiMzdhNGMwNzgwYjRmNjIy ZWY0Mzg1YzVkYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMKQEAgLTEzMCwyMSArMTMwLDYgQEAgV2ViSW5zcGVjdG9yLmxvYWRlZCA9 IGZ1bmN0aW9uKCkKIAogICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRPTUNvbnRlbnRM b2FkZWQiLCB0aGlzLmNvbnRlbnRMb2FkZWQuYmluZCh0aGlzKSk7CiAKLSAgICBkb2N1bWVudC5h ZGRFdmVudExpc3RlbmVyKCJiZWZvcmVjb3B5IiwgdGhpcy5fYmVmb3JlY29weS5iaW5kKHRoaXMp KTsKLSAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJjb3B5IiwgdGhpcy5fY29weS5iaW5k KHRoaXMpKTsKLQotICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5f bW91c2VXYXNDbGlja2VkLmJpbmQodGhpcykpOwotICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVu ZXIoImRyYWdvdmVyIiwgdGhpcy5fZHJhZ092ZXIuYmluZCh0aGlzKSk7Ci0gICAgZG9jdW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigiZm9jdXMiLCBXZWJJbnNwZWN0b3IuX2ZvY3VzQ2hhbmdlZC5iaW5k KHRoaXMpLCB0cnVlKTsKLQotICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJmb2N1cyIsIHRo aXMuX3dpbmRvd0ZvY3VzZWQuYmluZCh0aGlzKSk7Ci0gICAgd2luZG93LmFkZEV2ZW50TGlzdGVu ZXIoImJsdXIiLCB0aGlzLl93aW5kb3dCbHVycmVkLmJpbmQodGhpcykpOwotICAgIHdpbmRvdy5h ZGRFdmVudExpc3RlbmVyKCJyZXNpemUiLCB0aGlzLl93aW5kb3dSZXNpemVkLmJpbmQodGhpcykp OwotICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgdGhpcy5fd2luZG93S2V5 RG93bi5iaW5kKHRoaXMpKTsKLSAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigia2V5dXAiLCB0 aGlzLl93aW5kb3dLZXlVcC5iaW5kKHRoaXMpKTsKLSAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5l cigibW91c2Vtb3ZlIiwgdGhpcy5fbW91c2VNb3ZlZC5iaW5kKHRoaXMpLCB0cnVlKTsKLSAgICB3 aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigicGFnZWhpZGUiLCB0aGlzLl9wYWdlSGlkZGVuLmJpbmQo dGhpcykpOwotCiAgICAgLy8gQ3JlYXRlIHNldHRpbmdzLgogICAgIHRoaXMuX2xhc3RJbnNwZWN0 b3JWaWV3U3RhdGVDb29raWVTZXR0aW5nID0gbmV3IFdlYkluc3BlY3Rvci5TZXR0aW5nKCJsYXN0 LWNvbnRlbnQtdmlldy1zdGF0ZS1jb29raWUiLCB7fSk7CiAKQEAgLTE4MSw2ICsxNjYsMjIgQEAg V2ViSW5zcGVjdG9yLmxvYWRlZCA9IGZ1bmN0aW9uKCkKIAogV2ViSW5zcGVjdG9yLmNvbnRlbnRM b2FkZWQgPSBmdW5jdGlvbigpCiB7CisgICAgLy8gUmVnaXN0ZXIgZm9yIGdsb2JhbCBldmVudHMu CisgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiYmVmb3JlY29weSIsIHRoaXMuX2JlZm9y ZWNvcHkuYmluZCh0aGlzKSk7CisgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY29weSIs IHRoaXMuX2NvcHkuYmluZCh0aGlzKSk7CisKKyAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIHRoaXMuX21vdXNlV2FzQ2xpY2tlZC5iaW5kKHRoaXMpKTsKKyAgICBkb2N1bWVu dC5hZGRFdmVudExpc3RlbmVyKCJkcmFnb3ZlciIsIHRoaXMuX2RyYWdPdmVyLmJpbmQodGhpcykp OworICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImZvY3VzIiwgV2ViSW5zcGVjdG9yLl9m b2N1c0NoYW5nZWQuYmluZCh0aGlzKSwgdHJ1ZSk7CisKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcigiZm9jdXMiLCB0aGlzLl93aW5kb3dGb2N1c2VkLmJpbmQodGhpcykpOworICAgIHdpbmRv dy5hZGRFdmVudExpc3RlbmVyKCJibHVyIiwgdGhpcy5fd2luZG93Qmx1cnJlZC5iaW5kKHRoaXMp KTsKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigicmVzaXplIiwgdGhpcy5fd2luZG93UmVz aXplZC5iaW5kKHRoaXMpKTsKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigia2V5ZG93biIs IHRoaXMuX3dpbmRvd0tleURvd24uYmluZCh0aGlzKSk7CisgICAgd2luZG93LmFkZEV2ZW50TGlz dGVuZXIoImtleXVwIiwgdGhpcy5fd2luZG93S2V5VXAuYmluZCh0aGlzKSk7CisgICAgd2luZG93 LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlbW92ZSIsIHRoaXMuX21vdXNlTW92ZWQuYmluZCh0aGlz KSwgdHJ1ZSk7CisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInBhZ2VoaWRlIiwgdGhpcy5f cGFnZUhpZGRlbi5iaW5kKHRoaXMpKTsKKwogICAgIC8vIENoZWNrIGZvciBhIG5pZ2h0bHkgYnVp bGQgYnkgbG9va2luZyBmb3IgYSBwbHVzIGluIHRoZSB2ZXJzaW9uIG51bWJlciBhbmQgYSBzbWFs bCBudW1iZXIgb2Ygc3R5bGVzaGVldHMgKGluZGljYXRpbmcgY29tYmluZWQgcmVzb3VyY2VzKS4K ICAgICB2YXIgdmVyc2lvbk1hdGNoID0gLyBBcHBsZVdlYktpdFwvKFteIF0rKS8uZXhlYyhuYXZp Z2F0b3IudXNlckFnZW50KTsKICAgICBpZiAodmVyc2lvbk1hdGNoICYmIHZlcnNpb25NYXRjaFsx XS5pbmRleE9mKCIrIikgIT09IC0xICYmIGRvY3VtZW50LnN0eWxlU2hlZXRzLmxlbmd0aCA8IDEw KQo=