12961 2007-03-04 00:33:36 -0800 shouldBe() should support NaN 2007-03-04 22:31:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 12953 1 ap ap zimmermann oldest_to_newest 20496 0 ap 2007-03-04 00:33:36 -0800 Currently, JS shouldBe() tests don't work with NaN results, because NaN != NaN. Patch forthcoming. 20497 1 13468 ap 2007-03-04 00:35:51 -0800 Created attachment 13468 proposed patch 20508 2 zimmermann 2007-03-04 03:53:54 -0800 Looks fine, though what is the "===" operator? (you didn't add it - just wondering though...) - else if (_av === _bv) + else if (_av === _bv || (typeof(_av) == "number" && typeof(_bv) == "number" && isNaN(_av) && isNaN(_bv))) Niko 20518 3 ddkilzer 2007-03-04 07:05:44 -0800 (In reply to comment #2) > Looks fine, though what is the "===" operator? (you didn't add it - just > wondering though...) It's the identity (strict equality) operator. There is also a "not identity" operator: !== http://www.webreference.com/js/tips/991205.html 20550 4 13468 darin 2007-03-04 21:56:00 -0800 Comment on attachment 13468 proposed patch r=me 20555 5 ap 2007-03-04 22:31:54 -0800 Committed revision 19959. 13468 2007-03-04 00:35:51 -0800 2007-03-04 21:56:00 -0800 proposed patch 12961r1_patch.txt text/plain 1212 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5OTUyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDMtMDQgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTYx CisgICAgICAgIHNob3VsZEJlKCkgc2hvdWxkIHN1cHBvcnQgTmFOCisKKyAgICAgICAgKiBmYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qczogTWFrZSBzaG91bGRCZSgpIHN1Y2NlZWQgaWYg Ym90aCBzaWRlcyBhcmUgTmFOIG51bWJlcnMuCisKIDIwMDctMDMtMDIgIEtldmluIE1jQ3VsbG91 Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYu CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcwko cmV2aXNpb24gMTk5NTIpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcwkod29ya2luZyBjb3B5KQpAQCAtNTAsNyArNTAsNyBAQCBmdW5jdGlvbiBzaG91bGRC ZShfYSwgX2IpCiAKICAgaWYgKGV4Y2VwdGlvbikKICAgICB0ZXN0RmFpbGVkKF9hICsgIiBzaG91 bGQgYmUgIiArIF9idiArICIuIFRocmV3IGV4Y2VwdGlvbiAiICsgZXhjZXB0aW9uKTsKLSAgZWxz ZSBpZiAoX2F2ID09PSBfYnYpCisgIGVsc2UgaWYgKF9hdiA9PT0gX2J2IHx8ICh0eXBlb2YoX2F2 KSA9PSAibnVtYmVyIiAmJiB0eXBlb2YoX2J2KSA9PSAibnVtYmVyIiAmJiBpc05hTihfYXYpICYm IGlzTmFOKF9idikpKQogICAgIHRlc3RQYXNzZWQoX2EgKyAiIGlzICIgKyBfYik7CiAgIGVsc2Ug ewogICAgIHRlc3RGYWlsZWQoX2EgKyAiIHNob3VsZCBiZSAiICsgX2J2ICsgIiAob2YgdHlwZSAi ICsgdHlwZW9mIF9idiAK