129605 2014-03-03 05:30:22 -0800 Optimize StylePropertySet::findPropertyIndex() to improve CSS properties performance 2014-03-03 11:02:18 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 ltilve webkit-unassigned cgarcia commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard pnormand svillar oldest_to_newest 986323 0 ltilve 2014-03-03 05:30:22 -0800 A recent change that has been introduced on Blink has improved significantly the CSS properties performance https://codereview.chromium.org/169453006. This optimization could probably be backported into WebKit. 986325 1 225644 ltilve 2014-03-03 05:36:23 -0800 Created attachment 225644 Patch 986383 2 225644 kling 2014-03-03 09:56:02 -0800 Comment on attachment 225644 Patch Sure, r=me. 986412 3 225644 commit-queue 2014-03-03 11:02:15 -0800 Comment on attachment 225644 Patch Clearing flags on attachment: 225644 Committed r164995: <http://trac.webkit.org/changeset/164995> 986413 4 commit-queue 2014-03-03 11:02:18 -0800 All reviewed patches have been landed. Closing bug. 225644 2014-03-03 05:36:23 -0800 2014-03-03 11:02:14 -0800 Patch bug-129605-20140303143622.patch text/plain 5469 ltilve U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIwZmFlNzM4NGIzNDdl Y2I0YmRhMDhlMmQ0OTk4NmIyM2Q2ZjAyOC4uZGI3OTFmYTY2YTliNzIxMDg4OTAyNTI3ZTc0NDFl ZDVhNjRiYzViZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQyIEBACisyMDE0LTAzLTAzICBMb3Jl bnpvIFRpbHZlICA8bHRpbHZlQGlnYWxpYS5jb20+CisKKyAgICAgICAgT3B0aW1pemUgU3R5bGVQ cm9wZXJ0aWVzU2V0OjpmaW5kUHJvcGVydHlJbmRleCgpIHRvIGltcHJvdmUgQ1NTIHByb3BlcnRp ZXMgcGVyZm9ybWFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyOTYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1lcmdlZCBmcm9tIEJsaW5rIChwYXRjaCBieSBNaWtoYWlsIFBvemRueWFrb3YpOgor ICAgICAgICBodHRwczovL3NyYy5jaHJvbWl1bS5vcmcvdmlld3ZjL2JsaW5rP3ZpZXc9cmV2aXNp b24mcmV2aXNpb249MTY3MzI1CisKKyAgICAgICAgQXZvaWQgY2hlY2tpbmcgd2hldGhlciAnU3R5 bGVQcm9wZXJ0aWVzU2V0JyBpcyBtdXRhYmxlIGFuZCBhY2Nlc2luZyBkaXJlY3RseSB0byBpdHMK KyAgICAgICAgZGF0YSBtZW1iZXJzIHRvIGFjaGlldmUgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnRz CisKKyAgICAgICAgQmVmb3JlIHRoZSBvcHRpbWl6YXRpb24gYXBwbGllZDoKKyAgICAgICAgICAg IG1lYW46IDMwNjQuODMzNzE3MTkzNDA2MyBydW5zL3MKKyAgICAgICAgICAgIG1lZGlhbjogMzA5 Ny41ODk5Mzc5MzQzODU1IHJ1bnMvcworICAgICAgICAgICAgc3RkZXY6IDY2Ljg5Mjc0MDc0MDQ0 MTg3IHJ1bnMvcworICAgICAgICAgICAgbWluOiAyODkxLjc0NzkzMjQzNjI1ODUgcnVucy9zCisg ICAgICAgICAgICBtYXg6IDMxMTMuMjg4NjgzNDQwMTI1IHJ1bnMvcworCisgICAgICAgIEFmdGVy IHRoZSBvcHRpbWl6YXRpb24gYXBwbGllZDoKKyAgICAgICAgICAgIG1lYW46IDMzNDMuODM1NjEx NDEzODEwNSBydW5zL3MKKyAgICAgICAgICAgIG1lZGlhbjogMzM1Ni4yNTY4Mjk1NzQ0NiBydW5z L3MKKyAgICAgICAgICAgIHN0ZGV2OiAzNi4yOTc1MzMwODc0ODkwMzYgcnVucy9zCisgICAgICAg ICAgICBtaW46IDMyMzguNTQ2ODAzMjI2NDI0MyBydW5zL3MKKyAgICAgICAgICAgIG1heDogMzM2 OC42NjQ4Mzc1MzE0MjUgcnVucy9zCisKKyAgICAgICAgUGVyZm9ybWFuY2UgZ2FpbiBmb3IgdGhl IGF2ZXJhZ2UgdmFsdWUgaXMgYXBwcm94LiA5LjElLCBpbiB0aGUKKyAgICAgICAgcmFuZ2Ugb2Yg dGhlIDEwJSAtIDguMiUgZm9yIHRoZSBtaW4gYW5kIG1heCBtZWFzdXJlZAorICAgICAgICB2YWx1 ZXMgKExpbnV4IGRlc2t0b3AgeDY0KS4KKworICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnRpZXMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1tdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjpmaW5kUHJv cGVydHlJbmRleCk6CisgICAgICAgIChXZWJDb3JlOjpNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjpm aW5kUHJvcGVydHlJbmRleCk6CisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydGllcy5oOgorICAg ICAgICAoV2ViQ29yZTo6dG9NdXRhYmxlU3R5bGVQcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNv cmU6OnRvSW1tdXRhYmxlU3R5bGVQcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxl UHJvcGVydGllczo6ZmluZFByb3BlcnR5SW5kZXgpOgorCiAyMDE0LTAzLTAzICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJlc3BlY3QgU1ZHIGZyYWdtZW50 IGlkZW50aWZpZXJzIGluIDxpbWc+IHNyYyBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl UHJvcGVydGllcy5jcHAKaW5kZXggNzEyYzRiZDAwMWYxY2Y2ZGU4ZDQ4ZjAxMTY5MzJmY2MxZDhm NTQ0OS4uMDJlZDIyOWM5YzE3NzBhMzZjMmQ4NDEyZTMyOWQ4ZDRlMGNjZjBjYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKQEAgLTExMjksMTUgKzExMjksMjkgQEAgYm9v bCBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjpyZW1vdmVQcm9wZXJ0aWVzSW5TZXQoY29uc3QgQ1NT UHJvcGVydHlJRCogc2V0LCB1bnMKICAgICByZXR1cm4gY2hhbmdlZDsKIH0KIAotaW50IFN0eWxl UHJvcGVydGllczo6ZmluZFByb3BlcnR5SW5kZXgoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBj b25zdAoraW50IEltbXV0YWJsZVN0eWxlUHJvcGVydGllczo6ZmluZFByb3BlcnR5SW5kZXgoQ1NT UHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25zdAogewogICAgIC8vIENvbnZlcnQgaGVyZSBwcm9w ZXJ0eUlEIGludG8gYW4gdWludDE2X3QgdG8gY29tcGFyZSBpdCB3aXRoIHRoZSBtZXRhZGF0YSdz IG1fcHJvcGVydHlJRCB0byBhdm9pZAogICAgIC8vIHRoZSBjb21waWxlciBjb252ZXJ0aW5nIGl0 IHRvIGFuIGludCBtdWx0aXBsZSB0aW1lcyBpbiB0aGUgbG9vcC4KICAgICB1aW50MTZfdCBpZCA9 IHN0YXRpY19jYXN0PHVpbnQxNl90Pihwcm9wZXJ0eUlEKTsKLSAgICBmb3IgKGludCBuID0gcHJv cGVydHlDb3VudCgpIC0gMSA7IG4gPj0gMDsgLS1uKSB7Ci0gICAgICAgIGlmIChpZCA9PSBwcm9w ZXJ0eUF0KG4pLnByb3BlcnR5TWV0YWRhdGEoKS5tX3Byb3BlcnR5SUQpCisgICAgZm9yIChpbnQg biA9IG1fYXJyYXlTaXplIC0gMSA7IG4gPj0gMDsgLS1uKSB7CisgICAgICAgIGlmIChtZXRhZGF0 YUFycmF5KClbbl0ubV9wcm9wZXJ0eUlEID09IGlkKQogICAgICAgICAgICAgcmV0dXJuIG47CiAg ICAgfQorCisgICAgcmV0dXJuIC0xOworfQorCitpbnQgTXV0YWJsZVN0eWxlUHJvcGVydGllczo6 ZmluZFByb3BlcnR5SW5kZXgoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25zdAoreworICAg IC8vIENvbnZlcnQgaGVyZSBwcm9wZXJ0eUlEIGludG8gYW4gdWludDE2X3QgdG8gY29tcGFyZSBp dCB3aXRoIHRoZSBtZXRhZGF0YSdzIG1fcHJvcGVydHlJRCB0byBhdm9pZAorICAgIC8vIHRoZSBj b21waWxlciBjb252ZXJ0aW5nIGl0IHRvIGFuIGludCBtdWx0aXBsZSB0aW1lcyBpbiB0aGUgbG9v cC4KKyAgICB1aW50MTZfdCBpZCA9IHN0YXRpY19jYXN0PHVpbnQxNl90Pihwcm9wZXJ0eUlEKTsK KyAgICBmb3IgKGludCBuID0gbV9wcm9wZXJ0eVZlY3Rvci5zaXplKCkgLSAxIDsgbiA+PSAwOyAt LW4pIHsKKyAgICAgICAgaWYgKG1fcHJvcGVydHlWZWN0b3IuYXQobikubWV0YWRhdGEoKS5tX3By b3BlcnR5SUQgPT0gaWQpCisgICAgICAgICAgICByZXR1cm4gbjsKKyAgICB9CisKICAgICByZXR1 cm4gLTE7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRp ZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuaAppbmRleCA3MDAyNGEz M2Y1NzlhNDhlOWYxNzM1YjQzNjZiY2FmYjJhMmE3NzhkLi5mOTU4Yzg0MjczY2Y5ZjY4M2I4Zjc4 ZjU0YmZkYjVjNGMxMDY1YTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQ cm9wZXJ0aWVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5oCkBA IC0xNjMsNiArMTYzLDcgQEAgcHVibGljOgogCiAgICAgY29uc3QgQ1NTVmFsdWUqKiB2YWx1ZUFy cmF5KCkgY29uc3Q7CiAgICAgY29uc3QgU3R5bGVQcm9wZXJ0eU1ldGFkYXRhKiBtZXRhZGF0YUFy cmF5KCkgY29uc3Q7CisgICAgaW50IGZpbmRQcm9wZXJ0eUluZGV4KENTU1Byb3BlcnR5SUQpIGNv bnN0OwogCiAgICAgdm9pZCogbV9zdG9yYWdlOwogCkBAIC0yMjIsNiArMjIzLDggQEAgcHVibGlj OgogICAgIENTU1N0eWxlRGVjbGFyYXRpb24qIGVuc3VyZUNTU1N0eWxlRGVjbGFyYXRpb24oKTsK ICAgICBDU1NTdHlsZURlY2xhcmF0aW9uKiBlbnN1cmVJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9u KFN0eWxlZEVsZW1lbnQqIHBhcmVudEVsZW1lbnQpOwogCisgICAgaW50IGZpbmRQcm9wZXJ0eUlu ZGV4KENTU1Byb3BlcnR5SUQpIGNvbnN0OworCiAgICAgVmVjdG9yPENTU1Byb3BlcnR5LCA0PiBt X3Byb3BlcnR5VmVjdG9yOwogCiBwcml2YXRlOgpAQCAtMjM2LDYgKzIzOSwyMCBAQCBwcml2YXRl OgogICAgIGZyaWVuZCBjbGFzcyBTdHlsZVByb3BlcnRpZXM7CiB9OwogCitUWVBFX0NBU1RTX0JB U0UoTXV0YWJsZVN0eWxlUHJvcGVydGllcywgU3R5bGVQcm9wZXJ0aWVzLCBzZXQsIHNldC0+aXNN dXRhYmxlKCksIHNldC5pc011dGFibGUoKSk7CisKK2lubGluZSBNdXRhYmxlU3R5bGVQcm9wZXJ0 aWVzKiB0b011dGFibGVTdHlsZVByb3BlcnRpZXMoY29uc3QgUmVmUHRyPFN0eWxlUHJvcGVydGll cz4mIHNldCkKK3sKKyAgICByZXR1cm4gdG9NdXRhYmxlU3R5bGVQcm9wZXJ0aWVzKHNldC5nZXQo KSk7Cit9CisKK1RZUEVfQ0FTVFNfQkFTRShJbW11dGFibGVTdHlsZVByb3BlcnRpZXMsIFN0eWxl UHJvcGVydGllcywgc2V0LCAhc2V0LT5pc011dGFibGUoKSwgIXNldC5pc011dGFibGUoKSk7CisK K2lubGluZSBJbW11dGFibGVTdHlsZVByb3BlcnRpZXMqIHRvSW1tdXRhYmxlU3R5bGVQcm9wZXJ0 aWVzKGNvbnN0IFJlZlB0cjxTdHlsZVByb3BlcnRpZXM+JiBzZXQpCit7CisgICAgcmV0dXJuIHRv SW1tdXRhYmxlU3R5bGVQcm9wZXJ0aWVzKHNldC5nZXQoKSk7Cit9CisKIGlubGluZSBjb25zdCBT dHlsZVByb3BlcnR5TWV0YWRhdGEmIFN0eWxlUHJvcGVydGllczo6UHJvcGVydHlSZWZlcmVuY2U6 OnByb3BlcnR5TWV0YWRhdGEoKSBjb25zdAogewogICAgIGlmIChtX3Byb3BlcnR5U2V0LmlzTXV0 YWJsZSgpKQpAQCAtMjczLDYgKzI5MCwxMyBAQCBpbmxpbmUgdm9pZCBTdHlsZVByb3BlcnRpZXM6 OmRlcmVmKCkKICAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PEltbXV0YWJsZVN0eWxlUHJvcGVy dGllcyo+KHRoaXMpOwogfQogCitpbmxpbmUgaW50IFN0eWxlUHJvcGVydGllczo6ZmluZFByb3Bl cnR5SW5kZXgoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25zdAoreworICAgIGlmIChtX2lz TXV0YWJsZSkKKyAgICAgICAgcmV0dXJuIHRvTXV0YWJsZVN0eWxlUHJvcGVydGllcyh0aGlzKS0+ ZmluZFByb3BlcnR5SW5kZXgocHJvcGVydHlJRCk7CisgICAgcmV0dXJuIHRvSW1tdXRhYmxlU3R5 bGVQcm9wZXJ0aWVzKHRoaXMpLT5maW5kUHJvcGVydHlJbmRleChwcm9wZXJ0eUlEKTsKK30KKwog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gU3R5bGVQcm9wZXJ0aWVzX2gK