<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129599</bug_id>
          
          <creation_ts>2014-03-02 21:10:15 -0800</creation_ts>
          <short_desc>Debugging improvements from my gbemu investigation session</short_desc>
          <delta_ts>2014-03-02 21:53:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>barraclough</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>mmirman</cc>
    
    <cc>msaboff</cc>
    
    <cc>nrotem</cc>
    
    <cc>oliver</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>986262</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-02 21:10:15 -0800</bug_when>
    <thetext>Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986264</commentid>
    <comment_count>1</comment_count>
      <attachid>225631</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-02 21:19:34 -0800</bug_when>
    <thetext>Created attachment 225631
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986266</commentid>
    <comment_count>2</comment_count>
      <attachid>225631</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-03-02 21:31:59 -0800</bug_when>
    <thetext>Comment on attachment 225631
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986270</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-03-02 21:53:53 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/164970</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>225631</attachid>
            <date>2014-03-02 21:19:34 -0800</date>
            <delta_ts>2014-03-02 21:31:58 -0800</delta_ts>
            <desc>the patch</desc>
            <filename>blah.patch</filename>
            <type>text/plain</type>
            <size>4044</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0OTY4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA
CisyMDE0LTAzLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
RGVidWdnaW5nIGltcHJvdmVtZW50cyBmcm9tIG15IGdiZW11IGludmVzdGlnYXRpb24gc2Vzc2lv
bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTk5
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAg
ICBWYXJpb3VzIGltcHJvdmVtZW50cyBmcm9tIHdoZW4gSSB3YXMgaW52ZXN0aWdhdGluZyBidWcg
MTI5NDExLgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpT
Qzo6Q29kZUJsb2NrOjpvcHRpbWl6YXRpb25UaHJlc2hvbGRTY2FsaW5nRmFjdG9yKTogTWFrZSB0
aGUgZGF0YUxvZygpIHN0YXRlbWVudCBwcmludCB0aGUgYWN0dWFsIG11bHRpcGxpZXIuCisgICAg
ICAgICoganNjLmNwcDoKKyAgICAgICAgKEdsb2JhbE9iamVjdDo6ZmluaXNoQ3JlYXRpb24pOgor
ICAgICAgICAoZnVuY3Rpb25EZXNjcmliZSk6IE1ha2UgZGVzY3JpYmUoKSByZXR1cm4gYSBzdHJp
bmcgcmF0aGVyIHRoYW4gcHJpbnRpbmcgdGhlIHN0cmluZy4KKyAgICAgICAgKGZ1bmN0aW9uRGVz
Y3JpYmVBcnJheSk6IExpa2UgZGVzY3JpYmUoKSwgYnV0IHByaW50cyBkZXRhaWxzIGFib3V0IGFy
cmF5cy4KKwogMjAxNC0wMi0yNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK
ICAgICAgICAgSlNET01XaW5kb3c6OmNvbW1vblZNKCkgc2hvdWxkIHJldHVybiBhIHJlZmVyZW5j
ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAxNjQ5NjgpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE4LDYgKzIxOCw3IEBA
IHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmMKIHN0YXRpYyBFbmNvZGVk
SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUHJpbnQoRXhlY1N0YXRlKik7CiBzdGF0aWMg
RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlYnVnKEV4ZWNTdGF0ZSopOwog
c3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25EZXNjcmliZShFeGVj
U3RhdGUqKTsKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRGVz
Y3JpYmVBcnJheShFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9D
QUxMIGZ1bmN0aW9uSlNDU3RhY2soRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUg
SlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkdDQW5kU3dlZXAoRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5j
b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkZ1bGxHQyhFeGVjU3RhdGUqKTsKQEAg
LTM0Myw2ICszNDQsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIAogICAgICAgICBhZGRGdW5jdGlv
bih2bSwgImRlYnVnIiwgZnVuY3Rpb25EZWJ1ZywgMSk7CiAgICAgICAgIGFkZEZ1bmN0aW9uKHZt
LCAiZGVzY3JpYmUiLCBmdW5jdGlvbkRlc2NyaWJlLCAxKTsKKyAgICAgICAgYWRkRnVuY3Rpb24o
dm0sICJkZXNjcmliZUFycmF5IiwgZnVuY3Rpb25EZXNjcmliZUFycmF5LCAxKTsKICAgICAgICAg
YWRkRnVuY3Rpb24odm0sICJwcmludCIsIGZ1bmN0aW9uUHJpbnQsIDEpOwogICAgICAgICBhZGRG
dW5jdGlvbih2bSwgInF1aXQiLCBmdW5jdGlvblF1aXQsIDApOwogICAgICAgICBhZGRGdW5jdGlv
bih2bSwgImdjIiwgZnVuY3Rpb25HQ0FuZFN3ZWVwLCAwKTsKQEAgLTQ2Miw4ICs0NjQsMTkgQEAg
RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlYgogCiBFbmNvZGVkSlNWYWx1
ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRGVzY3JpYmUoRXhlY1N0YXRlKiBleGVjKQogewotICAg
IGZwcmludGYoc3RkZXJyLCAiLS0+ICVzXG4iLCB0b0NTdHJpbmcoZXhlYy0+YXJndW1lbnQoMCkp
LmRhdGEoKSk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKKyAg
ICBpZiAoZXhlYy0+YXJndW1lbnRDb3VudCgpIDwgMSkKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6
OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3Ry
aW5nKGV4ZWMsIHRvU3RyaW5nKGV4ZWMtPmFyZ3VtZW50KDApKSkpOworfQorCitFbmNvZGVkSlNW
YWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRGVzY3JpYmVBcnJheShFeGVjU3RhdGUqIGV4ZWMp
Cit7CisgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA8IDEpCisgICAgICAgIHJldHVybiBK
U1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CisgICAgSlNPYmplY3QqIG9iamVjdCA9IGpz
RHluYW1pY0Nhc3Q8SlNPYmplY3QqPihleGVjLT5hcmd1bWVudCgwKSk7CisgICAgaWYgKCFvYmpl
Y3QpCisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNTdHJpbmcoZXhlYywgIjxub3Qg
b2JqZWN0PiIpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIHRv
U3RyaW5nKCI8UHVibGljIGxlbmd0aDogIiwgb2JqZWN0LT5nZXRBcnJheUxlbmd0aCgpLCAiOyB2
ZWN0b3IgbGVuZ3RoOiAiLCBvYmplY3QtPmdldFZlY3Rvckxlbmd0aCgpLCAiPiIpKSk7CiB9CiAK
IGNsYXNzIEZ1bmN0aW9uSlNDU3RhY2tGdW5jdG9yIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAxNjQ5NjgpCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpA
QCAtMjkzOSwxMyArMjkzOSwxNiBAQCBkb3VibGUgQ29kZUJsb2NrOjpvcHRpbWl6YXRpb25UaHJl
c2hvbGRTCiAgICAgQVNTRVJUKGluc3RydWN0aW9uQ291bnQpOyAvLyBNYWtlIHN1cmUgdGhpcyBp
cyBjYWxsZWQgb25seSBhZnRlciB3ZSBoYXZlIGFuIGluc3RydWN0aW9uIHN0cmVhbTsgb3RoZXJ3
aXNlIGl0J2xsIGp1c3QgcmV0dXJuIHRoZSB2YWx1ZSBvZiBkLCB3aGljaCBtYWtlcyBubyBzZW5z
ZS4KICAgICAKICAgICBkb3VibGUgcmVzdWx0ID0gZCArIGEgKiBzcXJ0KGluc3RydWN0aW9uQ291
bnQgKyBiKSArIGMgKiBpbnN0cnVjdGlvbkNvdW50OworICAgIAorICAgIHJlc3VsdCAqPSBjb2Rl
VHlwZVRocmVzaG9sZE11bHRpcGxpZXIoKTsKKyAgICAKICAgICBpZiAoT3B0aW9uczo6dmVyYm9z
ZU9TUigpKSB7CiAgICAgICAgIGRhdGFMb2coCiAgICAgICAgICAgICAqdGhpcywgIjogaW5zdHJ1
Y3Rpb24gY291bnQgaXMgIiwgaW5zdHJ1Y3Rpb25Db3VudCwKICAgICAgICAgICAgICIsIHNjYWxp
bmcgZXhlY3V0aW9uIGNvdW50ZXIgYnkgIiwgcmVzdWx0LCAiICogIiwgY29kZVR5cGVUaHJlc2hv
bGRNdWx0aXBsaWVyKCksCiAgICAgICAgICAgICAiXG4iKTsKICAgICB9Ci0gICAgcmV0dXJuIHJl
c3VsdCAqIGNvZGVUeXBlVGhyZXNob2xkTXVsdGlwbGllcigpOworICAgIHJldHVybiByZXN1bHQ7
CiB9CiAKIHN0YXRpYyBpbnQzMl90IGNsaXBUaHJlc2hvbGQoZG91YmxlIHRocmVzaG9sZCkK
</data>
<flag name="review"
          id="249784"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>