129597 2014-03-02 19:30:55 -0800 [x86] Improve code generation of byte test 2014-03-05 10:50:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough commit-queue msaboff oliver rniwa oldest_to_newest 986246 0 benjamin 2014-03-02 19:30:55 -0800 [x86] Improve code generation of byte test 986247 1 225628 benjamin 2014-03-02 19:32:25 -0800 Created attachment 225628 Patch 986248 2 benjamin 2014-03-02 19:36:11 -0800 I have noticed that pattern from the CSS JIT. 986484 3 225628 ggaren 2014-03-03 13:48:58 -0800 Comment on attachment 225628 Patch r=me 986493 4 225628 commit-queue 2014-03-03 14:22:41 -0800 Comment on attachment 225628 Patch Clearing flags on attachment: 225628 Committed r165009: <http://trac.webkit.org/changeset/165009> 986494 5 commit-queue 2014-03-03 14:22:43 -0800 All reviewed patches have been landed. Closing bug. 986750 6 rniwa 2014-03-04 02:11:08 -0800 Looks like this was a 1% improvement on DYEBench on some machines. https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D 986865 7 benjamin 2014-03-04 10:36:51 -0800 (In reply to comment #6) > Looks like this was a 1% improvement on DYEBench on some machines. > > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D That's awesome :) 987307 8 rniwa 2014-03-05 10:50:04 -0800 Holy shit... this might have been a 15% improvement on Dromaeo's dom-query: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Dromaeo%2Fdom-query%3ARuns%22%5D%2C%5B%22mac-mavericks%22%2C%22Dromaeo%2Fdom-query%3ARuns%22%5D%5D 225628 2014-03-02 19:32:25 -0800 2014-03-03 14:22:41 -0800 Patch bug-129597-20140302193223.patch text/plain 2059 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy Yzk5ODM5MmYwYTk1OWUwZDRiMDMyOGYzYmE0MmM5NDE0NzY0MWZlLi5hMzkyOTRmMjExNzkyMzNi MTE2MDFjYzdkMmJkZGVmYTVkNDE0ZWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNC0wMy0wMiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW3g4Nl0gSW1wcm92ZSBjb2RlIGdlbmVyYXRpb24gb2YgYnl0ZSB0 ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk1 OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVu IHBvc3NpYmxlLCB0ZXN0IHRoZSA4IGJpdCByZWdpc3RlciB0byBpdHNlbGYgaW5zdGVhZCBvZiBj b21wYXJpbmcgaXQKKyAgICAgICAgdG8gYSBsaXRlcmFsLgorCisgICAgICAgICogYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVy WDg2Q29tbW9uOjp0ZXN0MzIpOgorCiAyMDE0LTAzLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBDb2RlQmxvY2s6Omhhc0RlYnVnZ2VyUmVxdWVzdHMoKSBzaG91 bGQgcmV0dXJuaW5nIGEgYm9vbCBpbnN0ZWFkIG9mIGFuIGludC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaApp bmRleCBhYzA5ZWFjYTQ0NzNmODJiZGI3ZTRiODY4MjFmOTI0Mjc3ZjgzY2VlLi4zNzhmZjUwMjQ3 NDliNTE4MjcwYzM5MTcxMjkxMmUzODkxODgwY2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCkBAIC0x MTQ5LDkgKzExNDksMTIgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgaWYgKG1hc2subV92YWx1 ZSA9PSAtMSkKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RsX3JyKHJlZywgcmVnKTsKLSAg ICAgICAgZWxzZSBpZiAoIShtYXNrLm1fdmFsdWUgJiB+MHhmZikgJiYgcmVnIDwgWDg2UmVnaXN0 ZXJzOjplc3ApIC8vIFVzaW5nIGVzcCBhbmQgZ3JlYXRlciBhcyBhIGJ5dGUgcmVnaXN0ZXIgeWll bGRzIHRoZSB1cHBlciBoYWxmIG9mIHRoZSAxNiBiaXQgcmVnaXN0ZXJzIGF4LCBjeCwgZHggYW5k IGJ4LCBlLmcuIGVzcCwgcmVnaXN0ZXIgNCwgaXMgYWN0dWFsbHkgYWguCi0gICAgICAgICAgICBt X2Fzc2VtYmxlci50ZXN0Yl9pOHIobWFzay5tX3ZhbHVlLCByZWcpOwotICAgICAgICBlbHNlCisg ICAgICAgIGVsc2UgaWYgKCEobWFzay5tX3ZhbHVlICYgfjB4ZmYpICYmIHJlZyA8IFg4NlJlZ2lz dGVyczo6ZXNwKSB7IC8vIFVzaW5nIGVzcCBhbmQgZ3JlYXRlciBhcyBhIGJ5dGUgcmVnaXN0ZXIg eWllbGRzIHRoZSB1cHBlciBoYWxmIG9mIHRoZSAxNiBiaXQgcmVnaXN0ZXJzIGF4LCBjeCwgZHgg YW5kIGJ4LCBlLmcuIGVzcCwgcmVnaXN0ZXIgNCwgaXMgYWN0dWFsbHkgYWguCisgICAgICAgICAg ICBpZiAobWFzay5tX3ZhbHVlID09IDB4ZmYpCisgICAgICAgICAgICAgICAgbV9hc3NlbWJsZXIu dGVzdGJfcnIocmVnLCByZWcpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG1f YXNzZW1ibGVyLnRlc3RiX2k4cihtYXNrLm1fdmFsdWUsIHJlZyk7CisgICAgICAgIH0gZWxzZQog ICAgICAgICAgICAgbV9hc3NlbWJsZXIudGVzdGxfaTMycihtYXNrLm1fdmFsdWUsIHJlZyk7CiAg ICAgfQogCg==