129595 2014-03-02 17:59:22 -0800 Remove non-working optimization that was attempted on iOS only 2014-03-07 09:45:19 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 darin darin benjamin commit-queue dbates ddkilzer ggaren joepeck kling mhahnenberg oldest_to_newest 986224 0 darin 2014-03-02 17:59:22 -0800 Remove non-working optimization that was attempted on iOS-only 986226 1 225621 darin 2014-03-02 18:02:24 -0800 Created attachment 225621 Patch 986227 2 darin 2014-03-02 18:03:16 -0800 I’m happy to consider the other version, fixing the optimization and enabling it for all platforms, if you’d prefer. 986229 3 225621 darin 2014-03-02 18:11:14 -0800 Comment on attachment 225621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225621&action=review > Source/WebCore/bindings/js/JSDOMWindowBase.cpp:215 > #if PLATFORM(IOS) I reversed this #if, but I forgot to add the "!". 986838 4 darin 2014-03-04 09:01:31 -0800 Landed this a while ago. Not sure the revision number. 986877 5 kling 2014-03-04 10:56:56 -0800 Not landed just yet. 986883 6 joepeck 2014-03-04 11:13:52 -0800 <rdar://problem/15798825> 988196 7 darin 2014-03-07 09:45:19 -0800 Committed r165269: <http://trac.webkit.org/changeset/165269> 225621 2014-03-02 18:02:24 -0800 2014-03-02 18:11:14 -0800 Patch bug-129595-20140302180224.patch text/plain 7197 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM5ZjAyY2RiMjcyMmJi ZGZkMzMwZWZlMGQwOWZkOGIxNGNkMDdjZi4uNmVmMzEwOWY0ZGI1ZDU1YzQzZWU0MmY2OTQ5MTRj ZWJmZDZjZWRkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE0LTAzLTAyICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgbm9uLXdvcmtpbmcg b3B0aW1pemF0aW9uIHRoYXQgd2FzIGF0dGVtcHRlZCBvbiBpT1Mgb25seQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTk1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29kZSBpbiBHQ0NvbnRyb2xsZXIg dHJpZWQgdG8gb3B0aW1pemUgY2FzZXMgd2hlcmUgdGhlIGNvbnRyb2xsZXIKKyAgICAgICAgd2Fz IHVzZWQsIGJ1dCBubyBKYXZhU2NyaXB0IGhhZCBiZWVuIHJ1biBpbiB0aGUgY3VycmVudCBwcm9j ZXNzLgorICAgICAgICBUaGUgY29kZSB3YXMgbmV2ZXIgZWZmZWN0aXZlLCBhbmQgd2FzIGlPUy1v bmx5LiBBbm90aGVyIHdheSB0byBmaXgKKyAgICAgICAgdGhlIHByb2JsZW0gd291bGQgYmUgdG8g Y2hhbmdlIHRoZSBjb2RlIHNvIGl0IHdvcmtzLCBhbmQgaWYgd2UgZG8KKyAgICAgICAgdGhhdCB3 ZSBzaG91bGQgZG8gaXQgZm9yIGFsbCBwbGF0Zm9ybXMsIG5vdCBqdXN0IGlPUy4KKworICAgICAg ICAqIGJpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHQ0Nv bnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0Tm93KTogUmVtb3ZlIGNoZWNrIG9mCisgICAgICAgIEpT RE9NV2luZG93Ojpjb21tb25WTUV4aXN0cywgc2luY2UgaXQncyBjYWxsZWQganVzdCBhZnRlciBh IGNhbGwKKyAgICAgICAgdG8gSlNET01XaW5kb3c6OmNvbW1vblZNLCB3aGljaCB3aWxsIGNyZWF0 ZSBpdCBhcyBhIHNpZGUgZWZmZWN0LgorICAgICAgICAoV2ViQ29yZTo6R0NDb250cm9sbGVyOjpy ZWxlYXNlRXhlY3V0YWJsZU1lbW9yeSk6IERpdHRvLgorCisgICAgICAgICogYmluZGluZ3MvanMv SlNET01XaW5kb3dCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93QmFzZTo6 Y29tbW9uVk0pOiBSZW1vdmVkIGlPUy1zcGVjaWZpYyBjb2RlCisgICAgICAgIHRoYXQgcHVsbGVk IHRoZSBjb21tb25WTSBnbG9iYWwgb3V0IGludG8gYW5vdGhlciBmdW5jdGlvbiBzbyB3ZQorICAg ICAgICBjYW4gY2hlY2sgZm9yIGl0cyBleGlzdGVuY2Ugd2l0aG91dCBjcmVhdGluZyBpdCBhcyBh IHNpZGUgZWZmZWN0LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmg6 IERpdHRvLgorCisyMDE0LTAzLTAyICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKwog ICAgICAgICBGaXggYnVpbGQgZm9yIGNhc2Utc2Vuc2l0aXZlIGZpbGUgc3lzdGVtcy4KIAogICAg ICAgICAqIHBsYXRmb3JtL1VzZXJBY3Rpdml0eS5oOiBSdW5sb29wIC0+IFJ1bkxvb3AuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcAppbmRleCBiYTcwZDRhMDY5 ZDVkYzk5N2UzNzMwZTMxNmNiZDkxNTU2YmQzOGIxLi45ZGE3MTc3Njg2OTg5ZWVkZjNhYzgxMGFk YzhmMWJmYzJlMGZjNGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9H Q0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dDQ29udHJv bGxlci5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA3IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNywgMjAxNCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTU4LDcgKzU4LDcgQEAgR0NDb250cm9sbGVyOjpHQ0NvbnRyb2xsZXIoKQogdm9p ZCBHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0U29vbigpCiB7CiAgICAgLy8gV2Ugb25seSB1 c2UgcmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGggb24gc3lzdGVtcyB3aXRoIENvcmVGb3VuZGF0 aW9uIAotICAgIC8vIHNpbmNlIGl0IHVzZXMgYSBydW5sb29wLWJhc2VkIHRpbWVyIHRoYXQgaXMg Y3VycmVudGx5IG9ubHkgYXZhaWxhYmxlIG9uIAorICAgIC8vIHNpbmNlIGl0IHVzZXMgYSBydW4t bG9vcC1iYXNlZCB0aW1lciB0aGF0IGlzIGN1cnJlbnRseSBvbmx5IGF2YWlsYWJsZSBvbgogICAg IC8vIHN5c3RlbXMgd2l0aCBDb3JlRm91bmRhdGlvbi4gSWYgYW5kIHdoZW4gdGhlIG5vdGlvbiBv ZiBhIHJ1biBsb29wIGlzIHB1c2hlZCAKICAgICAvLyBkb3duIGludG8gV1RGIHNvIHRoYXQgbW9y ZSBwbGF0Zm9ybXMgY2FuIHRha2UgYWR2YW50YWdlIG9mIGl0LCB3ZSB3aWxsIGJlIAogICAgIC8v IGFibGUgdG8gdXNlIHJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoIG9uIG1vcmUgcGxhdGZvcm1z LgpAQCAtNzQsMTkgKzc0LDEzIEBAIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdFNv b24oKQogI2lmICFVU0UoQ0YpCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2NUaW1lckZpcmVkKFRpbWVy PEdDQ29udHJvbGxlcj4qKQogewotICAgIGNvbGxlY3QoMCk7CisgICAgY29sbGVjdChudWxscHRy KTsKIH0KICNlbmRpZgogCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3ROb3coKQog ewogICAgIEpTTG9ja0hvbGRlciBsb2NrKEpTRE9NV2luZG93Ojpjb21tb25WTSgpKTsKLSNpZiBQ TEFURk9STShJT1MpCi0gICAgLy8gSWYgSmF2YVNjcmlwdCB3YXMgbmV2ZXIgcnVuIGluIHRoaXMg cHJvY2VzcywgdGhlcmUncyBubyBuZWVkIHRvIGNhbGwgR0Mgd2hpY2ggd2lsbAotICAgIC8vIGVu ZCB1cCBjcmVhdGluZyBhIFZNIHVubmVjZXNzYXJpbHkuCi0gICAgaWYgKCFKU0RPTVdpbmRvdzo6 Y29tbW9uVk1FeGlzdHMoKSkKLSAgICAgICAgcmV0dXJuOwotI2VuZGlmCiAgICAgaWYgKCFKU0RP TVdpbmRvdzo6Y29tbW9uVk0oKS0+aGVhcC5pc0J1c3koKSkKICAgICAgICAgSlNET01XaW5kb3c6 OmNvbW1vblZNKCktPmhlYXAuY29sbGVjdEFsbEdhcmJhZ2UoKTsKIH0KQEAgLTEwNywxOCArMTAx LDkgQEAgdm9pZCBHQ0NvbnRyb2xsZXI6OnJlbGVhc2VFeGVjdXRhYmxlTWVtb3J5KCkKIHsKICAg ICBKU0xvY2tIb2xkZXIgbG9jayhKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKSk7CiAKLSNpZiBQTEFU Rk9STShJT1MpCi0gICAgLy8gSWYgSmF2YVNjcmlwdCB3YXMgbmV2ZXIgcnVuIGluIHRoaXMgcHJv Y2VzcywgdGhlcmUncyBubyBuZWVkIHRvIGNhbGwgR0Mgd2hpY2ggd2lsbAotICAgIC8vIGVuZCB1 cCBjcmVhdGluZyBhIFZNIHVubmVjZXNzYXJpbHkuCi0gICAgaWYgKCFKU0RPTVdpbmRvdzo6Y29t bW9uVk1FeGlzdHMoKSkKLSAgICAgICAgcmV0dXJuOwotI2VuZGlmCi0KLSAgICAvLyBXZSBzaG91 bGRuJ3QgaGF2ZSBhbnkgamF2YXNjcmlwdCBydW5uaW5nIG9uIG91ciBzdGFjayB3aGVuIHRoaXMg ZnVuY3Rpb24gaXMgY2FsbGVkLiBUaGUKLSAgICAvLyBmb2xsb3dpbmcgbGluZSBhc3NlcnRzIHRo YXQuCisgICAgLy8gV2Ugc2hvdWxkbid0IGhhdmUgYW55IEphdmFTY3JpcHQgcnVubmluZyBvbiBv dXIgc3RhY2sgd2hlbiB0aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZC4gVGhlCisgICAgLy8gZm9sbG93 aW5nIGxpbmUgYXNzZXJ0cyB0aGF0LCBidXQgdG8gYmUgc2FmZSB3ZSBjaGVjayB0aGlzIGluIHJl bGVhc2UgYnVpbGRzIGFueXdheS4KICAgICBBU1NFUlQoIUpTRE9NV2luZG93Ojpjb21tb25WTSgp LT5lbnRyeVNjb3BlKTsKLQotICAgIC8vIEJ1dCBiZSBzYWZlIGluIHJlbGVhc2UgYnVpbGRzIGp1 c3QgaW4gY2FzZS4uLgogICAgIGlmIChKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS0+ZW50cnlTY29w ZSkKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNE T01XaW5kb3dCYXNlLmNwcAppbmRleCA3OWNhODkwZWVkMTQwOGI0ODNjNWM1MTVhOTNlYjBmZjU4 YjkwODQ1Li4xNTllODM0MjZiZWZjNjdmNjE0Y2I0NjFiYWVjOGQ1M2I3NzdiYWNjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAKQEAgLTEsNyAr MSw3IEBACiAvKgogICogIENvcHlyaWdodCAoQykgMjAwMCBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBr ZGUub3JnKQogICogIENvcHlyaWdodCAoQykgMjAwNiBKb24gU2hpZXIgKGpzaGllckBpYXN0YXRl LmVkdSkKLSAqICBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDcsIDIw MDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2V2ZWQuCisgKiAgQ29weXJpZ2h0IChD KSAyMDAzLTIwMDksIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2V2ZWQuCiAgKiAgQ29w eXJpZ2h0IChDKSAyMDA2IEFsZXhleSBQcm9za3VyeWFrb3YgKGFwQHdlYmtpdC5vcmcpCiAgKgog ICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKQEAgLTIwOCw0NCArMjA4LDI0IEBAIFZNKiBKU0RPTVdpbmRvd0Jhc2U6OmNvbW1v blZNKCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogCi0jaWYgIVBMQVRGT1JNKElP UykKLSAgICBzdGF0aWMgVk0qIHZtID0gMDsKLSNlbHNlCi0gICAgVk0qJiB2bSA9IGNvbW1vblZN SW50ZXJuYWwoKTsKLSNlbmRpZgorICAgIHN0YXRpYyBWTSogdm0gPSBudWxscHRyOwogICAgIGlm ICghdm0pIHsKICAgICAgICAgU2NyaXB0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZVRocmVhZGluZygp OwogICAgICAgICB2bSA9IFZNOjpjcmVhdGVMZWFrZWRGb3JNYWluVGhyZWFkKExhcmdlSGVhcCku bGVha1JlZigpOwogI2lmIFBMQVRGT1JNKElPUykKLSAgICAgICAgUGFzc093blB0cjxXZWJTYWZl R0NBY3Rpdml0eUNhbGxiYWNrPiBhY3Rpdml0eUNhbGxiYWNrID0gV2ViU2FmZUdDQWN0aXZpdHlD YWxsYmFjazo6Y3JlYXRlKCZ2bS0+aGVhcCk7Ci0gICAgICAgIHZtLT5oZWFwLnNldEFjdGl2aXR5 Q2FsbGJhY2soYWN0aXZpdHlDYWxsYmFjayk7Ci0gICAgICAgIFBhc3NPd25QdHI8V2ViU2FmZUlu Y3JlbWVudGFsU3dlZXBlcj4gaW5jcmVtZW50YWxTd2VlcGVyID0gV2ViU2FmZUluY3JlbWVudGFs U3dlZXBlcjo6Y3JlYXRlKCZ2bS0+aGVhcCk7Ci0gICAgICAgIHZtLT5oZWFwLnNldEluY3JlbWVu dGFsU3dlZXBlcihpbmNyZW1lbnRhbFN3ZWVwZXIpOworICAgICAgICB2bS0+c2V0RXhjbHVzaXZl VGhyZWFkKHN0ZDo6dGhpc190aHJlYWQ6OmdldF9pZCgpKTsKKyNlbHNlCisgICAgICAgIHZtLT5o ZWFwLnNldEFjdGl2aXR5Q2FsbGJhY2soV2ViU2FmZUdDQWN0aXZpdHlDYWxsYmFjazo6Y3JlYXRl KCZ2bS0+aGVhcCkpOworICAgICAgICB2bS0+aGVhcC5zZXRJbmNyZW1lbnRhbFN3ZWVwZXIoV2Vi U2FmZUluY3JlbWVudGFsU3dlZXBlcjo6Y3JlYXRlKCZ2bS0+aGVhcCkpOwogICAgICAgICB2bS0+ bWFrZVVzYWJsZUZyb21NdWx0aXBsZVRocmVhZHMoKTsKICAgICAgICAgdm0tPmhlYXAubWFjaGlu ZVRocmVhZHMoKS5hZGRDdXJyZW50VGhyZWFkKCk7Ci0jZWxzZQotICAgICAgICB2bS0+c2V0RXhj bHVzaXZlVGhyZWFkKHN0ZDo6dGhpc190aHJlYWQ6OmdldF9pZCgpKTsKLSNlbmRpZiAvLyAhUExB VEZPUk0oSU9TKQorI2VuZGlmCiAgICAgICAgIGluaXROb3JtYWxXb3JsZENsaWVudERhdGEodm0p OwogICAgIH0KIAogICAgIHJldHVybiB2bTsKIH0KIAotI2lmIFBMQVRGT1JNKElPUykKLWJvb2wg SlNET01XaW5kb3dCYXNlOjpjb21tb25WTUV4aXN0cygpCi17Ci0gICAgcmV0dXJuIGNvbW1vblZN SW50ZXJuYWwoKTsKLX0KLQotVk0qJiBKU0RPTVdpbmRvd0Jhc2U6OmNvbW1vblZNSW50ZXJuYWwo KQotewotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgc3RhdGljIFZNKiBjb21tb25W TTsKLSAgICByZXR1cm4gY29tbW9uVk07Ci19Ci0jZW5kaWYKLQogLy8gSlNET01HbG9iYWxPYmpl Y3QqIGlzIGlnbm9yZWQsIGFjY2Vzc2luZyBhIHdpbmRvdyBpbiBhbnkgY29udGV4dCB3aWxsCiAv LyB1c2UgdGhhdCBET01XaW5kb3cncyBwcm90b3R5cGUgY2hhaW4uCiBKU1ZhbHVlIHRvSlMoRXhl Y1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCosIERPTVdpbmRvdyogZG9tV2luZG93KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuaAppbmRleCBmYjRj NjAxYmMyYWM0YThiZWRmYzg2MzZjZDNmNDhmMjNhOTRhOGJjLi4zZWEzNDc5MTkwNjMzNzZmYWYz OTIwMzQzMTBkNjc5YTBlOGQ2ZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTVdpbmRvd0Jhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RPTVdpbmRvd0Jhc2UuaApAQCAtNzIsMTAgKzcyLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBKU0RPTVdpbmRvd1NoZWxsKiBzaGVsbCgpIGNvbnN0OwogCiAgICAgICAgIHN0YXRp YyBKU0M6OlZNKiBjb21tb25WTSgpOwotI2lmIFBMQVRGT1JNKElPUykKLSAgICAgICAgc3RhdGlj IGJvb2wgY29tbW9uVk1FeGlzdHMoKTsKLSAgICAgICAgc3RhdGljIEpTQzo6Vk0qJiBjb21tb25W TUludGVybmFsKCk7Ci0jZW5kaWYKIAogICAgIHByaXZhdGU6CiAgICAgICAgIFJlZlB0cjxET01X aW5kb3c+IG1faW1wbDsK