129591 2014-03-02 17:14:38 -0800 PolymorphicPutByIdList should have a simpler construction API with basically a single entrypoint 2014-03-05 21:56:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 129778 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 986210 0 fpizlo 2014-03-02 17:14:38 -0800 Patch forthcoming. 986234 1 225624 fpizlo 2014-03-02 18:41:42 -0800 Created attachment 225624 the patch 986271 2 fpizlo 2014-03-02 21:57:31 -0800 Landed in http://trac.webkit.org/changeset/164971 225624 2014-03-02 18:41:42 -0800 2014-03-02 21:51:47 -0800 the patch blah.patch text/plain 7213 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0OTY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UG9seW1vcnBoaWNQdXRCeUlkTGlzdCBzaG91bGQgaGF2ZSBhIHNpbXBsZXIgY29uc3RydWN0aW9u IEFQSSB3aXRoIGJhc2ljYWxseSBhIHNpbmdsZSBlbnRyeXBvaW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk1OTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL1BvbHltb3JwaGljUHV0 QnlJZExpc3QuY3BwOgorICAgICAgICAoSlNDOjpQdXRCeUlkQWNjZXNzOjpmcm9tU3RydWN0dXJl U3R1YkluZm8pOiBUaGlzIGZ1bmN0aW9uIGNhbiBmaWd1cmUgb3V0IHRoZSBzbG93IHBhdGggdGFy Z2V0IGZvciBpdHNlbGYuCisgICAgICAgIChKU0M6OlBvbHltb3JwaGljUHV0QnlJZExpc3Q6OlBv bHltb3JwaGljUHV0QnlJZExpc3QpOiBUaGlzIGNvbnN0dWN0b3Igc2hvdWxkIGJlIHByaXZhdGUs IG9ubHkgZnJvbSgpIHNob3VsZCBjYWxsIGl0LgorICAgICAgICAoSlNDOjpQb2x5bW9ycGhpY1B1 dEJ5SWRMaXN0Ojpmcm9tKToKKyAgICAgICAgKiBieXRlY29kZS9Qb2x5bW9ycGhpY1B1dEJ5SWRM aXN0Lmg6CisgICAgICAgIChKU0M6OlB1dEJ5SWRBY2Nlc3M6OnN0dWJSb3V0aW5lKToKKyAgICAg ICAgKiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnRyeUJ1aWxkUHV0QnlJZExpc3Qp OiBEb24ndCBwYXNzIHRoZSBzbG93IHBhdGggdGFyZ2V0IHNpbmNlIGl0IGNhbiBiZSBkZXJpdmVk IGZyb20gdGhlIHN0dWJJbmZvLgorCiAyMDE0LTAzLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBDb2RlQmxvY2s6Omhhc0RlYnVnZ2VyUmVxdWVzdHMoKSBzaG91 bGQgcmV0dXJuaW5nIGEgYm9vbCBpbnN0ZWFkIG9mIGFuIGludC4KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY1B1dEJ5SWRMaXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1vcnBoaWNQdXRCeUlkTGlz dC5jcHAJKHJldmlzaW9uIDE2NDk1MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Qb2x5bW9ycGhpY1B1dEJ5SWRMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUg QEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyLCAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMzIsMTAgKzMyLDEx IEBACiAKIG5hbWVzcGFjZSBKU0MgewogCi1QdXRCeUlkQWNjZXNzIFB1dEJ5SWRBY2Nlc3M6OmZy b21TdHJ1Y3R1cmVTdHViSW5mbygKLSAgICBTdHJ1Y3R1cmVTdHViSW5mbyYgc3R1YkluZm8sCi0g ICAgTWFjcm9Bc3NlbWJsZXJDb2RlUHRyIGluaXRpYWxTbG93UGF0aCkKK1B1dEJ5SWRBY2Nlc3Mg UHV0QnlJZEFjY2Vzczo6ZnJvbVN0cnVjdHVyZVN0dWJJbmZvKFN0cnVjdHVyZVN0dWJJbmZvJiBz dHViSW5mbykKIHsKKyAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHIgaW5pdGlhbFNsb3dQYXRoID0K KyAgICAgICAgc3R1YkluZm8uY2FsbFJldHVybkxvY2F0aW9uLmxhYmVsQXRPZmZzZXQoc3R1Yklu Zm8ucGF0Y2guZGVsdGFDYWxsVG9TbG93Q2FzZSk7CisgICAgCiAgICAgUHV0QnlJZEFjY2VzcyBy ZXN1bHQ7CiAgICAgCiAgICAgc3dpdGNoIChzdHViSW5mby5hY2Nlc3NUeXBlKSB7CkBAIC04NCwx OCArODUsMTQgQEAgYm9vbCBQdXRCeUlkQWNjZXNzOjp2aXNpdFdlYWsoKSBjb25zdAogfQogCiBQ b2x5bW9ycGhpY1B1dEJ5SWRMaXN0OjpQb2x5bW9ycGhpY1B1dEJ5SWRMaXN0KAotICAgIFB1dEtp bmQgcHV0S2luZCwKLSAgICBTdHJ1Y3R1cmVTdHViSW5mbyYgc3R1YkluZm8sCi0gICAgTWFjcm9B c3NlbWJsZXJDb2RlUHRyIGluaXRpYWxTbG93UGF0aCkKKyAgICBQdXRLaW5kIHB1dEtpbmQsIFN0 cnVjdHVyZVN0dWJJbmZvJiBzdHViSW5mbykKICAgICA6IG1fa2luZChwdXRLaW5kKQogewotICAg IG1fbGlzdC5hcHBlbmQoUHV0QnlJZEFjY2Vzczo6ZnJvbVN0cnVjdHVyZVN0dWJJbmZvKHN0dWJJ bmZvLCBpbml0aWFsU2xvd1BhdGgpKTsKKyAgICBtX2xpc3QuYXBwZW5kKFB1dEJ5SWRBY2Nlc3M6 OmZyb21TdHJ1Y3R1cmVTdHViSW5mbyhzdHViSW5mbykpOwogfQogCiBQb2x5bW9ycGhpY1B1dEJ5 SWRMaXN0KiBQb2x5bW9ycGhpY1B1dEJ5SWRMaXN0Ojpmcm9tKAotICAgIFB1dEtpbmQgcHV0S2lu ZCwKLSAgICBTdHJ1Y3R1cmVTdHViSW5mbyYgc3R1YkluZm8sCi0gICAgTWFjcm9Bc3NlbWJsZXJD b2RlUHRyIGluaXRpYWxTbG93UGF0aCkKKyAgICBQdXRLaW5kIHB1dEtpbmQsIFN0cnVjdHVyZVN0 dWJJbmZvJiBzdHViSW5mbykKIHsKICAgICBpZiAoc3R1YkluZm8uYWNjZXNzVHlwZSA9PSBhY2Nl c3NfcHV0X2J5X2lkX2xpc3QpCiAgICAgICAgIHJldHVybiBzdHViSW5mby51LnB1dEJ5SWRMaXN0 Lmxpc3Q7CkBAIC0xMDUsNyArMTAyLDcgQEAgUG9seW1vcnBoaWNQdXRCeUlkTGlzdCogUG9seW1v cnBoaWNQdXRCeQogICAgICAgICAgICB8fCBzdHViSW5mby5hY2Nlc3NUeXBlID09IGFjY2Vzc19w dXRfYnlfaWRfdHJhbnNpdGlvbl9kaXJlY3QpOwogICAgIAogICAgIFBvbHltb3JwaGljUHV0QnlJ ZExpc3QqIHJlc3VsdCA9Ci0gICAgICAgIG5ldyBQb2x5bW9ycGhpY1B1dEJ5SWRMaXN0KHB1dEtp bmQsIHN0dWJJbmZvLCBpbml0aWFsU2xvd1BhdGgpOworICAgICAgICBuZXcgUG9seW1vcnBoaWNQ dXRCeUlkTGlzdChwdXRLaW5kLCBzdHViSW5mbyk7CiAgICAgCiAgICAgc3R1YkluZm8uaW5pdFB1 dEJ5SWRMaXN0KHJlc3VsdCk7CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvUG9seW1vcnBoaWNQdXRCeUlkTGlzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY1B1dEJ5SWRMaXN0LmgJKHJldmlzaW9uIDE2 NDk1MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY1B1dEJ5 SWRMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAo QykgMjAxMiwgMjAxNCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTgzLDkgKzgzLDcgQEAgcHVibGljOgogICAgICAgICBy ZXR1cm4gcmVzdWx0OwogICAgIH0KICAgICAKLSAgICBzdGF0aWMgUHV0QnlJZEFjY2VzcyBmcm9t U3RydWN0dXJlU3R1YkluZm8oCi0gICAgICAgIFN0cnVjdHVyZVN0dWJJbmZvJiwKLSAgICAgICAg TWFjcm9Bc3NlbWJsZXJDb2RlUHRyIGluaXRpYWxTbG93UGF0aCk7CisgICAgc3RhdGljIFB1dEJ5 SWRBY2Nlc3MgZnJvbVN0cnVjdHVyZVN0dWJJbmZvKFN0cnVjdHVyZVN0dWJJbmZvJik7CiAgICAg CiAgICAgYm9vbCBpc1NldCgpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZSAhPSBJbnZhbGlkOyB9CiAg ICAgYm9vbCBvcGVyYXRvciEoKSBjb25zdCB7IHJldHVybiAhaXNTZXQoKTsgfQpAQCAtMTIyLDEw ICsxMjAsMTAgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gbV9jaGFpbi5nZXQoKTsKICAgICB9 CiAgICAgCi0gICAgUGFzc1JlZlB0cjxKSVRTdHViUm91dGluZT4gc3R1YlJvdXRpbmUoKSBjb25z dAorICAgIEpJVFN0dWJSb3V0aW5lKiBzdHViUm91dGluZSgpIGNvbnN0CiAgICAgewogICAgICAg ICBBU1NFUlQoaXNUcmFuc2l0aW9uKCkgfHwgaXNSZXBsYWNlKCkpOwotICAgICAgICByZXR1cm4g bV9zdHViUm91dGluZTsKKyAgICAgICAgcmV0dXJuIG1fc3R1YlJvdXRpbmUuZ2V0KCk7CiAgICAg fQogICAgIAogICAgIGJvb2wgdmlzaXRXZWFrKCkgY29uc3Q7CkBAIC0xNDMsMjAgKzE0MSw5IEBA IHByaXZhdGU6CiBjbGFzcyBQb2x5bW9ycGhpY1B1dEJ5SWRMaXN0IHsKICAgICBXVEZfTUFLRV9G QVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKLSAgICAvLyBJbml0aWFsaXplIGZyb20gYSBzdHViIGlu Zm87IHRoaXMgd2lsbCBwbGFjZSBvbmUgZWxlbWVudCBpbiB0aGUgbGlzdCBhbmQgaXQgd2lsbAot ICAgIC8vIGJlIGNyZWF0ZWQgYnkgY29udmVydGluZyB0aGUgc3R1YiBpbmZvJ3MgcHV0IGJ5IGlk IGFjY2VzcyBpbmZvcm1hdGlvbiBpbnRvIG91cgotICAgIC8vIFB1dEJ5SWRBY2Nlc3MuCi0gICAg UG9seW1vcnBoaWNQdXRCeUlkTGlzdCgKLSAgICAgICAgUHV0S2luZCwKLSAgICAgICAgU3RydWN0 dXJlU3R1YkluZm8mLAotICAgICAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHIgaW5pdGlhbFNsb3dQ YXRoKTsKLQogICAgIC8vIEVpdGhlciBjcmVhdGVzIGEgbmV3IHBvbHltb3JwaGljIHB1dCBsaXN0 LCBvciByZXR1cm5zIHRoZSBvbmUgdGhhdCBpcyBhbHJlYWR5CiAgICAgLy8gaW4gcGxhY2UuCi0g ICAgc3RhdGljIFBvbHltb3JwaGljUHV0QnlJZExpc3QqIGZyb20oCi0gICAgICAgIFB1dEtpbmQs Ci0gICAgICAgIFN0cnVjdHVyZVN0dWJJbmZvJiwKLSAgICAgICAgTWFjcm9Bc3NlbWJsZXJDb2Rl UHRyIGluaXRpYWxTbG93UGF0aCk7CisgICAgc3RhdGljIFBvbHltb3JwaGljUHV0QnlJZExpc3Qq IGZyb20oUHV0S2luZCwgU3RydWN0dXJlU3R1YkluZm8mKTsKICAgICAKICAgICB+UG9seW1vcnBo aWNQdXRCeUlkTGlzdCgpOwogICAgIApAQCAtMTgxLDYgKzE2OCwxMSBAQCBwdWJsaWM6CiBwcml2 YXRlOgogICAgIGZyaWVuZCBjbGFzcyBDb2RlQmxvY2s7CiAgICAgCisgICAgLy8gSW5pdGlhbGl6 ZSBmcm9tIGEgc3R1YiBpbmZvOyB0aGlzIHdpbGwgcGxhY2Ugb25lIGVsZW1lbnQgaW4gdGhlIGxp c3QgYW5kIGl0IHdpbGwKKyAgICAvLyBiZSBjcmVhdGVkIGJ5IGNvbnZlcnRpbmcgdGhlIHN0dWIg aW5mbydzIHB1dCBieSBpZCBhY2Nlc3MgaW5mb3JtYXRpb24gaW50byBvdXIKKyAgICAvLyBQdXRC eUlkQWNjZXNzLgorICAgIFBvbHltb3JwaGljUHV0QnlJZExpc3QoUHV0S2luZCwgU3RydWN0dXJl U3R1YkluZm8mKTsKKwogICAgIFZlY3RvcjxQdXRCeUlkQWNjZXNzLCAyPiBtX2xpc3Q7CiAgICAg UHV0S2luZCBtX2tpbmQ7CiB9OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBh dGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2gu Y3BwCShyZXZpc2lvbiAxNjQ5NTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0 Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQ1LDkgKzEyNDUsNyBAQCBzdGF0aWMgYm9vbCB0 cnlCdWlsZFB1dEJ5SWRMaXN0KEV4ZWNTdGF0CiAgICAgICAgICAgICBTdHJ1Y3R1cmVDaGFpbiog cHJvdG90eXBlQ2hhaW4gPSBzdHJ1Y3R1cmUtPnByb3RvdHlwZUNoYWluKGV4ZWMpOwogICAgICAg ICAgICAgCiAgICAgICAgICAgICAvLyBXZSdyZSBub3cgY29tbWl0dGVkIHRvIGNyZWF0aW5nIHRo ZSBzdHViLiBNb2dyaWZ5IHRoZSBtZXRhLWRhdGEgYWNjb3JkaW5nbHkuCi0gICAgICAgICAgICBs aXN0ID0gUG9seW1vcnBoaWNQdXRCeUlkTGlzdDo6ZnJvbSgKLSAgICAgICAgICAgICAgICBwdXRL aW5kLCBzdHViSW5mbywKLSAgICAgICAgICAgICAgICBzdHViSW5mby5jYWxsUmV0dXJuTG9jYXRp b24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxUb1Nsb3dDYXNlKSk7Cisg ICAgICAgICAgICBsaXN0ID0gUG9seW1vcnBoaWNQdXRCeUlkTGlzdDo6ZnJvbShwdXRLaW5kLCBz dHViSW5mbyk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGVtaXRQdXRUcmFuc2l0aW9uU3R1 YigKICAgICAgICAgICAgICAgICBleGVjLCBiYXNlVmFsdWUsIHByb3BlcnR5TmFtZSwgc2xvdCwg c3R1YkluZm8sIHB1dEtpbmQsCkBAIC0xMjYyLDkgKzEyNjAsNyBAQCBzdGF0aWMgYm9vbCB0cnlC dWlsZFB1dEJ5SWRMaXN0KEV4ZWNTdGF0CiAgICAgICAgICAgICAgICAgICAgIHN0dWJSb3V0aW5l KSk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBXZSdyZSBub3cgY29tbWl0dGVk IHRvIGNyZWF0aW5nIHRoZSBzdHViLiBNb2dyaWZ5IHRoZSBtZXRhLWRhdGEgYWNjb3JkaW5nbHku Ci0gICAgICAgICAgICBsaXN0ID0gUG9seW1vcnBoaWNQdXRCeUlkTGlzdDo6ZnJvbSgKLSAgICAg ICAgICAgICAgICBwdXRLaW5kLCBzdHViSW5mbywKLSAgICAgICAgICAgICAgICBzdHViSW5mby5j YWxsUmV0dXJuTG9jYXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxU b1Nsb3dDYXNlKSk7CisgICAgICAgICAgICBsaXN0ID0gUG9seW1vcnBoaWNQdXRCeUlkTGlzdDo6 ZnJvbShwdXRLaW5kLCBzdHViSW5mbyk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGVtaXRQ dXRSZXBsYWNlU3R1YigKICAgICAgICAgICAgICAgICBleGVjLCBiYXNlVmFsdWUsIHByb3BlcnR5 TmFtZSwgc2xvdCwgc3R1YkluZm8sIHB1dEtpbmQsCg==