129584 2014-03-02 15:01:31 -0800 CodeBlock::hasDebuggerRequests() should returning a bool instead of an int 2014-03-02 15:57:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 986178 0 mark.lam 2014-03-02 15:01:31 -0800 Trivial change. Patch coming. 986179 1 225613 mark.lam 2014-03-02 15:03:46 -0800 Created attachment 225613 the patch. 986186 2 225613 darin 2014-03-02 15:26:22 -0800 Comment on attachment 225613 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=225613&action=review > Source/JavaScriptCore/bytecode/CodeBlock.h:880 > + bool hasDebuggerRequests() const { return !!m_debuggerRequests; } By the way, there is no need for the !! here. That was only needed in compilers that lacked bool support, but we don’t compile WebKit with those kinds of old compilers. 986191 3 225613 commit-queue 2014-03-02 15:57:29 -0800 Comment on attachment 225613 the patch. Clearing flags on attachment: 225613 Committed r164954: <http://trac.webkit.org/changeset/164954> 986192 4 commit-queue 2014-03-02 15:57:31 -0800 All reviewed patches have been landed. Closing bug. 225613 2014-03-02 15:03:46 -0800 2014-03-02 15:57:29 -0800 the patch. bug-129584.patch text/plain 1274 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0OTUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAzLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD b2RlQmxvY2s6Omhhc0RlYnVnZ2VyUmVxdWVzdHMoKSBzaG91bGQgcmV0dXJuaW5nIGEgYm9vbCBp bnN0ZWFkIG9mIGFuIGludC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyOTU4ND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVj b2RlL0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6Omhhc0RlYnVnZ2VyUmVx dWVzdHMpOgorCiAyMDE0LTAzLTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgVGhpcyBzaG91bGRuJ3QgaGF2ZSBiZWVuIGEgbGF5b3V0IHRlc3Qgc2luY2UgaXQg cnVucyBvbmx5IHVuZGVyIGpzYy4gTW92aW5nIGl0IHRvIEpTQwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkocmV2aXNpb24gMTY0OTUxKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBA IC04NzcsNyArODc3LDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBoYXNPcERlYnVnRm9yTGluZUFu ZENvbHVtbih1bnNpZ25lZCBsaW5lLCB1bnNpZ25lZCBjb2x1bW4pOwogCi0gICAgaW50IGhhc0Rl YnVnZ2VyUmVxdWVzdHMoKSBjb25zdCB7IHJldHVybiAhIW1fZGVidWdnZXJSZXF1ZXN0czsgfQor ICAgIGJvb2wgaGFzRGVidWdnZXJSZXF1ZXN0cygpIGNvbnN0IHsgcmV0dXJuICEhbV9kZWJ1Z2dl clJlcXVlc3RzOyB9CiAgICAgdm9pZCogZGVidWdnZXJSZXF1ZXN0c0FkZHJlc3MoKSB7IHJldHVy biAmbV9kZWJ1Z2dlclJlcXVlc3RzOyB9CiAKICAgICB2b2lkIGFkZEJyZWFrcG9pbnQodW5zaWdu ZWQgbnVtQnJlYWtwb2ludHMpOwo=