129582 2014-03-02 14:15:12 -0800 Clean up use of Options::enableConcurrentJIT(). 2014-03-02 15:09:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 986161 0 mark.lam 2014-03-02 14:15:12 -0800 DFG Driver was conditionally checking Options::enableConcurrentJIT() only if ENABLE(CONCURRENT_JIT). Otherwise, it bypasses it with a local enableConcurrentJIT set to false. Instead we should configure Options::enableConcurrentJIT() to be false in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always check Options::enableConcurrentJIT(). This makes the code read a little cleaner. 986170 1 225611 mark.lam 2014-03-02 14:28:21 -0800 Created attachment 225611 the patch. 986182 2 225611 commit-queue 2014-03-02 15:09:11 -0800 Comment on attachment 225611 the patch. Clearing flags on attachment: 225611 Committed r164953: <http://trac.webkit.org/changeset/164953> 986183 3 commit-queue 2014-03-02 15:09:15 -0800 All reviewed patches have been landed. Closing bug. 225611 2014-03-02 14:28:21 -0800 2014-03-02 15:09:11 -0800 the patch. bug-129582.patch text/plain 2860 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0OTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTAzLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD bGVhbiB1cCB1c2Ugb2YgT3B0aW9uczo6ZW5hYmxlQ29uY3VycmVudEpJVCgpLgorICAgICAgICA8 aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5NTgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERGRyBEcml2ZXIgd2FzIGNvbmRpdGlvbmFsbHkgY2hlY2tp bmcgT3B0aW9uczo6ZW5hYmxlQ29uY3VycmVudEpJVCgpCisgICAgICAgIG9ubHkgaWYgRU5BQkxF KENPTkNVUlJFTlRfSklUKS4gIE90aGVyd2lzZSwgaXQgYnlwYXNzZXMgaXQgd2l0aCBhIGxvY2Fs CisgICAgICAgIGVuYWJsZUNvbmN1cnJlbnRKSVQgc2V0IHRvIGZhbHNlLgorCisgICAgICAgIElu c3RlYWQgd2Ugc2hvdWxkIGNvbmZpZ3VyZSBPcHRpb25zOjplbmFibGVDb25jdXJyZW50SklUKCkg dG8gYmUgZmFsc2UKKyAgICAgICAgaW4gT3B0aW9ucy5jcHAgaWYgIUVOQUJMRShDT05DVVJSRU5U X0pJVCksIGFuZCBERkcgRHJpdmVyIHNob3VsZCBhbHdheXMKKyAgICAgICAgY2hlY2sgT3B0aW9u czo6ZW5hYmxlQ29uY3VycmVudEpJVCgpLiAgVGhpcyBtYWtlcyB0aGUgY29kZSByZWFkIGEgbGl0 dGxlCisgICAgICAgIGNsZWFuZXIuCisKKyAgICAgICAgKiBkZmcvREZHRHJpdmVyLmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpjb21waWxlSW1wbCk6CisgICAgICAgICogcnVudGltZS9PcHRpb25z LmNwcDoKKyAgICAgICAgKEpTQzo6cmVjb21wdXRlRGVwZW5kZW50T3B0aW9ucyk6CisKIDIwMTQt MDMtMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBUaGlzIHNo b3VsZG4ndCBoYXZlIGJlZW4gYSBsYXlvdXQgdGVzdCBzaW5jZSBpdCBydW5zIG9ubHkgdW5kZXIg anNjLiBNb3ZpbmcgaXQgdG8gSlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0RyaXZlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdE cml2ZXIuY3BwCShyZXZpc2lvbiAxNjQ5NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0RyaXZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyLDEzICs5Miw3IEBAIHN0YXRpYyBD b21waWxhdGlvblJlc3VsdCBjb21waWxlSW1wbCgKICAgICBSZWZQdHI8UGxhbj4gcGxhbiA9IGFk b3B0UmVmKAogICAgICAgICBuZXcgUGxhbihjb2RlQmxvY2ssIHByb2ZpbGVkREZHQ29kZUJsb2Nr LCBtb2RlLCBvc3JFbnRyeUJ5dGVjb2RlSW5kZXgsIG11c3RIYW5kbGVWYWx1ZXMpKTsKICAgICAK LSAgICBib29sIGVuYWJsZUNvbmN1cnJlbnRKSVQ7Ci0jaWYgRU5BQkxFKENPTkNVUlJFTlRfSklU KQotICAgIGVuYWJsZUNvbmN1cnJlbnRKSVQgPSBPcHRpb25zOjplbmFibGVDb25jdXJyZW50SklU KCk7Ci0jZWxzZSAvLyBFTkFCTEUoQ09OQ1VSUkVOVF9KSVQpCi0gICAgZW5hYmxlQ29uY3VycmVu dEpJVCA9IGZhbHNlOwotI2VuZGlmIC8vIEVOQUJMRShDT05DVVJSRU5UX0pJVCkKLSAgICBpZiAo ZW5hYmxlQ29uY3VycmVudEpJVCkgeworICAgIGlmIChPcHRpb25zOjplbmFibGVDb25jdXJyZW50 SklUKCkpIHsKICAgICAgICAgV29ya2xpc3QqIHdvcmtsaXN0ID0gZW5zdXJlR2xvYmFsV29ya2xp c3RGb3IobW9kZSk7CiAgICAgICAgIHBsYW4tPmNhbGxiYWNrID0gY2FsbGJhY2s7CiAgICAgICAg IGlmIChsb2dDb21waWxhdGlvbkNoYW5nZXMobW9kZSkpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zLmNwcAkocmV2aXNpb24gMTY0OTQ4KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSAr MSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSwgMjAxMiwgMjAxNCBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK QEAgLTE4Niw2ICsxODYsOSBAQCBzdGF0aWMgdm9pZCByZWNvbXB1dGVEZXBlbmRlbnRPcHRpb25z KCkKICNpZiAhRU5BQkxFKFlBUlJfSklUKQogICAgIE9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpID0g ZmFsc2U7CiAjZW5kaWYKKyNpZiAhRU5BQkxFKENPTkNVUlJFTlRfSklUKQorICAgIE9wdGlvbnM6 OmVuYWJsZUNvbmN1cnJlbnRKSVQoKSA9IGZhbHNlOworI2VuZGlmCiAgICAgCiAgICAgaWYgKE9w dGlvbnM6OnNob3dEaXNhc3NlbWJseSgpCiAgICAgICAgIHx8IE9wdGlvbnM6OnNob3dERkdEaXNh c3NlbWJseSgpCg==