129562 2014-03-01 16:01:29 -0800 No need to ASSERT on infinite values in CSS lengths 2014-03-02 14:05:25 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 dino dino commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 986008 0 dino 2014-03-01 16:01:29 -0800 Infinite values should be clamped to the maximum allowed css lengths. 986012 1 dino 2014-03-01 16:25:46 -0800 Actually, they are already clamped. There is no need to assert. It's valid to say left: 1379382749871309473209874092874098723px 986013 2 225573 dino 2014-03-01 16:31:23 -0800 Created attachment 225573 Patch 986015 3 225573 darin 2014-03-01 16:39:02 -0800 Comment on attachment 225573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225573&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:-259 > - ASSERT(std::isfinite(num)); std::isfinite also checks for NAN. Instead of deleting the assertion I think you should change it to: ASSERT(!std::isnan(num)); 986016 4 225573 darin 2014-03-01 16:39:54 -0800 Comment on attachment 225573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225573&action=review > Source/WebCore/ChangeLog:12 > + Tests: fast/css/box-shadow-invalid-value.html > + fast/css/length-infinite-value.html Sure seems like there are a lot more cases to test! 986019 5 dino 2014-03-01 16:58:54 -0800 (In reply to comment #4) > (From update of attachment 225573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225573&action=review > > > Source/WebCore/ChangeLog:12 > > + Tests: fast/css/box-shadow-invalid-value.html > > + fast/css/length-infinite-value.html > > Sure seems like there are a lot more cases to test! Yeah. I'll exercise anything that would create a primitive value. I guess I should probably try more properties too (especially those that take combinations of values - we hit this in shadow parsing but it really applies to everything). 986159 6 dino 2014-03-02 14:05:25 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 225573 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=225573&action=review > > > > > Source/WebCore/ChangeLog:12 > > > + Tests: fast/css/box-shadow-invalid-value.html > > > + fast/css/length-infinite-value.html > > > > Sure seems like there are a lot more cases to test! > > Yeah. I'll exercise anything that would create a primitive value. I guess I should probably try more properties too (especially those that take combinations of values - we hit this in shadow parsing but it really applies to everything). Lucky you pushed me on this. I found other places where we barf. 225573 2014-03-01 16:31:23 -0800 2014-03-01 16:39:54 -0800 Patch bug-129562-20140302113121.patch text/plain 6772 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzUzOGJjN2FjNzQ0NWU4 ZmJiMjllZmE4N2ZmZTgxMmI3YjUxNjAwOS4uMTkzYjUwNGY1NzFkNDdmZTBhNmQ3YTQxMTQwM2Ex OGMwNDBjM2FkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTAxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBObyBuZWVkIHRvIEFTU0VSVCBv biBpbmZpbml0ZSB2YWx1ZXMgaW4gQ1NTIGxlbmd0aHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3Mgb2sgdG8gaGF2ZSBsZWZ0OiAxMzc5ODczMjk4 NDc5NzQyMzc0OTI4Mzc0cHg7IFdlIGNsYW1wCisgICAgICAgIGl0IGxhdGVyLgorCisgICAgICAg IFRlc3RzOiBmYXN0L2Nzcy9ib3gtc2hhZG93LWludmFsaWQtdmFsdWUuaHRtbAorICAgICAgICAg ICAgICAgZmFzdC9jc3MvbGVuZ3RoLWluZmluaXRlLXZhbHVlLmh0bWwKKworICAgICAgICAqIGNz cy9DU1NQcmltaXRpdmVWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVW YWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUpOiBSZW1vdmUgQVNTRVJUKHN0ZDo6aXNmaW5pdGUobnVt KSk7CisKIDIwMTQtMDItMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgTm9kZTo6Y29tcGFyZURvY3VtZW50UG9zaXRpb24gbGVha3MgbWVtb3J5IHN0cnVj dHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKaW5kZXggMmUwOWJk MTEwODlhZDI3OTc3NzNjNzcwZjQ3MWY0M2YzODNkZmMyOS4uYWNiNDdmMTE5NmRmZGRlN2Q3NTg2 ZDEyZjkwZGQ1Nzc3Y2YwZmZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1By aW1pdGl2ZVZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFs dWUuY3BwCkBAIC0yNTYsNyArMjU2LDYgQEAgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2 ZVZhbHVlKGRvdWJsZSBudW0sIFVuaXRUeXBlcyB0eXBlKQogICAgIDogQ1NTVmFsdWUoUHJpbWl0 aXZlQ2xhc3MpCiB7CiAgICAgbV9wcmltaXRpdmVVbml0VHlwZSA9IHR5cGU7Ci0gICAgQVNTRVJU KHN0ZDo6aXNmaW5pdGUobnVtKSk7CiAgICAgbV92YWx1ZS5udW0gPSBudW07CiB9CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA0ZmZjZDBjZTgzNTdmNmZjNTI3MjcxZDRjZjQ3MDA1MjQwYjMxZGFmLi5jMDNhMTQzYzU4ODll NTA3MDJkNDU0YzRkYTQzYzRkN2JkNTBiOGZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQt MDMtMDEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIE5vIG5lZWQg dG8gQVNTRVJUIG9uIGluZmluaXRlIHZhbHVlcyBpbiBDU1MgbGVuZ3RocworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTYyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3RzIHRoYXQgZXhlcmNp c2UgbWFzc2l2ZSBDU1MgdmFsdWVzLgorCisgICAgICAgICogZmFzdC9jc3MvYm94LXNoYWRvdy1p bnZhbGlkLXZhbHVlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2Jv eC1zaGFkb3ctaW52YWxpZC12YWx1ZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9s ZW5ndGgtaW5maW5pdGUtdmFsdWUtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9jc3MvbGVuZ3RoLWluZmluaXRlLXZhbHVlLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAyLTI4ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE5vZGU6OmNvbXBh cmVEb2N1bWVudFBvc2l0aW9uIGxlYWtzIG1lbW9yeSBzdHJ1Y3R1cmUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvY3NzL2JveC1zaGFkb3ctaW52YWxpZC12YWx1ZS1leHBlY3RlZC5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYm94LXNoYWRvdy1pbnZhbGlkLXZhbHVlLWV4cGVjdGVk Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uN2M4OWI1NDVjNWFjMGEyYTlkYjA1NzE3NDkwMjU5NDYzNDQzOTZl MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2JveC1zaGFkb3ctaW52 YWxpZC12YWx1ZS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEgQEAKKzxkaXY+PC9kaXY+CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ib3gtc2hhZG93LWludmFsaWQtdmFsdWUuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2JveC1zaGFkb3ctaW52YWxpZC12YWx1ZS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjIxNWJkYjVmMmJiMmE3YzJjNTk3YzljNmFkNGI5NWYwMjUyY2ZmMTgKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ib3gtc2hhZG93LWludmFsaWQtdmFs dWUuaHRtbApAQCAtMCwwICsxIEBACis8ZGl2IHN0eWxlPSJib3gtc2hhZG93OiAtMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMXZ3IHllbGxvdzsi PjwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGVuZ3RoLWluZmluaXRl LXZhbHVlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sZW5ndGgtaW5maW5p dGUtdmFsdWUtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MjYxYjkzMmFlMzZhNDg2MDc3NmYz Mzg0ZmI2ODRmZjk4N2Q5NDllCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MvbGVuZ3RoLWluZmluaXRlLXZhbHVlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyIEBACis8 ZGl2PjwvZGl2PgorPGRpdj48L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2xlbmd0aC1pbmZpbml0ZS12YWx1ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGVuZ3Ro LWluZmluaXRlLXZhbHVlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uM2VjZGEwNTE0MDBmMTFlMzRjM2ExZjFj ODUzNDM3ZDNiZWEzMmY3NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L2xlbmd0aC1pbmZpbml0ZS12YWx1ZS5odG1sCkBAIC0wLDAgKzEsMiBAQAorPGRpdiBzdHlsZT0i bGVmdDogMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMXZ3OyI+PC9kaXY+Cis8ZGl2IHN0eWxlPSJsZWZ0OiAtMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTEx MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMXZ3OyI+PC9kaXY+Cg==