129553 2014-03-01 13:28:36 -0800 Refactor css3/filters/huge-region test 2014-03-21 12:10:32 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68469 1 savagobr webkit-unassigned commit-queue krit simon.fraser oldest_to_newest 985962 0 savagobr 2014-03-01 13:28:36 -0800 This test uses a blur filter in a huge element which previously wouldn't be filtered at all, it should really become 2 tests: a) one for invalid blur values (it uses 2147483648px which will be clamped to 500). b) another for big regions, it would require to have the following dimensions: 4096x4096 (a bit less if you consider Margin + Border). 988274 1 226149 savagobr 2014-03-07 12:38:22 -0800 Created attachment 226149 Patch 988277 2 226149 krit 2014-03-07 12:44:02 -0800 Comment on attachment 226149 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226149&action=review > LayoutTests/css3/filters/huge-region.html:7 > + width: 4096px; > + height: 4096px; This probably should delayed until we get filter scaling working properly again. But then with much bigger values. 988281 3 savagobr 2014-03-07 12:53:08 -0800 Dirk Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. What would be a limit that would *also* block the execution once we have filter scaling working again? 988286 4 krit 2014-03-07 12:57:04 -0800 (In reply to comment #3) > Dirk > > Thanks for the review. The value of 4096px will be big enough to stop the filter execution… but we can use a much bigger value. > > What would be a limit that would *also* block the execution once we have filter scaling working again? Anything bigger than 4096 seems fine :) I would like to keep this bug open until we fixed filter scaling and add the blur test to another bug report. 988288 5 savagobr 2014-03-07 13:04:27 -0800 Ins't that covered in this bug: https://bugs.webkit.org/show_bug.cgi?id=129555 993257 6 226149 commit-queue 2014-03-21 12:10:27 -0700 Comment on attachment 226149 Patch Clearing flags on attachment: 226149 Committed r166089: <http://trac.webkit.org/changeset/166089> 993258 7 commit-queue 2014-03-21 12:10:32 -0700 All reviewed patches have been landed. Closing bug. 226149 2014-03-07 12:38:22 -0800 2014-03-21 12:10:27 -0700 Patch bug-129553-20140307123822.patch text/plain 3344 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MTkzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODQ5YTRjNzU0Zjk0YTViYmI3Zjk3 OWE2Zjk4NmY4YmU0Y2Y2NWNmYy4uNWM3ZTJlZDM0NjQ0NjZiMzZiNjAyODdiYjZiYzU2ZDM3YzA0 MzBiOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTA3ICBBZGVuaWxzb24gQ2F2YWxj YW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBSZWZhY3RvciBjc3MzL2Zp bHRlcnMvaHVnZS1yZWdpb24gdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI5NTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZWZhY3RvcnMgdGhlIGh1Z2UtcmVnaW9uIHRvIGJl Y29tZSBhIGJpZyBlbm91Z2gKKyAgICAgICAgZWxlbWVudCB0byAqbm90KiBiZSByZW5kZXJlZC4g UGx1cywgYWRkcyBhbm90aGVyIHRlc3QgdXNpbmcgYSBodWdlCisgICAgICAgIGJsdXIgZmlsdGVy IGtlcm5lbCBzaXplIHRoYXQgd2lsbCB0cmlnZ2VyIGNsYW1waW5nIHRoZSB2YWx1ZSB0bworICAg ICAgICBtYXhpbXVtIGFjY2VwdGVkIHZhbHVlICg1MDBweCkuCisKKyAgICAgICAgKiBUZXN0RXhw ZWN0YXRpb25zOgorICAgICAgICAqIGNzczMvZmlsdGVycy9odWdlLWJsdXItdmFsdWUtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBjc3MzL2ZpbHRlcnMvaHVnZS1ibHVyLXZhbHVlLmh0 bWw6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2NzczMvZmlsdGVycy9odWdlLXJlZ2lvbi5odG1s LgorICAgICAgICAqIGNzczMvZmlsdGVycy9odWdlLXJlZ2lvbi5odG1sOgorCiAyMDE0LTAzLTA2 ICBHdXJwcmVldCBLYXVyICA8ay5ndXJwcmVldEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMTU4MjU0KTogUnViYmVyLWJhbmRpbmcgYXQgQmluZyBpbWFnZSBzZWFyY2ggY2F1 c2VzIHRoZSB0b29sYmFyIHRvIG1vdmUgdXAgYW5kIGF3YXkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IGJjMTY1MzlkOTAxZGFhYmZlZmRhMmVmNWVkOGRmM2U3Mzk0ODQ0ODkuLjIyZGFiMjdlYzg5YWYx MTc1MjQwYjljOTg5OGY1ZDBmNWVlMjBjYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOCw5ICs4 LDYgQEAgd2Via2l0Lm9yZy9iLzQyMTk0IGZhc3Qvc2Nyb2xsaW5nL3Njcm9sbC1zZWxlY3QtbGlz dC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAjIHBlbmRpbmcgZnVuY3Rpb25hbCBwYXRjaCBh bmQgcGVyLXBvcnQgdmVyaWZpY2F0aW9uCiB3ZWJraXQub3JnL2IvMTA5OTU0IGNzczMvbGluZS1i cmVhayBbIFNraXAgXQogCi0jIHBlbmRpbmcgcmVmYWN0b3Igb2YgdGhpcyB0ZXN0Ci13ZWJraXQu b3JnL2IvMTI5NTUzIGNzczMvZmlsdGVycy9odWdlLXJlZ2lvbi5odG1sIFsgU2tpcCBdCi0KICMg cGVuZGluZyBpbXBsZW1lbnRhdGlvbiBjb21wbGV0aW9uIGFuZCBmZWF0dXJlIGVuYWJsaW5nCiB3 ZWJraXQub3JnL2IvMTA5NTcwIG1lZGlhL3RyYWNrL3JlZ2lvbnMtd2VidnR0IFsgU2tpcCBdCiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9odWdlLWJsdXItdmFsdWUtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2UtYmx1ci12YWx1ZS1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZWE3NTRkNzA0NWY4NjhhMGU3MDk1ODljZmFkOGI3NzgzM2My MWU4ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9odWdlLWJs dXItdmFsdWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1NvIGJsdXJyeS4uLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2UtYmx1ci12YWx1ZS5odG1sIGIvTGF5 b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2UtYmx1ci12YWx1ZS5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJk OTNkODhjZTMyYTNiYzE3YTQ3MGJjMjFhYzFkMWY5ZmM2M2FiM2EKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvaHVnZS1ibHVyLXZhbHVlLmh0bWwKQEAgLTAsMCAr MSwxOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGUgdHlwZT0i dGV4dC9jc3MiPgorICAgIC5iaWcgeworICAgICAgd2lkdGg6IDUwcHg7CisgICAgICBoZWlnaHQ6 IDUwcHg7CisgICAgICAtd2Via2l0LWZpbHRlcjogYmx1cigyMTQ3NDgzNjQ4cHgpOworCX0KKyAg PC9zdHlsZT4KKyAgPHNjcmlwdD4KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICB0 ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAg PGRpdiBjbGFzcz0iYmlnIj5TbyBibHVycnkuLi48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9odWdlLXJlZ2lvbi5odG1sIGIvTGF5 b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2UtcmVnaW9uLmh0bWwKaW5kZXggYTgzMjFhNjMyZDRm OWQ3NjA0ODU4YTVmZGEyNDY5YjQ5NGViNWMzMC4uYTdmNTVlZDViZTA2NzIxZTEyMmMwODYzMGJh MTFjMjQ5YjcxMzQ2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2Ut cmVnaW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL2h1Z2UtcmVnaW9uLmh0 bWwKQEAgLTMsMTEgKzMsMTAgQEAKIDxoZWFkPgogICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgog ICAgIC5iaWcgewotICAgICAgd2lkdGg6IDUwcHg7Ci0gICAgICBoZWlnaHQ6IDUwcHg7Ci0gICAg ICBwYWRkaW5nLWJvdHRvbTogNjU1MzYlOwotICAgICAgLXdlYmtpdC1maWx0ZXI6IGJsdXIoMjE0 NzQ4MzY0OHB4KTsKLQl9IAorICAgICAgd2lkdGg6IDQwOTZweDsKKyAgICAgIGhlaWdodDogNDA5 NnB4OworICAgICAgLXdlYmtpdC1maWx0ZXI6IGJsdXIoM3B4KTsKKwl9CiAgIDwvc3R5bGU+CiAg IDxzY3JpcHQ+CiAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQo=