129537 2014-02-28 21:19:41 -0800 [iOS] Assertions and bad behavior when zooming into an iframe containing apple.com 2014-03-02 21:43:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser benjamin simon.fraser thorton oldest_to_newest 985867 0 simon.fraser 2014-02-28 21:19:41 -0800 Assertions and bad behavior when zooming into an iframe containing apple.com 985868 1 225537 simon.fraser 2014-02-28 21:23:32 -0800 Created attachment 225537 Patch 985872 2 simon.fraser 2014-02-28 21:30:40 -0800 http://trac.webkit.org/changeset/164910 985997 3 benjamin 2014-03-01 15:23:34 -0800 I still get assertions in the simulator. I have not tried on device since your fix. 986115 4 simon.fraser 2014-03-02 09:52:13 -0800 What assertions? 986268 5 simon.fraser 2014-03-02 21:43:18 -0800 (In reply to comment #4) > What assertions? Ah, the original ones this bug was filed about. I filed another bug :\ 225537 2014-02-28 21:23:32 -0800 2014-02-28 21:28:05 -0800 Patch bug-129537-20140228212331.patch text/plain 5896 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTc5YmI5OTNiMzhmMDg5 NTRmMTIxOWQ2MWY0MzgwZTMxYzI3ZTg5My4uYzkwODgzZGVlOWU2NmJmODc0MGZhMjg4OGFiNjgz YWE2ZGRjYjViNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE0LTAyLTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIEFzc2Vy dGlvbnMgYW5kIGJhZCBiZWhhdmlvciB3aGVuIHpvb21pbmcgaW50byBhbiBpZnJhbWUgY29udGFp bmluZyBhcHBsZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyOTUzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgV2hlbiBidWlsZGluZyBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbnMs IHRoZSBvcmRlcmluZyBvZiBzZXR0aW5nIGNyZWF0ZWQKKyAgICAgICAgbGF5ZXJzIGFuZCBkb2lu ZyB0aGUgcmVjdXJzaXZlIHRyZWUgd2FsayB3YXMgd3JvbmcsIHN1Y2ggdGhhdCB3ZSBmYWlsZWQK KyAgICAgICAgdG8gbm90aWNlZCBsYXllcnMgY3JlYXRlZCBkdXJpbmcgdGhlIHJlY3Vyc2l2ZUJ1 aWxkVHJhbnNhY3Rpb24oKS4KKyAgICAgICAgCisgICAgICAgIEFsc28gaGFyZGVuIHRoZSBVSS1z aWRlIGNvZGUgYWdhaW5zdCBPYmotQyBleGNlcHRpb25zIHRocm93biB3aGVuIGxheWVycworICAg ICAgICBhcmUgbWlzc2luZy4KKworICAgICAgICAqIFNoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVl UHJvcGVydHlBcHBsaWVyLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVQcm9w ZXJ0eUFwcGxpZXI6OmFwcGx5UHJvcGVydGllcyk6IEFzc2VydCB3aGVuIAorICAgICAgICBjaGls ZHJlbiBhcmUgbm90IGZvdW5kLCBhbmQgcHJvdGVjdCBhZ2FpbnN0IE9iai1DIGV4Y2VwdGlvbnMu CisgICAgICAgICogU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbToKKyAg ICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyQ3JlYXRpb25Q cm9wZXJ0aWVzOjpMYXllckNyZWF0aW9uUHJvcGVydGllcyk6CisgICAgICAgIEluaXRpYWxpemUg dGhlIG1lbWJlcnMuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXll clRyZWVDb250ZXh0Lm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVDb250ZXh0 OjpidWlsZFRyYW5zYWN0aW9uKTogRG8gdGhlIHJlY3Vyc2l2ZSB3YWxrCisgICAgICAgIGJlZm9y ZSBzZXR0aW5nIGNyZWF0ZWQgYW5kIGRlc3Ryb3llZCBsYXllcnMsIHNpbmNlIHRoZSB3YWxrIGNh biBjcmVhdGUKKyAgICAgICAgbGF5ZXJzIChlc3BlY2lhbGx5IHdoZW4gc3dhcHBpbmcgaW50byB0 aWxlZCBsYXllcnMpLgorCisyMDE0LTAyLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgorCiAgICAgICAgIE1ha2UgVUlWaWV3cyBmb3IgY29tcG9zaXRpbmcgbGF5ZXJz IGluIHRoZSBVSSBwcm9jZXNzIG9uIGlPUwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTA4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tIGIvU291cmNlL1dlYktp dDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KaW5kZXggMDY0 Njg2MzkwNjU5MzRiNDU0YWViOTk2YTMzZDdiNDFhMmRhM2ZiOS4uZGZkOGQ3ODA5NWYyYmRjMzkz MTM3NjYxYzMyZWYzZTYyMjdkOTVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVk L21hYy9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KKysrIGIvU291cmNlL1dlYktp dDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KQEAgLTI4LDYg KzI4LDcgQEAKIAogI2ltcG9ydCAiUGxhdGZvcm1DQUxheWVyUmVtb3RlLmgiCiAjaW1wb3J0IDxR dWFydHpDb3JlL0NBTGF5ZXIuaD4KKyNpbXBvcnQgPFdlYkNvcmUvQmxvY2tFeGNlcHRpb25zLmg+ CiAjaW1wb3J0IDxXZWJDb3JlL1BsYXRmb3JtQ0FGaWx0ZXJzLmg+CiAjaW1wb3J0IDxXZWJDb3Jl L1Njcm9sbGJhclRoZW1lTWFjLmg+CiAjaWYgUExBVEZPUk0oSU9TKQpAQCAtMTk3LDEyICsxOTgs MTUgQEAgc3RhdGljIHZvaWQgYXBwbHlQcm9wZXJ0aWVzVG9MYXllcihDQUxheWVyICpsYXllciwg Y29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3QKIAogdm9pZCBSZW1vdGVMYXllclRyZWVQcm9w ZXJ0eUFwcGxpZXI6OmFwcGx5UHJvcGVydGllcyhDQUxheWVyICpsYXllciwgY29uc3QgUmVtb3Rl TGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJvcGVydGllcyYgcHJvcGVydGllcywgY29uc3Qg UmVsYXRlZExheWVyTWFwJiByZWxhdGVkTGF5ZXJzKQogeworICAgIEJFR0lOX0JMT0NLX09CSkNf RVhDRVBUSU9OUzsKICAgICBhcHBseVByb3BlcnRpZXNUb0xheWVyKGxheWVyLCBwcm9wZXJ0aWVz KTsKIAogICAgIGlmIChwcm9wZXJ0aWVzLmNoYW5nZWRQcm9wZXJ0aWVzICYgUmVtb3RlTGF5ZXJU cmVlVHJhbnNhY3Rpb246OkNoaWxkcmVuQ2hhbmdlZCkgewogICAgICAgICBSZXRhaW5QdHI8TlNN dXRhYmxlQXJyYXk+IGNoaWxkcmVuID0gYWRvcHROUyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBp bml0V2l0aENhcGFjaXR5OnByb3BlcnRpZXMuY2hpbGRyZW4uc2l6ZSgpXSk7Ci0gICAgICAgIGZv ciAoYXV0byYgY2hpbGQgOiBwcm9wZXJ0aWVzLmNoaWxkcmVuKQorICAgICAgICBmb3IgKGF1dG8m IGNoaWxkIDogcHJvcGVydGllcy5jaGlsZHJlbikgeworICAgICAgICAgICAgQVNTRVJUKHJlbGF0 ZWRMYXllcnMuZ2V0KGNoaWxkKSk7CiAgICAgICAgICAgICBbY2hpbGRyZW4gYWRkT2JqZWN0OnJl bGF0ZWRMYXllcnMuZ2V0KGNoaWxkKV07CisgICAgICAgIH0KIAogICAgICAgICBsYXllci5zdWJs YXllcnMgPSBjaGlsZHJlbi5nZXQoKTsKICAgICB9CkBAIC0yMjUsMTcgKzIyOSwyMSBAQCB2b2lk IFJlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBwbGllcjo6YXBwbHlQcm9wZXJ0aWVzKENBTGF5ZXIg KmxheWVyLCBjb25zdCBSZW1vdAogI2VuZGlmCiAgICAgICAgIH0KICAgICB9CisgICAgRU5EX0JM T0NLX09CSkNfRVhDRVBUSU9OUzsKIH0KIAogI2lmIFBMQVRGT1JNKElPUykKIHZvaWQgUmVtb3Rl TGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyOjphcHBseVByb3BlcnRpZXMoVUlWaWV3ICp2aWV3LCBj b25zdCBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6TGF5ZXJQcm9wZXJ0aWVzJiBwcm9wZXJ0 aWVzLCBjb25zdCBSZWxhdGVkTGF5ZXJNYXAmIHJlbGF0ZWRMYXllcnMpCiB7CisgICAgQkVHSU5f QkxPQ0tfT0JKQ19FWENFUFRJT05TOwogICAgIGFwcGx5UHJvcGVydGllc1RvTGF5ZXIodmlldy5s YXllciwgcHJvcGVydGllcyk7CiAKICAgICBpZiAocHJvcGVydGllcy5jaGFuZ2VkUHJvcGVydGll cyAmIFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpDaGlsZHJlbkNoYW5nZWQpIHsKICAgICAg ICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiBjaGlsZHJlbiA9IGFkb3B0TlMoW1tOU011dGFi bGVBcnJheSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eTpwcm9wZXJ0aWVzLmNoaWxkcmVuLnNpemUo KV0pOwotICAgICAgICBmb3IgKGF1dG8mIGNoaWxkIDogcHJvcGVydGllcy5jaGlsZHJlbikKKyAg ICAgICAgZm9yIChhdXRvIGNoaWxkIDogcHJvcGVydGllcy5jaGlsZHJlbikgeworICAgICAgICAg ICAgQVNTRVJUKHJlbGF0ZWRMYXllcnMuZ2V0KGNoaWxkKSk7CiAgICAgICAgICAgICBbY2hpbGRy ZW4gYWRkT2JqZWN0OnJlbGF0ZWRMYXllcnMuZ2V0KGNoaWxkKV07CisgICAgICAgIH0KIAogICAg ICAgICBbdmlldyBfd2ViX3NldFN1YnZpZXdzOmNoaWxkcmVuLmdldCgpXTsKICAgICB9CkBAIC0y NTEsNiArMjU5LDcgQEAgdm9pZCBSZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXI6OmFwcGx5 UHJvcGVydGllcyhVSVZpZXcgKnZpZXcsIGNvbnN0IFJlbW90ZUwKICAgICAgICAgICAgICAgICBt YXNrVmlldy5sYXllci5tYXNrID0gbWFza1ZpZXcubGF5ZXI7CiAgICAgICAgIH0KICAgICB9Cisg ICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLm1tIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbi5tbQpp bmRleCA2ZDI3MWFlMmY5YWM4N2UwOWRlOTM0NDk0ZDBlNjYwNTA1ZTE5OTE3Li5kZWViZDIyMzE4 ZDg1ZTU0ZWU1ZWU2MTUzYzBhYzdiMmVlMTk3YzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvbWFjL1JlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24ubW0KQEAgLTQxLDYg KzQxLDkgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAog UmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyQ3JlYXRpb25Qcm9wZXJ0aWVzOjpMYXll ckNyZWF0aW9uUHJvcGVydGllcygpCisgICAgOiBsYXllcklEKDApCisgICAgLCB0eXBlKFBsYXRm b3JtQ0FMYXllcjo6TGF5ZXJUeXBlTGF5ZXIpCisgICAgLCBob3N0aW5nQ29udGV4dElEKDApCiB7 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv UmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbQppbmRleCA3YWRjYTZlYTUwMDhmMWQx NTQ0MDRkYzY4NTQzM2I5MTBjYzljZGMxLi5kODgwNjM1ZTJmMzcyNzI3MmRiNTlhZGZlYTM4MmU2 YTY5YTkwZGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVDb250ZXh0Lm1tCkBAIC05NSwxMSArOTUs MTEgQEAgdm9pZCBSZW1vdGVMYXllclRyZWVDb250ZXh0OjpidWlsZFRyYW5zYWN0aW9uKFJlbW90 ZUxheWVyVHJlZVRyYW5zYWN0aW9uJiB0cmFuc2EKIHsKICAgICBQbGF0Zm9ybUNBTGF5ZXJSZW1v dGUmIHJvb3RMYXllclJlbW90ZSA9IHRvUGxhdGZvcm1DQUxheWVyUmVtb3RlKHJvb3RMYXllcik7 CiAgICAgdHJhbnNhY3Rpb24uc2V0Um9vdExheWVySUQocm9vdExheWVyUmVtb3RlLmxheWVySUQo KSk7Ci0gICAgCi0gICAgdHJhbnNhY3Rpb24uc2V0Q3JlYXRlZExheWVycyhzdGQ6Om1vdmUobV9j cmVhdGVkTGF5ZXJzKSk7Ci0gICAgdHJhbnNhY3Rpb24uc2V0RGVzdHJveWVkTGF5ZXJJRHMoc3Rk Ojptb3ZlKG1fZGVzdHJveWVkTGF5ZXJzKSk7CiAKICAgICByb290TGF5ZXJSZW1vdGUucmVjdXJz aXZlQnVpbGRUcmFuc2FjdGlvbih0cmFuc2FjdGlvbik7CisKKyAgICB0cmFuc2FjdGlvbi5zZXRD cmVhdGVkTGF5ZXJzKHN0ZDo6bW92ZShtX2NyZWF0ZWRMYXllcnMpKTsKKyAgICB0cmFuc2FjdGlv bi5zZXREZXN0cm95ZWRMYXllcklEcyhzdGQ6Om1vdmUobV9kZXN0cm95ZWRMYXllcnMpKTsKIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==