129533 2014-02-28 20:20:34 -0800 Fix WebKit2 build after r164890 2014-02-28 21:28:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue simon.fraser oldest_to_newest 985839 0 jinwoo7.song 2014-02-28 20:20:34 -0800 LayerRepresentation.h is not used in non MAC or IOS port. [ 83%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/DrawingAreaProxy.cpp.o In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/DrawingAreaProxy.cpp:31:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.h:40:33: fatal error: LayerRepresentation.h: No such file or directory compilation terminated. In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebProcessProxy.h:37:0, from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebContext.h:45, from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/APIURLRequest.cpp:29: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.h:40:33: fatal error: LayerRepresentation.h: No such file or directory compilation terminated. make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/DrawingAreaProxy.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/APIURLRequest.cpp.o] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 985846 1 225528 jinwoo7.song 2014-02-28 20:24:06 -0800 Created attachment 225528 Patch 985853 2 225528 simon.fraser 2014-02-28 20:38:30 -0800 Comment on attachment 225528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225528&action=review > Source/WebKit2/ChangeLog:9 > + but it is not used in non MAC or IOS port. MAC -> Mac, IOS -> iOS > Source/WebKit2/UIProcess/WebPageProxy.h:97 > +#if PLATFORM(MAC) || PLATFORM(IOS) This should be #if PLATFORM(COCOA) 985856 3 225532 jinwoo7.song 2014-02-28 20:48:33 -0800 Created attachment 225532 Patch Applied Simon's comments. 985870 4 225532 commit-queue 2014-02-28 21:28:49 -0800 Comment on attachment 225532 Patch Clearing flags on attachment: 225532 Committed r164909: <http://trac.webkit.org/changeset/164909> 985871 5 commit-queue 2014-02-28 21:28:51 -0800 All reviewed patches have been landed. Closing bug. 225528 2014-02-28 20:24:06 -0800 2014-02-28 20:48:28 -0800 Patch bug-129533-20140301132357.patch text/plain 1519 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjA2MzRjM2FlOGEzNGNk NTkyNjEwY2E5MzMxZjY3MDY0MGUzZWRmOC4uMjU5Mzg3ZTFkNDZiNGIxNjgxNjYzN2Y2NTQ5Y2Rm YjYxMTk4Zjg3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggV2ViS2l0 MiBidWlsZCBhZnRlciByMTY0ODkwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjk1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBMYXllclJlcHJlc2VudGF0aW9uLmggaXMgaW5jbHVkZWQgdG8gV2ViUGFn ZVByb3h5LmggaW4gcjE2NDg5MAorICAgICAgICBidXQgaXQgaXMgbm90IHVzZWQgaW4gbm9uIE1B QyBvciBJT1MgcG9ydC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKwog MjAxNC0wMi0yOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXVtXSzJdIGhpZ2hsaWdodCByZWN0cyBzaG91bGQgbmV2ZXIgYmlnIGJpZ2dlciB0 aGFuIHRoZSB2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXgg ZDI1NDBlZjMyMGFkM2NkZjc0NDZhZWUxNGI4NDY4MzQ3MzU3MWZkYy4uMGI3Y2U1YjhmNWM0Njhh NzVlYzI0Zjg0NTQ1MTAxNzk5MGRhYjM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaApAQCAtMzcsNyArMzcsNiBAQAogI2luY2x1ZGUgIkVkaXRvclN0YXRlLmgiCiAj aW5jbHVkZSAiR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5oIgogI2lu Y2x1ZGUgIkludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLmgiCi0jaW5jbHVkZSAiTGF5 ZXJSZXByZXNlbnRhdGlvbi5oIgogI2luY2x1ZGUgIkxheWVyVHJlZUNvbnRleHQuaCIKICNpbmNs dWRlICJNZXNzYWdlU2VuZGVyLmgiCiAjaW5jbHVkZSAiTm90aWZpY2F0aW9uUGVybWlzc2lvblJl cXVlc3RNYW5hZ2VyUHJveHkuaCIKQEAgLTk1LDYgKzk0LDEwIEBACiAjaW5jbHVkZSA8RXZhcy5o PgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykKKyNpbmNsdWRl ICJMYXllclJlcHJlc2VudGF0aW9uLmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIEFQSSB7CiBjbGFz cyBMb2FkZXJDbGllbnQ7CiBjbGFzcyBQb2xpY3lDbGllbnQ7Cg== 225532 2014-02-28 20:48:33 -0800 2014-02-28 21:28:49 -0800 Patch bug-129533-20140301134824.patch text/plain 1502 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjA2MzRjM2FlOGEzNGNk NTkyNjEwY2E5MzMxZjY3MDY0MGUzZWRmOC4uMWYwNTljY2JlNTc4M2M3MzJhMDM3NGZhY2FmNWU2 NjJlNDBkNGQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggV2ViS2l0 MiBidWlsZCBhZnRlciByMTY0ODkwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjk1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIu CisKKyAgICAgICAgTGF5ZXJSZXByZXNlbnRhdGlvbi5oIGlzIGluY2x1ZGVkIHRvIFdlYlBhZ2VQ cm94eS5oIGluIHIxNjQ4OTAKKyAgICAgICAgYnV0IGl0IGlzIG5vdCB1c2VkIGluIG5vbiBNYWMg b3IgaU9TIHBvcnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisKIDIw MTQtMDItMjggIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPU11bV0syXSBoaWdobGlnaHQgcmVjdHMgc2hvdWxkIG5ldmVyIGJpZyBiaWdnZXIgdGhh biB0aGUgdmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IGQy NTQwZWYzMjBhZDNjZGY3NDQ2YWVlMTRiODQ2ODM0NzM1NzFmZGMuLmQxZTFkMTg2ODY5YzJjMWM4 NWVjNTViMTYzOWVjNDAzOWY3NDg4MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmgKQEAgLTM3LDcgKzM3LDYgQEAKICNpbmNsdWRlICJFZGl0b3JTdGF0ZS5oIgogI2lu Y2x1ZGUgIkdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuaCIKICNpbmNs dWRlICJJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oIgotI2luY2x1ZGUgIkxheWVy UmVwcmVzZW50YXRpb24uaCIKICNpbmNsdWRlICJMYXllclRyZWVDb250ZXh0LmgiCiAjaW5jbHVk ZSAiTWVzc2FnZVNlbmRlci5oIgogI2luY2x1ZGUgIk5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlclByb3h5LmgiCkBAIC05NSw2ICs5NCwxMCBAQAogI2luY2x1ZGUgPEV2YXMuaD4K ICNlbmRpZgogCisjaWYgUExBVEZPUk0oQ09DT0EpCisjaW5jbHVkZSAiTGF5ZXJSZXByZXNlbnRh dGlvbi5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBBUEkgewogY2xhc3MgTG9hZGVyQ2xpZW50Owog Y2xhc3MgUG9saWN5Q2xpZW50Owo=