129518 2014-02-28 16:42:36 -0800 Micro-optimize JSNodeOwner::isReachableFromOpaqueRoots(). 2014-02-28 17:05:54 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue kling oldest_to_newest 985775 0 kling 2014-02-28 16:42:36 -0800 We can reorder things a bit to avoid unnecessary work. 985778 1 225507 kling 2014-02-28 16:44:18 -0800 Created attachment 225507 Patch 985782 2 commit-queue 2014-02-28 16:46:48 -0800 Attachment 225507 did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSNodeCustom.cpp:112: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSNodeCustom.cpp:117: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 985787 3 kling 2014-02-28 17:05:54 -0800 Committed r164900: <http://trac.webkit.org/changeset/164900> 225507 2014-02-28 16:44:18 -0800 2014-02-28 16:46:51 -0800 Patch bug-129518.diff text/plain 2912 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZGE2ZjUxLi4zYzkwN2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDItMjggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIE1pY3JvLW9wdGltaXplIEpTTm9kZU93bmVyOjppc1JlYWNoYWJsZUZyb21PcGFxdWVSb290 cygpLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI5NTE4PgorCisgICAgICAgIE9u bHkgZG8gaW1hZ2UgYW5kIGF1ZGlvIGVsZW1lbnQgc3BlY2lmaWMgY2hlY2tzIGZvciBlbGVtZW50 IG5vZGVzLgorICAgICAgICBUaW1lIHNwZW50IGluIGhlcmUgZ29lcyBmcm9tIDAuOCUgdG8gMC41 JSBvbiBEWUVCLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz UmVhY2hhYmxlRnJvbURPTSk6CisKIDIwMTQtMDItMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hh bUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hYywgaU9TXSBJbmNvcnJlY3Qgb3JkZXJpbmcgb2Yg Y29uc3RydWN0aW9uIGFyZ3VtZW50cyBmb3Igb3V0LW9mLWJhbmQgdGV4dCBlbGVtZW50cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAKaW5kZXggZGMzYThmZS4u NzQ4MmEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2RlQ3Vz dG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3Bw CkBAIC05NywyMSArOTcsMjUgQEAgc3RhdGljIGlubGluZSBib29sIGlzT2JzZXJ2YWJsZShKU05v ZGUqIGpzTm9kZSwgTm9kZSogbm9kZSkKIHN0YXRpYyBpbmxpbmUgYm9vbCBpc1JlYWNoYWJsZUZy b21ET00oSlNOb2RlKiBqc05vZGUsIE5vZGUqIG5vZGUsIFNsb3RWaXNpdG9yJiB2aXNpdG9yKQog ewogICAgIGlmICghbm9kZS0+aW5Eb2N1bWVudCgpKSB7Ci0gICAgICAgIC8vIElmIGEgd3JhcHBl ciBpcyB0aGUgbGFzdCByZWZlcmVuY2UgdG8gYW4gaW1hZ2UgZWxlbWVudAotICAgICAgICAvLyB0 aGF0IGlzIGxvYWRpbmcgYnV0IG5vdCBpbiB0aGUgZG9jdW1lbnQsIHRoZSB3cmFwcGVyIGlzIG9i c2VydmFibGUKLSAgICAgICAgLy8gYmVjYXVzZSBpdCBpcyB0aGUgb25seSB0aGluZyBrZWVwaW5n IHRoZSBpbWFnZSBlbGVtZW50IGFsaXZlLCBhbmQgaWYKLSAgICAgICAgLy8gdGhlIGVsZW1lbnQg aXMgZGVzdHJveWVkLCBpdHMgbG9hZCBldmVudCB3aWxsIG5vdCBmaXJlLgotICAgICAgICAvLyBG SVhNRTogVGhlIERPTSBzaG91bGQgbWFuYWdlIHRoaXMgaXNzdWUgd2l0aG91dCB0aGUgaGVscCBv ZiBKYXZhU2NyaXB0IHdyYXBwZXJzLgotICAgICAgICBpZiAoaXNIVE1MSW1hZ2VFbGVtZW50KG5v ZGUpKSB7Ci0gICAgICAgICAgICBpZiAodG9IVE1MSW1hZ2VFbGVtZW50KG5vZGUpLT5oYXNQZW5k aW5nQWN0aXZpdHkoKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfQot ICAgICNpZiBFTkFCTEUoVklERU8pCi0gICAgICAgIGVsc2UgaWYgKGlzSFRNTEF1ZGlvRWxlbWVu dChub2RlKSkgewotICAgICAgICAgICAgaWYgKCF0b0hUTUxBdWRpb0VsZW1lbnQobm9kZSktPnBh dXNlZCgpKQotICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICBpZiAobm9kZS0+ aXNFbGVtZW50Tm9kZSgpKSB7CisgICAgICAgICAgICBhdXRvJiBlbGVtZW50ID0gdG9FbGVtZW50 KCpub2RlKTsKKworICAgICAgICAgICAgLy8gSWYgYSB3cmFwcGVyIGlzIHRoZSBsYXN0IHJlZmVy ZW5jZSB0byBhbiBpbWFnZSBlbGVtZW50CisgICAgICAgICAgICAvLyB0aGF0IGlzIGxvYWRpbmcg YnV0IG5vdCBpbiB0aGUgZG9jdW1lbnQsIHRoZSB3cmFwcGVyIGlzIG9ic2VydmFibGUKKyAgICAg ICAgICAgIC8vIGJlY2F1c2UgaXQgaXMgdGhlIG9ubHkgdGhpbmcga2VlcGluZyB0aGUgaW1hZ2Ug ZWxlbWVudCBhbGl2ZSwgYW5kIGlmCisgICAgICAgICAgICAvLyB0aGUgZWxlbWVudCBpcyBkZXN0 cm95ZWQsIGl0cyBsb2FkIGV2ZW50IHdpbGwgbm90IGZpcmUuCisgICAgICAgICAgICAvLyBGSVhN RTogVGhlIERPTSBzaG91bGQgbWFuYWdlIHRoaXMgaXNzdWUgd2l0aG91dCB0aGUgaGVscCBvZiBK YXZhU2NyaXB0IHdyYXBwZXJzLgorICAgICAgICAgICAgaWYgKGlzSFRNTEltYWdlRWxlbWVudChl bGVtZW50KSkgeworICAgICAgICAgICAgICAgIGlmICh0b0hUTUxJbWFnZUVsZW1lbnQoZWxlbWVu dCkuaGFzUGVuZGluZ0FjdGl2aXR5KCkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICAgICAgfQorICAgICAgICAjaWYgRU5BQkxFKFZJREVPKQorICAgICAgICAgICAg ZWxzZSBpZiAoaXNIVE1MQXVkaW9FbGVtZW50KGVsZW1lbnQpKSB7CisgICAgICAgICAgICAgICAg aWYgKCF0b0hUTUxBdWRpb0VsZW1lbnQoZWxlbWVudCkucGF1c2VkKCkpCisgICAgICAgICAgICAg ICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgICAgfQorICAgICAgICAjZW5kaWYKICAgICAg ICAgfQotICAgICNlbmRpZgogCiAgICAgICAgIC8vIElmIGEgbm9kZSBpcyBmaXJpbmcgZXZlbnQg bGlzdGVuZXJzLCBpdHMgd3JhcHBlciBpcyBvYnNlcnZhYmxlIGJlY2F1c2UKICAgICAgICAgLy8g aXRzIHdyYXBwZXIgaXMgcmVzcG9uc2libGUgZm9yIG1hcmtpbmcgdGhvc2UgZXZlbnQgbGlzdGVu ZXJzLgo=