129514 2014-02-28 16:08:26 -0800 [CSS Shapes] CSS parser accepts trailing position arguments 2014-03-14 14:59:07 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124173 1 betravis betravis commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard rhauck webkit-ews oldest_to_newest 985760 0 betravis 2014-02-28 16:08:26 -0800 The shapes parsing code is accepting shapes like 'circle(at 10px 10px closest-side)', and dropping the last arguments after the position. For example: var el = document.createElement('div'); el.style.setProperty('-webkit-shape-outside', 'circle(at 10px 10px closest-side)'); console.log(el.style.getPropertyValue('-webkit-shape-outside')); Logs 'circle(at 10px 10px)' 990128 1 226614 betravis 2014-03-13 12:43:06 -0700 Created attachment 226614 Initial Patch Port of patch originally authored by rwlbuis here https://codereview.chromium.org/191553003/ 990690 2 226614 commit-queue 2014-03-14 14:59:04 -0700 Comment on attachment 226614 Initial Patch Clearing flags on attachment: 226614 Committed r165655: <http://trac.webkit.org/changeset/165655> 990691 3 commit-queue 2014-03-14 14:59:07 -0700 All reviewed patches have been landed. Closing bug. 226614 2014-03-13 12:43:06 -0700 2014-03-14 14:59:03 -0700 Initial Patch bug-129514-20140313124243.patch text/plain 6052 betravis U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBjMzhmNTViN2Q0MmU5 OGYyNjZiN2FkODVjNzJhNDAxY2E5MzY3Yy4uMWI4YThmYTRjYjNhYmE3YjJlMTc3MTdjOGFhOWQ0 ZDNhN2RlOGU0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTEzICBCZWFy IFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIFNoYXBlc10gQ1NT IHBhcnNlciBhY2NlcHRzIHRyYWlsaW5nIHBvc2l0aW9uIGFyZ3VtZW50cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgY2hlY2sgdG8gbWFrZSBz dXJlIHRoZXJlIGFyZSBubyByZW1haW5pbmcgZnVuY3Rpb24gYXJncworICAgICAgICBmb2xsb3dp bmcgYSBwb3NpdGlvbiBpbiB0aGUgY2lyY2xlKCkgYW5kIGVsbGlwc2UoKSBjc3Mgc2hhcGUKKyAg ICAgICAgZnVuY3Rpb25zLgorCisgICAgICAgIFVwZGF0ZWQgZXhpc3RpbmcgcGFyc2luZyB0ZXN0 cy4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT UGFyc2VyOjpwYXJzZUJhc2ljU2hhcGVDaXJjbGUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFy c2VyOjpwYXJzZUJhc2ljU2hhcGVFbGxpcHNlKToKKwogMjAxNC0wMy0xMyAgUmFkdSBTdGF2aWxh ICA8c3RhdmlsYUBhZG9iZS5jb20+CiAKICAgICAgICAgV2Via2l0IG5vdCBidWlsZGluZyBvbiBY Q29kZSA1LjEgZHVlIHRvIGdhcmJhZ2UgY29sbGVjdGlvbiBubyBsb25nZXIgYmVpbmcgc3VwcG9y dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDI1YzgxMTQ1YTAzNGE5ZTQxNDYxNDUx MjVlM2RhMDhmZTRlM2Q0YmEuLmQxMTcxY2Q4YjJlODA1MzgxZjJjZWE2YzdjOGFkNDk3NjU3MDQ1 Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC01NTEwLDcgKzU1MTAsNyBAQCBQYXNz UmVmUHRyPENTU0Jhc2ljU2hhcGU+IENTU1BhcnNlcjo6cGFyc2VCYXNpY1NoYXBlQ2lyY2xlKENT U1BhcnNlclZhbHVlTGlzdCogYQogICAgICAgICAgICAgUmVmUHRyPENTU1ZhbHVlPiBjZW50ZXJZ OwogICAgICAgICAgICAgYXJncy0+bmV4dCgpOyAvLyBzZXQgbGlzdCB0byBzdGFydCBvZiBwb3Np dGlvbiBjZW50ZXIKICAgICAgICAgICAgIHBhcnNlRmlsbFBvc2l0aW9uKGFyZ3MsIGNlbnRlclgs IGNlbnRlclkpOwotICAgICAgICAgICAgaWYgKGNlbnRlclggJiYgY2VudGVyWSkgeworICAgICAg ICAgICAgaWYgKGNlbnRlclggJiYgY2VudGVyWSAmJiAhYXJncy0+Y3VycmVudCgpKSB7CiAgICAg ICAgICAgICAgICAgQVNTRVJUKGNlbnRlclgtPmlzUHJpbWl0aXZlVmFsdWUoKSk7CiAgICAgICAg ICAgICAgICAgQVNTRVJUKGNlbnRlclktPmlzUHJpbWl0aXZlVmFsdWUoKSk7CiAgICAgICAgICAg ICAgICAgc2hhcGUtPnNldENlbnRlclgodG9DU1NQcmltaXRpdmVWYWx1ZShjZW50ZXJYLmdldCgp KSk7CkBAIC01NTYxLDcgKzU1NjEsNyBAQCBQYXNzUmVmUHRyPENTU0Jhc2ljU2hhcGU+IENTU1Bh cnNlcjo6cGFyc2VCYXNpY1NoYXBlRWxsaXBzZShDU1NQYXJzZXJWYWx1ZUxpc3QqCiAgICAgICAg IFJlZlB0cjxDU1NWYWx1ZT4gY2VudGVyWTsKICAgICAgICAgYXJncy0+bmV4dCgpOyAvLyBzZXQg bGlzdCB0byBzdGFydCBvZiBwb3NpdGlvbiBjZW50ZXIKICAgICAgICAgcGFyc2VGaWxsUG9zaXRp b24oYXJncywgY2VudGVyWCwgY2VudGVyWSk7Ci0gICAgICAgIGlmICghY2VudGVyWCB8fCAhY2Vu dGVyWSkKKyAgICAgICAgaWYgKCFjZW50ZXJYIHx8ICFjZW50ZXJZIHx8IGFyZ3MtPmN1cnJlbnQo KSkKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIEFTU0VSVChjZW50ZXJYLT5pc1By aW1pdGl2ZVZhbHVlKCkpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZmNTVkMjUyNjBhOTZjYWU3YTRkMGEwNWIzMzJhZWQ0 YjQwMWMyYTIuLmIyMTNjOTY5YzY5MjVlMjExNDdkZWExZWUyN2FhMGU0MTVmNDgxMGQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAxNC0wMy0xMyAgQmVhciBUcmF2aXMgIDxiZXRyYXZpc0BhZG9i ZS5jb20+CisKKyAgICAgICAgW0NTUyBTaGFwZXNdIENTUyBwYXJzZXIgYWNjZXB0cyB0cmFpbGlu ZyBwb3NpdGlvbiBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyOTUxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCBhIHNoYXBlIHdpdGggYW4gYWRkaXRpb25hbCBhcmd1bWVudCB0cmFp bGluZyB0aGUgcG9zaXRpb24KKyAgICAgICAgaW4gdGhlIGNzcyBzaGFwZXMgZnVuY3Rpb25zLgor CisgICAgICAgICogZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWluc2lkZS1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW91 dHNpZGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2lu Zy10ZXN0LXV0aWxzLmpzOgorCiAyMDE0LTAzLTEzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSB1bnVzZWQgY2FsbElkIHBhcmFt ZXRlciBmcm9tIGV2YWx1YXRlSW5XZWJJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1pbnNpZGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWluc2lkZS1leHBl Y3RlZC50eHQKaW5kZXggNjU1N2ZmZWJlZjUyZTdlYzA3MDU4ZmMxNTJhYjNhZjNhMGY3ZDgyNi4u YThiN2Y5NjBmYjVmODVhNjlmNDlhY2I3Y2M1ZjE2Y2FlZDJhNTQ5YyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWluc2lkZS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBl LWluc2lkZS1leHBlY3RlZC50eHQKQEAgLTIwNSw2ICsyMDUsOCBAQCBQQVNTIGdldENTU1RleHQo Ii13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZShhdCAxMHB4IDEwcHggYXQgY2VudGVyKSIp IGlzICIiCiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUi LCAiY2lyY2xlKGF0IDEwcHggMTBweCBhdCBjZW50ZXIpIikgaXMgIm5vbmUiCiBQQVNTIGdldENT U1RleHQoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZShhdCBjZW50ZXIgY2VudGVyIDEw cHgpIikgaXMgIiIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Via2l0LXNoYXBlLWlu c2lkZSIsICJjaXJjbGUoYXQgY2VudGVyIGNlbnRlciAxMHB4KSIpIGlzICJub25lIgorUEFTUyBn ZXRDU1NUZXh0KCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJjaXJjbGUoYXQgMTBweCAxMHB4IGNs b3Nlc3Qtc2lkZSkiKSBpcyAiIgorUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQt c2hhcGUtaW5zaWRlIiwgImNpcmNsZShhdCAxMHB4IDEwcHggY2xvc2VzdC1zaWRlKSIpIGlzICJu b25lIgogUEFTUyBnZXRDU1NUZXh0KCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJlbGxpcHNlKDEw cHggMjBweCAzMHB4KSIpIGlzICIiCiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtp dC1zaGFwZS1pbnNpZGUiLCAiZWxsaXBzZSgxMHB4IDIwcHggMzBweCkiKSBpcyAibm9uZSIKIFBB U1MgZ2V0Q1NTVGV4dCgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiZWxsaXBzZSgxMHB4IGF0IDEw cHggMTBweCAxMHB4KSIpIGlzICIiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBl cy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtb3V0c2lkZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtb3V0c2lkZS1leHBlY3RlZC50eHQK aW5kZXggYTc5Y2Y2NWZmNzc1NjMyMzg0NTViNDc5OWJmY2U0MmYzZmFlMDJlYS4uYTZlZjE2NzI2 NTEwOTg0NTVmNjE4NDA5ZThkODBhZDg1MTRhYWJjMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW91dHNpZGUtZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1vdXRzaWRl LWV4cGVjdGVkLnR4dApAQCAtMjAzLDYgKzIwMyw4IEBAIFBBU1MgZ2V0Q1NTVGV4dCgiLXdlYmtp dC1zaGFwZS1vdXRzaWRlIiwgImNpcmNsZShhdCAxMHB4IDEwcHggYXQgY2VudGVyKSIpIGlzICIi CiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgImNp cmNsZShhdCAxMHB4IDEwcHggYXQgY2VudGVyKSIpIGlzICJub25lIgogUEFTUyBnZXRDU1NUZXh0 KCItd2Via2l0LXNoYXBlLW91dHNpZGUiLCAiY2lyY2xlKGF0IGNlbnRlciBjZW50ZXIgMTBweCki KSBpcyAiIgogUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtb3V0c2lk ZSIsICJjaXJjbGUoYXQgY2VudGVyIGNlbnRlciAxMHB4KSIpIGlzICJub25lIgorUEFTUyBnZXRD U1NUZXh0KCItd2Via2l0LXNoYXBlLW91dHNpZGUiLCAiY2lyY2xlKGF0IDEwcHggMTBweCBjbG9z ZXN0LXNpZGUpIikgaXMgIiIKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Via2l0LXNo YXBlLW91dHNpZGUiLCAiY2lyY2xlKGF0IDEwcHggMTBweCBjbG9zZXN0LXNpZGUpIikgaXMgIm5v bmUiCiBQQVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIsICJlbGxpcHNlKDEw cHggMjBweCAzMHB4KSIpIGlzICIiCiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtp dC1zaGFwZS1vdXRzaWRlIiwgImVsbGlwc2UoMTBweCAyMHB4IDMwcHgpIikgaXMgIm5vbmUiCiBQ QVNTIGdldENTU1RleHQoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIsICJlbGxpcHNlKDEwcHggYXQg MTBweCAxMHB4IDEwcHgpIikgaXMgIiIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hh cGVzL3BhcnNpbmcvcGFyc2luZy10ZXN0LXV0aWxzLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFw ZXMvcGFyc2luZy9wYXJzaW5nLXRlc3QtdXRpbHMuanMKaW5kZXggN2I3MzgzNzY2NDZlOTg5ZWMy NDQyNmU3OTE5MzMwNDQyYzdjMTcwYy4uNmZkNzkzODgxZjA1NDBlNGRjOWM5NzRjMTQ3MjY1MTg3 N2UyOWVkNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJz aW5nLXRlc3QtdXRpbHMuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9w YXJzaW5nLXRlc3QtdXRpbHMuanMKQEAgLTExOCw2ICsxMTgsNyBAQCB2YXIgaW52YWxpZFNoYXBl VmFsdWVzID0gWwogICAgICJjaXJjbGUoYXQgMTBweCAxMHB4IDEwcHgpIiwKICAgICAiY2lyY2xl KGF0IDEwcHggMTBweCBhdCBjZW50ZXIpIiwKICAgICAiY2lyY2xlKGF0IGNlbnRlciBjZW50ZXIg MTBweCkiLAorICAgICJjaXJjbGUoYXQgMTBweCAxMHB4IGNsb3Nlc3Qtc2lkZSkiLAogCiAgICAg ImVsbGlwc2UoMTBweCAyMHB4IDMwcHgpIiwKICAgICAiZWxsaXBzZSgxMHB4IGF0IDEwcHggMTBw eCAxMHB4KSIsCg==