129513 2014-02-28 16:04:37 -0800 Use range-based loops where possible in Heap methods 2014-03-08 15:13:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue darin oldest_to_newest 985759 0 mhahnenberg 2014-02-28 16:04:37 -0800 The future is now! 987117 1 225854 mhahnenberg 2014-03-04 21:54:20 -0800 Created attachment 225854 Patch 987123 2 225854 mark.lam 2014-03-04 22:03:57 -0800 Comment on attachment 225854 Patch r=me 987271 3 225854 commit-queue 2014-03-05 08:40:41 -0800 Comment on attachment 225854 Patch Clearing flags on attachment: 225854 Committed r165109: <http://trac.webkit.org/changeset/165109> 987272 4 commit-queue 2014-03-05 08:40:43 -0800 All reviewed patches have been landed. Closing bug. 988644 5 225854 darin 2014-03-08 15:12:01 -0800 Comment on attachment 225854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225854&action=review > Source/JavaScriptCore/heap/Heap.cpp:572 > + for (auto pair : m_protectedValues) This need to be auto& pair, otherwise it will copy the pair and work on the copy. Very bad!!! > Source/JavaScriptCore/heap/Heap.cpp:585 > + for (auto vector : m_tempSortingVectors) { > + for (auto valueStringPair : *vector) { Same thing. Needs to be auto&. > Source/JavaScriptCore/heap/Heap.h:454 > + for (auto pair : m_protectedValues) Same thing. Needs to be auto&. 988645 6 darin 2014-03-08 15:13:12 -0800 Looks like Anders fixed it in bug 129745. 225854 2014-03-04 21:54:20 -0800 2014-03-08 15:12:01 -0800 Patch bug-129513-20140304215420.patch text/plain 6438 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1MDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE0LTAzLTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgVXNlIHJhbmdlLWJhc2VkIGxvb3BzIHdoZXJlIHBvc3NpYmxlIGluIEhlYXAgbWV0 aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5 NTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVw bGFjZSBvbGQgc2Nob29sIGl0ZXJhdG9yIGJhc2VkIGxvb3BzIHdpdGggdGhlIG5ldyByYW5nZS1i YXNlZCBsb29wIGhvdG5lc3MKKyAgICAgICAgZm9yIGEgYmV0dGVyIHRvbW9ycm93LgorCisgICAg ICAgICogaGVhcC9Db2RlQmxvY2tTZXQuY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2tTZXQ6 On5Db2RlQmxvY2tTZXQpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2tTZXQ6OmNsZWFyTWFya3Mp OgorICAgICAgICAoSlNDOjpDb2RlQmxvY2tTZXQ6OmRlbGV0ZVVubWFya2VkQW5kVW5yZWZlcmVu Y2VkKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrU2V0Ojp0cmFjZU1hcmtlZCk6CisgICAgICAg ICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6dmlzaXRQcm90ZWN0ZWRPYmpl Y3RzKToKKyAgICAgICAgKEpTQzo6SGVhcDo6dmlzaXRUZW1wU29ydFZlY3RvcnMpOgorICAgICAg ICAoSlNDOjpIZWFwOjpjbGVhclJlbWVtYmVyZWRTZXQpOgorICAgICAgICAqIGhlYXAvSGVhcC5o OgorICAgICAgICAoSlNDOjpIZWFwOjpmb3JFYWNoUHJvdGVjdGVkQ2VsbCk6CisKIDIwMTQtMDMt MDQgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgSW5zcGVjdG9yIGRv ZXMgbm90IHJlc3RvcmUgYnJlYWtwb2ludHMgYWZ0ZXIgYSBwYWdlIHJlbG9hZApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29kZUJsb2NrU2V0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxvY2tTZXQuY3BwCShyZXZpc2lvbiAxNjUw OTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxvY2tTZXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MSwxMCArNDEsOCBAQCBDb2RlQmxvY2tTZXQ6OkNvZGVCbG9ja1NldChC bG9ja0FsbG9jYXRvCiAKIENvZGVCbG9ja1NldDo6fkNvZGVCbG9ja1NldCgpCiB7Ci0gICAgSGFz aFNldDxDb2RlQmxvY2sqPjo6aXRlcmF0b3IgaXRlciA9IG1fc2V0LmJlZ2luKCk7Ci0gICAgSGFz aFNldDxDb2RlQmxvY2sqPjo6aXRlcmF0b3IgZW5kID0gbV9zZXQuZW5kKCk7Ci0gICAgZm9yICg7 IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCi0gICAgICAgICgqaXRlciktPmRlcmVmKCk7CisgICAgZm9y IChDb2RlQmxvY2sqIGNvZGVCbG9jayA6IG1fc2V0KQorICAgICAgICBjb2RlQmxvY2stPmRlcmVm KCk7CiB9CiAKIHZvaWQgQ29kZUJsb2NrU2V0OjphZGQoUGFzc1JlZlB0cjxDb2RlQmxvY2s+IGNv ZGVCbG9jaykKQEAgLTU2LDEwICs1NCw3IEBAIHZvaWQgQ29kZUJsb2NrU2V0OjphZGQoUGFzc1Jl ZlB0cjxDb2RlQmwKIAogdm9pZCBDb2RlQmxvY2tTZXQ6OmNsZWFyTWFya3MoKQogewotICAgIEhh c2hTZXQ8Q29kZUJsb2NrKj46Oml0ZXJhdG9yIGl0ZXIgPSBtX3NldC5iZWdpbigpOwotICAgIEhh c2hTZXQ8Q29kZUJsb2NrKj46Oml0ZXJhdG9yIGVuZCA9IG1fc2V0LmVuZCgpOwotICAgIGZvciAo OyBpdGVyICE9IGVuZDsgKytpdGVyKSB7Ci0gICAgICAgIENvZGVCbG9jayogY29kZUJsb2NrID0g Kml0ZXI7CisgICAgZm9yIChDb2RlQmxvY2sqIGNvZGVCbG9jayA6IG1fc2V0KSB7CiAgICAgICAg IGNvZGVCbG9jay0+bV9tYXlCZUV4ZWN1dGluZyA9IGZhbHNlOwogICAgICAgICBjb2RlQmxvY2st Pm1fdmlzaXRBZ2dyZWdhdGVIYXNCZWVuQ2FsbGVkID0gZmFsc2U7CiAgICAgfQpAQCAtNzUsMTAg KzcwLDcgQEAgdm9pZCBDb2RlQmxvY2tTZXQ6OmRlbGV0ZVVubWFya2VkQW5kVW5yZQogICAgIGlm ICh2ZXJib3NlKQogICAgICAgICBkYXRhTG9nKCJGaXhwb2ludGluZyBvdmVyIHVubWFya2VkLCBz ZXQgc2l6ZSA9ICIsIG1fc2V0LnNpemUoKSwgIi4uLlxuIik7CiAgICAgZm9yICg7OykgewotICAg ICAgICBIYXNoU2V0PENvZGVCbG9jayo+OjppdGVyYXRvciBpdGVyID0gbV9zZXQuYmVnaW4oKTsK LSAgICAgICAgSGFzaFNldDxDb2RlQmxvY2sqPjo6aXRlcmF0b3IgZW5kID0gbV9zZXQuZW5kKCk7 Ci0gICAgICAgIGZvciAoOyBpdGVyICE9IGVuZDsgKytpdGVyKSB7Ci0gICAgICAgICAgICBDb2Rl QmxvY2sqIGNvZGVCbG9jayA9ICppdGVyOworICAgICAgICBmb3IgKENvZGVCbG9jayogY29kZUJs b2NrIDogbV9zZXQpIHsKICAgICAgICAgICAgIGlmICghY29kZUJsb2NrLT5oYXNPbmVSZWYoKSkK ICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIGlmIChjb2RlQmxvY2stPm1f bWF5QmVFeGVjdXRpbmcpCkBAIC05MCw4ICs4Miw4IEBAIHZvaWQgQ29kZUJsb2NrU2V0OjpkZWxl dGVVbm1hcmtlZEFuZFVucmUKICAgICAgICAgICAgIGRhdGFMb2coIiAgICBSZW1vdmluZyAiLCB0 b1JlbW92ZS5zaXplKCksICIgYmxvY2tzLlxuIik7CiAgICAgICAgIGlmICh0b1JlbW92ZS5pc0Vt cHR5KCkpCiAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gdG9S ZW1vdmUuc2l6ZSgpOyBpLS07KQotICAgICAgICAgICAgbV9zZXQucmVtb3ZlKHRvUmVtb3ZlW2ld KTsKKyAgICAgICAgZm9yIChDb2RlQmxvY2sqIGNvZGVCbG9jayA6IHRvUmVtb3ZlKQorICAgICAg ICAgICAgbV9zZXQucmVtb3ZlKGNvZGVCbG9jayk7CiAgICAgICAgIHRvUmVtb3ZlLnJlc2l6ZSgw KTsKICAgICB9CiB9CkBAIC0xMDYsMTAgKzk4LDcgQEAgdm9pZCBDb2RlQmxvY2tTZXQ6OnRyYWNl TWFya2VkKFNsb3RWaXNpdAogewogICAgIGlmICh2ZXJib3NlKQogICAgICAgICBkYXRhTG9nKCJU cmFjaW5nICIsIG1fc2V0LnNpemUoKSwgIiBjb2RlIGJsb2Nrcy5cbiIpOwotICAgIEhhc2hTZXQ8 Q29kZUJsb2NrKj46Oml0ZXJhdG9yIGl0ZXIgPSBtX3NldC5iZWdpbigpOwotICAgIEhhc2hTZXQ8 Q29kZUJsb2NrKj46Oml0ZXJhdG9yIGVuZCA9IG1fc2V0LmVuZCgpOwotICAgIGZvciAoOyBpdGVy ICE9IGVuZDsgKytpdGVyKSB7Ci0gICAgICAgIENvZGVCbG9jayogY29kZUJsb2NrID0gKml0ZXI7 CisgICAgZm9yIChDb2RlQmxvY2sqIGNvZGVCbG9jayA6IG1fc2V0KSB7CiAgICAgICAgIGlmICgh Y29kZUJsb2NrLT5tX21heUJlRXhlY3V0aW5nKQogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIGNvZGVCbG9jay0+dmlzaXRBZ2dyZWdhdGUodmlzaXRvcik7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTY1MDkxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2OCw5ICs1NjgsOSBAQCB2 b2lkIEhlYXA6OnZpc2l0UHJvdGVjdGVkT2JqZWN0cyhIZWFwUm9vCiB7CiAgICAgR0NQSEFTRShW aXNpdFByb3RlY3RlZE9iamVjdHMpOwogICAgIE1BUktfTE9HX1JPT1QobV9zbG90VmlzaXRvciwg IlByb3RlY3RlZCBPYmplY3RzIik7Ci0gICAgUHJvdGVjdENvdW50U2V0OjppdGVyYXRvciBlbmQg PSBtX3Byb3RlY3RlZFZhbHVlcy5lbmQoKTsKLSAgICBmb3IgKFByb3RlY3RDb3VudFNldDo6aXRl cmF0b3IgaXQgPSBtX3Byb3RlY3RlZFZhbHVlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCi0g ICAgICAgIGhlYXBSb290VmlzaXRvci52aXNpdCgmaXQtPmtleSk7CisKKyAgICBmb3IgKGF1dG8g cGFpciA6IG1fcHJvdGVjdGVkVmFsdWVzKQorICAgICAgICBoZWFwUm9vdFZpc2l0b3IudmlzaXQo JnBhaXIua2V5KTsKICAgICBtX3Nsb3RWaXNpdG9yLmRvbmF0ZUFuZERyYWluKCk7CiB9CiAKQEAg LTU4MSwxNCArNTgxLDEwIEBAIHZvaWQgSGVhcDo6dmlzaXRUZW1wU29ydFZlY3RvcnMoSGVhcFJv b3QKIAogICAgIHR5cGVkZWYgVmVjdG9yPFZlY3RvcjxWYWx1ZVN0cmluZ1BhaXIsIDAsIFVuc2Fm ZVZlY3Rvck92ZXJmbG93PiogPiBWZWN0b3JPZlZhbHVlU3RyaW5nVmVjdG9yczsKIAotICAgIFZl Y3Rvck9mVmFsdWVTdHJpbmdWZWN0b3JzOjppdGVyYXRvciBlbmQgPSBtX3RlbXBTb3J0aW5nVmVj dG9ycy5lbmQoKTsKLSAgICBmb3IgKFZlY3Rvck9mVmFsdWVTdHJpbmdWZWN0b3JzOjppdGVyYXRv ciBpdCA9IG1fdGVtcFNvcnRpbmdWZWN0b3JzLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewot ICAgICAgICBWZWN0b3I8VmFsdWVTdHJpbmdQYWlyLCAwLCBVbnNhZmVWZWN0b3JPdmVyZmxvdz4q IHRlbXBTb3J0aW5nVmVjdG9yID0gKml0OwotCi0gICAgICAgIFZlY3RvcjxWYWx1ZVN0cmluZ1Bh aXI+OjppdGVyYXRvciB2ZWN0b3JFbmQgPSB0ZW1wU29ydGluZ1ZlY3Rvci0+ZW5kKCk7Ci0gICAg ICAgIGZvciAoVmVjdG9yPFZhbHVlU3RyaW5nUGFpcj46Oml0ZXJhdG9yIHZlY3Rvckl0ID0gdGVt cFNvcnRpbmdWZWN0b3ItPmJlZ2luKCk7IHZlY3Rvckl0ICE9IHZlY3RvckVuZDsgKyt2ZWN0b3JJ dCkgewotICAgICAgICAgICAgaWYgKHZlY3Rvckl0LT5maXJzdCkKLSAgICAgICAgICAgICAgICBo ZWFwUm9vdFZpc2l0b3IudmlzaXQoJnZlY3Rvckl0LT5maXJzdCk7CisgICAgZm9yIChhdXRvIHZl Y3RvciA6IG1fdGVtcFNvcnRpbmdWZWN0b3JzKSB7CisgICAgICAgIGZvciAoYXV0byB2YWx1ZVN0 cmluZ1BhaXIgOiAqdmVjdG9yKSB7CisgICAgICAgICAgICBpZiAodmFsdWVTdHJpbmdQYWlyLmZp cnN0KQorICAgICAgICAgICAgICAgIGhlYXBSb290VmlzaXRvci52aXNpdCgmdmFsdWVTdHJpbmdQ YWlyLmZpcnN0KTsKICAgICAgICAgfQogICAgIH0KICAgICBtX3Nsb3RWaXNpdG9yLmRvbmF0ZUFu ZERyYWluKCk7CkBAIC02NzIsMTAgKzY2OCw4IEBAIHZvaWQgSGVhcDo6Y2xlYXJSZW1lbWJlcmVk U2V0KFZlY3Rvcjxjb24KIHsKICNpZiBFTkFCTEUoR0dDKQogICAgIEdDUEhBU0UoQ2xlYXJSZW1l bWJlcmVkU2V0KTsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcmVtZW1iZXJlZFNldC5z aXplKCk7ICsraSkgewotICAgICAgICBjb25zdCBKU0NlbGwqIGNlbGwgPSByZW1lbWJlcmVkU2V0 W2ldOworICAgIGZvciAoYXV0byBjZWxsIDogcmVtZW1iZXJlZFNldCkKICAgICAgICAgTWFya2Vk QmxvY2s6OmJsb2NrRm9yKGNlbGwpLT5jbGVhclJlbWVtYmVyZWQoY2VsbCk7Ci0gICAgfQogI2Vs c2UKICAgICBVTlVTRURfUEFSQU0ocmVtZW1iZXJlZFNldCk7CiAjZW5kaWYKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9IZWFwLmgJKHJldmlzaW9uIDE2NTA5MSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL0hlYXAuaAkod29ya2luZyBjb3B5KQpAQCAtNDUxLDkgKzQ1MSw4IEBAIG5h bWVzcGFjZSBKU0MgewogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rvcj4gaW5saW5lIHR5 cGVuYW1lIEZ1bmN0b3I6OlJldHVyblR5cGUgSGVhcDo6Zm9yRWFjaFByb3RlY3RlZENlbGwoRnVu Y3RvciYgZnVuY3RvcikKICAgICB7Ci0gICAgICAgIFByb3RlY3RDb3VudFNldDo6aXRlcmF0b3Ig ZW5kID0gbV9wcm90ZWN0ZWRWYWx1ZXMuZW5kKCk7Ci0gICAgICAgIGZvciAoUHJvdGVjdENvdW50 U2V0OjppdGVyYXRvciBpdCA9IG1fcHJvdGVjdGVkVmFsdWVzLmJlZ2luKCk7IGl0ICE9IGVuZDsg KytpdCkKLSAgICAgICAgICAgIGZ1bmN0b3IoaXQtPmtleSk7CisgICAgICAgIGZvciAoYXV0byBw YWlyIDogbV9wcm90ZWN0ZWRWYWx1ZXMpCisgICAgICAgICAgICBmdW5jdG9yKHBhaXIua2V5KTsK ICAgICAgICAgbV9oYW5kbGVTZXQuZm9yRWFjaFN0cm9uZ0hhbmRsZShmdW5jdG9yLCBtX3Byb3Rl Y3RlZFZhbHVlcyk7CiAKICAgICAgICAgcmV0dXJuIGZ1bmN0b3IucmV0dXJuVmFsdWUoKTsK