129509 2014-02-28 15:19:38 -0800 Turn off margin tiles on iOS 2014-02-28 15:48:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin benjamin jonlee simon.fraser oldest_to_newest 985736 0 bdakin 2014-02-28 15:19:38 -0800 We should turn off margin tiles on iOS because they use a lot of memory. <rdar://problem/16200383> 985742 1 225497 bdakin 2014-02-28 15:23:35 -0800 Created attachment 225497 Patch 985748 2 225497 simon.fraser 2014-02-28 15:26:27 -0800 Comment on attachment 225497 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225497&action=review > Source/WebCore/page/FrameView.cpp:2467 > + // We don't support margin tiles on iOS because they use too much memory. We might support them > + // in the future if we can find a way to make them more efficient. A bit TMI I think. You could reference a radar here. 985756 3 bdakin 2014-02-28 15:48:18 -0800 Thanks, Simon! http://trac.webkit.org/changeset/164891 225497 2014-02-28 15:23:35 -0800 2014-02-28 15:26:27 -0800 Patch for-review.txt text/plain 1512 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDg4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUdXJuIG9mZiBtYXJnaW4gdGlsZXMg b24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjk1MDkKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTYyMDAzODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6 Om5lZWRzRXh0ZW5kZWRCYWNrZ3JvdW5kUmVjdEZvclBhaW50aW5nKToKKwogMjAxNC0wMi0yOCAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1YnBpeGVsIHJlbmRl cmluZzogQWRkIHN1YnBpeGVsIHN1cHBvcnQgdG8gYm9yZGVyIHR5cGUgb2YgZG91YmxlLCBncm9v dmUsIHJpZGdlLCBpbnNldCBhbmQgb3V0c2V0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAkocmV2aXNpb24gMTY0ODc3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYyLDYgKzI0NjIsMTIgQEAgYm9vbCBGcmFtZVZpZXc6 Om5lZWRzRXh0ZW5kZWRCYWNrZ3JvdW5kUgogICAgIC8vIHN1Y2ggYXMgaW1hZ2VzLCByZXF1aXJl IGV4dGVuZGluZyB0aGUgYmFja2dyb3VuZCByZWN0IHRvIGNvbnRpbnVlIHBhaW50aW5nIGludG8g dGhlIGV4dGVuZGVkCiAgICAgLy8gcmVnaW9uLiBUaGlzIGZ1bmN0aW9uIGZpbmRzIG91dCBpZiBp dCBpcyBuZWNlc3NhcnkgdG8gZXh0ZW5kIHRoZSBiYWNrZ3JvdW5kIHJlY3QgZm9yIHBhaW50aW5n LgogCisjaWYgUExBVEZPUk0oSU9TKQorICAgIC8vIFdlIGRvbid0IHN1cHBvcnQgbWFyZ2luIHRp bGVzIG9uIGlPUyBiZWNhdXNlIHRoZXkgdXNlIHRvbyBtdWNoIG1lbW9yeS4gV2UgbWlnaHQgc3Vw cG9ydCB0aGVtCisgICAgLy8gaW4gdGhlIGZ1dHVyZSBpZiB3ZSBjYW4gZmluZCBhIHdheSB0byBt YWtlIHRoZW0gbW9yZSBlZmZpY2llbnQuCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCisKICAg ICBpZiAoIWZyYW1lKCkuc2V0dGluZ3MoKS5iYWNrZ3JvdW5kU2hvdWxkRXh0ZW5kQmV5b25kUGFn ZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK