129506 2014-02-28 13:42:52 -0800 Web Inspector: ObjC exception opening the Web Inspector in Production / nightly builds 2014-02-28 14:46:14 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 985699 0 timothy 2014-02-28 13:42:52 -0800 <rdar://problem/16199363> 985700 1 timothy 2014-02-28 13:43:06 -0800 ObjC exception: -[NSURL initFileURLWithPath:]: nil string parameter 985702 2 225488 timothy 2014-02-28 13:48:46 -0800 Created attachment 225488 Patch 985710 3 225488 joepeck 2014-02-28 14:14:37 -0800 Comment on attachment 225488 Patch Looks fine. r=me 985716 4 225488 commit-queue 2014-02-28 14:46:12 -0800 Comment on attachment 225488 Patch Clearing flags on attachment: 225488 Committed r164884: <http://trac.webkit.org/changeset/164884> 985717 5 commit-queue 2014-02-28 14:46:14 -0800 All reviewed patches have been landed. Closing bug. 225488 2014-02-28 13:48:46 -0800 2014-02-28 14:46:12 -0800 Patch bug-129506-20140228134845.patch text/plain 5985 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggODIzZmM0OWUy NDZmYWIzYmRhNDMxMDQ5NzEwM2E1MzRkMWRkZmVlZi4uY2UwMzFiYmMwNTFiYWNjYTA1MmVkYTAz YmFhMDZlYzI4YjBlYTNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0 LTAyLTI4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBQ cm9wZXJseSBoYW5kbGUgd2hlbiBUZXN0Lmh0bWwgaXMgbm90IHByZXNlbnQgaW4gUHJvZHVjdGlv biBidWlsZHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyOTUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tOgorICAgICAgICAoLVtX ZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIGluc3BlY3RvclRlc3RQYWdlUGF0aF0pOgorICAg ICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIHdlYlZpZXc6ZGVjaWRlUG9saWN5 Rm9yTmF2aWdhdGlvbkFjdGlvbjpyZXF1ZXN0OmZyYW1lOmRlY2lzaW9uTGlzdGVuZXI6XSk6CisK IDIwMTQtMDItMjcgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogbW9kZWwgdGVzdHMgc2hvdWxkIHVzZSBhIHNwZWNpYWwgVGVzdC5odG1sIGlu c3BlY3RvciBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmIxOWE0YTMxMDE0ZTMyYWJiOGU2MjRkZjY0NDFl NTQxOGQ0N2U0Ni4uZWUzNmE5Yjg2NmNlYmNjYzkzMTJjODQ2MTVkOTJlOGY3ODc2NDBjMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTI4ICBUaW1vdGh5IEhhdGNoZXIgIDx0 aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9wZXJseSBoYW5kbGUgd2hlbiBUZXN0Lmh0 bWwgaXMgbm90IHByZXNlbnQgaW4gUHJvZHVjdGlvbiBidWlsZHMuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTUwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3Rv clByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6aXNNYWluT3JUZXN0SW5zcGVjdG9yUGFnZSk6 CisgICAgICAgICogVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAg ICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclRlc3RQYWdlVVJMKToKKwog MjAxNC0wMi0yOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTY0ODMyLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tIGIvU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCmluZGV4IDYx Y2U2OTU2OWNhZmE3MThhOTVmN2IyODAxNzMyMWMzZTk3OGY0ZTMuLmYxMzZhMTA2Nzk3Mjc2M2U3 NWZjMjgzZDNhMWJhNTA4Y2E2MzI4MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dl YkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21h Yy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0KQEAgLTQ2NCw3ICs0NjQsMTEg QEAgLSAoTlNTdHJpbmcgKilpbnNwZWN0b3JUZXN0UGFnZVBhdGgKICAgICBXZWJJbnNwZWN0b3JV SUxpYnJhcnkoKTsKIAogICAgIE5TU3RyaW5nICpwYXRoID0gW1tOU0J1bmRsZSBidW5kbGVXaXRo SWRlbnRpZmllcjpAImNvbS5hcHBsZS5XZWJJbnNwZWN0b3JVSSJdIHBhdGhGb3JSZXNvdXJjZTpA IlRlc3QiIG9mVHlwZTpAImh0bWwiXTsKLSAgICBBU1NFUlQoW3BhdGggbGVuZ3RoXSk7CisKKyAg ICAvLyBXZSBtaWdodCBub3QgaGF2ZSBhIFRlc3QuaHRtbCBpbiBQcm9kdWN0aW9uIGJ1aWxkcy4K KyAgICBpZiAoIXBhdGgpCisgICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gcGF0aDsK IH0KIApAQCAtNzYzLDcgKzc2Nyw4IEBAIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXdlYlZp ZXcgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjooTlNEaWN0aW9uYXJ5CiAgICAgfQog CiAgICAgLy8gQWxsb3cgbG9hZGluZyBvZiB0aGUgdGVzdCBpbnNwZWN0b3IgZmlsZS4KLSAgICBp ZiAoW1tyZXF1ZXN0IFVSTF0gaXNGaWxlVVJMXSAmJiBbW1tyZXF1ZXN0IFVSTF0gcGF0aF0gaXNF cXVhbFRvU3RyaW5nOltzZWxmIGluc3BlY3RvclRlc3RQYWdlUGF0aF1dKSB7CisgICAgTlNTdHJp bmcgKnRlc3RQYWdlUGF0aCA9IFtzZWxmIGluc3BlY3RvclRlc3RQYWdlUGF0aF07CisgICAgaWYg KHRlc3RQYWdlUGF0aCAmJiBbW3JlcXVlc3QgVVJMXSBpc0ZpbGVVUkxdICYmIFtbW3JlcXVlc3Qg VVJMXSBwYXRoXSBpc0VxdWFsVG9TdHJpbmc6dGVzdFBhZ2VQYXRoXSkgewogICAgICAgICBbbGlz dGVuZXIgdXNlXTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCmluZGV4IDliOWM5OGRhZjBhMmFkYjc5NDkw ZTlhMjdmMWMzYjNiYjhkNTNmNTIuLmYxMzVhMTliMGU2OTNlYWFhMjcyODRjZmE1MzEyYTg0NjMw YmQ5N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5 LmNwcApAQCAtMzY0LDE3ICszNjQsMjQgQEAgYm9vbCBXZWJJbnNwZWN0b3JQcm94eTo6aXNJbnNw ZWN0b3JQYWdlKFdlYlBhZ2VQcm94eSYgcGFnZSkKIAogc3RhdGljIGJvb2wgaXNNYWluT3JUZXN0 SW5zcGVjdG9yUGFnZShjb25zdCBXZWJJbnNwZWN0b3JQcm94eSogd2ViSW5zcGVjdG9yUHJveHks IFdLVVJMUmVxdWVzdFJlZiByZXF1ZXN0UmVmKQogewotICAgIC8vIFVzZSBVUkwgc28gd2UgY2Fu IGNvbXBhcmUganVzdCB0aGUgcGF0aHMuCi0gICAgVVJMIG1haW5QYWdlVVJMKFVSTCgpLCB3ZWJJ bnNwZWN0b3JQcm94eS0+aW5zcGVjdG9yUGFnZVVSTCgpKTsKLSAgICBVUkwgdGVzdFBhZ2VVUkwo VVJMKCksIHdlYkluc3BlY3RvclByb3h5LT5pbnNwZWN0b3JUZXN0UGFnZVVSTCgpKTsKICAgICBV UkwgcmVxdWVzdFVSTChVUkwoKSwgdG9JbXBsKHJlcXVlc3RSZWYpLT5yZXNvdXJjZVJlcXVlc3Qo KS51cmwoKSk7CisgICAgaWYgKCFXZWJDb3JlOjpTY2hlbWVSZWdpc3RyeTo6c2hvdWxkVHJlYXRV UkxTY2hlbWVBc0xvY2FsKHJlcXVlc3RVUkwucHJvdG9jb2woKSkpCisgICAgICAgIHJldHVybiBm YWxzZTsKIAorICAgIC8vIFVzZSBVUkwgc28gd2UgY2FuIGNvbXBhcmUganVzdCB0aGUgcGF0aHMu CisgICAgVVJMIG1haW5QYWdlVVJMKFVSTCgpLCB3ZWJJbnNwZWN0b3JQcm94eS0+aW5zcGVjdG9y UGFnZVVSTCgpKTsKICAgICBBU1NFUlQoV2ViQ29yZTo6U2NoZW1lUmVnaXN0cnk6OnNob3VsZFRy ZWF0VVJMU2NoZW1lQXNMb2NhbChtYWluUGFnZVVSTC5wcm90b2NvbCgpKSk7Ci0gICAgQVNTRVJU KFdlYkNvcmU6OlNjaGVtZVJlZ2lzdHJ5OjpzaG91bGRUcmVhdFVSTFNjaGVtZUFzTG9jYWwodGVz dFBhZ2VVUkwucHJvdG9jb2woKSkpOworICAgIGlmIChkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXMo cmVxdWVzdFVSTC5wYXRoKCkpID09IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyhtYWluUGFnZVVS TC5wYXRoKCkpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIC8vIFdlIG1pZ2h0IG5vdCBo YXZlIGEgVGVzdCBVUkwgaW4gUHJvZHVjdGlvbiBidWlsZHMuCisgICAgU3RyaW5nIHRlc3RQYWdl VVJMU3RyaW5nID0gd2ViSW5zcGVjdG9yUHJveHktPmluc3BlY3RvclRlc3RQYWdlVVJMKCk7Cisg ICAgaWYgKHRlc3RQYWdlVVJMU3RyaW5nLmlzTnVsbCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7 CiAKLSAgICBib29sIGlzTWFpblBhZ2VVUkwgPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXMocmVx dWVzdFVSTC5wYXRoKCkpID09IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyhtYWluUGFnZVVSTC5w YXRoKCkpOwotICAgIGJvb2wgaXNUZXN0UGFnZVVSTCA9IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNl cyhyZXF1ZXN0VVJMLnBhdGgoKSkgPT0gZGVjb2RlVVJMRXNjYXBlU2VxdWVuY2VzKHRlc3RQYWdl VVJMLnBhdGgoKSk7Ci0gICAgcmV0dXJuIFdlYkNvcmU6OlNjaGVtZVJlZ2lzdHJ5OjpzaG91bGRU cmVhdFVSTFNjaGVtZUFzTG9jYWwocmVxdWVzdFVSTC5wcm90b2NvbCgpKSAmJiAoaXNNYWluUGFn ZVVSTCB8fCBpc1Rlc3RQYWdlVVJMKTsKKyAgICBVUkwgdGVzdFBhZ2VVUkwoVVJMKCksIHdlYklu c3BlY3RvclByb3h5LT5pbnNwZWN0b3JUZXN0UGFnZVVSTCgpKTsKKyAgICBBU1NFUlQoV2ViQ29y ZTo6U2NoZW1lUmVnaXN0cnk6OnNob3VsZFRyZWF0VVJMU2NoZW1lQXNMb2NhbCh0ZXN0UGFnZVVS TC5wcm90b2NvbCgpKSk7CisgICAgcmV0dXJuIGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyhyZXF1 ZXN0VVJMLnBhdGgoKSkgPT0gZGVjb2RlVVJMRXNjYXBlU2VxdWVuY2VzKHRlc3RQYWdlVVJMLnBh dGgoKSk7CiB9CiAKIHN0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24o V0tQYWdlUmVmLCBXS0ZyYW1lUmVmIGZyYW1lUmVmLCBXS0ZyYW1lTmF2aWdhdGlvblR5cGUsIFdL RXZlbnRNb2RpZmllcnMsIFdLRXZlbnRNb3VzZUJ1dHRvbiwgV0tGcmFtZVJlZiwgV0tVUkxSZXF1 ZXN0UmVmIHJlcXVlc3RSZWYsIFdLRnJhbWVQb2xpY3lMaXN0ZW5lclJlZiBsaXN0ZW5lclJlZiwg V0tUeXBlUmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggM2ExNjM0ZGRi ODYzMjYyMjc1NGI4YWE4OGY0NjU3MDZiNDVmMWRhYi4uN2ZjMjY5OTk0OTFlYzY3ZmQzYTJjMTc5 MWQ4OGFlZmM1N2QxYWRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCkBAIC03NjMsNyArNzYzLDEwIEBAIFN0cmluZyBX ZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdG9yVGVzdFBhZ2VVUkwoKSBjb25zdAogICAgIFdlYklu c3BlY3RvclVJTGlicmFyeSgpOwogCiAgICAgTlNTdHJpbmcgKnBhdGggPSBbW05TQnVuZGxlIGJ1 bmRsZVdpdGhJZGVudGlmaWVyOkAiY29tLmFwcGxlLldlYkluc3BlY3RvclVJIl0gcGF0aEZvclJl c291cmNlOkAiVGVzdCIgb2ZUeXBlOkAiaHRtbCJdOwotICAgIEFTU0VSVChbcGF0aCBsZW5ndGhd KTsKKworICAgIC8vIFdlIG1pZ2h0IG5vdCBoYXZlIGEgVGVzdC5odG1sIGluIFByb2R1Y3Rpb24g YnVpbGRzLgorICAgIGlmICghcGF0aCkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCiAgICAg cmV0dXJuIFtbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOnBhdGhdIGFic29sdXRlU3RyaW5nXTsKIH0K