129501 2014-02-28 11:52:59 -0800 [Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements 2014-02-28 13:07:25 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio webkit-bug-importer oldest_to_newest 985665 0 bfulgham 2014-02-28 11:52:59 -0800 I made a mistake in the order of arguments passed to the new "createOutOfBand" constructor for the PlatformTextTrack in HTMLMediaElement::outOfBandTrackSources. The label and source URLs were reversed. This patch corrects that mistake so that the NSDictionary of items passed to AVFoundation is correct. 985666 1 webkit-bug-importer 2014-02-28 11:53:32 -0800 <rdar://problem/16198587> 985669 2 225479 bfulgham 2014-02-28 12:04:19 -0800 Created attachment 225479 Patch 985686 3 bfulgham 2014-02-28 13:07:25 -0800 Committed r164881: <http://trac.webkit.org/changeset/164881> 225479 2014-02-28 12:04:19 -0800 2014-02-28 12:30:52 -0800 Patch bug-129501-20140228120418.patch text/plain 1532 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDg3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMsIGlPU10gSW5jb3Jy ZWN0IG9yZGVyaW5nIG9mIGNvbnN0cnVjdGlvbiBhcmd1bWVudHMgZm9yIG91dC1vZi1iYW5kIHRl eHQgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyOTUwMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYxOTg1ODc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cGFyc2VBdHRy aWJ1dGUpOiBDb3JyZWN0IG9yZGVyIG9mIGFyZ3VtZW50cworICAgICAgICB0byBQbGF0Zm9ybVRl eHRUcmFjay4KKwogMjAxNC0wMi0yOCAgQmVtIEpvbmVzLUJleSAgPGJqb25lc2JlQGFkb2JlLmNv bT4KIAogICAgICAgICBQcm9wZXJseSBjbGVhciBtX2xvZ2ljYWxseUxhc3RSdW4gdG8gcmVtb3Zl IHVzZS1hZnRlci1mcmVlIHBvc3NpYmlsaXR5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDE2NDg3NykKKysrIFNvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1NjUsNyArNTU2NSw3 IEBAIFZlY3RvcjxSZWZQdHI8UGxhdGZvcm1UZXh0VHJhY2s+PiBIVE1MTWUKICAgICAgICAgZWxz ZQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgb3V0T2ZCYW5kVHJhY2tTb3VyY2Vz LmFwcGVuZChQbGF0Zm9ybVRleHRUcmFjazo6Y3JlYXRlT3V0T2ZCYW5kKHVybC5zdHJpbmcoKSwg dHJhY2tFbGVtZW50LmxhYmVsKCksIHRyYWNrRWxlbWVudC5zcmNsYW5nKCksIHBsYXRmb3JtS2lu ZCwgKyt1bmlxdWVJZCwgdHJhY2tFbGVtZW50LmlzRGVmYXVsdCgpKSk7CisgICAgICAgIG91dE9m QmFuZFRyYWNrU291cmNlcy5hcHBlbmQoUGxhdGZvcm1UZXh0VHJhY2s6OmNyZWF0ZU91dE9mQmFu ZCh0cmFja0VsZW1lbnQubGFiZWwoKSwgdHJhY2tFbGVtZW50LnNyY2xhbmcoKSwgdXJsLnN0cmlu ZygpLCBwbGF0Zm9ybUtpbmQsICsrdW5pcXVlSWQsIHRyYWNrRWxlbWVudC5pc0RlZmF1bHQoKSkp OwogICAgIH0KICAgICAKICAgICByZXR1cm4gb3V0T2ZCYW5kVHJhY2tTb3VyY2VzOwo=