<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>12950</bug_id>
          
          <creation_ts>2007-03-02 15:40:41 -0800</creation_ts>
          <short_desc>Assertions.cpp should not #define macros that are already defined</short_desc>
          <delta_ts>2007-03-04 17:46:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Gibson">dgibson77</reporter>
          <assigned_to name="Don Gibson">dgibson77</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>20452</commentid>
    <comment_count>0</comment_count>
    <who name="Don Gibson">dgibson77</who>
    <bug_when>2007-03-02 15:40:41 -0800</bug_when>
    <thetext>WINVER and _WIN32_WINNT should only be #defined when they don&apos;t already exist.

Patch coming shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20456</commentid>
    <comment_count>1</comment_count>
      <attachid>13456</attachid>
    <who name="Don Gibson">dgibson77</who>
    <bug_when>2007-03-02 16:14:28 -0800</bug_when>
    <thetext>Created attachment 13456
patch

Pretty simple, really...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20506</commentid>
    <comment_count>2</comment_count>
      <attachid>13456</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2007-03-04 03:46:20 -0800</bug_when>
    <thetext>Comment on attachment 13456
patch

Please remove the tabs used in JavaScriptCore/ChangeLog. As it&apos;s a trivial patch: r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20544</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-03-04 17:46:44 -0800</bug_when>
    <thetext>Committed revision 19956.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13456</attachid>
            <date>2007-03-02 16:14:28 -0800</date>
            <delta_ts>2007-03-04 03:46:20 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>931</size>
            <attacher name="Don Gibson">dgibson77</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTQ5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDMtMDIgIERvbiBHaWJz
b24gIDxkZ2lic29uNzdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisJaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NTA6
IERvbid0ICNkZWZpbmUgbWFjcm9zCisJdGhhdCBhcmUgYWxyZWFkeSBkZWZpbmVkLgorCisgICAg
ICAgICogd3RmL0Fzc2VydGlvbnMuY3BwOgorCiAyMDA3LTAzLTAyICBTdGV2ZSBGYWxrZW5idXJn
ICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzLgpJbmRl
eDogSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT
Y3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcAkocmV2aXNpb24gMTk5NDkpCisrKyBKYXZhU2Ny
aXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDggKzM1LDEy
IEBACiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKFdJTikKKyNpZm5kZWYgV0lOVkVSCiAjZGVmaW5l
IFdJTlZFUiAweDA1MDAKKyNlbmRpZgorI2lmbmRlZiBfV0lOMzJfV0lOTlQKICNkZWZpbmUgX1dJ
TjMyX1dJTk5UIDB4MDUwMAorI2VuZGlmCiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2luY2x1ZGUg
PGNydGRiZy5oPgogI2VuZGlmCg==
</data>
<flag name="review"
          id="5307"
          type_id="1"
          status="+"
          setter="zimmermann"
    />
          </attachment>
      

    </bug>

</bugzilla>