129497 2014-02-28 10:58:06 -0800 VisitedLinkProvider should keep track of processes, not pages 2014-02-28 11:26:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 985643 0 andersca 2014-02-28 10:58:06 -0800 VisitedLinkProvider should keep track of processes, not pages 985645 1 225477 andersca 2014-02-28 11:06:05 -0800 Created attachment 225477 Patch 985651 2 225477 mitz 2014-02-28 11:18:43 -0800 Comment on attachment 225477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225477&action=review > Tools/ChangeLog:12 > +2014-02-28 Anders Carlsson <andersca@apple.com> > + > + VisitedLinkProvider should keep track of processes, not pages > + https://bugs.webkit.org/show_bug.cgi?id=129497 > + > + Reviewed by NOBODY (OOPS!). > + > + Remove logging. > + > + * MiniBrowser/mac/WK2BrowserWindowController.m: > + (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]): > + This is unrelated. r=me but don’t use this bug’s title in the change log. 985653 3 andersca 2014-02-28 11:26:35 -0800 Committed r164877: <http://trac.webkit.org/changeset/164877> 225477 2014-02-28 11:06:05 -0800 2014-02-28 11:18:42 -0800 Patch bug-129497-20140228110605.patch text/plain 7409 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWY3NWQ5MWE2NTcwOTY0 NjAzMGFmMzBjZjI2YmE1NGQxZDg4ZmQ0MS4uMDUxNThjMGMwODhhNzFjZTFmMWRlMzZmYjBhZmEy NWM3NTgyZTAzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5IEBACisyMDE0LTAyLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVmlzaXRlZExpbmtQ cm92aWRlciBzaG91bGQga2VlcCB0cmFjayBvZiBwcm9jZXNzZXMsIG5vdCBwYWdlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5NDk3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGEgY291bnRlZCBz ZXQgb2YgV2ViUHJvY2Vzc1Byb3h5IHBvaW50ZXJzIGluc3RlYWQgb2YgYSBzZXQgb2YgcGFnZXMu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvVmlzaXRlZExpbmtQcm92aWRlci5jcHA6CisgICAgICAg IChXZWJLaXQ6OlZpc2l0ZWRMaW5rUHJvdmlkZXI6On5WaXNpdGVkTGlua1Byb3ZpZGVyKToKKyAg ICAgICAgQXNzZXJ0IHRoYXQgbV9wcm9jZXNzZXMgaXMgbnVsbC4KKworICAgICAgICAoV2ViS2l0 OjpWaXNpdGVkTGlua1Byb3ZpZGVyOjphZGRQcm9jZXNzKToKKyAgICAgICAgQWRkIHRoZSBwcm9j ZXNzIHRvIHRoZSBzZXQuCisKKyAgICAgICAgKFdlYktpdDo6VmlzaXRlZExpbmtQcm92aWRlcjo6 cmVtb3ZlUHJvY2Vzcyk6CisgICAgICAgIFJlbW92ZSB0aGUgcHJvY2VzcyBmcm9tIHRoZSBzZXQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvVmlzaXRlZExpbmtQcm92aWRlci5oOgorICAgICAgICAK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZVByb3h5OjpXZWJQYWdlUHJveHkpOgorICAgICAgICBJZiBvdXIgcHJvY2VzcyBpcyBj dXJyZW50bHkgcnVubmluZywgYWRkIGl0IHRvIHRoZSB2aXNpdGVkIGxpbmsgcHJvdmlkZXIuCisg ICAgICAgIE90aGVyd2lzZSBpdCB3aWxsIGJlIGFkZGVkIGluIGNvbm5lY3Rpb25XaWxsT3Blbi4K KworICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNsb3NlKToKKyAgICAgICAgSWYgb3Vy IHByb2Nlc3MgaXMgcnVubmluZywgcmVtb3ZlIGl0IGZyb20gdGhlIHZpc2l0ZWQgbGluayBwcm92 aWRlci4gCisgICAgICAgIE90aGVyd2lzZSBpdCdzIGVpdGhlciBjcmFzaGVkIG9yIG5vdCB5ZXQg bGF1bmNoZWQgYW5kIHdpbGwgbm90IGhhdmUgYmVlbiBhZGRlZC4KKworICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsT3Blbik6CisgICAgICAgIEFkZCB0aGUgcHJv Y2VzcyB0byB0aGUgdmlzaXRlZCBsaW5rIHByb3ZpZGVyLgorCisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6cmVzZXRTdGF0ZUFmdGVyUHJvY2Vzc0V4aXRlZCk6CisgICAgICAgIFJlbW92 ZSB0aGUgcHJvY2VzcyBmcm9tIHRoZSB2aXNpdGVkIGxpbmsgcHJvdmlkZXIuCisKIDIwMTQtMDIt MjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10g U3RvcCB1c2luZyBzb21lIGRlcHJlY2F0ZWQgZnVuY3Rpb25zIGluIFdLVmlldy5tbQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5rUHJvdmlkZXIuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5rUHJvdmlkZXIuY3BwCmluZGV4IGZl YWFmOTFkNzg4N2RkNDNjMDZkZTNlNzNjY2ZhZjQ3YmE5NzY3M2UuLmFiNTNlNTZlYmFiMGFkY2U3 ZmJkNDA4MWMxM2JlMWY0M2JhZTdhMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9WaXNpdGVkTGlua1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvVmlzaXRlZExpbmtQcm92aWRlci5jcHAKQEAgLTUxLDcgKzUxLDcgQEAgUGFzc1JlZlB0cjxW aXNpdGVkTGlua1Byb3ZpZGVyPiBWaXNpdGVkTGlua1Byb3ZpZGVyOjpjcmVhdGUoKQogCiBWaXNp dGVkTGlua1Byb3ZpZGVyOjp+VmlzaXRlZExpbmtQcm92aWRlcigpCiB7Ci0gICAgQVNTRVJUKG1f cGFnZXMuaXNFbXB0eSgpKTsKKyAgICBBU1NFUlQobV9wcm9jZXNzZXMuaXNFbXB0eSgpKTsKIH0K IAogVmlzaXRlZExpbmtQcm92aWRlcjo6VmlzaXRlZExpbmtQcm92aWRlcigpCkBAIC02MiwxNiAr NjIsMTggQEAgVmlzaXRlZExpbmtQcm92aWRlcjo6VmlzaXRlZExpbmtQcm92aWRlcigpCiB7CiB9 CiAKLXZvaWQgVmlzaXRlZExpbmtQcm92aWRlcjo6YWRkUGFnZShXZWJQYWdlUHJveHkmIHdlYlBh Z2VQcm94eSkKK3ZvaWQgVmlzaXRlZExpbmtQcm92aWRlcjo6YWRkUHJvY2VzcyhXZWJQcm9jZXNz UHJveHkmIHByb2Nlc3MpCiB7Ci0gICAgQVNTRVJUKCFtX3BhZ2VzLmNvbnRhaW5zKCZ3ZWJQYWdl UHJveHkpKTsKLSAgICBtX3BhZ2VzLmFkZCgmd2ViUGFnZVByb3h5KTsKKyAgICBBU1NFUlQocHJv Y2Vzcy5zdGF0ZSgpID09IFdlYlByb2Nlc3NQcm94eTo6U3RhdGU6OlJ1bm5pbmcpOworCisgICAg bV9wcm9jZXNzZXMuYWRkKCZwcm9jZXNzKTsKIH0KIAotdm9pZCBWaXNpdGVkTGlua1Byb3ZpZGVy OjpyZW1vdmVQYWdlKFdlYlBhZ2VQcm94eSYgd2ViUGFnZVByb3h5KQordm9pZCBWaXNpdGVkTGlu a1Byb3ZpZGVyOjpyZW1vdmVQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcykKIHsKLSAg ICBBU1NFUlQobV9wYWdlcy5jb250YWlucygmd2ViUGFnZVByb3h5KSk7Ci0gICAgbV9wYWdlcy5y ZW1vdmUoJndlYlBhZ2VQcm94eSk7CisgICAgQVNTRVJUKG1fcHJvY2Vzc2VzLmNvbnRhaW5zKCZw cm9jZXNzKSk7CisKKyAgICBtX3Byb2Nlc3Nlcy5yZW1vdmUoJnByb2Nlc3MpOwogfQogCiB2b2lk IFZpc2l0ZWRMaW5rUHJvdmlkZXI6OnByb2Nlc3NEaWRGaW5pc2hMYXVuY2hpbmcoV2ViUHJvY2Vz c1Byb3h5KiBwcm9jZXNzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Zp c2l0ZWRMaW5rUHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9WaXNpdGVkTGlu a1Byb3ZpZGVyLmgKaW5kZXggYWIyZmQwMTRiOThkYmVkNDNmMGE5ZWU1ODEyOWQ5NDA1NjE1M2Ez YS4uMDAzNjc2MjVjMDJkZjU1NzAyMjQyMzg1MjZmZDQ4NGM3M2YzOTU5NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5rUHJvdmlkZXIuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvVmlzaXRlZExpbmtQcm92aWRlci5oCkBAIC0yOSw2ICsyOSw3 IEBACiAjaW5jbHVkZSAiVmlzaXRlZExpbmtUYWJsZS5oIgogI2luY2x1ZGUgPFdlYkNvcmUvTGlu a0hhc2guaD4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgorI2luY2x1ZGUgPHd0Zi9IYXNoQ291 bnRlZFNldC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNv dW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgpAQCAtNDYsOCArNDcsOCBAQCBwdWJs aWM6CiAKICAgICB1aW50NjRfdCBpZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVudGlm aWVyOyB9CiAKLSAgICB2b2lkIGFkZFBhZ2UoV2ViUGFnZVByb3h5Jik7Ci0gICAgdm9pZCByZW1v dmVQYWdlKFdlYlBhZ2VQcm94eSYpOworICAgIHZvaWQgYWRkUHJvY2VzcyhXZWJQcm9jZXNzUHJv eHkmKTsKKyAgICB2b2lkIHJlbW92ZVByb2Nlc3MoV2ViUHJvY2Vzc1Byb3h5Jik7CiAKICAgICB2 b2lkIGFkZFZpc2l0ZWRMaW5rKFdlYkNvcmU6OkxpbmtIYXNoKTsKIApAQCAtNTksMTEgKzYwLDEy IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHBlbmRpbmdWaXNpdGVkTGlua3NUaW1lckZpcmVkKCk7 CiAKKyAgICBIYXNoQ291bnRlZFNldDxXZWJQcm9jZXNzUHJveHkqPiBtX3Byb2Nlc3NlczsKKwog ICAgIEhhc2hTZXQ8V2ViUHJvY2Vzc1Byb3h5Kj4gbV9wcm9jZXNzZXNXaXRoVmlzaXRlZExpbmtT dGF0ZTsKICAgICBIYXNoU2V0PFdlYlByb2Nlc3NQcm94eSo+IG1fcHJvY2Vzc2VzV2l0aG91dFZp c2l0ZWRMaW5rU3RhdGU7CiAKICAgICB1aW50NjRfdCBtX2lkZW50aWZpZXI7Ci0gICAgSGFzaFNl dDxXZWJQYWdlUHJveHkqPiBtX3BhZ2VzOwogCiAgICAgdW5zaWduZWQgbV9rZXlDb3VudDsKICAg ICB1bnNpZ25lZCBtX3RhYmxlU2l6ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKaW5kZXggYTNlMWQwMzA3MjgxYjAzYTM0Mzg3NWRmYjYwNWU5MjM0Mjg4M2UzOS4u MDBlY2Q2ZmRiOGE3MjQ3Mzk4MjgzZDk0Y2VhNDE3ZWY0OWRjNDNmNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTMzNiw3ICszMzYsOCBAQCBXZWJQYWdl UHJveHk6OldlYlBhZ2VQcm94eShQYWdlQ2xpZW50JiBwYWdlQ2xpZW50LCBXZWJQcm9jZXNzUHJv eHkmIHByb2Nlc3MsIHVpbgogICAgICwgbV9zY3JvbGxQaW5uaW5nQmVoYXZpb3IoRG9Ob3RQaW4p CiAgICAgLCBtX25hdmlnYXRpb25JRCgwKQogewotICAgIG1fdmlzaXRlZExpbmtQcm92aWRlci0+ YWRkUGFnZSgqdGhpcyk7CisgICAgaWYgKG1fcHJvY2Vzcy0+c3RhdGUoKSA9PSBXZWJQcm9jZXNz UHJveHk6OlN0YXRlOjpSdW5uaW5nKQorICAgICAgICBtX3Zpc2l0ZWRMaW5rUHJvdmlkZXItPmFk ZFByb2Nlc3MobV9wcm9jZXNzLmdldCgpKTsKIAogICAgIHVwZGF0ZVZpZXdTdGF0ZSgpOwogCkBA IC01NzUsNyArNTc2LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OmNsb3NlKCkKIAogICAgIG1faXND bG9zZWQgPSB0cnVlOwogCi0gICAgbV92aXNpdGVkTGlua1Byb3ZpZGVyLT5yZW1vdmVQYWdlKCp0 aGlzKTsKKyAgICBpZiAobV9wcm9jZXNzLT5zdGF0ZSgpID09IFdlYlByb2Nlc3NQcm94eTo6U3Rh dGU6OlJ1bm5pbmcpCisgICAgICAgIG1fdmlzaXRlZExpbmtQcm92aWRlci0+cmVtb3ZlUHJvY2Vz cyhtX3Byb2Nlc3MuZ2V0KCkpOwogCiAgICAgbV9iYWNrRm9yd2FyZExpc3QtPnBhZ2VDbG9zZWQo KTsKICAgICBtX3BhZ2VDbGllbnQucGFnZUNsb3NlZCgpOwpAQCAtMjY5Niw2ICsyNjk4LDggQEAg dm9pZCBXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsT3BlbihJUEM6OkNvbm5lY3Rpb24qIGNv bm5lY3Rpb24pCiB7CiAgICAgQVNTRVJUKGNvbm5lY3Rpb24gPT0gbV9wcm9jZXNzLT5jb25uZWN0 aW9uKCkpOwogCisgICAgbV92aXNpdGVkTGlua1Byb3ZpZGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vz cy5nZXQoKSk7CisKICAgICBtX3Byb2Nlc3MtPmNvbnRleHQoKS5zdG9yYWdlTWFuYWdlcigpLnNl dEFsbG93ZWRTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZUNvbm5lY3Rpb24obV9wYWdlSUQsIGNvbm5l Y3Rpb24pOwogfQogCkBAIC0zOTA4LDYgKzM5MTIsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cmVz ZXRTdGF0ZUFmdGVyUHJvY2Vzc0V4aXRlZCgpCiAgICAgaWYgKCFpc1ZhbGlkKCkpCiAgICAgICAg IHJldHVybjsKIAorICAgIG1fdmlzaXRlZExpbmtQcm92aWRlci0+cmVtb3ZlUHJvY2VzcyhtX3By b2Nlc3MuZ2V0KCkpOworCiAgICAgbV9wcm9jZXNzLT5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVz c2FnZXM6OldlYlBhZ2VQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJRCk7CiAK ICAgICBtX2lzVmFsaWQgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCAyYTVlMWYzNDNjZmMzYzY0NjM0N2MxN2RkMjFmOWUwZDI0YjJi MjllLi5lZWY1YTI4NjBhOGY0ODNmYzgwMjQ1ZGM5MmQ4NjgwYmZhNGU1MjA5IDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTQtMDItMjggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAg ICAgICBWaXNpdGVkTGlua1Byb3ZpZGVyIHNob3VsZCBrZWVwIHRyYWNrIG9mIHByb2Nlc3Nlcywg bm90IHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjk0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgbG9nZ2luZy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL21hYy9XSzJCcm93c2Vy V2luZG93Q29udHJvbGxlci5tOgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxl ciBicm93c2luZ0NvbnRleHRDb250cm9sbGVyOmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b246ZGVjaXNpb25IYW5kbGVyOl0pOgorCiAyMDE0LTAyLTI4ICBDb21taXQgUXVldWUgIDxjb21t aXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTY0ODU5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL1dLMkJyb3dzZXJXaW5k b3dDb250cm9sbGVyLm0gYi9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0Nv bnRyb2xsZXIubQppbmRleCAwYWVkZTUzNDFjOTlkZDM4ODIzOGUwYWQzYTllMmI1YTc0OTY0Nzk2 Li44NjdhYmQ0ZDQyYmM1NWUyZGU5ZTcyNTdlYzk0ZjcwMGFlMmIzODg0IDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQorKysgYi9U b29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQpAQCAtNjcz LDcgKzY3Myw2IEBAIC0gKHZvaWQpYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlcjooV0tCcm93c2lu Z0NvbnRleHRDb250cm9sbGVyICopc2VuZGVyIGRpZFJlY2VpCiAtICh2b2lkKWJyb3dzaW5nQ29u dGV4dENvbnRyb2xsZXI6KFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciAqKWJyb3dzaW5nQ29u dGV4dCBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOihOU0RpY3Rpb25hcnkgKilhY3Rp b25JbmZvcm1hdGlvbiBkZWNpc2lvbkhhbmRsZXI6KFdLUG9saWN5RGVjaXNpb25IYW5kbGVyKWRl Y2lzaW9uSGFuZGxlcgogewogICAgIExPRyhAImRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24iKTsKLSAgICBOU0xvZyhAImFjdGlvbiBpbmZvcm1hdGlvbiAlQCIsIGFjdGlvbkluZm9ybWF0 aW9uKTsKICAgICBkZWNpc2lvbkhhbmRsZXIoV0tQb2xpY3lEZWNpc2lvbkFsbG93KTsKIH0KIAo=