129476 2014-02-28 01:57:23 -0800 StyledElement::attributeChanged shouldn't do any work when the attribute value didn't change 2016-11-09 14:18:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa barraclough benjamin cdumez commit-queue dbates esprehn+autocc ggaren kangil.han kling koivisto oldest_to_newest 985506 0 rniwa 2014-02-28 01:57:23 -0800 StyledElement::attributeChanged shouldn't do any work when the attribute value didn't change 985507 1 225446 rniwa 2014-02-28 01:58:17 -0800 Created attachment 225446 Fixes the bug 985590 2 225446 ap 2014-02-28 09:23:05 -0800 Comment on attachment 225446 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=225446&action=review > Source/WebCore/ChangeLog:8 > + Exit early in attributeChanged when the attribute value didn't change like r164856. This description doesn't quite match the code change, there is no early exit. 985879 3 225446 kling 2014-02-28 22:20:29 -0800 Comment on attachment 225446 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=225446&action=review r=me >> Source/WebCore/ChangeLog:8 >> + Exit early in attributeChanged when the attribute value didn't change like r164856. > > This description doesn't quite match the code change, there is no early exit. Yeah, could be worded better. 985880 4 225446 rniwa 2014-02-28 22:21:15 -0800 Comment on attachment 225446 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=225446&action=review >>> Source/WebCore/ChangeLog:8 >>> + Exit early in attributeChanged when the attribute value didn't change like r164856. >> >> This description doesn't quite match the code change, there is no early exit. > > Yeah, could be worded better. Oops, yeah. We still need to call Element::attributeChanged. 1247502 5 293700 rniwa 2016-11-02 14:59:36 -0700 Created attachment 293700 Patch for landing 1247510 6 293700 rniwa 2016-11-02 15:13:18 -0700 Comment on attachment 293700 Patch for landing Wait for EWS first. 1247519 7 293700 koivisto 2016-11-02 15:32:51 -0700 Comment on attachment 293700 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=293700&action=review > Source/WebCore/dom/StyledElement.cpp:158 > + if (oldValue != newValue) { Can't we just not call attributeChanged() when nothing changed? 1247530 8 rniwa 2016-11-02 16:00:47 -0700 (In reply to comment #7) > Comment on attachment 293700 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=293700&action=review > > > Source/WebCore/dom/StyledElement.cpp:158 > > + if (oldValue != newValue) { > > Can't we just not call attributeChanged() when nothing changed? No, unfortunately, parseAttribute needs to be called even when the attribute value didn't change because some attributes on some elements can have a side effect. And Element::attributeChanged also creates a mutation record for mutation observer, which is pretty important. 1249480 9 294279 rniwa 2016-11-09 13:43:02 -0800 Created attachment 294279 Patch for landing 1249504 10 294279 commit-queue 2016-11-09 14:18:09 -0800 Comment on attachment 294279 Patch for landing Clearing flags on attachment: 294279 Committed r208485: <http://trac.webkit.org/changeset/208485> 1249505 11 commit-queue 2016-11-09 14:18:15 -0800 All reviewed patches have been landed. Closing bug. 225446 2014-02-28 01:58:17 -0800 2016-11-02 14:59:32 -0700 Fixes the bug bug-129476-20140228015817.patch text/plain 1858 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTI4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFN0eWxlZEVsZW1lbnQ6OmF0dHJp YnV0ZUNoYW5nZWQgc2hvdWxkbid0IGRvIGFueSB3b3JrIHdoZW4gdGhlIGF0dHJpYnV0ZSB2YWx1 ZSBkaWRuJ3QgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjk0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFeGl0IGVhcmx5IGluIGF0dHJpYnV0ZUNoYW5nZWQgd2hlbiB0aGUgYXR0cmlidXRl IHZhbHVlIGRpZG4ndCBjaGFuZ2UgbGlrZSByMTY0ODU2LgorCisgICAgICAgICogZG9tL1N0eWxl ZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVkRWxlbWVudDo6YXR0cmlidXRl Q2hhbmdlZCk6CisKIDIwMTQtMDItMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgRWxlbWVudDo6YXR0cmlidXRlQ2hhbmdlZCBzaG91bGRuJ3QgZG8gYW55IHdv cmsgd2hlbiBhdHRyaWJ1dGUgdmFsdWUgZGlkbid0IGNoYW5nZQpJbmRleDogU291cmNlL1dlYkNv cmUvZG9tL1N0eWxlZEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9TdHlsZWRFbGVtZW50LmNwcAkocmV2aXNpb24gMTY0ODU2KQorKysgU291cmNlL1dlYkNvcmUv ZG9tL1N0eWxlZEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTEsMTEgKzE1MSwxMyBA QCBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzJiBTdHlsZWRFbGVtZW50OjplCiAKIHZvaWQgU3R5bGVk RWxlbWVudDo6YXR0cmlidXRlQ2hhbmdlZChjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25z dCBBdG9taWNTdHJpbmcmIG9sZFZhbHVlLCBjb25zdCBBdG9taWNTdHJpbmcmIG5ld1ZhbHVlLCBB dHRyaWJ1dGVNb2RpZmljYXRpb25SZWFzb24gcmVhc29uKQogewotICAgIGlmIChuYW1lID09IHN0 eWxlQXR0cikKLSAgICAgICAgc3R5bGVBdHRyaWJ1dGVDaGFuZ2VkKG5ld1ZhbHVlLCByZWFzb24p OwotICAgIGVsc2UgaWYgKGlzUHJlc2VudGF0aW9uQXR0cmlidXRlKG5hbWUpKSB7Ci0gICAgICAg IGVsZW1lbnREYXRhKCktPnNldFByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlSXNEaXJ0eSh0cnVl KTsKLSAgICAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhJbmxpbmVTdHlsZUNoYW5nZSk7CisgICAg aWYgKG9sZFZhbHVlICE9IG5ld1ZhbHVlKSB7CisgICAgICAgIGlmIChuYW1lID09IHN0eWxlQXR0 cikKKyAgICAgICAgICAgIHN0eWxlQXR0cmlidXRlQ2hhbmdlZChuZXdWYWx1ZSwgcmVhc29uKTsK KyAgICAgICAgZWxzZSBpZiAoaXNQcmVzZW50YXRpb25BdHRyaWJ1dGUobmFtZSkpIHsKKyAgICAg ICAgICAgIGVsZW1lbnREYXRhKCktPnNldFByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlSXNEaXJ0 eSh0cnVlKTsKKyAgICAgICAgICAgIHNldE5lZWRzU3R5bGVSZWNhbGMoSW5saW5lU3R5bGVDaGFu Z2UpOworICAgICAgICB9CiAgICAgfQogCiAgICAgRWxlbWVudDo6YXR0cmlidXRlQ2hhbmdlZChu YW1lLCBvbGRWYWx1ZSwgbmV3VmFsdWUsIHJlYXNvbik7Cg== 293700 2016-11-02 14:59:36 -0700 2016-11-09 13:42:57 -0800 Patch for landing bug-129476-20161102145537.patch text/plain 1880 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFN0eWxlZEVsZW1lbnQ6OmF0dHJp YnV0ZUNoYW5nZWQgc2hvdWxkbid0IGRvIGFueSB3b3JrIHdoZW4gdGhlIGF0dHJpYnV0ZSB2YWx1 ZSBkaWRuJ3QgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjk0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisg ICAgICAgIEF2b2lkIGNhbGxpbmcgc3R5bGVBdHRyaWJ1dGVDaGFuZ2VkIGFuZCBzZXRQcmVzZW50 YXRpb25BdHRyaWJ1dGVTdHlsZUlzRGlydHkKKyAgICAgICAgd2hlbiB0aGUgYXR0cmlidXRlIHZh bHVlIGRpZG4ndCBjaGFuZ2UgYXMgaW4gcjE2NDg1Ni4KKworICAgICAgICAqIGRvbS9TdHlsZWRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlZEVsZW1lbnQ6OmF0dHJpYnV0ZUNo YW5nZWQpOgorCiAyMDE2LTExLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVkZSBEZWJ1Z2dlckFnZW50IGluIFdv cmtlcnMgLSBzZWUsIHBhdXNlLCBhbmQgc3RlcCB0aHJvdWdoIHNjcmlwdHMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9kb20vU3R5bGVkRWxlbWVudC5jcHAJKHJldmlzaW9uIDIwODMwNCkKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU1LDExICsx NTUsMTMgQEAgTXV0YWJsZVN0eWxlUHJvcGVydGllcyYgU3R5bGVkRWxlbWVudDo6ZQogCiB2b2lk IFN0eWxlZEVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFt ZSwgY29uc3QgQXRvbWljU3RyaW5nJiBvbGRWYWx1ZSwgY29uc3QgQXRvbWljU3RyaW5nJiBuZXdW YWx1ZSwgQXR0cmlidXRlTW9kaWZpY2F0aW9uUmVhc29uIHJlYXNvbikKIHsKLSAgICBpZiAobmFt ZSA9PSBzdHlsZUF0dHIpCi0gICAgICAgIHN0eWxlQXR0cmlidXRlQ2hhbmdlZChuZXdWYWx1ZSwg cmVhc29uKTsKLSAgICBlbHNlIGlmIChpc1ByZXNlbnRhdGlvbkF0dHJpYnV0ZShuYW1lKSkgewot ICAgICAgICBlbGVtZW50RGF0YSgpLT5zZXRQcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZUlzRGly dHkodHJ1ZSk7Ci0gICAgICAgIGludmFsaWRhdGVTdHlsZSgpOworICAgIGlmIChvbGRWYWx1ZSAh PSBuZXdWYWx1ZSkgeworICAgICAgICBpZiAobmFtZSA9PSBzdHlsZUF0dHIpCisgICAgICAgICAg ICBzdHlsZUF0dHJpYnV0ZUNoYW5nZWQobmV3VmFsdWUsIHJlYXNvbik7CisgICAgICAgIGVsc2Ug aWYgKGlzUHJlc2VudGF0aW9uQXR0cmlidXRlKG5hbWUpKSB7CisgICAgICAgICAgICBlbGVtZW50 RGF0YSgpLT5zZXRQcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZUlzRGlydHkodHJ1ZSk7CisgICAg ICAgICAgICBpbnZhbGlkYXRlU3R5bGUoKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIEVsZW1l bnQ6OmF0dHJpYnV0ZUNoYW5nZWQobmFtZSwgb2xkVmFsdWUsIG5ld1ZhbHVlLCByZWFzb24pOwo= 294279 2016-11-09 13:43:02 -0800 2016-11-09 14:18:09 -0800 Patch for landing bug-129476-20161109133854.patch text/plain 1856 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTA5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFN0eWxlZEVsZW1lbnQ6OmF0dHJp YnV0ZUNoYW5nZWQgc2hvdWxkbid0IGRvIGFueSB3b3JrIHdoZW4gdGhlIGF0dHJpYnV0ZSB2YWx1 ZSBkaWRuJ3QgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjk0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisg ICAgICAgIEF2b2lkIGNhbGxpbmcgc3R5bGVBdHRyaWJ1dGVDaGFuZ2VkIGFuZCBzZXRQcmVzZW50 YXRpb25BdHRyaWJ1dGVTdHlsZUlzRGlydHkKKyAgICAgICAgd2hlbiB0aGUgYXR0cmlidXRlIHZh bHVlIGRpZG4ndCBjaGFuZ2UgYXMgaW4gcjE2NDg1Ni4KKworICAgICAgICAqIGRvbS9TdHlsZWRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlZEVsZW1lbnQ6OmF0dHJpYnV0ZUNo YW5nZWQpOgorCiAyMDE2LTExLTA5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1NWR10gU3RhcnQgbW92aW5nIHNwZWNpYWwgY2FzaW5nIG9mIFNWRyBvdXQgb2YgdGhl IGJpbmRpbmdzIC0gU1ZHQW5nbGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5j cHAJKHJldmlzaW9uIDIwODQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU1LDExICsxNTUsMTMgQEAgTXV0YWJsZVN0eWxlUHJv cGVydGllcyYgU3R5bGVkRWxlbWVudDo6ZQogCiB2b2lkIFN0eWxlZEVsZW1lbnQ6OmF0dHJpYnV0 ZUNoYW5nZWQoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiBv bGRWYWx1ZSwgY29uc3QgQXRvbWljU3RyaW5nJiBuZXdWYWx1ZSwgQXR0cmlidXRlTW9kaWZpY2F0 aW9uUmVhc29uIHJlYXNvbikKIHsKLSAgICBpZiAobmFtZSA9PSBzdHlsZUF0dHIpCi0gICAgICAg IHN0eWxlQXR0cmlidXRlQ2hhbmdlZChuZXdWYWx1ZSwgcmVhc29uKTsKLSAgICBlbHNlIGlmIChp c1ByZXNlbnRhdGlvbkF0dHJpYnV0ZShuYW1lKSkgewotICAgICAgICBlbGVtZW50RGF0YSgpLT5z ZXRQcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZUlzRGlydHkodHJ1ZSk7Ci0gICAgICAgIGludmFs aWRhdGVTdHlsZSgpOworICAgIGlmIChvbGRWYWx1ZSAhPSBuZXdWYWx1ZSkgeworICAgICAgICBp ZiAobmFtZSA9PSBzdHlsZUF0dHIpCisgICAgICAgICAgICBzdHlsZUF0dHJpYnV0ZUNoYW5nZWQo bmV3VmFsdWUsIHJlYXNvbik7CisgICAgICAgIGVsc2UgaWYgKGlzUHJlc2VudGF0aW9uQXR0cmli dXRlKG5hbWUpKSB7CisgICAgICAgICAgICBlbGVtZW50RGF0YSgpLT5zZXRQcmVzZW50YXRpb25B dHRyaWJ1dGVTdHlsZUlzRGlydHkodHJ1ZSk7CisgICAgICAgICAgICBpbnZhbGlkYXRlU3R5bGUo KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIEVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQobmFt ZSwgb2xkVmFsdWUsIG5ld1ZhbHVlLCByZWFzb24pOwo=