129472 2014-02-28 00:29:47 -0800 [iOS][WK2] highlight rects should never big bigger than the view 2014-02-28 15:50:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin sam oldest_to_newest 985488 0 benjamin 2014-02-28 00:29:47 -0800 [iOS][WK2] highlight rects should never big bigger than the view 985489 1 225443 benjamin 2014-02-28 00:31:04 -0800 Created attachment 225443 Patch 985732 2 225443 enrica 2014-02-28 15:03:09 -0800 Comment on attachment 225443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225443&action=review Looks good to me. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:296 > +static inline bool highlightedQuadsFitInRect(const Vector<FloatQuad>& quads, const FloatRect& rect) maybe isHighlightQuadSmaller ? 985757 3 benjamin 2014-02-28 15:50:12 -0800 Committed r164892: <http://trac.webkit.org/changeset/164892> 225443 2014-02-28 00:31:04 -0800 2014-02-28 15:03:09 -0800 Patch bug-129472-20140228003104.patch text/plain 5188 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0ODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk0MGE5ZjgyYWRhMTk3 NmY0M2ViYTNjZmQ3NjA4NmRkNTViMDBiZC4uMTBiZmY1MzEyNmVhNzM3MTMxZDM0NzA2ZGE3M2Uz ZjU0Nzk0YjhhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g aGlnaGxpZ2h0IHJlY3RzIHNob3VsZCBuZXZlciBiaWcgYmlnZ2VyIHRoYW4gdGhlIHZpZXcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTQ3MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisKIDIwMTQtMDItMjcgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU11bV0syXSBQYWdlcyB3aXRoIEdyYXBoaWNzIExheWVycyBjYXVz ZSBnaWFudCB0aWxpbmcgc3VyZmFjZXMgb24gem9vbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDkwMmJkMDdjNjc0 MTYyOGU4YjI1ZWFhZTI5NDg4ZDk4MDBlNWYyOGYuLmMwYjE4ODRkY2QzMGMxMWI4OGMzN2RjMzA2 Y2NjNGQ4OWI0NDliM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0wMi0yOCAg QmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXVtX SzJdIGhpZ2hsaWdodCByZWN0cyBzaG91bGQgbmV2ZXIgYmlnIGJpZ2dlciB0aGFuIHRoZSB2aWV3 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk0NzIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1NjczNjU1PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB1bm9ic2N1cmVkUmVjdCBvbiBXZWJQYWdl UHJveHkgaXMgdGhlICJ0cnVlIiB2aWV3IHJlY3QgYXMgc2VlbiBieSB0aGUgdXNlci4KKyAgICAg ICAgVXNlIHRoYXQgdG8gY29uc3RyYWluIG91ciBoaWdobGlnaHQgcmVjdHMuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKGhp Z2hsaWdodGVkUXVhZHNGaXRJblJlY3QpOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9kaWRH ZXRUYXBIaWdobGlnaHRGb3JSZXF1ZXN0OmNvbG9yOldlYkNvcmU6OnF1YWRzOldlYkNvcmU6OnRv cExlZnRSYWRpdXM6V2ViQ29yZTo6dG9wUmlnaHRSYWRpdXM6V2ViQ29yZTo6Ym90dG9tTGVmdFJh ZGl1czpXZWJDb3JlOjpib3R0b21SaWdodFJhZGl1czpXZWJDb3JlOjpdKToKKwogMjAxNC0wMi0y NyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XVtXSzJdIFBhZ2VzIHdpdGggR3JhcGhpY3MgTGF5ZXJzIGNhdXNlIGdpYW50IHRpbGluZyBzdXJm YWNlcyBvbiB6b29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IGI1M2U5ZjYzZDcxZGY4MTM4ZGYy ZmVjN2QxOWNiNjlmNjIzOWM0NTAuLmUzNmRlMTBkMTkyYzlhMjA0YjYxYzA0OGIzMWFmNzI1ZDk2 NWRjNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCkBAIC0yNTIsNiArMjUyLDcgQEAgX19aTjdXZWJD b3JlMTJpY29uRGF0YWJhc2VFdgogX19aTjdXZWJDb3JlMTNLZXlib2FyZEV2ZW50QzFFdgogX19a TjdXZWJDb3JlMTVGb2N1c0NvbnRyb2xsZXIyMG5leHRGb2N1c2FibGVFbGVtZW50RU5TXzIwRm9j dXNOYXZpZ2F0aW9uU2NvcGVFUE5TXzROb2RlRVBOU18xM0tleWJvYXJkRXZlbnRFCiBfX1pON1dl YkNvcmUxNUZvY3VzQ29udHJvbGxlcjI0cHJldmlvdXNGb2N1c2FibGVFbGVtZW50RU5TXzIwRm9j dXNOYXZpZ2F0aW9uU2NvcGVFUE5TXzROb2RlRVBOU18xM0tleWJvYXJkRXZlbnRFCitfX1pOSzdX ZWJDb3JlOUZsb2F0UmVjdDhjb250YWluc0VSS1MwXwogX19aTks3V2ViQ29yZTExSFRNTEVsZW1l bnQ1dGl0bGVFdgogX19aTks3V2ViQ29yZTE3SFRNTE9wdGlvbkVsZW1lbnQ0dGV4dEV2CiBfX1pO SzdXZWJDb3JlMTdIVE1MU2VsZWN0RWxlbWVudDEzc2VsZWN0ZWRJbmRleEV2CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCmluZGV4IDExODY5Y2VkNGMxZjk0MGZlZDY0ZDRiZjE3Nzc1ZGE2NDllNWQ3NTIuLjgxZTQ4 MDMyM2FmNDliYzg2OWMwMWM4ZmJhNzU5OTQxOGFmYWYwMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBA IC0yOTMsMTEgKzI5MywyNCBAQCBzdGF0aWMgRmxvYXRRdWFkIGluZmxhdGVRdWFkKGNvbnN0IEZs b2F0UXVhZCYgcXVhZCwgZmxvYXQgaW5mbGF0ZVNpemUpCiAgICAgfQogfQogCitzdGF0aWMgaW5s aW5lIGJvb2wgaGlnaGxpZ2h0ZWRRdWFkc0ZpdEluUmVjdChjb25zdCBWZWN0b3I8RmxvYXRRdWFk PiYgcXVhZHMsIGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKK3sKKyAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IHF1YWRzLnNpemUoKTsgKytpKSB7CisgICAgICAgIEZsb2F0UmVjdCBib3VuZGluZ0Jv eCA9IHF1YWRzW2ldLmJvdW5kaW5nQm94KCk7CisgICAgICAgIGlmIChib3VuZGluZ0JveC53aWR0 aCgpID4gcmVjdC53aWR0aCgpIHx8IGJvdW5kaW5nQm94LmhlaWdodCgpID4gcmVjdC5oZWlnaHQo KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9 CisKIC0gKHZvaWQpX2RpZEdldFRhcEhpZ2hsaWdodEZvclJlcXVlc3Q6KHVpbnQ2NF90KXJlcXVl c3RJRCBjb2xvcjooY29uc3QgV2ViQ29yZTo6Q29sb3ImKWNvbG9yIHF1YWRzOihjb25zdCBWZWN0 b3I8V2ViQ29yZTo6RmxvYXRRdWFkPiYpaGlnaGxpZ2h0ZWRRdWFkcyB0b3BMZWZ0UmFkaXVzOihj b25zdCBXZWJDb3JlOjpJbnRTaXplJil0b3BMZWZ0UmFkaXVzIHRvcFJpZ2h0UmFkaXVzOihjb25z dCBXZWJDb3JlOjpJbnRTaXplJil0b3BSaWdodFJhZGl1cyBib3R0b21MZWZ0UmFkaXVzOihjb25z dCBXZWJDb3JlOjpJbnRTaXplJilib3R0b21MZWZ0UmFkaXVzIGJvdHRvbVJpZ2h0UmFkaXVzOihj b25zdCBXZWJDb3JlOjpJbnRTaXplJilib3R0b21SaWdodFJhZGl1cwogewogICAgIGlmICghX2lz VGFwSGlnaGxpZ2h0SURWYWxpZCB8fCBfbGF0ZXN0VGFwSGlnaGxpZ2h0SUQgIT0gcmVxdWVzdElE KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIWhpZ2hsaWdodGVkUXVhZHNGaXRJblJlY3Qo aGlnaGxpZ2h0ZWRRdWFkcywgX3BhZ2UtPnVub2JzY3VyZWRDb250ZW50UmVjdCgpKSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgY29uc3QgQ0dGbG9hdCBVSVdlYlZpZXdNaW5pbXVtSGlnaGxpZ2h0 UmFkaXVzID0gMi4wOwogICAgIGlmICghX2hpZ2hsaWdodFZpZXcpIHsKICAgICAgICAgX2hpZ2hs aWdodFZpZXcgPSBhZG9wdE5TKFtbX1VJSGlnaGxpZ2h0VmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpDR1JlY3RaZXJvXSk7CkBAIC0zMjQsMTAgKzMzNyw4IEBAIHN0YXRpYyBGbG9hdFF1YWQgaW5m bGF0ZVF1YWQoY29uc3QgRmxvYXRRdWFkJiBxdWFkLCBmbG9hdCBpbmZsYXRlU2l6ZSkKICAgICAg ICAgfQogICAgIH0KIAotICAgIC8vIEZJWE1FOiBXZWJLaXQxIHVzZXMgdGhlIHZpc2libGVSZWN0 LiBVc2luZyB0aGUgd2hvbGUgZnJhbWUgZnJvbSB0aGUgcGFnZSBzZWVtcyBvdmVya2lsbC4KLSAg ICBDR1JlY3QgYm91bmRhcnlSZWN0ID0gW3NlbGYgZnJhbWVdOwogICAgIGlmIChhbGxIaWdobGln aHRSZWN0c0FyZVJlY3RpbGluZWFyKQotICAgICAgICBbX2hpZ2hsaWdodFZpZXcgc2V0RnJhbWVz OnJlY3RzLmdldCgpIGJvdW5kYXJ5UmVjdDpib3VuZGFyeVJlY3RdOworICAgICAgICBbX2hpZ2hs aWdodFZpZXcgc2V0RnJhbWVzOnJlY3RzLmdldCgpIGJvdW5kYXJ5UmVjdDpfcGFnZS0+ZXhwb3Nl ZENvbnRlbnRSZWN0KCldOwogICAgIGVsc2UgewogICAgICAgICBSZXRhaW5QdHI8TlNNdXRhYmxl QXJyYXk+IHF1YWRzID0gYWRvcHROUyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBpbml0V2l0aENh cGFjaXR5OnN0YXRpY19jYXN0PGNvbnN0IE5TVUludGVnZXI+KHF1YWRDb3VudCldKTsKICAgICAg ICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBxdWFkQ291bnQ7ICsraSkgewpAQCAtMzM4LDcgKzM0 OSw3IEBAIHN0YXRpYyBGbG9hdFF1YWQgaW5mbGF0ZVF1YWQoY29uc3QgRmxvYXRRdWFkJiBxdWFk LCBmbG9hdCBpbmZsYXRlU2l6ZSkKICAgICAgICAgICAgIFtxdWFkcyBhZGRPYmplY3Q6W05TVmFs dWUgdmFsdWVXaXRoQ0dQb2ludDpleHRlbmRlZFF1YWQucDMoKV1dOwogICAgICAgICAgICAgW3F1 YWRzIGFkZE9iamVjdDpbTlNWYWx1ZSB2YWx1ZVdpdGhDR1BvaW50OmV4dGVuZGVkUXVhZC5wNCgp XV07CiAgICAgICAgIH0KLSAgICAgICAgW19oaWdobGlnaHRWaWV3IHNldFF1YWRzOnF1YWRzLmdl dCgpIGJvdW5kYXJ5UmVjdDpib3VuZGFyeVJlY3RdOworICAgICAgICBbX2hpZ2hsaWdodFZpZXcg c2V0UXVhZHM6cXVhZHMuZ2V0KCkgYm91bmRhcnlSZWN0Ol9wYWdlLT5leHBvc2VkQ29udGVudFJl Y3QoKV07CiAgICAgfQogCiAgICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiBib3JkZXJSYWRp aSA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eTo0XSk7 Cg==