<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>129470</bug_id>
          
          <creation_ts>2014-02-27 21:37:59 -0800</creation_ts>
          <short_desc>[GTK] WebKit1 downloads not working</short_desc>
          <delta_ts>2014-03-02 11:38:48 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ben Boeckel">mathstuf</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>985457</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Boeckel">mathstuf</who>
    <bug_when>2014-02-27 21:37:59 -0800</bug_when>
    <thetext>It&apos;s been happening for a while AFAICT, but I&apos;ve finally had the time to chase it down. My guess is that it broke in v2.3.3[1] (I&apos;m running 2.3.90 right now) with the change over to didReceiveBuffer rather than didReceiveData. The behavior is that I call webkit_download_start and then…nothing. No data received, signals called, status change, not a thing. If while in gdb, inside of webkit_download_start, I do &quot;call download-&gt;priv-&gt;resourceHandle.m_ptr-&gt;start()&apos; at the end of the function, then continue executing uzbl, the download successfully completes. I doubt it&apos;s the correct behavior, but something, somewhere, stopped calling start on the handle.

[1]All I have is a git history of tarballs; the official repo is way too large for my bandwidth to handle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986140</commentid>
    <comment_count>1</comment_count>
    <who name="Ben Boeckel">mathstuf</who>
    <bug_when>2014-03-02 11:38:48 -0800</bug_when>
    <thetext>I found my problem. When I had ported over to WebKit2, the download destination was determined asynchronously, but WebKit1&apos;s download mechanism calls _start and _cancel on its own, so if we&apos;re async, the destination isn&apos;t set when the download is started by WebKit itself, implicitly and silently cancelling it. The fix is to make the WebKit1 code sync.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>